* [dpdk-stable] [dpdk-dev] [PATCH v2] net/thunderx: avoid sq door bell writes on zero packets [not found] <1531293723-930-1-git-send-email-kkokkilagadda@caviumnetworks.com> @ 2018-07-11 8:24 ` Kiran Kumar 2018-07-11 9:05 ` Jerin Jacob 0 siblings, 1 reply; 3+ messages in thread From: Kiran Kumar @ 2018-07-11 8:24 UTC (permalink / raw) To: jerin.jacob, maciej.czekaj, ferruh.yigit; +Cc: dev, Kiran Kumar, stable Avoid sq door bell write on zero packet case to reduce additional traffic on register bus. Fixes: 1c421f18e0 ("net/thunderx: add single and multi-segment Tx") Cc: stable@dpdk.org Signed-off-by: Kiran Kumar <kkokkilagadda@caviumnetworks.com> --- v2 Changes: - changed summery and description. - added same optimization to nicvf_xmit_pkts_multiseg drivers/net/thunderx/nicvf_rxtx.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/net/thunderx/nicvf_rxtx.c b/drivers/net/thunderx/nicvf_rxtx.c index 72305d9..6e075e2 100644 --- a/drivers/net/thunderx/nicvf_rxtx.c +++ b/drivers/net/thunderx/nicvf_rxtx.c @@ -162,12 +162,14 @@ nicvf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) free_desc -= TX_DESC_PER_PKT; } - sq->tail = tail; - sq->xmit_bufs += i; - rte_wmb(); + if (likely(i)) { + sq->tail = tail; + sq->xmit_bufs += i; + rte_wmb(); - /* Inform HW to xmit the packets */ - nicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT); + /* Inform HW to xmit the packets */ + nicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT); + } return i; } @@ -218,12 +220,14 @@ nicvf_xmit_pkts_multiseg(void *tx_queue, struct rte_mbuf **tx_pkts, } } - sq->tail = tail; - sq->xmit_bufs += used_bufs; - rte_wmb(); + if (likely(used_desc)) { + sq->tail = tail; + sq->xmit_bufs += used_bufs; + rte_wmb(); - /* Inform HW to xmit the packets */ - nicvf_addr_write(sq->sq_door, used_desc); + /* Inform HW to xmit the packets */ + nicvf_addr_write(sq->sq_door, used_desc); + } return i; } -- 2.7.4 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/thunderx: avoid sq door bell writes on zero packets 2018-07-11 8:24 ` [dpdk-stable] [dpdk-dev] [PATCH v2] net/thunderx: avoid sq door bell writes on zero packets Kiran Kumar @ 2018-07-11 9:05 ` Jerin Jacob 2018-07-18 9:41 ` Ferruh Yigit 0 siblings, 1 reply; 3+ messages in thread From: Jerin Jacob @ 2018-07-11 9:05 UTC (permalink / raw) To: Kiran Kumar; +Cc: maciej.czekaj, ferruh.yigit, dev, stable -----Original Message----- > Date: Wed, 11 Jul 2018 13:54:36 +0530 > From: Kiran Kumar <kkokkilagadda@caviumnetworks.com> > To: jerin.jacob@caviumnetworks.com, maciej.czekaj@caviumnetworks.com, > ferruh.yigit@intel.com > Cc: dev@dpdk.org, Kiran Kumar <kkokkilagadda@caviumnetworks.com>, > stable@dpdk.org > Subject: [dpdk-dev] [PATCH v2] net/thunderx: avoid sq door bell writes on > zero packets > X-Mailer: git-send-email 2.7.4 > > Avoid sq door bell write on zero packet case to reduce additional > traffic on register bus. > > Fixes: 1c421f18e0 ("net/thunderx: add single and multi-segment Tx") > Cc: stable@dpdk.org > > Signed-off-by: Kiran Kumar <kkokkilagadda@caviumnetworks.com> Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> > --- > v2 Changes: > - changed summery and description. > - added same optimization to nicvf_xmit_pkts_multiseg > > drivers/net/thunderx/nicvf_rxtx.c | 24 ++++++++++++++---------- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/thunderx/nicvf_rxtx.c b/drivers/net/thunderx/nicvf_rxtx.c > index 72305d9..6e075e2 100644 > --- a/drivers/net/thunderx/nicvf_rxtx.c > +++ b/drivers/net/thunderx/nicvf_rxtx.c > @@ -162,12 +162,14 @@ nicvf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > free_desc -= TX_DESC_PER_PKT; > } > > - sq->tail = tail; > - sq->xmit_bufs += i; > - rte_wmb(); > + if (likely(i)) { > + sq->tail = tail; > + sq->xmit_bufs += i; > + rte_wmb(); > > - /* Inform HW to xmit the packets */ > - nicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT); > + /* Inform HW to xmit the packets */ > + nicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT); > + } > return i; > } > > @@ -218,12 +220,14 @@ nicvf_xmit_pkts_multiseg(void *tx_queue, struct rte_mbuf **tx_pkts, > } > } > > - sq->tail = tail; > - sq->xmit_bufs += used_bufs; > - rte_wmb(); > + if (likely(used_desc)) { > + sq->tail = tail; > + sq->xmit_bufs += used_bufs; > + rte_wmb(); > > - /* Inform HW to xmit the packets */ > - nicvf_addr_write(sq->sq_door, used_desc); > + /* Inform HW to xmit the packets */ > + nicvf_addr_write(sq->sq_door, used_desc); > + } > return i; > } > > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] net/thunderx: avoid sq door bell writes on zero packets 2018-07-11 9:05 ` Jerin Jacob @ 2018-07-18 9:41 ` Ferruh Yigit 0 siblings, 0 replies; 3+ messages in thread From: Ferruh Yigit @ 2018-07-18 9:41 UTC (permalink / raw) To: Jerin Jacob, Kiran Kumar; +Cc: maciej.czekaj, dev, stable On 7/11/2018 10:05 AM, Jerin Jacob wrote: > -----Original Message----- >> Date: Wed, 11 Jul 2018 13:54:36 +0530 >> From: Kiran Kumar <kkokkilagadda@caviumnetworks.com> >> To: jerin.jacob@caviumnetworks.com, maciej.czekaj@caviumnetworks.com, >> ferruh.yigit@intel.com >> Cc: dev@dpdk.org, Kiran Kumar <kkokkilagadda@caviumnetworks.com>, >> stable@dpdk.org >> Subject: [dpdk-dev] [PATCH v2] net/thunderx: avoid sq door bell writes on >> zero packets >> X-Mailer: git-send-email 2.7.4 >> >> Avoid sq door bell write on zero packet case to reduce additional >> traffic on register bus. >> >> Fixes: 1c421f18e0 ("net/thunderx: add single and multi-segment Tx") >> Cc: stable@dpdk.org >> >> Signed-off-by: Kiran Kumar <kkokkilagadda@caviumnetworks.com> > > Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com> Applied to dpdk-next-net/master, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-07-18 9:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1531293723-930-1-git-send-email-kkokkilagadda@caviumnetworks.com>
2018-07-11 8:24 ` [dpdk-stable] [dpdk-dev] [PATCH v2] net/thunderx: avoid sq door bell writes on zero packets Kiran Kumar
2018-07-11 9:05 ` Jerin Jacob
2018-07-18 9:41 ` Ferruh Yigit
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).