* [dpdk-stable] [dpdk-dev] [PATCH] app/eventdev: fix order test service init
@ 2018-07-13 8:51 Pavan Nikhilesh
2018-07-13 17:52 ` Eads, Gage
0 siblings, 1 reply; 4+ messages in thread
From: Pavan Nikhilesh @ 2018-07-13 8:51 UTC (permalink / raw)
To: jerin.jacob, gage.eads; +Cc: dev, stable, Pavan Nikhilesh
Previous modification to evt_service_setup() broke order_queue/atq
tests.
Fixes: b0333c55dfa5 ("app/eventdev: add service core configuration")
Cc: stable@dpdk.org
Reported-by: Gage Eads <gage.eads@intel.com>
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
---
app/test-eventdev/test_order_atq.c | 12 ++++++++----
app/test-eventdev/test_order_queue.c | 12 ++++++++----
2 files changed, 16 insertions(+), 8 deletions(-)
diff --git a/app/test-eventdev/test_order_atq.c b/app/test-eventdev/test_order_atq.c
index c57fbbfa6..35debcfdc 100644
--- a/app/test-eventdev/test_order_atq.c
+++ b/app/test-eventdev/test_order_atq.c
@@ -151,10 +151,14 @@ order_atq_eventdev_setup(struct evt_test *test, struct evt_options *opt)
if (ret)
return ret;
- ret = evt_service_setup(opt->dev_id);
- if (ret) {
- evt_err("No service lcore found to run event dev.");
- return ret;
+ if (!evt_has_distributed_sched(opt->dev_id)) {
+ uint32_t service_id;
+ rte_event_dev_service_id_get(opt->dev_id, &service_id);
+ ret = evt_service_setup(service_id);
+ if (ret) {
+ evt_err("No service lcore found to run event dev.");
+ return ret;
+ }
}
ret = rte_event_dev_start(opt->dev_id);
diff --git a/app/test-eventdev/test_order_queue.c b/app/test-eventdev/test_order_queue.c
index f603a0230..17f7b9845 100644
--- a/app/test-eventdev/test_order_queue.c
+++ b/app/test-eventdev/test_order_queue.c
@@ -164,10 +164,14 @@ order_queue_eventdev_setup(struct evt_test *test, struct evt_options *opt)
if (ret)
return ret;
- ret = evt_service_setup(opt->dev_id);
- if (ret) {
- evt_err("No service lcore found to run event dev.");
- return ret;
+ if (!evt_has_distributed_sched(opt->dev_id)) {
+ uint32_t service_id;
+ rte_event_dev_service_id_get(opt->dev_id, &service_id);
+ ret = evt_service_setup(service_id);
+ if (ret) {
+ evt_err("No service lcore found to run event dev.");
+ return ret;
+ }
}
ret = rte_event_dev_start(opt->dev_id);
--
2.18.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] app/eventdev: fix order test service init
2018-07-13 8:51 [dpdk-stable] [dpdk-dev] [PATCH] app/eventdev: fix order test service init Pavan Nikhilesh
@ 2018-07-13 17:52 ` Eads, Gage
2018-07-24 15:36 ` Jerin Jacob
2018-07-25 13:33 ` Jerin Jacob
0 siblings, 2 replies; 4+ messages in thread
From: Eads, Gage @ 2018-07-13 17:52 UTC (permalink / raw)
To: Pavan Nikhilesh, jerin.jacob; +Cc: dev, stable
> -----Original Message-----
> From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> Sent: Friday, July 13, 2018 3:51 AM
> To: jerin.jacob@caviumnetworks.com; Eads, Gage <gage.eads@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Pavan Nikhilesh
> <pbhagavatula@caviumnetworks.com>
> Subject: [dpdk-dev] [PATCH] app/eventdev: fix order test service init
>
> Previous modification to evt_service_setup() broke order_queue/atq tests.
>
> Fixes: b0333c55dfa5 ("app/eventdev: add service core configuration")
> Cc: stable@dpdk.org
>
> Reported-by: Gage Eads <gage.eads@intel.com>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> ---
Acked-by: Gage Eads <gage.eads@intel.com>
Thanks for the quick turnaround,
Gage
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] app/eventdev: fix order test service init
2018-07-13 17:52 ` Eads, Gage
@ 2018-07-24 15:36 ` Jerin Jacob
2018-07-25 13:33 ` Jerin Jacob
1 sibling, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2018-07-24 15:36 UTC (permalink / raw)
To: Eads, Gage; +Cc: Pavan Nikhilesh, dev, stable
-----Original Message-----
> Date: Fri, 13 Jul 2018 17:52:42 +0000
> From: "Eads, Gage" <gage.eads@intel.com>
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
> "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH] app/eventdev: fix order test service init
>
> External Email
>
> > -----Original Message-----
> > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Friday, July 13, 2018 3:51 AM
> > To: jerin.jacob@caviumnetworks.com; Eads, Gage <gage.eads@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Pavan Nikhilesh
> > <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH] app/eventdev: fix order test service init
> >
> > Previous modification to evt_service_setup() broke order_queue/atq tests.
> >
> > Fixes: b0333c55dfa5 ("app/eventdev: add service core configuration")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Gage Eads <gage.eads@intel.com>
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
>
> Acked-by: Gage Eads <gage.eads@intel.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] app/eventdev: fix order test service init
2018-07-13 17:52 ` Eads, Gage
2018-07-24 15:36 ` Jerin Jacob
@ 2018-07-25 13:33 ` Jerin Jacob
1 sibling, 0 replies; 4+ messages in thread
From: Jerin Jacob @ 2018-07-25 13:33 UTC (permalink / raw)
To: Eads, Gage; +Cc: Pavan Nikhilesh, dev, stable
-----Original Message-----
> Date: Fri, 13 Jul 2018 17:52:42 +0000
> From: "Eads, Gage" <gage.eads@intel.com>
> To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>,
> "jerin.jacob@caviumnetworks.com" <jerin.jacob@caviumnetworks.com>
> CC: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>
> Subject: RE: [dpdk-dev] [PATCH] app/eventdev: fix order test service init
>
> External Email
>
> > -----Original Message-----
> > From: Pavan Nikhilesh [mailto:pbhagavatula@caviumnetworks.com]
> > Sent: Friday, July 13, 2018 3:51 AM
> > To: jerin.jacob@caviumnetworks.com; Eads, Gage <gage.eads@intel.com>
> > Cc: dev@dpdk.org; stable@dpdk.org; Pavan Nikhilesh
> > <pbhagavatula@caviumnetworks.com>
> > Subject: [dpdk-dev] [PATCH] app/eventdev: fix order test service init
> >
> > Previous modification to evt_service_setup() broke order_queue/atq tests.
> >
> > Fixes: b0333c55dfa5 ("app/eventdev: add service core configuration")
> > Cc: stable@dpdk.org
> >
> > Reported-by: Gage Eads <gage.eads@intel.com>
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
> > ---
>
> Acked-by: Gage Eads <gage.eads@intel.com>
Applied to dpdk-next-eventdev/master. Thanks.
>
> Thanks for the quick turnaround,
> Gage
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-07-25 13:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-13 8:51 [dpdk-stable] [dpdk-dev] [PATCH] app/eventdev: fix order test service init Pavan Nikhilesh
2018-07-13 17:52 ` Eads, Gage
2018-07-24 15:36 ` Jerin Jacob
2018-07-25 13:33 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).