From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40047.outbound.protection.outlook.com [40.107.4.47]) by dpdk.org (Postfix) with ESMTP id B10BD1C01 for ; Fri, 27 Jul 2018 04:11:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RSisWVB71Qe9cQPkrBhf8EUV4LP6a7qtdjU9XtOK/1k=; b=yv3TAAByYB398JaYmcJJy5R0iwW7JDO8o1Ck9633Jrx52UPLYmcvbHh5gfw2L9zBsPhxSS92sd0A0JGD6+xSuKGm6JVozF5SDwupKc/0EYBXJGwyaTPcu6FHGp2MxutEIHIky2hfmVWq8sXOX3+VmzFHnbML5GyE6dvmmXvh/Zw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:10:59 +0000 From: Yongseok Koh To: Nikhil Rao Cc: Narender Vangati , Jerin Jacob , dpdk stable Date: Thu, 26 Jul 2018 19:09:08 -0700 Message-Id: <20180727021019.37388-12-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727021019.37388-1-yskoh@mellanox.com> References: <20180727021019.37388-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM6PR08CA0022.namprd08.prod.outlook.com (2603:10b6:5:80::35) To HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: db5022b0-bbaf-4d94-0b8d-08d5f36632b1 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2041; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 3:zgwIjdnTRm/a68b9v75tub7+nxwGoLawm+E5tCytIHYsi22rhbb/ENALaZf4XLRlnEmdq3uBKksUBoTV80F1cUOaVDrCQ80djfWm8t6R7uebmVvALz/1uomTbKBWnVQb8vNnMcmFrJ6s+nj2+lXfY8lWaD8h/14MLrVyoVkBntrx+XDODbKJg9FCm/Tv3kxhLzv/kHHl1/QiDQdoSeOxUqQWM6+f/jgFZZYGQxU+Dw3YdzbRzVCjxEFyi4ogPUzo; 25:qRU371BS+qOZYfjVnKhiIM0LPpvPecYzYYMfCGegFc+hcfyAPwcnpuCihKUBCZHrzaPgQOszgAWfM65Gs8ScHSKsbRo96GIZYj4IZWnjA8e+6OgTDnKAC81j9lx8xZZk249NKzFuGpYaFuH2gXj8PF/InVevrf8N16yFXDuS5oPWhfGSMZ4PbvT1hjY6rLf5tkY9vugh6+7xyGS0QppMuQxtLDj9OYV6AN4C1eJHQJAdTKMUFG0KiB5ZFGurzdlWmC2008J4+JFs9MJUI4UaUgW7aAO8MSU5ttGiom4A4Lek5oxWIHc4ktaXhp0UH6rk7EmeFmJpb1o6/dXMVma+mg==; 31:3HS2VyuyGGqybV34yo9CZms2nrJWj2hSmobCNesDf91M5fVnrsr10GbiYxxo1w/zoR6Q+FwHfJ8SB7eu5ExR91/5EW7/CeGQEmbIJtnp1k2QgD8+8QL33GPAbuGGRPho8sHPzGFtxVCKHlUyunsaZvWjCeN1PiaYpHolBhhuMki74ZhafNrbZ+FwbEATjcXBZ2dat5boDzOc9L5yc7Xl460wnU0T5dNX5vYvzJ1oJQ0= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2041: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 20:9p3sYm65BW00XDdxIP2s/bTixiQ5wdFHl0tbThjOJy9cGGJJAbQg2fQnLDQAspYti8PzqjMAvEhySvwkpeUfys/xs8EKscFdlMkPENwH5BlP0bEvU8rucWR24Atm4uKEKtooiNDCT0Z2a1hhwMlkuHQVSSs2HlNRN/zn5bm0jXJfJ6d1McdTKuiltB+EnCywz8AD/MH+RIG5NgwYsHXY5OI9AxQdjU0m06V28Zwpgwz5o/ef3p10TL3VgrWdSm0anfjOikdT77yfMUVKqlq2Y7OewaRhCjCW7sOn4nb+FC0yo6lEwxxYSSwrvwwETQoIzxQRmEw/H/+5dnANMRD3FyU9NMiAo+LcmEQLyJ4P6UZCMlayHO2xUKQjSJ7jykctCtBRAaG0jPXqq602UfIvAG/Q35Kk5qPbSfrw5iBsqt0oGQ/AATAD8qzsk7It6WZzkUNhasw9wGw3F6/+KRuYuvbE7aSTIVHiCg0gfLhZ6T3A4fIU5pBQ2qZMfLr0iN4K; 4:v8y1aEAaENAWdL3INKYbipSLQsSvvq4UiLCXLYZD3Jp08olRQRSRQ9K3Oa++Y15EhCH6DwmrcHZTWWxJ6/KwTMiVKMvRYyn61IilY0kEg+Ach0+nGDwmL9Nz5Ug3TrT7AkV6MgAGRTohi5rb9mXbV5Np8i3LWfGPFVuaz9HY0mpWuH5BLE1p0s5EoEKSi7CZvBb/U1jrHwuOxuUME/9gY/lHgkWFII3eMSkE5F/gv5J66irrNqu4ZoEJRAkeqDecizpnKC1xaSXWhWiynBZaGygia0kT+SbheYXg0bCYfTkRyvWq/Wqev13hh6qL5Zdh X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2041; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2041; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(136003)(376002)(396003)(346002)(69234005)(28163001)(189003)(199004)(6306002)(55016002)(53376002)(36756003)(4326008)(76176011)(2906002)(105586002)(26005)(2616005)(25786009)(956004)(486006)(21086003)(386003)(966005)(106356001)(51416003)(7736002)(86362001)(53546011)(50466002)(16526019)(48376002)(1076002)(52116002)(8936002)(54906003)(5660300001)(11346002)(3846002)(16586007)(446003)(66066001)(81166006)(68736007)(316002)(69596002)(7696005)(6116002)(14444005)(97736004)(53936002)(476003)(81156014)(50226002)(6666003)(47776003)(6916009)(186003)(1720100001)(8676002)(305945005)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2041; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2041; 23:NeO/xFVs8OzN+0mKHkHBWngNrrPDhl9uNm1Fhr0?= =?us-ascii?Q?JsNzr3gzkU3zyZbMmJDKfSjPUzHPW7DfeiZ69OtXURW8afBZCu+SlN7SIaTV?= =?us-ascii?Q?erRPqlypvNsby1aMgbH+qs8Cokw7fyHToC+tptVTH9xN5K7qr/IdGFqeWL/9?= =?us-ascii?Q?8u9NA82YMuwAH4BYbOFczMUR+8oJvf6GBaEswoUozzi0soEDhPJQnK3xaTNM?= =?us-ascii?Q?8p26LMaVcdf6Y3Z882X3BxrSqKdDIRoGx+kChMbSNtaazAUM3SgWrdELHfEN?= =?us-ascii?Q?z0IAu37DyA/K6f1aEO7lpimAf4ycgpmG81srCRh9213x0phLyVGaDU3MY2+h?= =?us-ascii?Q?oI56b7Vxr1r4SAmq+qX1xF4ME8Bjr1t0ng63oL7NHKprLrMoD07l0NunRrwC?= =?us-ascii?Q?kLmUCrHneVS4fQpZSkmaVaJmhBQBhcZzzNZ8qLSCNn5qREpmRdVGxPcwWe+u?= =?us-ascii?Q?UigM35S+AgU4GD4d06BbyN6aCpWkiZXEODowhIVR1ZJy1Cl2IjOizEutwfuH?= =?us-ascii?Q?40S9ExkqkauNyAErYBvPuINlNDPysxI7lxa9RbliEhthf8j44QPPOlGHEd22?= =?us-ascii?Q?L7BFolLZdcCrfs+72dbUEx6GAcrMUvQBQHnQe0txmUjefIL4LtflCMylGGcd?= =?us-ascii?Q?Cil0r6DZilKsI1Op4p8FwbpgyNBtjW60/OqoIE+OIxo0eNBzTBdVXedY7xmO?= =?us-ascii?Q?0x+iWQRzfSxsCzs/tudOIdzg1bupVY8xG5vI2ZaiBFx6+Y1g+PcfVV8J0INN?= =?us-ascii?Q?YbO5ri8QmdTNuEvC2w9mizh4qjGW1GkenSz+z3fhA+Q1Ii6+1q/MouELS0jn?= =?us-ascii?Q?OJ6iHfv8vddUGr8ol+o/ohrzC7gzI1zCYzOS190UWy9v0ljaEs//b4xFjW5X?= =?us-ascii?Q?zS2QyyRn2fURZ84yvyBpih6Zelrsq35IoP4ujkwGTWk5i4+5szKgn84O0+zb?= =?us-ascii?Q?wMN+aziq7pW5lAY3iCQmeC/gFG+Ya+ytkQCg8VcAZ1DdxCqyVNL2nb+NzrXp?= =?us-ascii?Q?VSXeh8NXEl/AU+VHQsh0dZHFf88V3pTOenJQzNexJJp+ar4Bkvkafix3IX+j?= =?us-ascii?Q?g1wytvNzI/YZ63YQ6K6LTmHe2gqWaYj8tZGVtic8o3r53tkz+wbDk4mUw99P?= =?us-ascii?Q?++GnYuUj25nCQw+pfNAQFRAOE0Ggf/+aKON9M58AbA0vfsVVX5i8xQJJ7w84?= =?us-ascii?Q?CqNxayJS/P7lCPAXySUnO+5GLrZ2VCM0Zx1yCMKI5XJjH2lSbbIAmh9mNgTC?= =?us-ascii?Q?bDxYFqooaWvE6mEDL3/zvt0CjXMvWGeISq8flXf3sjzeORhN9jWQVoCZoRv1?= =?us-ascii?Q?gERY4qF53IbLEtn9MFUJoPa9MRxxk272rgQi7Vff4e8eTajX06lNlAQVUj2Y?= =?us-ascii?Q?CfZeS3l8j9zzwYE7d8LeZBlRapm067k5GM3JAzeru7iOflWX3?= X-Microsoft-Antispam-Message-Info: gf7FDzmbfew8qyiROOXLrIiNvexkrjA6Bq+tgxUBbMxtlkDWefsj81LObERKYR2nBhOH1kjS5iZA8mz9osaov7cixqPUhp1AMJYTO3vJQW7IxihuixMX8nVnfTN5CagK+8c2ff3BYTT5hYpfcMxn7BJrV/LgFu8bA7ZowlIXDD/9mYS4PWznhldpxZ/LeHeVqM/b0fVVptnEChB6SkF84sP8+Z4hgWPeeTPbg24n1cTjhBK/FIG6M+QcfVNg9V4AqxPUtziKQvipEgbH8RPgNS5X3/bhT+dftsomZq/xAdWcqk34xEAZ3llx+ePJBU1DoCww3BLzYwGdeMMq5SNZFLu4Vo/stHkUt51UlLjb64M= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 6:1MVOf8nJMp5YS0pxhQbHZzHoBjuEjuFWshQvAOkQZXfewDtZigdQkBMrWDsW+j9E/7hfIgnrU3kY2aodi0sr4o7GE4sGihkghj2u+5GXulDcDszX3PgWLaI498DgiKb0TmTMe6qQgTeavhKCPnZIke4ZmlAxvJI+3ZrR8qbMLTPWs9mBVbZnpL2jR2V1MksnxzLLmko4GocWWPqqcnqecidhicywFNhKDtYKBiCNKhXBptVyQKOPLqHyCWuG+Szdd1WhqOZ+yGyuUQIk/T7otgKeI/c1q/OrXP7JqwdvR0VOAtLIJI5mtfqOS6iu+LtAwSsid9FHOu7quA0d+O5dtp16TeE3JGCK3RqnLVRdVvF0H/KiWYddDHsxflhUJbH7ILdplT6k5wOjKIXQEEofFweucHIdbNSevQb2rGn+Z81MhZtDTWF8pZXwHCa5+YChMPQBSSuUH5D1Q1R4oA1Tew==; 5:zbgh5oIOE+7SC1++2FjCrjEcYlmTvSEBwdmGNyDwesi4so6Xqq2Ruot9pabMZTvD+a0RKFfdP5bHwrw6/uHRLNkC4j7akyVs4kBqJS5cg6RCv/XYqj1qMLLDhtVPt7ZCsEoaXWYSy8NoL/uX0KDgppdoryHSh79v5La0gO9mljQ=; 7:bJoxxRYB7HM5H8H5wuBf3hkVlB+oALGK4UqMpNrCFB8YJjxp9FZ16cRFDLLruAvyJOGQK3aeVfbUcRbyBDx/ktOCW6QK01BKHq+4uwLIshQO6fyCZPLkgGZ0hRRZ+1n2+SW5p4f0tSt7Cus41bq8hcKv29qtarSjjpdqUjla5X0z4MkwSEA8/q6Z4MfLlZjP83Fivd4QiSPDIATj5JeM5U6/BEB/KTyDsEEhxR16YxgBLHEUh0W1EclSM3uDfJA8 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:10:59.1876 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: db5022b0-bbaf-4d94-0b8d-08d5f36632b1 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2041 Subject: [dpdk-stable] patch 'eventdev: add event buffer flush in Rx adapter' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:11:03 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 9b4c8ab2cfbe9ed232c417cdc4a78f66e12374a5 Mon Sep 17 00:00:00 2001 From: Nikhil Rao Date: Sun, 3 Jun 2018 18:12:25 +0530 Subject: [PATCH] eventdev: add event buffer flush in Rx adapter [ upstream commit 6b83f59355437c0631a64e5ecb9f080c17a8ba24 ] Add an event buffer flush when the current invocation of the Rx adapter is completed. This patch provides lower latency in case there is a BATCH_SIZE of events in the event buffer. Suggested-by: Narender Vangati Signed-off-by: Nikhil Rao Acked-by: Jerin Jacob --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c index 1cdbb848b..377db42d9 100644 --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c @@ -476,7 +476,7 @@ fill_event_buffer(struct rte_event_eth_rx_adapter *rx_adapter, * the hypervisor's switching layer where adjustments can be made to deal with * it. */ -static inline uint32_t +static inline void eth_rx_poll(struct rte_event_eth_rx_adapter *rx_adapter) { uint32_t num_queue; @@ -505,7 +505,7 @@ eth_rx_poll(struct rte_event_eth_rx_adapter *rx_adapter) flush_event_buffer(rx_adapter); if (BATCH_SIZE > (ETH_EVENT_BUFFER_SIZE - buf->count)) { rx_adapter->wrr_pos = wrr_pos; - break; + return; } stats->rx_poll_count++; @@ -521,7 +521,7 @@ eth_rx_poll(struct rte_event_eth_rx_adapter *rx_adapter) if (nb_rx > max_nb_rx) { rx_adapter->wrr_pos = (wrr_pos + 1) % rx_adapter->wrr_len; - return nb_rx; + break; } } @@ -529,20 +529,18 @@ eth_rx_poll(struct rte_event_eth_rx_adapter *rx_adapter) wrr_pos = 0; } - return nb_rx; + if (buf->count >= BATCH_SIZE) + flush_event_buffer(rx_adapter); } static int event_eth_rx_adapter_service_func(void *args) { struct rte_event_eth_rx_adapter *rx_adapter = args; - struct rte_eth_event_enqueue_buffer *buf; - buf = &rx_adapter->event_enqueue_buffer; if (rte_spinlock_trylock(&rx_adapter->rx_lock) == 0) return 0; - if (eth_rx_poll(rx_adapter) == 0 && buf->count) - flush_event_buffer(rx_adapter); + eth_rx_poll(rx_adapter); rte_spinlock_unlock(&rx_adapter->rx_lock); return 0; } -- 2.11.0