From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40047.outbound.protection.outlook.com [40.107.4.47]) by dpdk.org (Postfix) with ESMTP id B9A96288C for ; Fri, 27 Jul 2018 04:11:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TIjTdMr619BGrNN75PWcAC8OMtzY3I0zzZ/DKvLZY8Y=; b=m37g4DGv70rEgnxhrMpnumc0OHnXy4hu/UicWavOcvTjILqnzMcnHjP1oaDimp2Gz77kbZnomCBIrXFhJ2SQcYGeyol8IJBIje+UM/fr4+Hih4bDEFVuBbGPs6CV/QoAmZDTTSHiRNHSl0yE8C3FMy6Cw/bjNnsny2BTNi+wQxM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:11:02 +0000 From: Yongseok Koh To: Nikhil Rao Cc: dpdk stable Date: Thu, 26 Jul 2018 19:09:10 -0700 Message-Id: <20180727021019.37388-14-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727021019.37388-1-yskoh@mellanox.com> References: <20180727021019.37388-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM6PR08CA0022.namprd08.prod.outlook.com (2603:10b6:5:80::35) To HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ea9f3af8-8d13-402f-993b-08d5f366347f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2041; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 3:HuXS8Z7F3F+5K43g0WbEoMSzA3EsYcDJ7JXYW+lgdhYTKFaz4KSqSJAqtHSNUVOy+ux96UanKDHJGFN5Rcyko9jHX8pggAJ15zq9ATPYHObxyozWRa0lwtts6RcOcpGD75oO2xRxjBNZ17zvJt5vLc594J9S9rYzWmveg27DTBdgATDo+75vPaLDvRersqLrbg45AtkGTxvnsE0yeA1JAuHtIy2XEU1aMTQot3fzKeZ+fvHyfEpESU7wxoGWw4z0; 25:HB39epaShEF7vX4CKoNCEHjaMj0Hj6uRCwmPm/AKwgBbv9ONCcTbQPzIaCfYZE2SYZOgefgzXC6ohA96VbRZETANqQXG1XSvYJPCDFubvKD3sCArDOggb0MOVtJpNNVKL/X9AlMfvBr1daam62wpvtEfjqP89763DqJYeNdV5r6lcVb1f0xoQpOnIwcrIh8i7upQTapBGGXADXJsdkQ4Rd9yN7mERhQEBRJ9e4XWsZkq+ILOV+s2lmqs2uWgMsq4F5RhxFjvlmJY9wihe3Y/7fqlTt/o9pwGXECbDruUk1tB9lYeFB/18I2P0WH4UxmnAKKoEjiqRL9S+IXlzEwY8g==; 31:lr2W2gp/HYVQ6+hNC+opOHeTt3q2jHooFFP9d8GlVs/SWmopx2Uvws7uQa2BttYYPZJP4VdMs5j7Ms7pdwi9EeAAujST9dC4eB3QFOlFiHRyd35zArG2r/Hh4uXcEvLC1V17rlR97t5zEAtA3Til0EoCVIK0DKMDKH8wMdAd7DeCNdTB4M5f3JhymBDpZQlVxi1p51YKqDEkOrBoDIhd3Jf/3X+gEcBTeE71cyghOE0= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2041: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 20:RHvkkNzxoRUmlsINaBliqTfe9EvHnNotw9qRYyTl2q8FzqjrR+iTb5T+mXjAQwZ4QGqJBOyJNzWsAD7Acr82IOrf2l+GGwMMpdvu+5Tbp/sppNoxBFc6Qkp12xHLFBR6E4Fa0CKACffmSPCDzJoM8rVDeHjhA7/AWPRdIhIwV8+ogZb5DdRllSI7csjrHnBQiWjSgcjJOjXZ34DrZTHMR772T30n/MzSczWCFvQkq0iEXjng78KyWyL1WOGEiMMCgJ3t9r3r6El2kyqqCSCp6RBi5S06KkgKuatk78TJYh2aWULeW6TgKKNZYuQwPWUk6+n4HlQNhCVIuw3oqnJ1Haueu8shGvYBQx/mu0P+M5NVBQ0nm7r5NUZ1ZKMlJDAxkrIrlqKHBubZHH0Y2RcL4KK+rsaE2T2nXfhV/v16hJU0PqrU8axn+bwjTdlRpZKwMIadeHIeYv+7kPzNCjK16V+ZVbNn+ajg5K/XYCK62iWOVCBzSNkaMTn7pQVqWJ3E; 4:q1aCfR7sOs/nW4GjiGfcu/9egqMNLrivsURzfeTBUm8U7bmpWMQ6YTtRepPIEaPg31l7ooGJCiHZiHpgt+pBzB1kMvCB/pkd+UhHynygV/bKCuw7QLhs6y2D4GAeQUTvUfRffVzRdcDuiQ2jqxifFC8sGYVmTIaqGuD3jjMVLU8cpuvblCtdjoAdzAurP+cR91FWJ4dvyhX5BWSAyJPfIylkE6lzP6PtTvSZGukJ9Vk1XuZ92K1elcxB7Vg/HXBirr8hASXFlUSMyWa7kRBcdquJsheoMKa/usxukRlaLuWBlNWXk7O8AhHxODlkeNaV X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2041; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2041; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(136003)(376002)(396003)(346002)(69234005)(28163001)(189003)(199004)(6306002)(55016002)(53376002)(36756003)(4326008)(76176011)(2906002)(105586002)(26005)(2616005)(25786009)(956004)(486006)(21086003)(386003)(966005)(106356001)(51416003)(7736002)(86362001)(53546011)(575784001)(50466002)(16526019)(48376002)(1076002)(52116002)(8936002)(5660300001)(11346002)(3846002)(16586007)(446003)(66066001)(81166006)(68736007)(316002)(69596002)(7696005)(6116002)(14444005)(97736004)(53936002)(476003)(81156014)(50226002)(6666003)(47776003)(6916009)(186003)(1720100001)(8676002)(305945005)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2041; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2041; 23:JY2007qceoOHk7CyZ+IlZVN+mZXAu/5UE06p1FH?= =?us-ascii?Q?LSLuG050gqPCBCwuHJz3XqDF7Xw/Sq5FLoOj4o/p4s8kgkv01wYIi4f/AI1D?= =?us-ascii?Q?ukXo8OgsckEJPRQTzmHwpUake7jKCf0X93FLfhX3Rd1Kt5fGZH4/SNLV82cC?= =?us-ascii?Q?+8Y89QMf9vmfJD+aHZiRU0X3C7tv7q+eFBS0MmKkpbS6J5swLGlZoT2Xtrax?= =?us-ascii?Q?3WZ4VabewVXfkhw1Fy3JejOxf+84k88Z8XWQgpixioJBeCYRUGgsMmmxLf/p?= =?us-ascii?Q?6nIcEfZpJmgcNpj+0X7q5kEwzi2z9By2Hx9+OdbNZS8lGsMVgdii4LtPBBFp?= =?us-ascii?Q?JwOMEqO8f4J9xpLGH10DMfKEEj0qqbXgVmxvKn+5+GJjsJFo4ad5m6PuMFtw?= =?us-ascii?Q?CDoKFBsdCrQr2wm/9j4bSwvRt6ycudNvsQ1rxEYSmsZI6AAUALHthoq4OfBo?= =?us-ascii?Q?LGosMRcMMYDVlA+E3+TO6rtjLrISP+hnyBNA7WPmB++i/JBpxZerR044Bj7E?= =?us-ascii?Q?9dZKiFKFybjhcF50xtGqKsQg/GrY+dpNeCjA1qRyyDG3RMbISVUdKF8Usj2v?= =?us-ascii?Q?V6lesQ6BQXiBy/d/iGK7im5Q6875Js2oesbCu5yLXkkLRxStLOjqrqe0Z0g7?= =?us-ascii?Q?+YjF0fO6yKOZEQi6sW2atgxC/i1eDgOppKzTw4DslNY1ciX+8A13iUCysp7J?= =?us-ascii?Q?RQmw+ljU6pFTHopySuhJGxI4hgpsFHScUesmm7Iw6OV8jAdm/sDZYheIyZwg?= =?us-ascii?Q?pZ50H3avKmpCIQ89bvs6n5mZKxmdEriTDO57piYrmi5Fafq3sUAVDlgEnRDK?= =?us-ascii?Q?ljaAZ5MmuxDAOWkAc2R5P0OidBxKQG7bT54TbR/dp/1ABv22dIv9q2khr8rn?= =?us-ascii?Q?kh/inpF7TP/Uy+nde8ZZNdawrY978lkBU34xrS5shrIX0OZGwkuHZzXL8Ucs?= =?us-ascii?Q?ZcJj6nljO1iKSNHihUHwUiVqybABK10qE0QuvFgV/F3UwsxxZ8C5/lT+ymao?= =?us-ascii?Q?nTBS6bsVFQWhvOiHfi4CparvqUNePKf9J74dPqVjVC3jdALvmV5qoWqo3dDy?= =?us-ascii?Q?gNmalf7/N3ExKxE3ofhsryvQ/Nj5GRGV9Q/H/sbvCCpYK03/mUPh4f8Tu5yj?= =?us-ascii?Q?KY4lXAGg3vexmwXlukIrSTeA0u6szcKftN1jQ5eLkq2FG9VLVuKsgj7NC3/p?= =?us-ascii?Q?1V7CJNfeG56riuJnvtq2DdUredrThiDIIt1tb0rTVUtdYnjWW0lhLmIlyHx/?= =?us-ascii?Q?kLCTG7DfjI+ILvUpSMEE6vp+UL/34wpYQV7Gi14rLuTuh9c9KhRaBaUla3Wv?= =?us-ascii?Q?+SeD1caxsi6mvDo+/Q2W687bjIzKRXNeyM6PmrJfcqZOgPI3xpPAUDd9IQpv?= =?us-ascii?Q?T9Ka+6g03NAoHgPAQxYiR94rg9dnT6ajzFzrAXJwbkAhRuTyW?= X-Microsoft-Antispam-Message-Info: 6sxTONXunDwxOHP7FyM2KT8UqJmyhEOogJf9i+vV57t4IIBi9sKr4s+4ZJAI6RQD5sw6lQhNS/nuycenxTGTetd/AN0ytPugCdmcvsgOoJmXnzw6sOVZj1IXxFg6v7ukjNM0eFPBwkT1/72/oa1W36+h8wmeoW7Msf99AEET8FSmttZzPr1JaeWcXHbol2cVsz+LsdrGAlSHqOmmWonU1GrvTTtb+x5kIjfW4wgUy6DOWzV3cd3oCBs6Srb0i7RzJXMlcF48XbK2oEoija7OE4YWntRcWyBBCtjRjjRyPYSb45zqd0ajm3gguoRz3JrmByUdMTl73Mr89zvr3b1YWlRbd5HCgSwLcMbiOsFQbJI= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 6:6D3rCYv3Tci5K+4UvozKtRrkwTnwmMxVaoxSKBVMAd5HniT4a56X9MOoqKxaMER4rIznoYsafQA3qEAPr3hqYFiUQqbhNUmELpv6Hf2UpRw+k2jqUtxDH0LzJu461PcLYU1sVOYWc1M3lsMD3KR+Pn2ZCNpzFBZbtfGD4apkjlk7cNujUDuKCeDnXKKy/fAHJQuj+Vgc3nRFygT9ESvo3NN2zPVQO6l2nFBH3VBwvkxG56Jmp6utu+q2eg5vpeIdnLRqYw5En1G08gSXmCShISIipSj/hkGhTE120wc/AkS0TighOYiPiA35U36LudeNNoqqfpB675BqxMzP9O6XHDIbayNCiLTNoPsBdCiVllrGOHKMPY/AcvFXAtUw5CbfVsoK0/7pPFyc/BocYlOgxRWjS3Kj5tau6N11WDn2cvMyyi3HPLi3mzqskFyp9ikT9uN6FmDi0X4lEO1cqxpOvA==; 5:YWyJL7ZUWznpzbRKW+TJV5M/AbBXB6oByds5FjGiXM9ReV9n6YAG6rSKCyUj7DKCvgdM2iVDxVvBzaiPooDtHRtbUcYXtFERUZbeC+omc16MVA/HkhlWW/MraKjZU3vD/dMdJWbY5pZRKjNOR13RKyVeyBDOzcBRm0AWKQGrf+Q=; 7:mHEmhj2J3F4g5SCofC5ZqFhXiWBzEC0uwlj2X+gsXvAWgeLmJF6YDztB544Q4fF67VZ2qACKUAR7PjzTYpn8NRdxKuThQ/ryOuXqqHbCy8JRddG9EHf+dqK1Arl4Q1292whc4boWOm0meoYdj5PSJuindrcSaC5jJjzSJWsroe1OuH++3ETr6wbtxgO6MBolfvgR6IAuJKhNQjapqLpNjnWrjhj49oiGG8y1eRYKJYd7KYtjTiyf5D8I0Eund7sH SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:11:02.6409 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ea9f3af8-8d13-402f-993b-08d5f366347f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2041 Subject: [dpdk-stable] patch 'eventdev: fix Rx SW adapter stop' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:11:05 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From ca24d9649e81e0be9305897cf744db239117843d Mon Sep 17 00:00:00 2001 From: Nikhil Rao Date: Mon, 4 Jun 2018 18:25:17 +0530 Subject: [PATCH] eventdev: fix Rx SW adapter stop [ upstream commit a66a83744667f31ee97e18eefa90105c462ed81b ] The Rx adapter stop call does not guarantee that the SW service function will not execute after the rte_event_eth_rx_adapter_stop() call. Add a "started" flag to prevent the adapter from executing if stop has been called. Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") Signed-off-by: Nikhil Rao --- lib/librte_eventdev/rte_event_eth_rx_adapter.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lib/librte_eventdev/rte_event_eth_rx_adapter.c b/lib/librte_eventdev/rte_event_eth_rx_adapter.c index e767591e8..d5c3fd56c 100644 --- a/lib/librte_eventdev/rte_event_eth_rx_adapter.c +++ b/lib/librte_eventdev/rte_event_eth_rx_adapter.c @@ -87,6 +87,8 @@ struct rte_event_eth_rx_adapter { int socket_id; /* Per adapter EAL service */ uint32_t service_id; + /* Adapter started flag */ + uint8_t rxa_started; } __rte_cache_aligned; /* Per eth device */ @@ -542,6 +544,10 @@ event_eth_rx_adapter_service_func(void *args) if (rte_spinlock_trylock(&rx_adapter->rx_lock) == 0) return 0; + if (!rx_adapter->rxa_started) { + return 0; + rte_spinlock_unlock(&rx_adapter->rx_lock); + } eth_rx_poll(rx_adapter); rte_spinlock_unlock(&rx_adapter->rx_lock); return 0; @@ -831,8 +837,12 @@ rx_adapter_ctrl(uint8_t id, int start) &rte_eth_devices[i]); } - if (use_service) + if (use_service) { + rte_spinlock_lock(&rx_adapter->rx_lock); + rx_adapter->rxa_started = start; rte_service_runstate_set(rx_adapter->service_id, start); + rte_spinlock_unlock(&rx_adapter->rx_lock); + } return 0; } -- 2.11.0