From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20048.outbound.protection.outlook.com [40.107.2.48]) by dpdk.org (Postfix) with ESMTP id 8B154288C for ; Fri, 27 Jul 2018 04:11:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c4KLXjywU4vdaNvH04XbtBCZMzQjUP49WJ1dqzVc3Uc=; b=rtMwY4Ryej7uSRgLL6xzseZ/zhlFKemU+dh/GdzWx5VpEZWTmt+j0RjBSUf227fb77ypDwxaVEtpnkgyy3n/msiu9MfYu9PMDC1pf5FUtGvY+kBKS279HshMasD8/HDdhiCCmgRKOOeE+9H8T9sgSFJ/AIRBxFAUAyyUw0X7Snk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:11:05 +0000 From: Yongseok Koh To: Ferruh Yigit Cc: Pablo de Lara , dpdk stable Date: Thu, 26 Jul 2018 19:09:12 -0700 Message-Id: <20180727021019.37388-16-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727021019.37388-1-yskoh@mellanox.com> References: <20180727021019.37388-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM6PR08CA0022.namprd08.prod.outlook.com (2603:10b6:5:80::35) To HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 335bb3ce-9c43-4cd2-6114-08d5f3663668 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2041; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 3:8opaWay1MqUMoatJwJGFplnxG398LtCOgggFx0GbH0qxnKF4kA8rA9Xbz5wPd5RZ6u0yzFxq8RVA52aagA1jWBoCZ9F6LuCwbr+HjQgJOkOufOWgwiB7k2F2loebMjNwhfMkOjdWrezcDJRuCNmX20DwTIMis6+cJWaTg49uEN+OlpEwuRbTd16+1enh++OK9oqYSVASc8Fhw1gV8z7LX96qz1Qhi9pUld45S5clFZNdFTF9dl7UdUsXzidKkR96; 25:2UxA07DszXZKzuzXbfUZaWB86g/StsRSUB1m4Bql/VAyNvdufwblpmZ0x5R61PUKzb0das8LW8EsihbEITjcGPRd+9qYYWl9gQNA0QJ9euW4R7vo4tsqYUEiQ5EDktEK7rN1CnnUEhOVhmMsYcTq8uiuJ/f+W9abgjH+HOp0Oz5/ECCTp3ioB8b45LaByi32ngxKV89m4n7A6LbC6R1K5xspUBF41gGOHcgdrYPHJC+PY4XZ1wLhZXIF1GK8KmOTUgP8JNCnB9kCeTJc2dqKPAUnShqMMjnLIuJTqSILDprUwyRIYe/9tv9fd+8aKLwKbYlVR3/QPhpX/tN8CI4aZQ==; 31:k3UXn5B8h2TZ7ARS3u71NDb8VCjAF5nxR9M0VZZ2oWCGzTYPxbhpj9NHmH71zpwJfii9Qqsd6VETWvpE+mhVRorX0ap3zPdvsUTlL1AQrt02CEk6PmMtzVhJxaxhKW5e4r/Dp6WUm1eBpYw0WDu/cpBfxlg1GzDE2B4aD+sJxm0uZv1eZ5yYvin8BCkfORLnENlrk7+afRrEO7QMc1R2ODYCQZCZcurT8JtSjDZalqA= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2041: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 20:J00sJjkm7ct3mw56OTvHuelfZ38d0nAJZPZQTRpdO9Sq77Qn+7PEi6cgvkPYvGvfw4ByaTctg4K3HfRuJRrNrY8EW41FAyZB0kvHjf2eXu/Bqsicf4QEwqcJOHnNC9rFyyy58KmZ4n/qvtcVj49UobCVcQa5S3uWB6PCi5m8Px2sArdnKCBD8K/Jnp/awoYIyNNvDgqopdA2E4Htg/NOu2gTWy3rtBnpfpL/4+z64K8tdt8thotEPTupa6d7gUc0lXRj5i7UHE4PL0lsU2SKZWaUlx+GjvkXtJH8TSNSBaKUSdCOXiVn7KEq380bm8p2sGL6fiNVMXVEE+W6FivxF9O/SAv9Gg8fZ2kJET84PfZnsffeGEuIyrC2+5Q6FWtYS73qBLISDqNeTqceUh7Hk5cZHElzRcbhMNBhaRYwRdFMXNPo3KSdODuNw83TKlULm7Xf52xXT20qfWABhv4Ncqf+9KtcMWip1sGl2THEjjyg3nvRthVMEW8yDMcVLnTZ; 4:82kmOS8D7EiYb+Ved5trYzE+0au1PcCRUYq9ogxuZ8ETJNAO7jl+cJ9tbZFXdcFad47krnk6bp2xKu0yZm95qHnCVslweDD+NuJ8pjAztSS8Vf5XCinyN20N+/X00orbmKGmInOuIaF0nxI7vWEJ6OWj3qy0fLm6JmhCuXEON4+2nUmMgWGQpEApPgHonaKF5KEB3WPLF+xKwwycRCl5SdoTmCwDn4NOXuY6kBU8aqoQJEaP05wuQAtPjhhMtDQtaNjr+RL4lazueMn7jBr7EyjgSk+lIEHgc7rJ08d73U68tuUr1iTerkupMMAYsrv5 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2041; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2041; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(136003)(376002)(396003)(346002)(69234005)(28163001)(189003)(199004)(6306002)(55016002)(53376002)(36756003)(4326008)(76176011)(2906002)(105586002)(26005)(2616005)(25786009)(956004)(486006)(21086003)(386003)(966005)(106356001)(7736002)(86362001)(53546011)(50466002)(16526019)(1076002)(52116002)(8936002)(54906003)(5660300001)(11346002)(3846002)(446003)(66066001)(81166006)(68736007)(316002)(69596002)(7696005)(6116002)(97736004)(53936002)(476003)(81156014)(50226002)(6666003)(47776003)(23676004)(6916009)(186003)(1720100001)(8676002)(2870700001)(305945005)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2041; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA1MDFNQjIwNDE7MjM6RnN5bnlpKzE2VXNSbzRpdWYvU3NEc1Z0?= =?utf-8?B?SFUwbUV1TlF4Z0hTakpBcFlJYTh3RUZZTDh1U1l5enk3OGovakl0VVpkKzVR?= =?utf-8?B?M2g4ZHN2WHNOaFNNb0dHRkNKeVVHcUtROXJIZmlKYUFVK0NDUTZhZHNzeWxD?= =?utf-8?B?OGtGcEpiOEdDazNlOU0vSXRYSzhsaVBCMEs4SytyUDRjb0pEYVJwVzdaSldt?= =?utf-8?B?ZUVZZE5QU3p3QzAzS3JTMXJRNXpOUERmZis2aVg3VlZ0UktkY21NcnRMcHIv?= =?utf-8?B?RmVzdFBoQ1ZGNEVYbWdmV2VWQ0JpcjBHNEtZNXhRblpUL0x4RFdEZmVBdnpR?= =?utf-8?B?a3E0a1V6bVlYY0k4b2tJRTdjdEhPb3l3ZmZlaXA5amdrNmpnNUxUM3VyNzQv?= =?utf-8?B?RVNZZmZpS2RKMU1qMWtmQ2JVeE4vdk1KdWVhYVR6ZmlHU2VLT2E2SzVJcWh4?= =?utf-8?B?Z3N0RXdHSFcwQWN5SDRwZTFjU1I3Y3M1Nmd0YXJrNWVqMC85UFF0RVUrMXFK?= =?utf-8?B?ZC85UjdIalcrZHhmM2QxUVlOVW1JRXlYUkd6V01BMlc0eXovWGtXV0l0UnJq?= =?utf-8?B?U0o1ekJBOWQ0R0J4TDNNTVZ2S00xMEJEZW1jMm1kN3lpWHNPY2Rvb2xjREM5?= =?utf-8?B?NDNtVFJGclFWZ1VkaHk2NDBVVHk2NWtRbVVTdFhkYit2YkJsSTcyOTR0M3N2?= =?utf-8?B?K3YxYTBTQmRIUHJHRjl1cUN2UWM2TTFqRWRSaXU0ZjY2cUVTYkhTMlVOSk95?= =?utf-8?B?MUc0UUFSb2tmd3NnN05mTU1lMkxDTHJUendhclMwa2VranJnOW9panpKdy9J?= =?utf-8?B?OHFwTzVVTDUwWHpmdVZYSlVMWXdaSFI1ZDVKWTJsS0ZLdzlVY2lUazUxVWow?= =?utf-8?B?b0hxRDlMTy9adncyYitlS3RDSEtacXBlb1UwSzRPRUlMeGxhUjZpS1c4VjBy?= =?utf-8?B?V3ViM1BEMzB2K1NZREo0cTRMUHFtcVBYQ3I2TzVqamVhZ1NBWXczVmp6aTJY?= =?utf-8?B?UTNxeENiR3puMm1rYXp4WThNVTNKVUlLZ1V1WThDdC9laEl1OWlXbjU1dlRG?= =?utf-8?B?SEtJNUVZZUlBT3ExS3dHRC9hVEZLaWM4b3dRNjhOOHByVlFwWUpXaXZEdnVn?= =?utf-8?B?WlJ5R0xvSU9pS0t1cHB4eEJLVkdIdU5KTHlyUFc3bnBWRWpDeDJrZlpJY0Nt?= =?utf-8?B?YUo4Z2FmWEFKdE5Xd0UwZDVkRGRhRVJMVDdOVFI2L3cyclZjc083UWtQNFEv?= =?utf-8?B?d2hxUkNqYUNLaDlMRXpBK2FneDFrK2ZBYmZETHViZU5Zc1k5bTVSc1NyWU5O?= =?utf-8?B?VU5HT21aOGEvaklSQy9wbWtXYnBZbzVBQ0lHVG5qYVVkOTc2TVh4Zytrbzhu?= =?utf-8?B?V3ArLy9iY3BKRmdoaVVmeVI4ak9xYjIvRSt4OGF2Wm1idkprUTdIYnBJVW1B?= =?utf-8?B?YTA0QktiL1MwQTJ5L2hxcG1UNkU4Rk1LOFc4VHMyNlZpa29SZ2prTk5va0NO?= =?utf-8?B?NXMyK3dxelZqRVNyV3RBV1VmT0lqUEUzcVdrUlEzR2hacWtZQ2ZIbC9kQmNz?= =?utf-8?B?RE8zZnBHK1dnaERhVG4rVzByUUl5RC9Ea3pZUG93clM0aWRpalBsVXlUUmJQ?= =?utf-8?B?UlRMTG9GRG5jcU5TYVlqL1A4dXZmdUoyVlF4RUwrYW8rQVdDYUcyaktLM1BU?= =?utf-8?B?N2dqYm5PSU1lenFUa2JhNmFrNXovU3J5bHVVVEc0ckJ0YWxNYmtQVnJQWFQx?= =?utf-8?B?OGVySFIvcE9VZHl3TFZBeHU4c3NFbXZqN3hTTmN5NGU4TVpsYjQ2UUVZU0xa?= =?utf-8?B?NnFNMjRhSm5jcjl1eS9ZR2k1T2xlUjljWW5zUWJKREc4NDBwaGxyakk4c2Fw?= =?utf-8?Q?hQgY3vx1xZtUM=3D?= X-Microsoft-Antispam-Message-Info: 3K3e+k6fPkCIk1JZa+ZefXFlAYKeTPqLvfyistycZI5kzJ3Y7LgKVAVr+Oc43CZI1jjn9GK0Do8AjF2i6hOyqHAWJTLH1wRgMtT3Di1+hjsK2bd2VyAfY6bOntU00Zt06ueJ879UOoNggjrPz3MrKl9tdG+Wth2ori1FnTM/xr0L3VQDuhg2eMlxvnaSnXetVxjVfhLPJpPyT6NN7KbDCF2f8NWN4obbE42c+mKvQjJyOVq3qpzopwXXF3Wti5aob51SbUG3WohtNtKpsAbhT7IypUIQrzUN6C1X0ZSpFxzbpyMOwerG0OQ2u6OBDrly5N7COPuKwPZl+je39oTP9upYYBGtyjzp+Sb25XI+q5U= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 6:fFnmd27jte1sHHQoJEZTBcr3ZAAUsudQ9B6yo8tiAUJgcLFHMoGOLm0lacPZBNlVHWdCeKtBF377G1Owka3MOUG2nMkXY9KeDftwuiuZxZMv2s9bEUIM+oNIQkFlaRlzJMzDTDkMmAGXfMQ7hG7vy9hnTX3l8CPtsh1dY9b1h3+1nMCx2aGnRe7hycFl6DEwchC6Odbk//knFU0lS/eIJB0ObMJIIQF0nK4+r8c5G5Urvz9B+XQoyYrNVBQgl39+I1Py7eVzeYYL6xTMfA/g52C5SOAhC/uN4Z1XtGwfYdUouEYJ4V0ehg8r0DViS/4x/lETRU1JGg8rmGvEcB3sf5u0f4idpHBTAQ0jFVOPCN20fVwjSSUwT0XCihDAl7eKa1xumVZzLa2W5A5jO1tI4dDpIFk/htOcnsLZFb0LdLpoHQJJbAxWwsrRlKPbJrvS4ecfVY1iRZbqSMyVOYOLdA==; 5:kMq9ayeY/KOKEdarABP1ngsFWIWy87IS/1m379P6fSFMEXwNUWsp+A+Tkb4UorK90vcD+4mhpV8xjSR6T6t7RfF9RXYTeD87JBa61EnvKCbsS9gqC9CIF3S+WAvqippR4DtPiqpNHvBOH4Td793gZufjbpYq2Op7OB8KnWtgw2E=; 7:oSxcS+kJhFOJw+A3P2UyEpndU7DxfIiphbw20CltsOpQinIvYWWcEtCHAdtXbW6JM6M57B+oyKS+dP475StIAgmbWzHiAWX6yxTOhmbG3JMc6rWjptOUfhKxBoknV9Z6dTRZEVRz7+fCDkIHJwa9VSeCNb1ct7nT3ehN45eNkuBX2yU961cyiu9MgtR30u8WcwW4hs95+n1xKjudSFc0Hb5ts8WcqAEk4u9iw8eTUWMHod+XnghJae/8v5PnJSAY SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:11:05.6410 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 335bb3ce-9c43-4cd2-6114-08d5f3663668 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2041 Subject: [dpdk-stable] patch 'kni: fix build with gcc 8.1' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:11:08 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From e9106897f3d7ca13353df6ddea61f1c68a829ad3 Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Tue, 26 Jun 2018 12:38:07 +0100 Subject: [PATCH] kni: fix build with gcc 8.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit a36b40dd8ecfb61648045e418551f75055ca77f9 ] Error observed when CONFIG_RTE_KNI_KMOD_ETHTOOL config option is enabled. build error: In function ‘strncpy’, inlined from ‘igb_get_drvinfo’ at kernel/linux/kni/igb_ethtool.c:814:2: include/linux/string.h:246:9: error: ‘__builtin_strncpy’ output may be truncated copying 31 bytes from a string of length 42 [-Werror=stringop-truncation] return __builtin_strncpy(p, q, size); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Fixed by using strlcpy instead of strncpy. adapter->fw_version size kept same because of c3698192940c ("kni: fix build with gcc 7.1") Also next line strncpy usage replaced with strlcpy while arround. Fixes: c3698192940c ("kni: fix build with gcc 7.1") Signed-off-by: Ferruh Yigit Acked-by: Pablo de Lara --- lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c index 95e262b78..aed14bcc8 100644 --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/igb_ethtool.c @@ -826,9 +826,10 @@ static void igb_get_drvinfo(struct net_device *netdev, strncpy(drvinfo->driver, igb_driver_name, sizeof(drvinfo->driver) - 1); strncpy(drvinfo->version, igb_driver_version, sizeof(drvinfo->version) - 1); - strncpy(drvinfo->fw_version, adapter->fw_version, - sizeof(drvinfo->fw_version) - 1); - strncpy(drvinfo->bus_info, pci_name(adapter->pdev), sizeof(drvinfo->bus_info) -1); + strlcpy(drvinfo->fw_version, adapter->fw_version, + sizeof(drvinfo->fw_version)); + strlcpy(drvinfo->bus_info, pci_name(adapter->pdev), + sizeof(drvinfo->bus_info)); drvinfo->n_stats = IGB_STATS_LEN; drvinfo->testinfo_len = IGB_TEST_LEN; drvinfo->regdump_len = igb_get_regs_len(netdev); -- 2.11.0