From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40055.outbound.protection.outlook.com [40.107.4.55]) by dpdk.org (Postfix) with ESMTP id 89F003238 for ; Fri, 27 Jul 2018 04:11:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ld40YMG31q3bhkqlHC+faXjqkO3y9U27BqJAjeFuKWs=; b=jxEoJ5rfKtrSTGPFUHdAZ6JtIo+HkusFr5eS0vco2eUGIL7eEUUgV3M+pB+xzHm9AKCLvyn0to2uyl0jtX7iKCCfECraLZfa88kArr+P/n/cowjscjZQealWcCeFCxblrtO/LTCZ1FILZd7RktNpeK/FMgpFRqA6PXMXyBsLUvM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:11:13 +0000 From: Yongseok Koh To: Beilei Xing Cc: Qi Zhang , dpdk stable Date: Thu, 26 Jul 2018 19:09:17 -0700 Message-Id: <20180727021019.37388-21-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727021019.37388-1-yskoh@mellanox.com> References: <20180727021019.37388-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM6PR08CA0022.namprd08.prod.outlook.com (2603:10b6:5:80::35) To HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6e67a942-9f7f-4b3c-aceb-08d5f3663b36 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2041; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 3:LdqicQMTAK8UI3bXFXOic5J1ArbSJOaq8v7KggdMI0q8uqZhyJgjoQ2PMlVBYzt7BJdN0/dT3UwADi+THwEclrL8U2qLaFYCNf2l8lazXJy9hOUaQUz/zcb5vWNX13SJLcOAqWwN9LjpbyJcHXq/y+noQ/RIcdgqVnd0Rx4hv5yFO6tjaMNYFaqxfjrk/F8VZq1gDHDZAZ+f1iumzl0TAgJN/kvGgUB7fLIr4/imhfXLmdurLUO/cx84ewu4HMa7; 25:CNB0zDICyuuAtahAJi/KdaTlTWj8RKgf4CpymKNIAgc7/kXGjTsKYjwTbQVi6wkKk0ImDb/mXYmgaNo9dOnzp1MU4xSHjcyvjPAYFGBsoBYMvmG8KsOk3V1LhquX+PvYEWZoAG1/qfUCQil97jLGmyBxsS4aflrV/T+7h2TfiFJ3w0Penz402l6/h/DQfdFCKYTIxBC1681/NwMbH74RskWRfOxZJy+a1G0NdORtUxmZPBiUwCJ49SPNFKnj4GeGq8a0IqhZof195Wwj+7anN+tTraDUC2c3DfjKIjQ6OQeYZk5ZNyNDXpIsrItaR20WbmVjqjW1EIbCR6kefaFaHQ==; 31:SqqeqiAuZpt6elb5F9oKdh4FJAMwN6nRWWbbaHUSIU79k2IEn5GOXJ99VQN2WQj/5wzLdaXW3ZQjf9i3ONt3cd3Lm7ItsyQgRfUxqKa5k3uKvnGUQXWkTt0DtgNv8I4D30sDRj3JBuiGghFs9Zwz/QWHc7kH2/8LyXjPF3itzlYXnSWv+b9WRAIDVagTEHXyxvb5Y4VvwQSchk9xSTDos+wzT0FS0dgTrLO1MnCBJpg= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2041: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 20:cdCZPx5klEgVRYT0XWqybiCEvIVTTgeBPL0HSH19DiPSXwZ0Urm70bmEjnE/t2EVFVVUC38uzDcSTF5k4sA43LRltIni10n+k5xcBGQKYNd5KuGWDaI8bqdRakb0eFc9JSUyeO2rc0ImRmfb3426Z6UAzs2YACfEVjh4CX7nX2LYjio3cSHz4hMLAHuPYam1Rqb2moB7yCE4s04vljut2H+Qsmt7LQlNLmncWFkT4MCpfKV0SXioYbzoTylx42TD8hlrwRWj+6rO9WibMjM6EZcxFys7hB6Hxt9fghuYFaf2lr8hkmI91fBCFQHk2otisQbJol13zpmENzZwG7BZj0Dgj+nP5LTPNTlAlLOSXW5HwK6HsY/nbafohHxAxftSKUwWNdrWxL3wuGNsa/MwukpBala7OsDCs8inAoNyFJVD4+gnM4yV0gwqCBziiHVdn844YlYGIl2CTglNr1GLRAkub8mszXHYAi7iQ5gUHfC52f0aZw0JC0iurH/56ezQ; 4:t/TSOUMtFyQa9PeaDO5Vztou8ColKdrIqQCaziojzfB0qpV0dJPsrH7ZtABD4WnXMBVftBfcDKmdV3M3IrhQSHmN8LwIEnOD/LKOdLXWF8aRZdRdI6y5o2ls2Hdv0enhI2x3L1ILYgKFJDAuHJEuNchuHnlFuBHNUJmKiQ5r5W7tFV0jzkJaSXJ6k938Oc+oISczdCYAqrat/2PssYQncUU8uI+R5p7BQ/uCalJbM5XCVxfIKkVkoQ6qCQiohVAYY9rJQhWK831ZT5FWv2tpRJC/b+DrXjqTs8huaA/GfLa7txB2nJJkoCdSJ06tbFvv5oKcgWxN6PH28vw31e7QXjj2P/aGw9chEbfsIzU6kZE= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2041; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2041; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(136003)(376002)(396003)(346002)(69234005)(28163001)(189003)(199004)(6306002)(55016002)(53376002)(36756003)(4326008)(76176011)(2906002)(105586002)(26005)(2616005)(25786009)(956004)(486006)(21086003)(386003)(966005)(106356001)(51416003)(7736002)(86362001)(53546011)(50466002)(16526019)(48376002)(1076002)(52116002)(8936002)(54906003)(5660300001)(11346002)(3846002)(16586007)(446003)(66066001)(81166006)(68736007)(316002)(69596002)(7696005)(6116002)(97736004)(53936002)(476003)(81156014)(50226002)(47776003)(6916009)(186003)(1720100001)(8676002)(305945005)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2041; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2041; 23:gd7g/L++jkaOAqs1Es4oYtwu8muyjDr2nbIvdyg?= =?us-ascii?Q?HJZzQJ0DCjtxLIQE4wnHsWTXSjrleTDd03O/kAg/yhM2ASWCLrwBsH1s7b05?= =?us-ascii?Q?gvt5qwuBiMM3pYPKzOsabk60zht92NoK8E58GANMOFc3Z6vESfeY303dXhAw?= =?us-ascii?Q?iYKeVlp83nqEVTciVEmZx4Jrz5sDF22bs1eOIHi8BT1lt9NG6QCd5SzbLOb7?= =?us-ascii?Q?nqWGxadph6zCieFR9MUKUCtKeNFRF/o2BxsCYhYy04pYpZswHBh0IQFWss9t?= =?us-ascii?Q?7oIRtGKaqT8Gqxfm0mzWxsb4u6axKG6ZcyLEZ5Tw1ocJzZmJdCZQarUVNviF?= =?us-ascii?Q?P2KyDbcBmVnl4C/mcCkjro0JOdl+G+IZM/tIKVT//lrPw2yN5pkbWRSfdBpW?= =?us-ascii?Q?ezNA7crduUuIdBx2i1snvqw0gKk8YL86fWZ8C3WZUv0X7PCpdAh4O0LNf8DO?= =?us-ascii?Q?gqhk252QiqDHltmXlBuWTEHjUyQ+sppy0hLBWOREnELnC0VpRFlhsHCgVe3R?= =?us-ascii?Q?Tw7hxlpUeCGZMTMbvLOjfSgVIpPdrQawpCa7LK1KIm0rxEFODzAUWvNJkG4o?= =?us-ascii?Q?kErCCyzP5ly9HK0MvGRSvJrknPh2OMXw3jCn9R6JfAmeCdMdbSasHxOo8KiG?= =?us-ascii?Q?eTt/rfWno7WckfojS7N0/Ksmq54tYTPXotmM2tgZktK/R0QSNqUEfmqhbm0R?= =?us-ascii?Q?/Vujt2vfiBS/sD9rWzvXt02/zNsumaKor/yoJAL9rBxfrLVfCo5za5+3pIVH?= =?us-ascii?Q?eKWUVCngVtQkffJMd02tTB8yupdGceTy+fTdWYaDwp3CpKOwN2Fnt3h5oG3w?= =?us-ascii?Q?esfmq1jACKCEWDmSHqPIVX/t/TgFX7K/ZFO3M3oz1STnreE68adxC/jp2bE6?= =?us-ascii?Q?LOhs/JD6oeykh/gci3GwtE/B5j2t8jmq2p99uezHOj07hnRyePZO47cKDsoF?= =?us-ascii?Q?TvcgYQtmO6+FuHMFi0jHz3WDjJWIi1r12HjjUR+gY/y8WLL/Jp0sKKUXABC2?= =?us-ascii?Q?1FpFCkgWGqfdl/TM6vXx7IcUkL5dVU+WEBPE1Pfe9bc0tTtBoP7vnEnXdxLG?= =?us-ascii?Q?9LtGtYDqlDYL7ESXpoDsqJgxm65NJDT2uhRrJzl4vGHc1RzT+0oHhQ3xMM4i?= =?us-ascii?Q?kDVTasSUb+sHIb4FrkKVmHPkchiwFlFIsRvj81z7kG5TBOoCp2Y36C9nWK/0?= =?us-ascii?Q?eWhayaq1haq/I0YFYqf7Uea4+J7axuzsZMLQpVFHf+nAoU2zjmJ6El3hnTA1?= =?us-ascii?Q?5iPv2mnY+xh/oof07H9BYGJjwr6C09lCbfWZFmhKyNeMPXIuLV5zdkpo3gyc?= =?us-ascii?Q?T6MIIceDrO8m7Lxocz1E2jb39q8VZn+sFHtlmKngLu0qaM0AI9Cx6+wI+5TA?= =?us-ascii?Q?C0yGQrw=3D=3D?= X-Microsoft-Antispam-Message-Info: GWD30FQc8DtvC4vC1IyzxY3tqQ87fAUR9H+Lu3VLKFJnzYR10ImWGTID2RmwLnK2uzTxu6y3k6y27MwkFAyzL9xIiU7v4qHZhKqVifIi6oCgVNS/aYp9f9vsqwDqaGpGgnb2xNHMLDe08EU5nkyeLqkHjkveryjbliJ7npV2+AsRbLmFRvf+mLB6E0d7MxWNN5LuOt4IAhkh143LWDQ4olnM3pKesosUdVNLFO0QZDwL78RBTGWb5kfgh60Moxn0uYkQKntmeWEMQBgUKctMjT0mO/lnicNgsfSFAKkCpR4MM1OERxDXBuTzPejwZ4Xl4EXwijVqFvF/U3p0ATqbj3oe+Qt6Jce2J7zdQuX5dVg= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 6:i5HbMaYNb8cWvhHsdwyySSq5XMravpuk6ll5SjlN9CG5G1DWhpCQ7O5Rqb3pjQoEVxLkHoY+EjWcT8xI56IyA0lSiDzLwaUR+2xB2tMgZhH9ZdyA3Vihnnk4DtycOvG0VrtvV0Zjd3rth7rwGZRp7sEiIdwiKUawjXtqxYpCR+lqUx5LLEzdAo6+n73LTAee84eptliKFfBZAO7EQCDpENzDB0UQvje1IIa5d7SuEhxJPQX01VY5ClLGXNExW93Ca0iwNwEjbpx/S8S6MyWf5aNKY+xD9qvoMLTynTuOsTdeSBbSrsmp5n61GuD8vXHXogoj0/y0yVqIQDsEkb2CAROA+FUCw8nRt68mChw8h7SjMnto93LJCuJOpC39Anx/CRmA0dXhXD3E7iYTvZy/N711aDKoALudu2rHK0WlIQY3JoczQYC0DlTk+QZ7LmFMG3rafqWdsVHNpojDZL1CcQ==; 5:pGpbKOh37AFrZ/SL4pfG8SVrRrF1d+KDUTjzvQ2TfNy3PVXuBIc17YOf5KhC8gqGJZoyu0UDFKvB+eYJrmx3nXDDgteNn8ok4FkAcUSMSSB9WjTFSyC5GEYYxJzLG3QgeW97vmaMd9xRLwAnM4PIWPUHwyq/D7MyMYojpGRXXrw=; 7:cGmtVvardY8sngAc9XD3sjx7ykQUXhC63fzR911fjD2E7vCmgZAHRor5tCF/sLhJ00zTnx4u7w4n0BpjkFRNEM16nF4uSMZhwksIlkmmyDUcAJ9U+Bwc+RgM11PqVm0YpYKYMXvGTwKWVpbVH5zqbSB5BIa9nlY/qRVGY2LgOg2rIh5A648ogyR2WfXuI66bTuts5FlO5x4ee/Z1PVFrsIKTNc9vvfmfdQmD4kyRYdwJMYU4y6UdJQ02oLMF8zRo SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:11:13.7195 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6e67a942-9f7f-4b3c-aceb-08d5f3663b36 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2041 Subject: [dpdk-stable] patch 'net/i40e: fix shifts of 32-bit value' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:11:16 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From cd21f29cdf3a08ecd689b9109732ff92726f69aa Mon Sep 17 00:00:00 2001 From: Beilei Xing Date: Wed, 23 May 2018 15:46:46 +0800 Subject: [PATCH] net/i40e: fix shifts of 32-bit value [ upstream commit bc98bf3a2d0301a17707bc04e95fc32746a397c4 ] Cppcheck reports following error, (error) Shifting 32-bit value by 36 bits is undefined behaviour According to datasheet, there's PHY type and PHY type extension in setting PHY config command, should exclude PHY type extension when setting PHY type. Fixes: 1bb8f661168d ("net/i40e: fix link down and negotiation") Signed-off-by: Beilei Xing Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 85baff9e9..660175b31 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -2015,8 +2015,8 @@ i40e_phy_conf_link(struct i40e_hw *hw, - /* To enable link, phy_type mask needs to include each type */ - for (cnt = I40E_PHY_TYPE_SGMII; cnt < I40E_PHY_TYPE_MAX; cnt++) + /* PHY type mask needs to include each type except PHY type extension */ + for (cnt = I40E_PHY_TYPE_SGMII; cnt < I40E_PHY_TYPE_25GBASE_KR; cnt++) phy_type_mask |= 1 << cnt; /* use get_phy_abilities_resp value for the rest */ -- 2.11.0