From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20067.outbound.protection.outlook.com [40.107.2.67]) by dpdk.org (Postfix) with ESMTP id 7AF4214E8 for ; Fri, 27 Jul 2018 04:11:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cig0YLQocIuhfKuZGE+bIgsdf6gINlAGPfNbpUU/eQk=; b=IwWTBtFtdT8cyzqAao6I7SvOm4B+86Ime4irw/XJv8/Cw5GFJ9AG4a9i7mUInh2i8rLL5bfTZgCEQtUXmmx3LdShc98TMXJs5NlR8ecPiQX7S0a/gxZ3YV7+Y03oluAEo2BnobZUo+EjsgIlr+doWOjtQnL+y+RzR5twBr1w2VI= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:11:20 +0000 From: Yongseok Koh To: Ferruh Yigit Cc: Richard Walsh , Jerin Jacob , dpdk stable Date: Thu, 26 Jul 2018 19:09:21 -0700 Message-Id: <20180727021019.37388-25-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727021019.37388-1-yskoh@mellanox.com> References: <20180727021019.37388-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM6PR08CA0022.namprd08.prod.outlook.com (2603:10b6:5:80::35) To HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c2ab228d-7975-4d38-b0ef-08d5f3663f3c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2041; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 3:uVKHLBCCifd1CQE4kZq+J323B4SQS2g0mdVR1ljOJ21/idKQZmIXE3kgFErCFjnWEhlLnI23wqRGYwxTm+L2Wx4BaJKlMrergW3b/hGjzMCYTboWE6d0lSd/2DKUYxwIXnfVqyJsbGgfFBRft6sj0j9huXIDxFUN/BoY7c2PrG+SKruSXLwqb7g/d1p2CL/oQ/912YO3zDspAhVhJxDfJH4FLqfVmjsxbSfjbmMuac1o+X2v8oGQOsAXv3VZbsJd; 25:+i8e5rBdcyMJHl6UFd2FzCVuFqY/dwSWr2u3bPWT9SBjG4dDE2F3QWfRWxgfTG6kUkAtKFdDegzfKqj7iRICO2yRSlqPVqC6UyVXnxrCjPON8I96veFRieGWngZCJE+fkfXwC3P+0qfTOss2MMvRkPA/lR1sgzvoy835+2Y5ycrDjSZHr8SVdzXiDjrTL1GNl+pvcE/d10QEg56aG1q8yFPv/v1C2K0muBRYEeJO0qNRTJDBdSJ4ZY0Tqc2VH2fiHWPBOIWSJgt2CtD2NEbCKpAczBSrBb+Vo5GHhZPPd+oXTeqWmMNogKpQ0blhTCMPfMynO9uKA041mlVd8qITuA==; 31:RNaznCZ0fMS1kzYot363P4Zs6SleDp/cLFPoXHgy3Eelnm26gLfUmvhOa2j2chArbOX6r3CwkQ9gOxWT8rvSk7e176X37tDZEjrI/VtMhjJ8nupTDelI7IM1qtODaRKH1xtBgjY0zWYA5qhwf/ACd/HnThLR0nWl0vmytadl1Yvoehr5wI0KyGHGyG2rAhUg3Nfh+ygpR65IeGFJE310i2kyfnNA1byT+2YwC+OUv5A= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2041: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 20:WCuL+owl9T6LOZVy4JY3eejvrgiP061x7PviYZby+0PS0JixFcIpqZhivot2P1BrryYz7F4yqXVCp4ayxdZY1emQmvrXkKisFXZG/T6w0tvaywBr5vBf6IZNNn4tZDWVRwrIrK6OOZIU+sjMwTHdgVV08tHeWdIr4g/IXtISqapXzCA+/N8SezwgwYeyspCqBM3vupjIeFFY6it82UnSUjKPH/Lhhm808C0SkL5VZ3QRKu9pd8W6LO5uQX5I70qOt0Te8YYMnlzml9zfP95szrMGqkortaRQ7pCzP35eBdat/6AFbQthzdrNDObV5m2DYqU66QIBxCfq1MVUyyo+aFgy9zW2eXeA7mykfwGsdUZ6KMYyzH4sjOwUM3r5NzH+tPNmFTEGF3/iOAAi5Z4llrkYjU7BRYoyaatfFtHHevvEw+CiNl0MhehbK1Y+slaaUeFj6r8K1Kpj2Zj96Sp7++hVkFKgTiaBkC/EknbCs5yNWXsGUxsOY6MN7uW37R1J; 4:RIKDRFrc60hRdfYkMIGgwvzTQaKnb7kOJh8ogoWbcmeAEnXqPpLdPmcjTUfIwfxEGIaoaR7POtp5W8fOjLkV6xRrEeaxJJFZeh6f4yjCn5aukFyjkiUBmoxInBAelfsdB7gnWqG/OemMm/8IUqmEm3QVWIewTu+8ZGJyqlbzb6m4ffhwNaIucq3D62YgUhDLrAtwkqobTR8BcH83yCxv3rIiX2bj35UXVLn2NUZ5x2yuvPgGpAlSO6On/PmJ200qfc9sU9jMBoe786o2j06g+XFQF7PhuKXmIYk+XIM3OJ0WnSMZlRnjPLZkmNPdKovc X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2041; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2041; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(136003)(376002)(396003)(346002)(69234005)(28163001)(189003)(199004)(6306002)(55016002)(53376002)(36756003)(4326008)(76176011)(2906002)(105586002)(26005)(2616005)(25786009)(956004)(486006)(21086003)(386003)(966005)(106356001)(7736002)(86362001)(53546011)(50466002)(16526019)(1076002)(52116002)(8936002)(54906003)(5660300001)(11346002)(3846002)(446003)(66066001)(81166006)(68736007)(316002)(69596002)(7696005)(6116002)(14444005)(97736004)(53936002)(476003)(81156014)(50226002)(47776003)(23676004)(6916009)(186003)(1720100001)(8676002)(2870700001)(305945005)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2041; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA1MDFNQjIwNDE7MjM6Z2VWRzhYMGpqdXVlM0REUU95RW5jU0U5?= =?utf-8?B?dDJuL2p3NnZGUUUwV0tlV0lvWW5vSkkxQ2F3RUd1Y3ErSzBRaTZFUGs2ZzRk?= =?utf-8?B?c2xCeXo0WkdLK01hNllvcHV1ZS80U0szUVViV0xXMXh1YzV6eGR4NklJQUdM?= =?utf-8?B?b3ZZSVhjdUJXZ2ZkaE5rUVptRlRZdE9aTGk0b2YyMTUrYVFTb0tQRkQvSXd0?= =?utf-8?B?SnRoRjFkZ0lndHJSUUZENHN3RFo1dXRqanJTcDN2Y3R1N3dvYmtWVWE5emlm?= =?utf-8?B?Qmk3K2F6T3RVVkp3U2FhWFFSZDdiai9wZjJRZ2dpQjJGeitCcnl3bDM4OHpi?= =?utf-8?B?S1puZndZZzltMHFEc1A4a0xHOEhYdDRiTGh0UTNUd2FOQnVrNllvQ3FHYnUy?= =?utf-8?B?R1hrclJUR3FHNHNreUlBUFRJdjZnT0dnNWVweEFyZW41Uk0zdm90M1QwZXVO?= =?utf-8?B?UExUN25sdnN5L2QvY0RmRFc3ZlEwNHRBN2FVdm84Yk5mYnBNS0VKRHY4cWRI?= =?utf-8?B?TVIrQk5LYStSNGcxZGJkWmxUbWRydGt4bWEzN3k3aG4xdXYzZWR3ZkRLS3lG?= =?utf-8?B?ZnpGVDljeURqMnRjTUhuUlBJWENtSk9NaU5Kb1FpU1pQQkxra0Y2Z29xWFpi?= =?utf-8?B?cGZhS1RhNWZQY1k5NkNIejJNYnJpWVpwQUMrbEx1Y2VweWJjL2J1YzdiVUZF?= =?utf-8?B?R0U5R0tTQ0F3WnRVcEpoMlQ2QjFUdHprYnVHWmlhaVpGa0FaeWoyWDhTVUtu?= =?utf-8?B?bmRaWUFYR3VIRmVuMmMrNzNnczF3SUJQaEMxbDY3SVdkcEc1ZmptaTE2YnZJ?= =?utf-8?B?d0FHZE1OWW94OCtpWXd3YkpZUFVyakw4WTlyVTZNWnhiczlJdnZHZlJ2dXNu?= =?utf-8?B?dXdGSnpnRGlYNk5ZQi84N2V1SDNYVGtFM3JEZjlXWDdMWWI5ODFOd2xHcnpj?= =?utf-8?B?WUdoOUYrRlBDN054ME5TN2pOV1lURHlTUEJUZzdFd3FvdmZjM3paK2J1QXFj?= =?utf-8?B?b2hCRjZHZ1pRelZkVTJUZlhCQUtJWm8xR0wvUmhlYVZPS0pKTmx0RW5veVRk?= =?utf-8?B?N1NwTU92bHQvazNjc2lQT0pxRzRNeDRtcUEwOGlRanZjbE91YWczcDZLL3Bz?= =?utf-8?B?M0YvU2t5c0Q3OEMrbWlxWmk3bG0razJHR2lqa2dvMHNFT1V6aXMrUkFHTnpx?= =?utf-8?B?R3BIc05vZXR2bGpTaWFZUnErNXNhOVY5NTNwRGpCT3BPVktmb05nejFKOFda?= =?utf-8?B?NEpKWW03L1Q1Vmp4MXFqZDZNWm1MVkd1THhQYXNBWlpQL2hCQjBXN2Y1WW5i?= =?utf-8?B?aDZxUmxnK2k5Q0JhczJqamgvbFRXVVNoVGRpQUZFcUJDdExqbkxIY296T3hw?= =?utf-8?B?Vzh1UFMvTEhuQjBWbGNqNmF5TWlIVDEyUE1uUVIwN3phWXpMZzNxUFZ1L21Y?= =?utf-8?B?MG9yVm1qTUlHZVRRVHFDMzh1NjA5bXY4UEVNaWdwOURQSE0ySWluRkdQTStu?= =?utf-8?B?QVFHaFBHeWhLQjlZTGd0Y3ZkcElCa2tYTGZqNEZZajI2eGE3RVloR2NpQUEw?= =?utf-8?B?Nk16Qzk2V2ZXcEJ4UnhpRVJEVmVxWFUxSnNQMUVSWCtCSjZ5VmMzTkM5Rk5y?= =?utf-8?B?SDlPK3dMb2dvWXB4dFJJSVdTejF5MnJ1MzNRUG82OUxYZFY1dVVxd0srS2cw?= =?utf-8?B?SlJQdmRPM1RpSzgwbnZqZHZ0eWl2UmpVb3hKSEp3aEpRREJWT0pwNmJvb0pY?= =?utf-8?B?bGQxaFZ6MGhzZ3FYUnh1eW9NQXlFZFpxUVo2WXNPM1JDSys5TGU1M3VsNlNS?= =?utf-8?B?UlhHbkZhWXNPbkVCNnc0YUwvdC9RMU9jNU1hd1J3UWtiYzM4ZWk3Ti83UWVB?= =?utf-8?Q?uZCi2SFfSobA8=3D?= X-Microsoft-Antispam-Message-Info: WJqT2xsudIDX9IHa3afBar/HXgWWwsl+RKzU/VRxkY9j8siGXoxGUOVcUmJvAvDYnUY/w0gJ7qU0Qip5wtFFsxJ4qjc4X7jyEJsqLsn12gFvjDQK0iJPAvJxtguW5+ZmoQQFxShycKBZfLSf2arZqABDKXoor+HCopumbdCHXzvDKvfO3CzSDKUU65AyCWK8d/KbwkDYjtRuGm7A5qvUWy01R9AvM7sqAvMVbNFTx5gDGnpHxekJ3ExjXjvIgh5JIzCuDL9kW6zujzwCwq5zkyC+koVBt6nfN1hFw0miABUy88uW5RYi1Jm/omrnXd1qHy4AaxkxLltDVRq51BDWIlegmKLJC4mm1qQx5I1HXQc= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 6:sU9B6Z22TSD6ZoDFEo1iE3RDwtzpP4nUAnlbuEShsLqcXdMZGVV/AzYFrDOEZO0GBoo5WhwxXBZ0LLFbUKIouuHADdSV824yflLY6NsGIV76e7oisoHO+NmudeHYe+iy/G/SJqmbzj9okms7z2xMtf0Q4nD9Yqq1tcMF4VKv85QVotTmZxbqhTiSJbHfFywFSDzsto/OWSOsZnwYQLq2zUj03mMOkTZZvDd8P8pd1jTwkw2a/foHYtpC0SCb6qeDI6EZIYVg1vhQq1FjYcuS3iwphWyA2/pqFwTJ1qZD6T1BXJFrT4nspyzM7YnSqII1fBrogWvsAHfE3dk+hQcnLOAH9bwkswmNnp1dlZDQS3nA6DtuZIf2RkQ8EdtW66Vt1XMFAXhHjaFBzm5jvXvj9RkgLEmfqLyFyNxKh9Zi7ozB6mttCyfmQcN/oOhlB3urqRQ3kE5r6FmaI0emBuDg9w==; 5:8zKuVIQ2mCytGPo7RPD477nHjAk54fMln9CWzY/z315ndKrnow/Hna2tu01LEZGDFYEzT3gyH9a29I8TXeHJImljkXI9uweMuPU4f3p69WG9yBjlLDozA6nVStNex7NA9qBGMF8f/jrhGAX+Axq3vVD9NzAbjJ2FYj4iL176834=; 7:FzIahvf6UeazMPvrj4KGbk7UPUbb+XSzTI3S0dYgoj4nqVoKO4MuDNTSoWe7gqpvA3HZ/Defr9XoKKr9jReGt/5IQjzfhasE4XUqgMJSOKXVWkiqZs8501ueFe1PURNCBsMPSDot8htAiqjkg8cildswlE6DRGPwPXW0wdqgr/HXzSa2Lge+3oHEpIx6DfzfVFmHI1cSfNrZ2AtBF4smTZd5UImxUdQHwYWjWPx6QR+j+kjCBBP+88WAx5lT59Tz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:11:20.2823 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c2ab228d-7975-4d38-b0ef-08d5f3663f3c X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2041 Subject: [dpdk-stable] patch 'net/thunderx: fix build with gcc optimization on' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:11:23 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 147d06d845676d519c46f8ca22d2d7625b19197f Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Thu, 21 Jun 2018 19:14:50 +0100 Subject: [PATCH] net/thunderx: fix build with gcc optimization on MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit d90141961b9acead2a3cfacc7547ac1a256979eb ] build error gcc version 6.3.1 20161221 (Red Hat 6.3.1-1), with EXTRA_CFLAGS="-O3": .../drivers/net/thunderx/nicvf_ethdev.c:907:9: error: ‘txq’ may be used uninitialized in this function [-Werror=maybe-uninitialized] if (txq->pool_free == nicvf_single_pool_free_xmited_buffers) ~~~^~~~~~~~~~~ .../drivers/net/thunderx/nicvf_ethdev.c:886:20: note: ‘txq’ was declared here struct nicvf_txq *txq; ^~~ Same error on function 'nicvf_eth_dev_init' and 'nicvf_dev_start', it seems 'nicvf_set_tx_function' inlined when optimization enabled. Initialize the txq and add NULL check before using it to fix. Fixes: 7413feee662d ("net/thunderx: add device start/stop and close") Reported-by: Richard Walsh Signed-off-by: Ferruh Yigit Acked-by: Jerin Jacob --- drivers/net/thunderx/nicvf_ethdev.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/thunderx/nicvf_ethdev.c b/drivers/net/thunderx/nicvf_ethdev.c index c62371cb1..3843084b9 100644 --- a/drivers/net/thunderx/nicvf_ethdev.c +++ b/drivers/net/thunderx/nicvf_ethdev.c @@ -897,7 +897,7 @@ nicvf_dev_tx_queue_release(void *sq) static void nicvf_set_tx_function(struct rte_eth_dev *dev) { - struct nicvf_txq *txq; + struct nicvf_txq *txq = NULL; size_t i; bool multiseg = false; @@ -918,6 +918,9 @@ nicvf_set_tx_function(struct rte_eth_dev *dev) dev->tx_pkt_burst = nicvf_xmit_pkts; } + if (!txq) + return; + if (txq->pool_free == nicvf_single_pool_free_xmited_buffers) PMD_DRV_LOG(DEBUG, "Using single-mempool tx free method"); else -- 2.11.0