From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40088.outbound.protection.outlook.com [40.107.4.88]) by dpdk.org (Postfix) with ESMTP id 4D6E11C01 for ; Fri, 27 Jul 2018 04:10:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TyGVzLiW/88eWpB62bU+JinUoIqnxxaBBWdICF1STc8=; b=G7K49gOS5unBxQ+M+5esEs4WJkUWlEW09pAKgDpIO9dDi5fTtGwc6oTy1jeE9mii5vfCE1fbs+sDgkmYe50tywE99VmKOVy4ubwe8mHBovNZ0ZrZ4hfC/o7BZJ5K72FQf/jYuoCBwv7F6wy4Mig0jIh42AsdNOd79R5XuefNXZo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:10:50 +0000 From: Yongseok Koh To: Alejandro Lucero Cc: dpdk stable Date: Thu, 26 Jul 2018 19:09:02 -0700 Message-Id: <20180727021019.37388-6-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727021019.37388-1-yskoh@mellanox.com> References: <20180727021019.37388-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM6PR08CA0022.namprd08.prod.outlook.com (2603:10b6:5:80::35) To HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 168c347a-1cbd-401d-8bc2-08d5f3662d0e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2041; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 3:hRfsZzAAWtKLCoXhsyteciS9wjEyVDO6mF+lhoOfEmGrONfkBbNBVAdCLCHYn+ZxZL23IKcnr+Mko26Meb07H34lXuRTBpPiw26SM1si8QYN+LmKkFOUNdjyj0QwenycosY7DjCSaAxNKF3dxNQMP22JSAim2PKKszk/8SwxTiUhWl+HDsUqWo/n+2nw5UGOdxpJksH5T/36hUdJXZH+MmJ4yu9BnH2sxirOhJk0nMtKLhjMpl6EoldV1eRe+UAP; 25:QSCNImxLbcXw2mDWd+oJpThUajQHyUL0tfX3kWteltfpWROg4FHsxPFFTZ78LVaHWiz56Y9z19z1X+vzc9AKLG9yq1gUEPkI4I7ZNcC/AgXw3sf2m9zNI33/AHAPoJ5asd98UfcRt/O9rwdev+nGgxFR2RQBzhxbOtwi0Sn4VUVBMyYArKl/mkP48Rz6/cFGzUVT77MVh8XajI1EEUIxwjQg3sVVtAJsy916ntIO2Jt+LweQLNJgWbUNmoXHTP0/nqIvwGIi9C4n0WLVi+EXll7W+862LM05lvju0dTWf8gm62L1ozhX833nf0E8qDgrevYcyq5HvB6Yvh+HZIDAhg==; 31:6jPPaEIw4AAveIUqgmz3j+bRIgxFyxBXVjFzkfgGj/DyCa0x7vPyrAd1u0nacph+TmATUiNcLHsLohc94ce86DNTNH6iN6LAVIEsFVPAgrpidzXsC3LO3WsBW6WtNjG7p0zQICWSOpMPct7ZlYRrDDid9NueBnjnyPMfzKrWa7IRGNRbpcF4W69HFd5k/UakYESUGBFZ+TAbnTNQH8QXwHZdkDVq+br1Q74GPkJSU+Q= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2041: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 20:N7xRaU1KLT2/Z5mTGyYZhwetlsqB6r6dAE5Jt5nX72jFaVH0CBjJoT6wJ4X58OeIbKn0svhQp7hv59NnAhAUI3et95YZ0owFg5tzK9Avif1VLdqN9hy861LCARGiR1qK7eNUT4wkxyBrhT522/eMR2Z1jiLvc8vgX7y2wKJVZ4Lp/rA34l4HF4okl5/5rySJOgrLqXkEtWjg5omWI7YqXXJg+S3ZFHyDAKaeihoDDXpgj/iiqyFM7IIVmZclMYp6P6ttSOLDLNnfoqDCUyGLUKHpHfw+SPCudc/VoS5nqsVJtot97Wwz4Lyon5Jgxyh3HBhVaAt8zQ2qCFSZ7V/VnWCiboqwu/Pd4yO77vdkagkv9xoh4UwEecdaR24qqdXvaYYPDGak+j3mIuPFk201TL81DtKdPAuaMa6hEL6FIBnxj8CNQD9je2HAQDzQMrknhQoxsyicumDk8D5l6IxMa3ie+lEZGoieWhYfDJfOiQGS8Tyn/Xn7ewe3Jya+Ljmf; 4:fMjQyuOAwD9k/p5c3jHaR8cPsRwf9OCPhuVvPX+DTBGDzo6qkcpQb6W+LlyndGO19dk8v/vxnzsA86M98ZhZRXmThFZjSN67A0ifCVvr7f8ArYGs2XNCOwmP3fhYyk46LjNN1BbDl5EPIrhWtiN/7/eVDhK84cUjDyntF1Vo0sDIEUKzI6YPFwqQlSwt5XYXKe2uKSa278DQLAcnzFirDg4kbFe9ykq58D0YK+N2aSwWlFpOI+5r2So1oXbTSGKLUc4JhR+WjO0OWEVpnQGchw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2041; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2041; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(136003)(376002)(396003)(346002)(69234005)(28163001)(189003)(199004)(6306002)(55016002)(53376002)(36756003)(4326008)(76176011)(2906002)(105586002)(26005)(39060400002)(2616005)(25786009)(956004)(486006)(21086003)(386003)(966005)(106356001)(51416003)(7736002)(86362001)(53546011)(575784001)(50466002)(16526019)(48376002)(1076002)(52116002)(8936002)(5660300001)(11346002)(3846002)(16586007)(446003)(66066001)(81166006)(68736007)(316002)(69596002)(7696005)(6116002)(97736004)(53936002)(476003)(81156014)(50226002)(6666003)(47776003)(6916009)(186003)(1720100001)(8676002)(305945005)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2041; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2041; 23:D6KCj95gO6h194R6CuZ9pOfsyTzu8Av9XXI1ip/?= =?us-ascii?Q?qS6PCcnErKadYxHIrCXsd//ZbyV7eEKTtVlODdWBGDJpbOqyg8b85ymNBjZ5?= =?us-ascii?Q?4KPZ4sA6Y6UzS466r6wYdUsHRFhmVPF0AYS9L5oq24fHdc+ssm4Y+sTnwS5n?= =?us-ascii?Q?AIIarpI7cq8wyQIOc3W5VRCcEapBsj3p6PYCuDB0qQIQgqUXWNSoTx0FYiB7?= =?us-ascii?Q?M+8am0VpDh9kl/gh/UXMZxIGBsiRkLbJPq5Bxvvqf4Zq24X7P2ptJej1aD1Q?= =?us-ascii?Q?YtsgMZFC37N/V6P+FbAXZ8xyFOToQwxonQDQPybgog2eHN5UBv5MAlgXGl7f?= =?us-ascii?Q?VdOyFAZKbYFIr8AJRsSXyKJs2zoF4KX+OoWAcDoO/By/Yg1AFMNzw/h66In8?= =?us-ascii?Q?ilgvzDbuWuF8FEngAEjFAFkVGh2AF2PdzvhSa68tB0s58IyCVT3m5vWc6gry?= =?us-ascii?Q?0B4SDP+OgVLUwaEy0debS57iONKPHkrw5ngpXHF8PqvYdVdehEoXFD31GPeV?= =?us-ascii?Q?YUr6F9yS7CNf0YQzDlLCT0M6PhgX70WjZTHZ8jaVDPLzCO75NmPNNhLYR15r?= =?us-ascii?Q?gSb1g77WrpW8Yq9wmkYVPbK9OgArTZGwuFTKyGeWmDkMGS79+C51MDgWScD4?= =?us-ascii?Q?lKohISBuoWfgVptB4OsVi6l4SWcCCq3urEh+0h2/SG85gkxF1azS/xQBmt8b?= =?us-ascii?Q?L6VuDVtjnLLtYh9HVQj/woKQT9cHcs2mGhUIXvzGhChHkD1pUHjX0Gi073VF?= =?us-ascii?Q?wGns96IILF99tFMAT/2ymEC+cMc14RNXsRwbLMJ/116ErgNv4oUI5c3RNUeU?= =?us-ascii?Q?niUd9LxIIWhr8e5rtwvBBaPZOKI7OYM27wa2BRMD2rSn5IcQ2Novgli/c8tj?= =?us-ascii?Q?b/9CbATyoR4vlWhsxZPgNZFK6RS1UXX69iaVZEM3jnkMj6IDlIfYiTLR81Z8?= =?us-ascii?Q?2DGkbVL2t4xpLqJAN6EN7Y++K7n3YGb4BEIHCBSH6yk4DvkG03zJZwvpZfnO?= =?us-ascii?Q?o+cgbC8K8o60VJItDfvQ9AWbpT2/mJ3C3AF402SNtYUYEiKaSmt5GxMSCZZc?= =?us-ascii?Q?hAhETud4W/vZg/2nmeTCaccfKP/IhpVz8wcccnVKUk2VOXB9gYROWNVuK50N?= =?us-ascii?Q?95l4lONnE4QAHv5FNwrknkKuRDVq0G9qxuPQ+Zvl/Jl+LiRTLcfgZ5zIIMp5?= =?us-ascii?Q?WlMhVfsOGnyHn8JIhfPIebuBFa4mWexvPzf3vnjxhEyhDyixK0faBy5w/sI8?= =?us-ascii?Q?4nwSgG6WzGn1nYrX53ZNcxjxqGvV70lKWgnkIexsH4aEbI/Prt4n0z/4s/pt?= =?us-ascii?Q?yl3XY9Xnr5DD/O8yjKDnpHItryiRrTf6sdW0zuwAY8T0wTkBPAr4I6yL4N2N?= =?us-ascii?Q?s3Xta9qd+V44QTRg8prrqLngF334xCHIaW6O+gxb6Az0VokDTvnP+X1N2tlz?= =?us-ascii?Q?e/TvS8Hc8ZQ=3D=3D?= X-Microsoft-Antispam-Message-Info: RsGSWdVfR23HZ4MWueslWd0WjucPIdmgQEwQknK1VboeH3AoxdvsSnp6n4xq+FBXampru3lnwMZjB581IiwyXaGRK0k9M3xz8MXAC6E8V/718/BGYseuD9eeGZyqMvS01JUKg2uqUDT5ixdl3wxJcuUfFB3niGHS10V5N94Jva/KILLOc5nlaffz0fLXAT+iHRXoBzSKakubHR0m8dadA0wJIYpRZJw/pHdo3c7bdIu3v8RH1NcQUga1BxwfGPc+wOhUVrSUZR4Ho+HKs/1u/koTm1dZf+h3TYlnvGQBhYxixqKTjA29KYAJQjh7JwmcXDNVj9zD3H/jUvkCm+IDqvm4kpjoabjOlzMU9IQBlbY= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 6:diHxx67o/j0utt1Q7SHY80TdYMR/woQOByyvchLfqjoePkNl+nmqOMWxkzywxdGzVqB/l4vkIpqA6y24CZmCL+0BVcxuS/Au38fUQtlTOvVxvALWZamewv8hxsNT3024V64cnD29/8IwkJ0KKAPsmGZUyQZl2L3obFmLFGR4Nnr94qfaQKEHmuleEORi6DuwMiOy0oFGC97HBNVpqlZNXWH7AEyZ4HY+AAChM/ZSsmUXqJ5qe9/ahhr8PEPMYEvSAAEE4MPC6Ub9qppprReP1dZYXQNlhrcI0aFNclAwHdvez5BPkhHc2cIbThKnH+D0O/OHvLJuwNhRt+JBGTb3uSaE85OZuPWQuL+uydNgOC99q1VpU68WcnDSuSZU5X+mP4S+XPtWEFTx/KmwRF+1drFmji0Z1NoR5YzO6sdrcBtBytvUIRdAUQs29m2qlRR+B3uu8wq4YKa5uVAR/qYOYg==; 5:4YQZIg3l8gka799VwQEfDhIjg61vqvS9xoYPgbHyWGXrav2ILJ0AHIFVoPVyICmLLIUeQ1fg9RGoG7wAlzb66WIhze0kt3eO1teNETQSATg4LPVuGm3eIG2p4qxKwbUQ3eEcH2n4ZmB+56Y9NZIPZc86s0KWE2Ktuaf+ulx4smo=; 7:jaty/lbxk90poNxTMPOpCunnS4gnqxVNNAsjtJCvp8kBbi6bgjsNQ7p+Nz2QFERTz20JX9VyMG0+OyGwl8bst0lxf2Pt6KwrlqA005JCW2dOudpj+wSPEcVEhuEXuTtb4QfRHigfyFX38SODB3/083RE18Fx3KqkvX6xA8Ah/xQAW8c2cGemn9z9ocoJPEzF/se6rJwzDDFaSCRS/FrFq0Bz07IUryuXVkSixcHdcCnQtQBrE5TrQYZMObOSRQqU SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:10:50.1559 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 168c347a-1cbd-401d-8bc2-08d5f3662d0e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2041 Subject: [dpdk-stable] patch 'net/nfp: fix field initialization in Tx descriptor' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:10:52 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From e04a4d32da10a7362e538de821cd7fe411f027f2 Mon Sep 17 00:00:00 2001 From: Alejandro Lucero Date: Mon, 11 Jun 2018 10:50:37 +0100 Subject: [PATCH] net/nfp: fix field initialization in Tx descriptor [ upstream commit 01f65293ceb94921a35554fa7b17bc0ec1764c96 ] TX descriptor eop_offset field is not initialized and it could contain garbage. This patch fixes the potential problem setting EOP as the only subfield. The other subfield, data offset, is not used by now. Fixes: b812daadad0d ("nfp: add Rx and Tx") Signed-off-by: Alejandro Lucero --- drivers/net/nfp/nfp_net.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c index d9cd04732..96484d95e 100644 --- a/drivers/net/nfp/nfp_net.c +++ b/drivers/net/nfp/nfp_net.c @@ -2292,11 +2292,15 @@ nfp_net_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) txq->wr_p = 0; pkt_size -= dma_size; - if (!pkt_size) - /* End of packet */ - txds->offset_eop |= PCIE_DESC_TX_EOP; + + /* + * Making the EOP, packets with just one segment + * the priority + */ + if (likely(!pkt_size)) + txds->offset_eop = PCIE_DESC_TX_EOP; else - txds->offset_eop &= PCIE_DESC_TX_OFFSET_MASK; + txds->offset_eop = 0; pkt = pkt->next; /* Referencing next free TX descriptor */ -- 2.11.0