From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40059.outbound.protection.outlook.com [40.107.4.59]) by dpdk.org (Postfix) with ESMTP id B132F1C01 for ; Fri, 27 Jul 2018 04:10:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WmGjBVKVjw6xGyzAQ7IVyskN7ESZfM7b3ZxHdotk0SI=; b=q+ot2imS+ftegm8YC9YIl/lSCNk6dWxk/9n1QXBXrb6o5vXJzJkzQPe/pHqJvE6FWeuOjcJHoiPZIitkdm7ULcHs+zaCK1IxNNGgLS0tKLtjlqxGSOOW1rEYhPl96EY3GVz0p+BQ9fNKPxC6Q517zk1V0sD5rO5tuPUIjyLfQ7o= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:10:51 +0000 From: Yongseok Koh To: Chas Williams Cc: dpdk stable Date: Thu, 26 Jul 2018 19:09:03 -0700 Message-Id: <20180727021019.37388-7-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727021019.37388-1-yskoh@mellanox.com> References: <20180727021019.37388-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM6PR08CA0022.namprd08.prod.outlook.com (2603:10b6:5:80::35) To HE1PR0501MB2041.eurprd05.prod.outlook.com (2603:10a6:3:35::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d379d5ec-d69e-40d7-21e9-08d5f3662de5 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2041; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 3:VRqhO7xZI+e+gwML9kk728CgufCjy+xZ5eK0zR3PbAcu55NI5n2j3fuRJNab/wtgXWgXL9oAKfva+mK2hvdP2X6Ca4bbBnJnqYCk5RklvtN6svZcMDl38AlNXid091lfyRbdtyPDB42g/G0LbPoA3kNN3n+UfzqYiKLI+ZZWMKZdUk4WhkJff5Gwrz0TTdTBpgwQVBayhubdJa9oZ8y2IFdXkRkxACc24QowZao1hkOAj9YGrkBmCJQ/njtMndFw; 25:RCiTAv1ZSitsOQftgsnvvQVE0YDx9myF9O9qrg0Fd+RnWOcDjefZteTpRcB0BnBaoTmyfU6i0Vgw2D+T1YaOfQ8BKR/5Vnhmm2yZg3tbUXMau++XbFg+8xf45uGa2S8Znr1CWh4FOaGaHcJ7XdeWbEeiQN/B7+fS+vPOLK17pylE6HUt/vDEasxfWfv4/TFEAxEnc2FsIcBylqudCROpdmXES+IGhi6MBAmsycbkIdkAfMs5sSDmU9HPG2i8t2EhxGzeXTmMn08nn6ZhWC+JM2ZS0+EvBN/wiTmU0uyxw2b+Kp6YWSSNyPCbNTWmw1ey45AKD/ZU2FhFyCgTasDWlg==; 31:0zV1VGelAQwt7f74rfnVsfmz6UPxlbLRt31pYTl8b04MsebgEjoBD5YSW2ADNwtiE+ycz0MbaKs8BIpIXoKbjQpRpAy98Hp5RGsW3ZfaSbg4M3thc8xKI++7CNlw7+AWTfjfBXQ5cQquBfX4iwvc3N8UvYwX3HZI80lUWTds4VatFAilpcoL8ZeqAPr95y+b+jU5mkN12KFgF8PZ/d3G94bJ8S0XpudY8fMkSQH/4wM= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2041: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 20:ylIl/sUmi5pI8/lRowGo1Wy7cvGN+J1GkWOD7fxO0nCT3L1SBUcSDITLnOtdfXq9UBgggebgE8GNkzeSLAnF/umnLgCr7Jga+VAcB9EQr7+zQ+hr0M6clG/Ztc5MW5rSebHHLwCtfhxqks0HZNxmxtEwigordYuGSrBRm8NLnc6EOm1RL926bawbQj8YrZqlcNAi2sYusdDZZyj5/bkHibY33EepCtGIqYGMJDr5cUOFY4VAtG8C0qC10FXzHjeKXm2R89TWfsGy8C1u7wuXRN4RgOfEYVXfPjKUMzEjoj4MbYNeNm0TagfSndCvMagtK0/xx6Wk+71XPWbG3uj+zpSQAX+vgu0Ea3Ekb5zrag0ws2zvOSI5iieZASKlncTtlY00/ncWw4oZXcgxLlBs7i6erCCikI2/YEwkIiuSeF+uD0OaTHSaOjVilC4QwMoynhuj1xrfpA/bj6AkD1wcd11x7kVR04PVjABKFykJigza7d8TXuhUlWdgpsfoYSx1; 4:OUTb3kYfDON4GBms/zP0vo+o4O6jggJE32/OOXwfB4344p3UhAGdeMoNBvgpz2wdE6wUf7WQ84RFEyrMNaO80pfY60PKOsrdV/PxTm4PUOIJTF6SUWZhXPWHZzrrkrLriQiLsG4hAwyj3KyKAN7JipdD1pVY0i2eXQogjG2JioeHHndljipQOK3TlN7Hw9fZB/LKPYLiVykBGyxyFOLwwWDgxraZF3K+UjGNO7/7USBZSnfFbVI0H2LvmrtXH2YxkfiRuc6B+gTADehrc/lQEkni17FEZjrHjZUOzFswGZfwpfEjWy+QUiDuRIZcvyL1 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(97927398514766); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(10201501046)(6055026)(149027)(150027)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123558120)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2041; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2041; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(136003)(376002)(396003)(346002)(69234005)(28163001)(189003)(199004)(6306002)(55016002)(53376002)(36756003)(4326008)(76176011)(10710500007)(2906002)(105586002)(26005)(2616005)(25786009)(956004)(486006)(21086003)(386003)(966005)(2420400007)(106356001)(51416003)(7736002)(86362001)(53546011)(50466002)(15650500001)(16526019)(48376002)(1076002)(52116002)(8936002)(5660300001)(11346002)(7110500001)(3846002)(16586007)(446003)(66066001)(81166006)(68736007)(316002)(69596002)(7696005)(6116002)(14444005)(97736004)(53936002)(476003)(81156014)(50226002)(6666003)(47776003)(6916009)(186003)(1720100001)(8676002)(305945005)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2041; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2041; 23:HsfH4WjHVzaUVjjgNjeiKokLNLcP9TOYU9rek02?= =?us-ascii?Q?k7Fcek2t4TePkK3eISz0oas23uRi4bIYxS4xnXkUIVcJ4WYlUl3GtzlWN4eD?= =?us-ascii?Q?caw3l0cGBk31rOzDnZTxAxatjJlV0D3aBqUFJPQabxUJv6WlLAJyvtD55Jk4?= =?us-ascii?Q?sN0bP00bHZvW/d8ZlTyrITKvCb8X8YixxY9j5iTTIfbbIBYbwTnGX8B2sBSX?= =?us-ascii?Q?mZZ4hPUyI71G36Q50NhRcIpOPbyAA6MEHUZ5l0dy0T4pKAfCDAPlt6x1+NcL?= =?us-ascii?Q?ThhzSDigqNOISw7fvngYacchRroFkKPG4NLGYV90Pga+XR+TisJPbtgEWy/d?= =?us-ascii?Q?13493uzR2O8xzVOMOKoJ6wz4k2rv5mcrr2tHgAIVzeIZnXu7VQKqDnPNGyjc?= =?us-ascii?Q?XGyIfn4vyEUlgElCQIq0O9w0IotvfGf5PUNrh89SZloUalDSh3NDmzZRoT+E?= =?us-ascii?Q?8o0h6X1fHVnAgQco0XWdeL2ESPx1cXdBXIWMkWi0tw4C20X0WVwvGmgzeV7r?= =?us-ascii?Q?Y+C5bkrceqLQT6CgSqhiWowGas7UJjZUEWKB/BfZZuURRNftzDQUb9BvMLX1?= =?us-ascii?Q?TKqAVJ2Wi5OZuipbtR2LOrFJts46qFwiciIeawzw+0z0SiVQUBOd/HGNhOc3?= =?us-ascii?Q?BUDHodf/sPAOrdeVL5OSD22X4hgvlk3M/YC+bPfsM7g1UfZUM1mcNm/rqGz6?= =?us-ascii?Q?yvog1/Bo0BDxq+0Vf4GM+1mQEh+CpSMVA2X+7aMoh7Ypjl4OmiEZBuIkdHug?= =?us-ascii?Q?Ds1fLh5cXvd9zuAIYf0muBgsBctNPpWMsIsl9axp8gFFmeiiv+2l7Wa0bB9m?= =?us-ascii?Q?kmlCB3/UnatL1sZlbwQ3MQZjXQpT5B3Th5RiWpJh5U4cBlkzJw7X4Ny5XIQq?= =?us-ascii?Q?tGL8wVZbkWM4WXTO3hd1hsaXNXTT2ju0SZ608P0o2f7jnLHBmBsAnJZhqCJ3?= =?us-ascii?Q?ucXjgvnnfnPAj+U7NddVVFZ0whRsYKl1U8Hac9A6qo0uvJnwbqsegAUptygU?= =?us-ascii?Q?6w5djxtXBLob9xBbvyuO/EZSVOMGYsIY+JsMxkRTghzfPhTENDxLbHRFtJr8?= =?us-ascii?Q?3tfu82dZTu+ZfhVDcGJLgzSDAvSZAt+HxLkCUoWEZviDzMXncqvVZ/RGcMda?= =?us-ascii?Q?fo99nSZG0Gfl0Vhp1mDKRWti6UpNmDpz3I0DHef1xHbH474tqMo2hWd83hf+?= =?us-ascii?Q?5oNoVR/jpCjY0pKlWoEEJji5wV/0JViBNbMFA3GsywWxQf2BCqw3E5kmAe3I?= =?us-ascii?Q?87Y5kiVbzgROWekMPVHkO1/2Gr8kjlFwUO8IgHgw4camLozE2yv1X5X+HOsd?= =?us-ascii?Q?LM/r7db7e+SDtTm9R/GuctAdeBtUuUKhbFc7rqNdTf+M20xbg1oy5zGfLdNY?= =?us-ascii?Q?lm9Hb48c4bjrkuN+HH0nbsnU6vQF6QQkDQ7x9owc6K6oE0M91aTI4BYExn1r?= =?us-ascii?Q?3S7PF3RN/sgXd1giX8y8SYuTqGCaJ9s+JjHuAJ57Kf5JhvURiQznMRK9/aCj?= =?us-ascii?Q?VKyqFpIIaAOd5+w=3D=3D?= X-Microsoft-Antispam-Message-Info: qYEJOzHRPyvizakGFmzhG4QJXbXCsRTDLlQQHJj+4fI/TrbS9QqK+zRdf67LpM2e6iZHe2piVAtnIebBlgfdHY9X2Jjojzo3/CBj3SGMviCMX9s3xd77U90YQdugNwW4luNbh4tnk/fLhu/jke+HUUuD1Ql2zqpDcJ+YWKhmGY5Otzsw9bJuNwsI2OFKPmehgSvotiSOAJVRyYzF7zBvX48a/PHuukC+iwCpsUlgrFoZ6Q3Me/tQExi8L/dR6/8rkeVIeTtx4drWXhaPP7hMFuw0D6nukdhbQWeRG09PeWwjA/oIAgdoXGzysp46HkpSoYQz0TLozmjxETGj55yLJQhPP7moytloReY3TiuRxAs= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2041; 6:6y36puMisWFryKe1dp6gHfHocx6G66L3hAkHnM1pcPIDBQ1FI+LW5EasVep2XL1uBBZ+V6cjE4F/jau6Bh8q8GwJh/nASieg7+L8XesKPT2i/4b3lj3y13qF3whZZgshZ+uMnPVcfT2595Xffe9IihyIpyGvtVkHB1ztZ09azqeFXXFBRgqpSH5H8HUvTV/CZZbRMhHoHM4DgfGugJPrObgpmu18VqI5AIOomaZmgoF+pSJwiBWcmyF5JRfd59XlB8x+wFRViFDeh1p59mSKxTbkAl8O8LRvRPyoq8wPw03sHDCvuqnlsDNaMLsqRiUmay7B7jC9clQNpXoLlUPdSkpcJG0tsech/ji0CN+Mty7F8RnhkvTK+ZqkAd64Cxvvz/VjRn1HbVqwWLb1foTT7PM21C1edUReE98qWva7WLhF0AYT1c4sRBVniaEeaBAQoMhz8qep+4K9t9Q+gmSsNA==; 5:/evWMkd4fMThbL8Jk4ydgw+sOOvJqZw1sl4s2O09PJiYnCKiwBV0a5Iyfizs6sJW5Av6bW41THDDArtuQgcCWc1RGisK5pN9zSQeRUaOJjje+s3+TcspmVz2hU14iVvBkJqQZT1Rus+5L2jCOTXfkOloQk7OvUbTiqXVdiTZ5EQ=; 7:ln28vYOL2Q3ZYivX7P8VdlXvLDn9O4vLa3GpcDmUMw75VMtypBTfXO1wUxadljvvbogKlj4n9DG2UOD+RWV1QTMT7q667YpTx9gjaKx3Z4G/MxI11900E+DtXklOdlkKvwop+fejdUsYxzhqrMgk3pZXmR4GIDfC+fefPxLIgYbZPMNU7K0izAOg7wRjufJA4MDNpV4342Q5UZXqL9j/cZgjaBApwY8J6RQk/ZikKh5Vq8hbq2/or12Hs3wWGc0k SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:10:51.5622 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d379d5ec-d69e-40d7-21e9-08d5f3662de5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2041 Subject: [dpdk-stable] patch 'net/bonding: always update bonding link status' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:10:54 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From d4ee3056efafaca957b9d9e23c9fc8703bd1c76f Mon Sep 17 00:00:00 2001 From: Chas Williams Date: Thu, 17 May 2018 19:22:52 -0400 Subject: [PATCH] net/bonding: always update bonding link status [ upstream commit 0e677a35349f316d50ba25485354363f3e65c12e ] When the first ETH_LINK_UP slave is added to a bonding device, it is immediately activated. If these are polling slaves, there will be a later link state event, when last_link_status doesn't match link_status. But because this slave is already activated, the bonding device's link status isn't updated. To fix this, we always attempt to update the bonding device's link status in the link state change callback. Fixes: 46fb43683679 ("bond: add mode 4") Signed-off-by: Chas Williams --- drivers/net/bonding/rte_eth_bond_pmd.c | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index e19a4a3e8..0cbe08ada 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -2535,10 +2535,8 @@ bond_ethdev_lsc_event_callback(uint16_t port_id, enum rte_eth_event_type type, rte_eth_link_get_nowait(port_id, &link); if (link.link_status) { - if (active_pos < internals->active_slave_count) { - rte_spinlock_unlock(&internals->lsc_lock); - return rc; - } + if (active_pos < internals->active_slave_count) + goto link_update; /* if no active slave ports then set this port to be primary port */ if (internals->active_slave_count < 1) { @@ -2557,10 +2555,8 @@ bond_ethdev_lsc_event_callback(uint16_t port_id, enum rte_eth_event_type type, internals->primary_port == port_id) bond_ethdev_primary_set(internals, port_id); } else { - if (active_pos == internals->active_slave_count) { - rte_spinlock_unlock(&internals->lsc_lock); - return rc; - } + if (active_pos == internals->active_slave_count) + goto link_update; /* Remove from active slave list */ deactivate_slave(bonded_eth_dev, port_id); @@ -2579,6 +2575,7 @@ bond_ethdev_lsc_event_callback(uint16_t port_id, enum rte_eth_event_type type, } } +link_update: /** * Update bonded device link properties after any change to active * slaves @@ -2616,7 +2613,7 @@ bond_ethdev_lsc_event_callback(uint16_t port_id, enum rte_eth_event_type type, rte_spinlock_unlock(&internals->lsc_lock); - return 0; + return rc; } static int -- 2.11.0