From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-eopbgr70058.outbound.protection.outlook.com [40.107.7.58]) by dpdk.org (Postfix) with ESMTP id 8A81A1C01 for ; Fri, 27 Jul 2018 04:20:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8BY2c4NTICI3E7LXKXjqbSDqzTPCHmqsUtpk32ctvBk=; b=oiZEFxuSvTZZv9fgH6MtSz8xVSPbhfD3Z5gWKKMMqPA2Ot0NQLwuLaFhuimLSUzfscQ4ARubhtrw4Y8NqJp43pJQaJAOsVvgROALmPVlgF5fiqoAFY7MJWUBK6pMe3jH6XsPm5Hoc9Gh2gLzh8AOThnHU3vmXgGirZP0rk7T1jg= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:20:07 +0000 From: Yongseok Koh To: Jay Ding Cc: Randy Schacher , Ajit Khaparde , dpdk stable Date: Thu, 26 Jul 2018 19:19:21 -0700 Message-Id: <20180727021921.37680-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: CS1PR8401CA0046.NAMPRD84.PROD.OUTLOOK.COM (2a01:111:e400:7503::32) To HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c6e06491-4a35-49a1-51db-08d5f3677958 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2043; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 3:G2U46hSJbjuxzxVR517JZ5moFQFF91dLVwgR0oVcvWq0/E5/HHkVYel+3i7TWEkb3GbKIdW92OPA7dJQjWa22HqZBA+nIIcbO5YGri0Ru59Qeu/z5agI/cXVglymqwemobeogCMlsyVQIxa5zlpf0n566dKeZBMbhqJmSlX+tbHWPVRd4T6nG09tX+2Z+DEMmOQpt7rMFrpBU7g1JeaDIKyoHF14KdBvIwXi6M0kPfRK+l26yz1tFoqPEg3+RJzJ; 25:O3UR2rd/k0CfpYR5ykRgGPuprdwN8bydq7By571jWVpc6nGofp3Zq0NYy9zmYkPr7bEttKeQE4dJ9kRqBO6if60dAa/p+YYUjmGxuXtBWDtEw2Is6XjJntQk3FQoUxhTfHPPi6q8wNEYf7wDEOr1PRAx08NdHIEHpKyz4Q5movvfYsBsZ1fTLGdBZPmp/rq4MSPZoJiTHDBcG4NxMc+Z/aSrbzYVHnkHCySZZJ3PsmOqmFlkrnREo18Kv4uoyS9UzZHLixcUCP3M+UX8Eth1hBcvoFrVNdiKDOn7WejYtB7YX9QZbnKoWqkm7rJ569VzIHmCr+jzOoyljPRuwlTvkA==; 31:1CtEJvCxzEkLOn8jcbBWfngy7VKdF6qw1cW/1svkc86hoP06TwosSbav5D0cRE+/UKdldqaOpmtizPDroTXQAcFk1J30iJwK/XsmyOxi2BGXdF+pRF8N6kIskjd2gK4JxH+ZMjI5oIBnAV3AgEypjK+iifmY8V/KBld2aAlh+YIUIOZSVd/YIqenfg/9uZ1zJ/vx1p9BQFhQ5jJpSJhMBSpdpJWfCCoYf6dpJxg0i5E= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2043: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 20:kUSSYeCPyyvtchmdjjHcH9/gBFVnDFFNKh6NkzTt47seep+ui945M72z8a4FxOJL+hRSQVC2by2FVCnyG98snA+Bmp4yucp5FT1CtrFvD805t3OxTVMgYc9c4/5KuvXUbAtnv6ducZE7njfntO9YZpbtqLIenR92DdRXyG52HevPb/Syj7eGgCoFQE+DT/iY7fDs/zWfSSVz9Fi+cfk56gUZ/lviHlEMhYh9zcd4CUUXb0pQXC4EgMWBUfUbIv/8YnwopRgfhc2LwgRVr0gqXcyE6JVMy/65EgQ9gkUZEVpR90m7dVIxct+hy2LriLoMG1pBtdJOHEHikfFBgUgfpCm32Wm4CdW2XlHddNQmA2EirUpVfgM+ROPu/craG8oivRs4fgP7Lc0r0adxT5Cw+PGmo5WZ4uUHnEkb/Q3q5O6cRgBMsX2DfAYzE286GHeLA+45iKZjK3a6BfA+QESB1jbqXkzNlA8gle406X+I0M2N3jgUa6tpsd2GLdvIBZ5z; 4:trMyDrLnKRdF6FD+MsGIsQCuKveUJongE2laiC+KtLf8jcJtN5G+a84XTaMXyJTD8rIg1WfEOpIrPfu2YTSy/KKbq2ots043IwJ4h1IDeLM4Tdgs6Xj9knbIE+bh6eE235TjDFiV8tz5iZeA0KVobVnOnPVVXJz9VAOQy8NNfFirU4ozFP7UaZwTcqxwYukQna/KDlAjG6EKIBM6hHT/O6Ibyqmx2wxKB0iQy6XDs9EnqQR826JWr71Jnj+IYlIXL4hDQDS58mqEAxtUHHu9fi74l8mTldC6ImOtbwkIxvAl4+NjM3jHCggpN8kvZyZS X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(208715162771679); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2043; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2043; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(396003)(346002)(366004)(39850400004)(136003)(189003)(199004)(69234005)(28163001)(50226002)(106356001)(7696005)(575784001)(186003)(66066001)(97736004)(26005)(8936002)(5660300001)(86362001)(2906002)(16526019)(52116002)(51416003)(1076002)(25786009)(386003)(305945005)(81166006)(48376002)(36756003)(105586002)(6116002)(69596002)(6916009)(50466002)(486006)(53546011)(3846002)(53936002)(54906003)(316002)(1720100001)(478600001)(16586007)(7736002)(68736007)(6306002)(476003)(956004)(2616005)(81156014)(21086003)(53376002)(55016002)(6666003)(47776003)(8676002)(4326008)(966005); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2043; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2043; 23:nR3AnxXTAQC6SnqbIkbvzcyXI/OozYjk7QESRrZ?= =?us-ascii?Q?tgp4CFWlpZAxpLSRwsp4Cu4kVXj80VA94ss4uqqndYdp17OwsiZF8r8uRunZ?= =?us-ascii?Q?5vSD0XvBQ5DZVLp5xRNsXDpsi+NbD0oYTEqiPUHjUfJYfmQ+KmTGtRjZmbyd?= =?us-ascii?Q?aWwKMgDxA9IHtMCxr7OTZPRD0q77zksGyKUUzABSfSgZ5sROXjwdUYMtD1MT?= =?us-ascii?Q?7BX2c28hyZpSrqIe6LA7EP++JiDQCGx/j/Gy/KZ/GpDbNf0boZp1evkae5Hs?= =?us-ascii?Q?ThjAys5MOk5tZOvhCJ9eJCaLiSpvwE5T6T0iykImCUd+xYO99AdQDZWu8PgY?= =?us-ascii?Q?aVvuel6icspAvCxpOH6Q0gBNginPFQTgpejunosyWyBvbzQrjW3kKrEZ3bb9?= =?us-ascii?Q?KN6LP6pzVvCa+lmVyfblBRlLj+qeuOuMirEoAQTRHpux+95d1YPMi8DAzXsv?= =?us-ascii?Q?pHEi3SmGAH52esdmK216WQl1ZdhIkZjTojTHawczfSx7faLo5H5ZLSPtAhFv?= =?us-ascii?Q?EMuDm3fGMbilbLa3IU2o5psfb/+r+f6MafIogHZsz7/TkiGlUiQ/QojbWESB?= =?us-ascii?Q?sang30AqjmG9plU1h9IZPzUgiJU9pWZGJQqngY5l0m7f2W81P8hrE2gexrik?= =?us-ascii?Q?qJz06g120dh/3CjOvBKrU5/GgcKZpkUZ1UumWhXsCAm3WzJmTSsdGkeJC1cE?= =?us-ascii?Q?E04qEWO1aajrUdc6a0smUu9MtXxf+tY5ywJ9eJog14pd8dc9j37lg196CzQa?= =?us-ascii?Q?J+OCsCFMIsxlaqv/NYxKVUfWbVUlTFGmX5Xuo6/nU9n/7qq6+wvjKsjZz0Sc?= =?us-ascii?Q?vSu39YL9B6R5Hc4XnWg5vE04Ezr7bhCLxwt/RVki6a3H0zXpos6G6uix3j05?= =?us-ascii?Q?N6ZuQlua/S2jbLOYAhdN0EwKhScvOyNODcX1Jfn6ulYoANmYVT9G2IGCta1y?= =?us-ascii?Q?OYQfMdglAdpjms/C/oMA0F15gY+BsSebJbsymXRRWCKa+fFrvKpM4mAI6hFI?= =?us-ascii?Q?68gK4imVAQiwJjk8oU24AdoLo1ecgQ/haigJnkRIBEZOVxu0LMgdH82g2yBo?= =?us-ascii?Q?VqgZnReqO2N7N1Gpiz4hzbJTx8nRi+BB+KyhzxcE7ykuB7FOy9UOHqT2bPD6?= =?us-ascii?Q?PE8DVq9ufKmYR3AxAaF3vsH0hYVvZ2+/8eMPQQbayqEiC74P1YoNtN/zzIgd?= =?us-ascii?Q?n/YNEjoxoqu2tYd3FX/LLqutbPwSrP1EBnQKA4yX+xuBDQKKBrPqXGq/JJ98?= =?us-ascii?Q?gFR5/0uW+z0cFiX3RaMj277aVY6aRK0dx8jBc/h0P/NIEH0jSJaokKerLpiq?= =?us-ascii?Q?yQ1UlPW1UmdsgkS2xR1h4Tp+0ggzmM1T9y3IhgHEDU6QGFlzcobm56K68yhP?= =?us-ascii?Q?U4ygH8w=3D=3D?= X-Microsoft-Antispam-Message-Info: yHIfLs5fUJAO6QO5zKKA7pfYw+aXl9rGKbWwMzKrpNkxKT/cEnJTKc9JpzDOz3M+ITj5MHLskvUtdVvhAChfWSoin06tQUb4KSzw9LT8UKpahHChrSYcbWGUydOCdHAQ3qd3fw552hawNs59sqgDjRF035vhbrdGm+JAC5ediy5EsgGhC3BLzEjmJe5yoiTTsCADP0Nli8ByZ7CFDwGMFxPR9u1anbct3ij43R+8XXFXpiCMIE8dh04ltX1vwOR0hPaVqxu5S8JRizGFKrdGs6Grgdrh7qLt4GiBhYub1R2oyMTOd6AO3oHRwdjcEYPBgMnp/emOQ+t6F69TF+2v8F4f/ZDPNnuYTWtCUkAzo/8= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 6:vq/mcNBLDE6snSbj2Eyz6oHPDyxZ1ZRQIFIVWkEoXKJFzXW9Om3qjU7QSgr9TeNqUuW5BPiVdz63/cOHUImWa5FqFitcgcBcXhO15mIF54rxacszeVuZJYHe8mm59bFFXFYKRcEYSry0JsFBZHMu7oBHeWrpdB7LKah+DbIyeG7V9pvzYgd4lKQM7+1QSjHSAO/eH0LKrzd+QLbhfm4xXAJizk8RsaxAbNDDz4/2UJ1KUE1+Xag3tT2RuROqhqpQt8wxzJTllG4LCIpw53cQY4KvwkGiadH9f2OVDHe4pJy+KtlFeapd5wc3Q2h7bso8DCOOYTW54lpi/Qlqb6e1EWCDcDn4sMQKVTGkFRl/L7h9vXU9Jl9EsqmVehdjnIp2th5quzNb0nnIg15dcCUR0uGLB2vKQTpFI6eqN7ng2050I0Uq1nVAC1+wpRVnAF9wK510P8c8SsJfX60RIii9zA==; 5:5dPpRaXLPhVr2jfvr8zr71C3d7oRlqr95buFlZBwizfgLTGZvTN5CuRkRydKbeyfy24yxJ6dg6Il+A43Ce++BOBcUuIB1nnY/eLg/jqj4NCBqHG1UOqKYgLtT8YHwBCzlUkTttf5AuFNF1Kjs8W9tJkupGcdXx7H6z4dYxlltiU=; 7:Pa0XXhvHR9X44zI2geq9DfalqyHLtBpjUjWOadhuj1JIHz+ohRxipfuoGElssBYJb2T4rXYRixk1VjhA/6E4lit8v/hoDiHB6os+qXjSz1fsqiDLZ7Efrf4TFdjnuN5t6KVI0f/pl0V/TOi0Rfyt1+AZkINQ60m8Rvob9XtqIdlhFKOv8Vgvo1RQldCWdnmuxzKh8h50y8VxsJZEWud2YI4YvmYY1zgYIUfx7CLR9OYMNgExyKsuuDS7j+r3Mjw0 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:20:07.2210 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c6e06491-4a35-49a1-51db-08d5f3677958 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2043 Subject: [dpdk-stable] patch 'net/bnxt: check for invalid vNIC id' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:20:11 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From d2253aca3ea545509e20eb1af6e3f3959c685101 Mon Sep 17 00:00:00 2001 From: Jay Ding Date: Thu, 28 Jun 2018 13:15:38 -0700 Subject: [PATCH] net/bnxt: check for invalid vNIC id [ backported from upstream commit e9950366d08f20e4d968fd76dcd0d5bc8afc09a0 ] Passing an invalid fw_vnic_id to the firmware will cause the bnxt_hwrm_vnic_plcmode_cfg command to fail. Add a check for VNIC id before sending message to firmware. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Signed-off-by: Jay Ding Reviewed-by: Randy Schacher Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 22f092f16..bc213fc06 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1385,6 +1385,11 @@ int bnxt_hwrm_vnic_plcmode_cfg(struct bnxt *bp, struct hwrm_vnic_plcmodes_cfg_output *resp = bp->hwrm_cmd_resp_addr; uint16_t size; + if (vnic->fw_vnic_id == INVALID_HW_RING_ID) { + RTE_LOG(DEBUG, PMD, "VNIC ID %x\n", vnic->fw_vnic_id); + return rc; + } + HWRM_PREP(req, VNIC_PLCMODES_CFG); req.flags = rte_cpu_to_le_32( -- 2.11.0