From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0072.outbound.protection.outlook.com [104.47.0.72]) by dpdk.org (Postfix) with ESMTP id E87A91C01 for ; Fri, 27 Jul 2018 04:21:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q9MgY/o0Nmm9H1ltuqokeUayQ6jZi5Cjxiraet0VdsY=; b=comMjouOjR4W1gRtuQoezsHuPQlun3Vc7Due+9XxD2JWx3HvwHZ7H+XrNpDhcEwBHbJ7TY//SYw1kc4LCWUTBMYjUWjH1O4JOnnq+YQmPmPNVWOMTbxNPy7fvIRiaVBAAaiViBxzU9m12YKhOkGPsWHOf6j/eMemBpQQxFUtmpE= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2035.eurprd05.prod.outlook.com (2603:10a6:203:1a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:21:56 +0000 From: Yongseok Koh To: Ajit Khaparde Cc: dpdk stable Date: Thu, 26 Jul 2018 19:21:36 -0700 Message-Id: <20180727022136.37807-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BYAPR07CA0029.namprd07.prod.outlook.com (2603:10b6:a02:bc::42) To AM5PR0501MB2035.eurprd05.prod.outlook.com (2603:10a6:203:1a::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b5f77b1d-ec43-47f0-6cd3-08d5f367ba0f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2035; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 3:d/5MHq89QSXKIrTqxGlLPTyhZ7Qd8ywpu0wEd++KpYbsZjtgUDkBPZTl2hepw1I0mRQjMv+WgOEggqnxJdqzYdLBbDB+9c3Aw+Dppd4b4S7y0Dg7sDrP6PMUerpgFvbeiSK9+7vvtmmo2flMtdDaMiZn7Lbce4EZgs+YnETyhXVIJ1nY7QqvAxqQGQUi4HKb7N1mJRPb/DgQu/ZmYK+2WfVIyJPMjyTM5IPIOgR8feJbXkddf8TFPBS+gD9gOhKw; 25:nGolXotceCqdRNCSm/DDmcp4v9lMgSFrvTC0ULb48A4qGmxZsUw4MAH5kpfJTgId/o4sy/tNVjNHPO7EWvj1G5z9663uqIWxWY+I3Crs18yJgoffZN2EBEeW7/9Tt3Okw8ALAlypit6rcpJusSER2RqlMaclowMvW/b76zcISg0iT5lcAUvLQS0T6H3Iti74f6rkzn0KGMS3QU7XqCIzbaJXWFpc2Glnlp2WoPJkS7NWR5yo/3xEPhJLB3HVllA1VwC9FLDZ2NoUidSTph+oPAlCSxMURmmkoM3Z8pxx+uM0gT9ZIo2H84NbF7jxGkk5DNz/DMzUyjVznPcptcSKRw==; 31:vX5z9TK41qcMSELntdid6iQ4KZHVhH/qh42rHVcehfDlIyNsEctAgjei7dtuhDuttIx3rAJCl0nqSqC2qB88hdyUhMFVxy2+9TGUYovvHfDIQC9ZPepE/yOArp8y9txb6ELQMQvDBGDYF+bzX8QHsVG2e00ev4BoFdH6jkramZ/Fb9uYwpI5uZsR7byWTQLgrj4/f8PIjb6ySgnW89UsNgCKQKIcxhUiVBLv5zYvKEs= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2035: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 20:bYBlz9KNMka72yE7eii9gJST0JfIWK5DXGhmLs5nyJiDJiuhFXNeTdqHNhFmWIf1f0FbQdLRJS6GJjdJs3/EkLZoTmWWThEZz3pCq5BpljcfMGzwVjLVrzwkM1Ixp9PyY9XdY26lYRpWDVEGmxQf3OiUeyt+vOMiDwQbNBWweiY2B9rM4Z2n2vdKn1VgnVcjPvehgfloNsjn94uAzmL8YtX201ohRx93UhkFWZDqyw7+XUUGUrKkMyO8I7TUbdBb+ZZZqOfttbE/UIvupF4iP1EsH1wdHKPe8hQf7HVASKbp6WTPAEFZHx8mhHdJBuOcLJ+TdYIIz0y2cRy+8dW7ECjvXyavZ1TXq6DBvVdQiRvzbhAr1v9PoVTAhy/qPwpGNP0M9U7O/66LqMPLxIZL2Sqlg4F1WzqWwMfcX9MUbZyUeoYGiCH58LFiwxMNJIWT2yOECljOsMTqZ7QJlrfamwXC6r1qT0Kp8YXzAZ1sM+yB17Dr3Ve2t+ytZ5TlYGtG; 4:OQTac5zuDxxiezXEW1uxFXt837b0LfAS+OsUsyN+JBKmm0dldZj2PsvqHswFhtV2IgnIKatt3UO5RalJfO48ijdYWvc+I2e1M62tvoY06sZkSVycK3TrBV4udS1z1M5wjlx0Y+AnszKvnaTOmAn6olaeBevkXN6vwxQTxsyTYoEy74gOLhypzWA5kfn36zL7gf8QOps2wTGCbFT6jPND63DeGBV4qyVLp37FM09K/p6Q0qnI6qq6uErvzZ5F+3o1eENE/AOk2irh/9E3HP4161ATU/SIp7MrM6OC5k6TbE1F3SgMOjmaTWxPugwmJJEN X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(208715162771679); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2035; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2035; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(396003)(376002)(346002)(136003)(28163001)(69234005)(199004)(189003)(81166006)(186003)(8936002)(68736007)(7736002)(50226002)(21086003)(8676002)(36756003)(305945005)(26005)(81156014)(97736004)(6306002)(55016002)(2906002)(69596002)(956004)(16526019)(476003)(53936002)(486006)(2616005)(14444005)(1720100001)(966005)(6916009)(25786009)(6666003)(4326008)(48376002)(50466002)(1076002)(52116002)(51416003)(7696005)(386003)(53546011)(3846002)(316002)(16586007)(6116002)(47776003)(5660300001)(66066001)(53376002)(86362001)(106356001)(478600001)(105586002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2035; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2035; 23:ZctHUCs0iLeJKoz9r70b83hcEGOCXpM1A+7Y92m?= =?us-ascii?Q?HIqzoOv051XcjTy9QGHgTBZwKommAGGcxROzVzzTq4GeEKcyhi8RCYiPsuQX?= =?us-ascii?Q?Z3eopt3ViUh3wtxauZ9dmcFWRheXgHA9e+eVZL099tRyei500aFDTt5OTdL5?= =?us-ascii?Q?auVZ+HPgq28H9T+UmtN0ERgtmisuiF4Q+G6hoR/HbnhnR9zgIEBvn/vXHjGh?= =?us-ascii?Q?PvWcnRyqUzacUztpHYYP181z+N2G/030h2aZ728phao+w+ODjnHwWauVwS/w?= =?us-ascii?Q?opafmyYeFpvTSHXs9BOuURrPegUkMKOz7Oi68psvu17nP53lXv71XBnxr856?= =?us-ascii?Q?G7qORo3fXVLMRHZG3qBzPGzJuZzb+J9HVFy9lT3VaoYdytC7os2ux0Up//J7?= =?us-ascii?Q?A8zdDna2n2vo39qOY1QCi0dss4/D34un6TnYQVpoIwj3f9ODugx/lu9I69zi?= =?us-ascii?Q?m7sfZqaJ6ysIjAvmYG+qr4kx2CDRoGqDcHCilIDJ6AebnpY//xA/rkyt+gID?= =?us-ascii?Q?1aUbPz2EzIBXFCWez57MVgqmKl+4vdLJN94uVqybitSxJItkseCxAN8PHup6?= =?us-ascii?Q?35gIFczNtHAUyq+piXG0ChZLtFE2PgPyn00WkqwQ/KL3J0MgNmV290Annmem?= =?us-ascii?Q?8Rrt4bjGB0tGUWOSH5atjnihDLT6Wt5DvRLQcoANgnkWqX4RztMacVxS8gsO?= =?us-ascii?Q?9/YB9ZXB/17rLPB6tZsvn/g4poUin1KR0Sf1PMSOEYIWpGVNm95rVZQFXCQe?= =?us-ascii?Q?y/h5eoxL2g8/P+ABu/LjuVcQ6Egy0y1PvdAzYWCXiyMju6B3NFZkhtvyQopB?= =?us-ascii?Q?eUzzsiGZJMzKbGlqz3kARNPUyi/0apzKrWEdOnTizZzysSy+48XHoWxSVolz?= =?us-ascii?Q?LDUNTldXN2iQMSHE1EUeK5Xj7jP8Rb0gZxPzFtBs4CX/cvx5SNgeOBvW8ghu?= =?us-ascii?Q?7IK32jr46FeNmq+jqq9Etkk7Ouo8x7PLE3ndQwzIn92Y6QF05n58uhqWx2GY?= =?us-ascii?Q?QRX1hLjBtnZMmK4/3ntEjP2MUZprIm4aASUpVgol6+57Him4r4WzJmUuq87o?= =?us-ascii?Q?rS/5pm7VXOassJO9blv5/tZ9Vv4mgZBxCc1UIZbcErGvOJ6/Z7Dq4co6nelX?= =?us-ascii?Q?bKCU/TDwFx6AJzvDprsqmK76aE+jOL3xlXtxf6emGikQLlAmd26+xVmBYD0R?= =?us-ascii?Q?1+zo6WoNWxw+AQ/UMqLfqPMrKAIEWpTAZDXm/RZ0GQyaxrr/Xptl29ot7rRa?= =?us-ascii?Q?orpQzBpN3GmJCz4L1SIjxNSLwYzQlgbF6+dcWCWVqGnZBnTx+8Zdy/tJ7Goa?= =?us-ascii?Q?N9hmtR2hNBDXbwylS1mllQShaUFxF3Wv6DqddMjwEKbM+?= X-Microsoft-Antispam-Message-Info: 0X0gL8H+yt5prl9mva6MgAFgM0ADV8XUSZsqFq3tJfLZK1GT38G4ZZ9W8nuKIlUbLDXhF77zwPYWQ9VaXc6K2lPPCAr1cFfbqhluR+cYUZrKPxA6w0lIPkFMiNqBtep2yzoWIdJCm86AXD4wiJsxenyST71Bikslvye3Vt/nRSqsZxwTM05sw4RIcqHWFVumy3xtgAcMShZs5rYGWiShQ/CEFTPpB6f+bcFJbJqn9+TUa55+D0HeapZWSK0aXTacxiRjqN5lgJ8F/5yuO48dAx884/Of5qXAvoWDvf33iWdnJrRH0rd7IiRRAc2wPzZ4chYGxifhnPw/0vVL5Qp4lolO6TM86GaV7oofLB2RmiQ= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 6:h+k+K+niLeWTy4rniMP2+BTdunBW+IIXMlvhd6tXZEJK6axDUOgLpDYOYdskVvJP4sWezSovgdQzrN8M4MsfzZjcZ2z1UilhF4lQdyi4rO5K5MTFNKXU3xBeXw38yc3eqnKznfp9XJqE9LYWUTk4fce7QGXgTE8T+seiP37lwFbJfv7Tt0BJYi1NEf+d8MTCi1Bsm2Cj+UWwAc4GEI7ic20Jo/rcuqNAsBBwYF1vCPrzXriyWlfRyWIU3WyGTuddX10B3J78u1TGiuQpxGsVdohpbv18Qtzc2/pOIusQf1heHkobDnwLA8P3RbkBCc307qZw3nBMi3kUIH4odk8saJ2z2YM9X+FLNTONfmQwKe2P4nejYrYni1vmTh9gpXV9ANxofiTz5YPHKEpSv4XIWB55bdfOtBlRfhv4t5jYOouK7U3Rhbp1T9fxQllkZmyoT5LBlpOaUinmU7Eg3EMq6g==; 5:DOfYd6KcKv4J6eNQF8yN0qOsS0ucOQi52ji5xquJ34wGPiya2L6GGffO3L0EJY0kIIeqFWgZ27Ivt7dvd2/ohXg1XimS6R3NF8WCg0v191vxvPbXYGzXMlR3OdraryHZNqoZebnni5ckboCoC9+FYvCVJC5y8ZUbwcHoQCzzfBM=; 7:orZPnnZLRXqPZwLfApWO2i4FPCoWZlhcs6haY3buOyHqMfDPdvZiFcCkjofKoWygMC3hAFPwzQ0jYEaH6T3K1U2bdw9yNYAdJrI0F71gIAgBWucze/wgNxhGh3Oy3twgnT2n5vL4iiyDbl0LE7jKsu8fuGhFga6iD7DFZNJaMXdsMY8DPglBdFJDimf/B5ET3DREdUiW++wXDa7q9TKMSvX1pWa5d29zearDy6H+6hqYivKk2nb5r6eU/RF8LxIf SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:21:56.3751 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b5f77b1d-ec43-47f0-6cd3-08d5f367ba0f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2035 Subject: [dpdk-stable] patch 'net/bnxt: fix set MTU' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:22:00 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 2e7a60f49b688319f7a17b03c44959da74e411da Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Thu, 28 Jun 2018 13:15:43 -0700 Subject: [PATCH] net/bnxt: fix set MTU [ upstream commit e80e88a097771ef814611f3592291a527fe1a9cd ] There is no need to update bnxt_hwrm_vnic_plcmode_cfg if new MTU is not greater than the max data the mbuf can accommodate. Fixes: daef48efe5e5 ("net/bnxt: support set MTU") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 52c511ee0..2021e1bb7 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -1541,6 +1541,7 @@ static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu) for (i = 0; i < bp->nr_vnics; i++) { struct bnxt_vnic_info *vnic = &bp->vnic_info[i]; + uint16_t size = 0; vnic->mru = bp->eth_dev->data->mtu + ETHER_HDR_LEN + ETHER_CRC_LEN + VLAN_TAG_SIZE * 2; @@ -1548,9 +1549,14 @@ static int bnxt_mtu_set_op(struct rte_eth_dev *eth_dev, uint16_t new_mtu) if (rc) break; - rc = bnxt_hwrm_vnic_plcmode_cfg(bp, vnic); - if (rc) - return rc; + size = rte_pktmbuf_data_room_size(bp->rx_queues[0]->mb_pool); + size -= RTE_PKTMBUF_HEADROOM; + + if (size < new_mtu) { + rc = bnxt_hwrm_vnic_plcmode_cfg(bp, vnic); + if (rc) + return rc; + } } return rc; -- 2.11.0