From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30077.outbound.protection.outlook.com [40.107.3.77]) by dpdk.org (Postfix) with ESMTP id 80BB71DB8 for ; Fri, 27 Jul 2018 04:25:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=alZLlCSDCQwYvj4OnYukIADq7hkyuwvkDCbLtR2F8Yc=; b=wKsdUCaOfYtUiOXjNTDub00SJT++8P/XGtHkqfkp5iDtx7tYrkwxHmMaUe/C2I5Qu2drS/Ekz/uYz59WDbMvDc1L0RNOg+CZuoB9lYc3/zalhycwCQ2xrQ+LZ57jGC+xQwWvZCVrOhxdTmGo/GdkfP1kG6DBunEJJx0VDALGnSw= Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.18; Fri, 27 Jul 2018 02:25:20 +0000 From: Yongseok Koh To: Chas Williams Cc: dpdk stable Date: Thu, 26 Jul 2018 19:24:44 -0700 Message-Id: <20180727022444.38157-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BN6PR03CA0002.namprd03.prod.outlook.com (2603:10b6:404:23::12) To AM5PR0501MB2036.eurprd05.prod.outlook.com (2603:10a6:203:1a::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b1da9b02-590b-4021-5260-08d5f368337e X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2036; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 3:tKhd3VRUmLSANlsZZjrfoCoNLdFvQi4JP8mScTPhV6a8CwqFlQ6DhklKF5/iECVV9te3d9b7ZmOQZU9tXsEGdf01jvJDPnmqvNcFkT409n7ZhQ995AkKQDCB61Xdmb/ZkZPMmPwPwNtR/y4Vpc96owTlHJpJm3XG4oraAPnigkXiXgSaNQaCZf560eRjzpOYR4IhBGYD4ifVGJcHKdpDU5nmrjje6xkZ14ejR0Px5nGqFItubrLagf2wYpcpF6Ta; 25:1hVxnIHB9mBVxDwEIhLcrUAo+Q2o1GMy/Ll2dtIwe6uuzTJIOEjlmWsjze7N2siftDin02EzD/elHXAIzRzDQ/eMQZZ7ks63HutigdruQHHAqS8NWDu9Um2K6Vd29a3c8cAiglA729qTFaSRourdYRhmxlD7h01I6UnvCZ5X/kLdY5LMF0dfp1lplJVHIzd6wdKO9UyFlg6f0jxnLsMYL/s7jmhrxeSIg6t0L8MkIxFzWA1nMzTKMR3xqSgM3txIs/Fr/R48uQjfG28BbedieYoyigJnS4QKEuB4ZcKio8dZ6MCascVnxDwGrFS+tzcFiMiDKHoSCla7JqQM2DMSLA==; 31:c+W0pvTPp1fohLyAv4HDqMM3B/OuJo0cyKG8/CdgZCPWowVGgD+XByZIFW9t5dfCNjJMO7WpDz3TDJsTN56eDYmRZU0P9NVAqCFWlSXVy/EsqpuZhlmF9OxecbTO/F+L7+MBAvqzO4vB2+c2WJp28rmq9PG+vSIzYmyZktpMX8obgXjMrvtGNu5IaUiyG8NQCeRADchSkCv+f2168owjnccC5eUIp2W/TIhw0xfscrY= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2036: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 20:NxJtq0I3ECrwe67JouIeUX7l67FnzXyvCeiwZrenXMXqc9uY0iYdLCebQvMqJsm38NaWwYoQ2MYPug9x2TX1GItTVte0Mx9rKiZxDHA8WivciuUZFCGyuM2pEy7cZo9hXEUkJiMO2JsgEG6VvnQm6fwyn37CCFE+rxqTgHZ6BeyQo2kSVNMlxZlZdH6yrvfF2sAP4MA8N/pW0hVUp34c1uN3hVXSKn2CpRAuh5/zc4K+gvink0RTGdNH3FEG2DqDQTwNsmhDIZD2X/ALbu7+Z+KmkLtrhC605J7/ATRcvVcN7HeYTwi1dfibfk6k1bLvQBVMaokeFvkfGi7ealNidUY5rVXccbT/4TxfAKMa4mB6VTpAWtdWpDEX4r7aUffX6goZU1iXHz00KBg05VuyopadxZJn3LzpTd7JkDUxn/z7CG9J8Zk29tqjJLlSedwav6v7DYU7GdTqrTWJGAmIOeXMGsmBdhPTPZQV9Viea00AEb6loQP55q5cpN4tX2wh; 4:6Vai996qwoozNkiNmXpZTRaCy2GL993wOMX9luT01vFmj5OtZa3U8mkkIjI2XhpULUVJCF8WHqgltYzKVfwyC5KBgjSTUoef98Hm//oaK7qAtl++ho4NgoVAlDmbuv+nelzDiDzREWLmP0ihkfJeqLn8AcKdfoQICqeyUEFE1EER2yVR0uQ99r6od0qXyqkE5+pUCXojp9UXgqNpAYm+9OYWvpis1tKYPUxWUv2FguiplxE0IvpqRCVDoNg35d2TMClXCqRynLqkPnNgsBZQayCt8rgei2/2r+iZY8RE2RQMOKoBCYEBIf/gFz04cYNd X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(97927398514766); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2036; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2036; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(346002)(396003)(376002)(39860400002)(366004)(199004)(189003)(69234005)(28163001)(55016002)(305945005)(1076002)(53936002)(8676002)(14444005)(81166006)(7696005)(6666003)(51416003)(97736004)(6306002)(2906002)(8936002)(7736002)(81156014)(5660300001)(6116002)(53376002)(3846002)(1720100001)(50226002)(21086003)(26005)(16526019)(575784001)(86362001)(186003)(478600001)(966005)(476003)(486006)(16586007)(316002)(66066001)(68736007)(105586002)(47776003)(69596002)(4326008)(106356001)(386003)(52116002)(6916009)(53546011)(956004)(2616005)(25786009)(48376002)(50466002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2036; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2036; 23:hgU1tZYqT+KqxWGFfzZsYbDyEfpO/T00OXKCBNW?= =?us-ascii?Q?H7DeeXyMYMjLxxRGw+D1jIrD5Sjf1ED8ZZT9nL/tCfzIEhBUn2T2OuCW6c1O?= =?us-ascii?Q?mVspJHpQNE1rVetpgLUycnu9bYQc8O7iUhPxBVyc0dF33gCMJ+5zdl/Np67E?= =?us-ascii?Q?TbxbV1+3JHbhMbUuhRDfvA3VIpGWypolZvqD5iov4oj2epbUEGYa7ejNSejT?= =?us-ascii?Q?pkbsBF5CJtg7C/Oy+EP70mM8S+TwYfJGRqarO49aqzvZ14LmSk62hpQScMyO?= =?us-ascii?Q?e0LjuQNC1mGPQOgmBfeFpaO9ANml/ZbqLW3yn5y6oZAxtBjrYVtt3LEB66s1?= =?us-ascii?Q?F7xFw9Cy9TN/3gn2ge6emAmw8+3fOZVqc4L1EviALHda9ebWONUFcMTW0beN?= =?us-ascii?Q?08bKKAXXemtoORPrGuY1xWFXnbY/ZtSw3+JUw9zCfHU2R573P/9Og4FnQw1B?= =?us-ascii?Q?wLSag5I5/w3HJ7Jnb+xFaQKqWfdoxF36X9nZVOp/pOnq7M/TYSsoqRs85klT?= =?us-ascii?Q?JrmvcRlV4WYXYkVbccYw82RfNlEXcdAnbbVJramjsAHc6P41ElPhVRfiOeRl?= =?us-ascii?Q?IkqtLra/oXvh/5elwk09UYy/UOOZqazPBXcyjUsMsajmeMLZce1LGXYXww1j?= =?us-ascii?Q?VMA5GP9h4ufz4evmHQMOYCYaQaBz4cCcVWJv0tgwVtKBXKxIbRESvdTDSJlg?= =?us-ascii?Q?uZ85hcyBjjccJ0xzCDTUyTVBWh9i/sveAA1KJKJonDO07sTuhC5hgFgPvaCG?= =?us-ascii?Q?s6wdAnOSeqeCruL38f+5sDi0qysdydkTxwOSWoaPCugYR/EDiqFOCp+8ixep?= =?us-ascii?Q?6H+HiYeZp8q+AvIk+UzLwF0bClZvTIuJi1hMX8nTSV0HTAqVqsF9aJbkCskp?= =?us-ascii?Q?oVKbb3vOHdfBTeMjZXMcnJejx70tVWDyS0EnhIAXbTdXqYTN/y6ImpEoo8Ab?= =?us-ascii?Q?67fhNATBM+G0h1k+I0MSJLw34qmBx4nul9Z8tWHDSl1z6BvlnIOIjYS3IdW4?= =?us-ascii?Q?TFnL6VISNAVUMignu4kD7TQC9O/ZiJm6lRZVQCtFBqzdby+qxbSiVtQKm3QC?= =?us-ascii?Q?G15cMOlU1lbKVQMxP3GGOqolBeXMAVZZ8KiSfgmdkE5++gLnfNv9AMzsKKN3?= =?us-ascii?Q?Kgqpaf5ID+rLoadGPx6CQhBPQHSNc2HztlNPRRR9V2DnNr0MJxgpQ9HkXO48?= =?us-ascii?Q?Jj8KnXRLHTIgly5WglnXKQkvNlekSsRs1QYwF9InUM0DRW7h7/u/sy77QJao?= =?us-ascii?Q?WBpR3iVJ0GFpH/Wia8Y1VVWk6RE3JoNZAkdoBpHYIXluQ/5SA3OLQnAM0sY5?= =?us-ascii?Q?h5ruJm3y++/DCUlPBitYKC+zXu0V9Wjb5MOLQHaEXSFr0c3q0kTkFDzQq3wE?= =?us-ascii?Q?qEL1sDw=3D=3D?= X-Microsoft-Antispam-Message-Info: 3tWRxA2vcq1oINZhZ1A4xfCvzc4i5GW05HDKENP2u6H2j4cfS1n954gMZpwNhGN/PDvhHgATaRoJArqw+J58DLQ31I7t6sg2EQft/rKxJT5wjTvldT3VTa4PsXB+J0Ig+/oAtEBcvntdIlQdtW2WjeFoJCv8VzWWoAWGTNbwAvA9wN2zp4wtjfKiA1tVACg2XnYTIkQImetD4SlOMsYTUVuTFPtIW6wZ9YVK3d3/hfMy3V+U/QZbR798tTDtWncX2lt1Sl54EgjUjRB97D6PVaa4ZNery1f1fYXR3gtk8y5lBRrffk1VYlxgkTRR+9JTwtrx0uidAk7RQDcX11o7V5oPH8OAsrNz8HR+xitfPsw= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2036; 6:/rtDJ4wDiPDENawxFPl7oTeMmaR+b3G6H17AKnbDqM/iT09BFsEh/s2bnDwOBzNi9M9IGhilXtBuBF8DQs68DoOO0xLPdEzT6WJzjr18lMuplEqyVjzdD8sDMVBxtmxwvJBQlD0n2dNPd+2SQhGjD2twyHZaFU9yzJp6Q+PobSZeQZhG4bwlRzANOHebK1ihJDjU0fDOP3BaqFKGmEqW/JRb+eEcHvZ5sdYj/9ZN8T3iOfzZHGSZ5XNToOov9s5AtDeJ3xACuraN3Ee95kl+YRA4VvcRw1upx6Gvr+Hkfq2pRgcaFFe6Fo3WQbkvFT/SS9CWHqTlv0BxfV8MlKG486hzpBmiQXOE8jgNQ70T4l+6jIzCsIfNgMeiYepihXhYRHNf123CH6n4ue+/oomN7k319pz3bUpcyLv/ofNkIx1fS5xopXQCvBmyaCXj5TrM2T3CxcLsL8DaMZAbulyiuQ==; 5:37zq65aV2uC4g+J4OnCuBPy9E+o+Q7UPa8WSbTac5RNU+yg03uw28KyO96u3TIro2n2hmoVVNVmLSF0hY2zqgz9MyRE8k/ktIvnLFre20VRVPl9mA8y3XWVxP46vLkzWWU7zlycp+33jmxbHHKJKWHXI16OUAJQ0dg3SpzTkcCI=; 7:T/nypaPiPhjyw6qZ9bEzIEMIzOhOwFuYb7c045LGsXDOnXEXGvv7M4sBzFg32kFMi7t6DWzmSLr6M51V9zsSbDE1n9dVIKBTvSCfqm1ogNIYywyNGkIDzpSw0dZb0H43m3rvtaHhxJg8ZmITAziCsPXteKy7zIO6EvLzsjFXCVIqPK3Nl4am4pAwZmTQ2z3F0pm2d2cExlyvzJvS3n3k7ytoJ+ze4k7uQZf43JPMJQDLk9B4b76oWrzfrMI/CXUY SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:25:20.1051 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b1da9b02-590b-4021-5260-08d5f368337e X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2036 Subject: [dpdk-stable] patch 'net/bonding: do not clear active slave count' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:25:22 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 44b6d0b59d2ce3ff3b94ff8297b3e1dce8154135 Mon Sep 17 00:00:00 2001 From: Chas Williams Date: Tue, 3 Jul 2018 22:28:32 -0400 Subject: [PATCH] net/bonding: do not clear active slave count [ upstream commit 69bce062132bd2b4a943fafbb710215a7999d198 ] When the bond PMD is stopped, the active slave count is reset. For 802.3ad mode this potentially leaks memory and clears state since a second sequential activate_slave() will occur when the bond PMD is restarted and the LSC callback is triggered while the active slave count is 0. To fix this, don't clear the active slave count when stopping. Only deactivate_slave() should be used to clear the slaves. Fixes: 2efb58cbab6e ("bond: new link bonding library") Signed-off-by: Chas Williams --- drivers/net/bonding/rte_eth_bond_pmd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 0cbe08ada..98515bc39 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -2048,7 +2048,6 @@ bond_ethdev_stop(struct rte_eth_dev *eth_dev) tlb_last_obytets[internals->active_slaves[i]] = 0; } - internals->active_slave_count = 0; internals->link_status_polling_enabled = 0; for (i = 0; i < internals->slave_count; i++) internals->slaves[i].last_link_status = 0; -- 2.11.0