From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0084.outbound.protection.outlook.com [104.47.1.84]) by dpdk.org (Postfix) with ESMTP id 70D761DB8 for ; Fri, 27 Jul 2018 04:26:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Z44a6z4oQPtx/MO1YOV0BX44nPPdD9Onn7vvbDuinwo=; b=J/WS07JO5szCPG9QANujsBvXX/FOhkDX3ZIJ/iJKk7NrMV+MCOljIa4tuovy7lgfHyBDfVmKFy55mqNMlSy5b1dzKC9bbb7FQevq4sCLYSoitCp64Zs+EzD8bmLwg60g2jKFZGa4s+u8HX9viyCfTDYsuU9oJ1HzfQpnMhGsUH8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2034.eurprd05.prod.outlook.com (2603:10a6:203:1a::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:26:40 +0000 From: Yongseok Koh To: Radu Nicolau Cc: Akhil Goyal , dpdk stable Date: Thu, 26 Jul 2018 19:26:15 -0700 Message-Id: <20180727022615.38319-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM3PR12CA0061.namprd12.prod.outlook.com (2603:10b6:0:56::29) To AM5PR0501MB2034.eurprd05.prod.outlook.com (2603:10a6:203:1a::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5dc3ed27-1a92-48c6-cfe7-08d5f3686360 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2034; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2034; 3:chzcxxCn1n7JNh9fyrIw2dyDTJLBZL5DjrKFkxAKOQ91+3av1w5wtJjk+6hBshAGNh+gKQk5q1Ci/XBRaVmLk78AwxVtJ6SSuyzwxz8vAbKyojqeEStkm4nrgm1NxgaL8U7uUYB4GdR3LiCYGGpYPVTacFf4MEOlyZ1jb5ovGIfUHCuqZcJy3Gv4oHkgK8HHc3+8xjo1sFe+lG2QsL0GQgoa61ydX4EUqlYJO68hquQFNhzQLxj2ZxkXaBSz3EC9; 25:kKlxPtRSeQxvvQkHTCs3YDmlmAfTcLfAQTkv2Ki60bM1ls52HM8JXqaCmpnHzW4vqUfaPzLEHKgnGvDqBtJBE2azE5ta8BigmpKTodi7yHqR8J34AMDRWY9nFkG/Lx6N58Obx7riXV5b6kLUyxDTASpK5vZsmz0pE4gaMYvVyieEvIYrsW9ysFgP4FUfm3FeJWXwtbEl4nt0qcWrkRwrcfgBqeL4ExJwKpjI9MiQf1B1AWmXwTO7Xp5Us4lLJEC704VsE0LP4XXAtW6MOY2jg8k4EFnlDohDG3ef7QN/isR3gw70KGHj2W9fxmLGgGyQU0xfS7bMLCBPBcUT9ItRaw==; 31:vqooapArorvYa1LiKGSW1hYfpb4OEzQ8zu6RONj7gy6PbnQlOOT2v1VZzqT+vdaRhVs6NgwbUt25Sh1atXBRsGiyb3CtfrghbLAGbZ/l0N0y98EldS96lpwrRuKRhHgHhAu/4diMaOKPGpRtZ7eejeNl9lKKacXqoGTtHqHh1A16/H/Fd4WpRKl4YmMoZfzzSFJuRnKWsh2F3g0VilDxJiT0SdnuMEc7ft7bktYW44A= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2034: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2034; 20:/Io8yXp70/G3ge9kbwq+xMfzqpxQdLLcnkhiDZfAI/kibwnSfo3EWUKGagqSPtvKqJ8db/TuKBV6xwUYsjZo99kiYHXHpurf6cTSIDCcVixGa8JJdOdk8H83Or0MZRr4+9Q0/8J2qSkNg54d0syvm32ZCgaVKDY1VM47QiaktMnWlx5kdtzpMVd1hHw1xkeraVi7PsoHLBO3GbQ3Rzq2mgCkdgiYH8n6zloo3pgLan+C6+Cyx8qA59rsNR1bCA/YUj5OIN8t+NzsHO1RyenLZVviOLbr/YhfI+h/Th+QCwooickqtelXG/s/1LkjcGADpB2q9t/APIu8bHuP4k+BPT3Gn2WqAcVpFqG53A+Zr/3Yb0o6j9ZGXVWXI5cIBdP46XvPPwjb6uO9unFp6b2gL/t+pxbhmNh8AwgVgIz3D+fQz7FTMgDwL0I7fqWGLQICWwt5zvGtJurqHFtcOoMi7fziv72yQLDhPyn/nXy3NUVNuNLk7qW4PB67odR7ABlj; 4:8bzmiAeNPyAoA5Zk04SfwvKG8VTtrhszAvd8U3tjFqCydaGf2Y4VIqwDngPXvVGK85pfYytjS7HmEnmtiNJlUXHWQkW4mLEbVcLPKGiq1fIVCkj7zOlgQ7qYG2EaT5dB8SAgaEZzs7xUo6CnXnG2G4+9ibI3sF+Q+sdv5GA0iF73JNWgZ+wJJzzkLF0CXm0RWc4PO0TCRdNobDpAAPgTzupk7hA8j46zH/GQ2Dt7Zz/TT/XSt8SUiImn7IpVRdQK+ba/S8th+g4/fg5EwmxAy8+ABUR78mAFp/OXIPu9eJfrnTYp6w6P0HRbxN0hTzcfFaQs+9mLwjDY6mOw4DwS8tEPpPs5G5zHksC66ca19r+etZftAnyVsOShMne1j1Av X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(192374486261705)(185117386973197)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2034; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2034; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(346002)(136003)(366004)(396003)(28163001)(69234005)(189003)(199004)(53936002)(53376002)(476003)(106356001)(2616005)(4326008)(16526019)(186003)(26005)(956004)(486006)(68736007)(105586002)(21086003)(1076002)(69596002)(6116002)(6306002)(50226002)(2420400007)(3846002)(1720100001)(55016002)(48376002)(50466002)(16586007)(54906003)(316002)(2906002)(14444005)(5660300001)(15650500001)(7110500001)(97736004)(305945005)(53546011)(7736002)(478600001)(6666003)(966005)(81166006)(8676002)(7696005)(81156014)(386003)(575784001)(52116002)(86362001)(51416003)(10710500007)(36756003)(66066001)(47776003)(6916009)(25786009)(8936002); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2034; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2034; 23:wqjcGOYQVGqv0+KNlghMmc1pg5Lxtsc839yiJoQ?= =?us-ascii?Q?+vvVWbF3PTmkj28Ze0LAvdSAzgPbwwS3Q0+HuxRvh2irXyQCRVVTx0+Pj65T?= =?us-ascii?Q?xr44M6PaZHUmAEuLaJ0y8YYeWITdEMQFJEqYOUZh5ojD4I8xSkAEUsXWc1vh?= =?us-ascii?Q?VSbsLY/J4gdeMt+QSssEnpj7az9rRbIcS5wwms2AxEQB9jZq3Ow2ujqWz10S?= =?us-ascii?Q?9w4xDf2B33jWqU/N8em9uD1lox6hygqfJmskBaQnW0NGTtm51zKBIvMjXNU6?= =?us-ascii?Q?fk9GT1T9PKfHr/mkd0K3YFIj5sVBYw1cWLja+FsMDuuE3q3SUFBFNb6tOW17?= =?us-ascii?Q?eMsbD+SMPpkq2MAfE4l94t6kiwD5oxlBS1RuA0JYgxgDEcxLIUz6wcyFHWeq?= =?us-ascii?Q?slAsBOD0LsNo7f0vEt9wu7oWJiukHheZBeJ8U0IIRoT0qDZYPvO7fKO4315g?= =?us-ascii?Q?50he/04NcRXZ4Du7nkrMlYdHHPxysoUiLFMOSxIXnhXAlWxxVpX038QkvgJm?= =?us-ascii?Q?aEH3iMdY/+aGcjzsJ+Lv3U4qlSuFylt/CSrdqWyWkxfSrBz16QbGbOV7ybH6?= =?us-ascii?Q?VbTxjyaZq6JJBELgdVASjdiOfvyRVKa3D+g4IhaviBTK7M0oyJrfsG6N80lh?= =?us-ascii?Q?cXLjSIngsXXyfIP9BOpkjyG9UQ61fYw7semhKizIMKOO1KKv986uiRzF6/sY?= =?us-ascii?Q?/gruIq1IbM4dERKaemZUMY7OeX4IP+zYrzII9vMQm0sV46fTM4dvax2kGpXS?= =?us-ascii?Q?zDren7SHwIpVRTd6A30WF7XV6ZfWmN7cSV8h3WHuJH9qSpIy6wjZiqsu6JxB?= =?us-ascii?Q?2HHwTgrCBROpcqaAPB2AbhgAz3YKhqCyPccFS0xgBINqmQCNCAZK3GuSLgui?= =?us-ascii?Q?4OFNDmvPXWApRPpZ1ylnc+pJPQCfxm1eCtd5QOi9SxKV50Xt3Ungj1XW/1IH?= =?us-ascii?Q?sdJWhMAbRNVYh3sfpnL2/allvxUM11rqBoyBdBIAK9hCuS4gAXt9j3jSRxVI?= =?us-ascii?Q?MRa4HTzagewXhyv9N2+jcIiJkFadsNJrOfs7sZaJpJDgrpbik1bbYidfkop2?= =?us-ascii?Q?O7BfamvjveZ1Cjr4pnATDdYk2DDW6qak0qRB47BTfdHpFNBHcZzDYZpF+CV4?= =?us-ascii?Q?ewpX0+UsbRflzsJCgEhEhSfbjX7Vl9i6BI0sl9uhh9qDKnZU6n6WpM6ovfEX?= =?us-ascii?Q?VLIWdFoyaKJGaXVfQl5vvM8SeBeM9mjXNXFRJ/7erw0CsWfzcPM2YtIANwe3?= =?us-ascii?Q?2JgLIsF6qr3zGEdCqUVeLwQFOjlez//TdPyEdSYsvav0/MQGZk4phmQktclC?= =?us-ascii?Q?sSCrQ5YhZaM2P5r1k8YYeiTb2NyT5YcLmoQPrgPH6XwArkcsov78VCx9KSC1?= =?us-ascii?Q?C5sD4ASUs3tydwH6vOHIziD1c7hx+heGo/xSuOG0UZEXl9HkqqYAE2yQ0mw2?= =?us-ascii?Q?Yk7jQ6XpoTKtm2WTS7Wsx4J/XO+geTiVqoL9sJWSHYGPFKuX+79XMXjrwiWv?= =?us-ascii?Q?fYgbFVT482vMvfw=3D=3D?= X-Microsoft-Antispam-Message-Info: mZzteMmyeNQ8B0rgbeqTsIsXrRZcOBCBANEuGNvkjE9u69ULVr4oosv26MKZPceIe/A7fFdtgnSp53RZL+/2F/VFNG+mqV3nELVN7nBDZeez1QBcG6QZ/8cjU7f3ZbToE0dy5YweREu5sfrRYVidv0W5/dAsYhfB8HUtFZgVcv3sg65nXY5xORfZFCWfArofLdyXqz1Uy5rtZyYTOtJzvo4g68OQOUBlv54BWvRKyT1qSnt4tyPA7bD+LCYPJ98enr9jjepD/4B9OKO3brm2BETIzDqHzlVfe2tRke8l7wszL4qyNDNpn4JlMtYNUrf17uirTUrt2SYGR2O7TD9Nm8Mj7tzg0hSdehNKT39uscw= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2034; 6:cMYg7hdvzKKv5Kt5nTex2Gzsw0YnpQcI0MeSv07/CUqcN7A/N3jzqLN51Fq7ACYddDW35tcxaBATAF+mfdlFii2mJ3I1nagqKsj4aV/ZdDy5iPtMk9bvemEN1kFkLAqpHXx0ty8rYNu4m8je0PvJ2ZCCu9hSSvcmOg1/Z/+wFsI3JRtgoyXzQ1ayolyljwScpbhneO4flWfGuOdizHMYlcIxDBfRONqJGc7/pFzui7mP+dEmZ4P1w8IOl+lZidZj7hIvPes0HLjrgdfccxBK7Uj4eJlOnyYhRUfSpkUpb5Mq2W04bNytTf074u+fJQEVVW9ZBZm7Uc+gVCca7pNeB4Eqn/qSYvQ7g7hrepDC1jqQCGpVE0QWxOOgGicRlpjSDdpl43Q2wlapq7LWgbpjA4pjjF/ALqbp91SZnF/kOvI/fvcVwqrENzfZkQ2qhRrs9qs5k8e9F2ij18rLl5td2A==; 5:AUQo01fjO2ap/KefMN7Ipf1vbw3T3q9Bb5kUjz3r9jdKEg3kSH6E2F3e3lwo3I3dWnBYYlpNGvRydmDEb2vFwvcyloVqMznc8CnyYaqfhrMG5wCrVCLJR1+9oBZ9AbK9gLLFEtkZgj+Xdc2p4BZDOP9Q3u12i0KMceecdh+o0qo=; 7:3sogo5+i8aXpivKmFPpi/6lfPcrpjuYkduXvHYkzTzKGZn36oDwKY8W6XQj7JLbtxGhnCiRFoX8Wdck66Hozyit0PlC2RMb4uy/rTl1fyCFGCWiNYCKHDsipiEIcZIfJHz1yLRseXt5QQ2D/eN4nZ7OeNxOFSNcQiEhhLogyujxPMiDw05pb6Dvs0fZ0s1dAULmj01hdqS1D2hZtDgYS+7vnSy1j5Jg7yAD6hKPUF+DS/1rI0Fw4GQuVtBGIvzy7 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:26:40.2352 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5dc3ed27-1a92-48c6-cfe7-08d5f3686360 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2034 Subject: [dpdk-stable] patch 'security: fix crash on destroy null session' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:26:42 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From f76fb8869e4c0e2ccf3cf5d6ca57f252e70cd7c5 Mon Sep 17 00:00:00 2001 From: Radu Nicolau Date: Thu, 5 Jul 2018 11:04:42 +0100 Subject: [PATCH] security: fix crash on destroy null session [ upstream commit 8a29f519ef1b2fdddb0324e867006c76c70173cb ] rte_security_session_destroy should return -EINVAL if session is NULL, but segfaults because of rte_mempool_from_obj(NULL) call. Fixes: c261d1431bd8 ("security: introduce security API and framework") Signed-off-by: Radu Nicolau Acked-by: Akhil Goyal --- lib/librte_security/rte_security.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lib/librte_security/rte_security.c b/lib/librte_security/rte_security.c index 685729f42..503f5b533 100644 --- a/lib/librte_security/rte_security.c +++ b/lib/librte_security/rte_security.c @@ -84,7 +84,6 @@ rte_security_session_destroy(struct rte_security_ctx *instance, struct rte_security_session *sess) { int ret; - struct rte_mempool *mp = rte_mempool_from_obj(sess); RTE_FUNC_PTR_OR_ERR_RET(*instance->ops->session_destroy, -ENOTSUP); @@ -93,7 +92,7 @@ rte_security_session_destroy(struct rte_security_ctx *instance, ret = instance->ops->session_destroy(instance->device, sess); if (!ret) - rte_mempool_put(mp, (void *)sess); + rte_mempool_put(rte_mempool_from_obj(sess), (void *)sess); return ret; } -- 2.11.0