From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80087.outbound.protection.outlook.com [40.107.8.87]) by dpdk.org (Postfix) with ESMTP id 54CBD1C01 for ; Fri, 27 Jul 2018 04:28:03 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cNMwj0PGWTtH+84CBiSRYp7oe5pz1bxu7BU5mV0Txvk=; b=tdIdiHQnr07Nu1tkjkmsxMLvIsLWriRrj92c7xCuvc03AVkyYyXnIY+Sj9YART/cZMhQSBLkc70t6kOpWsoynJD4lL8Aq7DpJYFDPD1ZqyUAh1amhHmMqZKTL5RXxM5NlG7N9t+rD6LV9o5BS+4XPPNmYGhDYHN9xAaE99+0z/g= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:27:58 +0000 From: Yongseok Koh To: Gavin Hu Cc: Honnappa Nagarahalli , Steve Capper , Ali Alnubani , Thomas Monjalon , dpdk stable Date: Thu, 26 Jul 2018 19:27:37 -0700 Message-Id: <20180727022746.38457-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM5PR21CA0034.namprd21.prod.outlook.com (2603:10b6:3:ed::20) To HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e9c3da56-b2f3-41d9-84ca-08d5f36892b6 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2043; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 3:D0LwEHl7PlubLhNOHsVu+V2NCMpLAbE35bBkW/bAuTneD1he5Miazex/9Xpe2M5gbmVPw1fI0tNDyKuJQcpTLKwFmQ+vKMvbihvS82zIl01Vha1orW2ZPSzGVMY3h8Dl2gdQVFSh9UIMMBKNJo0ZOLkX0ENt2tHSeP63BxZUn2+j8HDxr4OMXANv4ey7+yI8+jK9PZQEo5TJWYuJJDl7ADWr+iy7AR1NFYhsv624560UXuD6bzD1TOyt/Zguabar; 25:Z/AKPrmObuNsiyGc8K2wXZyr/bnj0zKi1uuwmAVzsfKGHTZ1fmC63IxiFuXcA35pVQ9WkFRtCSrXZHpJJc5lmSX3p9/z3HXTprBPHPcOeN1VFm+olxCbaAlHaFeXzWhNuHOh5dNBWA8kWVAyjXJsP7KeijGvRPaMq2ai2XNvww9JhLw+vtms0HHHDhLqFx+wiaoxab6trYXb7b9Vf9m52qstSPD4qjf71yVUrqnhF1RdjM6aCZc52YWZ+frIjwhEE/6UsY2+YtoEAfLrgn6gDqzhdQ/wD0nf11D1IpKkE50rsS0JFVUKIh044QnVdEqWAk5WdoH5GDMZqjoejqA4rA==; 31:X8ThJvlilfMJJ9BRZnoHxFb453IBFclOpG6+sQnxYHxh/Eo38Dt7Iu0RcXyaeqUu9jV/CgPe78DpGIW2cY2ghaEW7qNstUgReLqTQ1agBTqZX9bmsYibnJD/Jvdma4E5lUe66KsTfhIWKUfGM5mqwAvJwBa17ZGPxhGE8YlyR6JBSF2VWjYTD1QPddABp5ZL3QWNO59HrF2+0AFUBNLjdXIoiM0Wxr/yjzRAQ4PAJkA= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2043: X-LD-Processed: a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 20:/zbPOQ0IACVEHkDYo5OK8s2xppSyE5OpDsdAwGHenTG1SJi8m6XS+dwCrORL6TozST7da9oG85vG77e3RoYcyOQk5C7VbqaQ3jaBQw75Z9Io1ly2CIi36DEvoSrfoSAVZozqKWMd/yZJgnv4JoStN/+wA07MDfSrGeerSitWw8MnmeWIZlTZDifFWWtWU3Q1Q+5ud++xu1zDsUKp8eqtFpNKWeirRwFRTc2gKf9OyRIorFwW2ofPAcgwilvyTmw7KUHq3qMfAKXWLHhhz6+Wb9c2jsV/8J0aSDImnBZhX9K9JWk21ApHp+Q2CniF+LnK069ZvlRP0Bg5MbqDNjJtaDt/HvD4hCFRTnBtjMos5LztkYOHZT7jqESpVWOg53hQT7/dY9p/aI3dkSWjsjtZhdPSCtO66Hu2twbFXHIoDFUMTR9tw5dC4qHmMUTqdovuNoAsgodm1ICdRK/r9gXG6Vj9EPTQkLt/pAJEMSMWAdNg+iqxif3e12/nGMi+xonG; 4:EbweILfa7WY5H1nbhnabPCFO+l/EiTM8Tqaby+qoRyPWUveKIeDtds0TGOuAtlJyND2seFLeOGatgxjLdhFluTA/N61PuznzyCnBu13riCKU7KUZG50liyHdsy7qz0GeaSR8e4Z4r8S+9f+i/ZlMxQH38xVIpC9C1ZfRHdLwyLguIvQc/kTSibzB3Bblc+wMxVBw5HJ5g3tly+IbS3yrqhl6FfCvrdEPBepA301d7YvnXEw9UVPWpNFqvpypfSI1jEL+nj5Q5zwrfx3AmmxH7JOGvzxP1Ai1Us+ZOokGek7YAHzK8+AE/R4AH07Paq49 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2043; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2043; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(136003)(39850400004)(376002)(346002)(396003)(28163001)(69234005)(189003)(199004)(478600001)(68736007)(6306002)(7736002)(316002)(1720100001)(53936002)(54906003)(47776003)(55016002)(6666003)(8676002)(966005)(4326008)(956004)(476003)(53376002)(81156014)(21086003)(2616005)(14444005)(8936002)(16526019)(2906002)(86362001)(5660300001)(106356001)(7696005)(575784001)(50226002)(97736004)(66066001)(26005)(186003)(52116002)(6116002)(486006)(50466002)(53546011)(3846002)(69596002)(6916009)(386003)(23676004)(305945005)(81166006)(1076002)(2870700001)(25786009)(105586002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2043; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtIRTFQUjA1MDFNQjIwNDM7MjM6Zk5vd2IrNyt2MGRlOFpuQWw2ZldhTGRC?= =?utf-8?B?Yis2MjhONnZRMkFGc0QrZ1NoYUVBZ0JuaTAvV1FaM3RmNDhKQVBMWFFUNU10?= =?utf-8?B?d3lCSUpPdVpIazJWbmJULzhSaFVsaTFrWlRuVVNjdE5XY0NvcXVJUVZhcHZu?= =?utf-8?B?Y1NpbGxvOFlJZVdYUVhVa3ZQWHpsM3ozQnc4aW9qNUxSMkp3UG9DVURoRmR1?= =?utf-8?B?YlNGNXVPTXRzQUk4WFBsRFpuRjUzOGxzVWVTY0swWWE2cFU1Q3NSUGRtak5p?= =?utf-8?B?V0FwZndBd2w1eWl3ZjlWZmtCUFUxUjZXOFV1UjFVcVNhUmhWdWJaeTdNQjE4?= =?utf-8?B?enRTOHhHcFpOZDd4ZGsrMkk5dEx0S3hKQ284SU02bmxDQ1lYQ1gzemQ2VkRa?= =?utf-8?B?a1o5TWZHZTZjbUJrQi9ndjBLa3pVWklxaGVHdUJkbEkxVHlaWXJlOExqL3Vx?= =?utf-8?B?bGFJT1pHOEYvUGc5OVhST2FKTDdnWjFGVjQ5elNna0I2MmxJNG1zZWtNczZP?= =?utf-8?B?YmFVSS9vS3FYMDgxUnpqMXlWS0ozbzI4YXhQQzZ5d2hBR1RBenpNZWFyZ1R1?= =?utf-8?B?WEVoRnQ5RFlhVWZNcWpLQVlub0pUdEpwbmliTG04TkFSaFZqUGdXTDdJL0hw?= =?utf-8?B?NlE1TzhLZm8xMDJJaUxGaUZ1VFc0ZjZZbURJcE94MHFPN3h6dHJBZWNFdTFi?= =?utf-8?B?TkhQcHhmWlF3Q0xyUGYzQnFGN2NHUXJOeWJRK3pndzl2bzNyMVUyU2lELzQ1?= =?utf-8?B?OFFsRXQ2YWdDZVNGUUdFVEI2RVhyOFZNdkJNYURVZnRRM2FIS1dSamhBWlpE?= =?utf-8?B?bm41QWJoekgxWnhEcmt5SDFFdlRPVzQ5VjNTRGE3Zm1ZbGllOGwrVHZwYWFm?= =?utf-8?B?OWw4T1QxZDZvWGNINzRKbW1lQTJSeUpOcmlBd1I5dGc0amdhR1JWZDhzaFBC?= =?utf-8?B?VkRNaGxvZyszdUpiWVpxRE5xMjNWUVR0eEFhN2lVMlZVem9RYk9XSkJ0SkFB?= =?utf-8?B?L1lBbGZaNzUxY2R1TWpOc1lLUlBteG0yejhRUjQ1NFMyVzEvdmp6SHNLcFlE?= =?utf-8?B?L3dac0k1VDhjWVliSE5DcitLSHphM0FiWm44a0VaNGtCbEhiR3lHd0l0cUEz?= =?utf-8?B?SWdDU043U05GLzJVSTZraGVBVkI3T3FhOUJCOXltUEpyT2VjQiszRW1aRXIy?= =?utf-8?B?ZEd2TGtReUk1cVRnUnI2ajFZc0JvVXlhMXFmYUdPc3pTTnJWMXhneDhZbWxM?= =?utf-8?B?eWNQTENETmttcFBOM05tL2NtNmVycG9teDZmalY4QVowaDR3VmVlaXB3YXE5?= =?utf-8?B?NWprby91NHNpRUpPbEh5cDhFUm5YSWw3RnZyc2pSckkzcVRBMFpZangrVnNR?= =?utf-8?B?TzA1d2FxNkdiUGF2blZVdytuOGRqY1lzMloybEsxQ283TGJkSS9xQlViWGU5?= =?utf-8?B?VlAwd3RSK045c2QzcHRKVldSS3UxTHg1czM3S2lTQUgybGJ6UVR3QXFTSjZk?= =?utf-8?B?ajhaamV3TWR1ZXVzTHFxODk4cXhBOWcybE9VZUdlOFhsT25tOFdLVXgrS2dU?= =?utf-8?B?NldIaGVIM0RXTHc2OGFNSW1YWGEvUWhjREpWUlJFcHVMTUNXWDUxTXhsNGpk?= =?utf-8?B?WjhSMk5CbENwc2pKaDQ1V2l2dTVrSU1yWTBqQ2RrYTRXbzVDaDI0S0JYM3RD?= =?utf-8?B?WE5hVVVvQ1dkUVYwcFhvMm52R0pNemRRRXN3MWVKT3pNWjJJQ01QbUJDOS9E?= =?utf-8?B?WFR4cENqaUZZWlFzdlNrUmg4aEJPWktIUnFGakJGOTRCQzBFRzBqQXV6NjNK?= =?utf-8?B?YkxZUWROazErT0RwVTRGUVF3UWE2NWdzYTYvZlgzaGNXbzlBZz09?= X-Microsoft-Antispam-Message-Info: BvB6P/E7YmkRGOzImnNg7sK7HQToxP6eiFYlQ5g2XrmxUt43bD8Tc3Pec06vmSqY/oWTXPspLaqoHRE9siohwKoGSzPh1LTzYtLboXVylKDrBPoYGNb9c0vkVEc+76rzerq9R2nVY+EZx9/lOtF04RzvVdCi7w0CPfJ21QZj2Dr0AAPvsQYgW5J+Svlj54mZMQ6EvyaUaBIcrsm0VqW+jbt1FefAJoLN5GtreqZ8cRML/Sp08mwuivTqhXiPD2aj0KY3tp0cPs0K3acy17NOzh+jgoGZIIyeM4O+dm4xxMI0ZQfYemLLy8TXPTbWM+hANwJXOv9cN1U3uBeq0CmJM/4Pn+FonmET8KXl5TwSwks= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 6:8pypU8QhiltnqZf6/wO9+gesFPz5xEevI++5CrfRQm14huQU1AjXZcEHJsfjWzxaODzhb8HeoWqO5xA0bO8ObED4htHCiaVLGZm8CgLM4ZMVkiLs056+ZvXOQ18VIKO+w0YiAwoPhoUdAajBDGyF80SbSxOykGyUNFhF+EaVwoULfnzT0F7kYu1dcEZM5ZqPKqyXFjpJeSLju71kqh5utEAJvMwCC9DgzdHC2Xl5aqL8A/3rKtNcJITvOEWLmatnOtk5YRSN6aVZDuRLA71/vMCd2REczTbCQHLm6q/h5j1sz6BMSTRJAL9jFuauy8n5JazzTEZ87YWOchVRUT8J022B4ufueWwsLXpJXr6DSvq60uH+Pz0msI0Q+EbVQjTov3M+ofX7l2psjzl4nK6dxhABoFPVBC/lTjlwW/Lovjc0O6XF4s0e1mPAVmvCXaGNOoWDhQ2J9H3Y9vxKZaw7dA==; 5:jSezPJzLA6jyghDkkE4gbyJ3YrUtpyfFyq3clT3jobgCrRzTW1rLc9Q7voCIKyTPcmBXK/BYnyF5boxIWVw+NWK5ITbFH3dPXHqYEXtjJLV8e9xMa2RuABhVtKHah5+K/iqIu6iuH4QCNTPh8ILYDN6gy458pUsupAycpN46idI=; 7:+vJ7UUtQjBNe8XJFmzIvB0QW+u5LjstAqxyJoCCjGgeJilFAqx7uPEWcpKQ08GBku8uYiwPwSvSw86+b1q/oCS9qptlKmWIVTSp7Io/qGmfHYZ2kWn8bMt5CC9w/Jgtl/tuOdA4OTOu0dsUg/VTB8YeNg6ytsNQ+2211Dt9zZILc+vw7cI1Z4zW3SakpTnCXsMqm/d57v1bzkNwIgO6wIWorQ7VXBjM9YK5AI6UqOTQyClBjx3Mtfizlhrbbbs3z SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:27:58.9344 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e9c3da56-b2f3-41d9-84ca-08d5f36892b6 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2043 Subject: [dpdk-stable] patch 'mk: fix cross build' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:28:03 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 6c29e90b93ed3aca8f0a22b0f167b6974ddf89a0 Mon Sep 17 00:00:00 2001 From: Gavin Hu Date: Sat, 30 Jun 2018 01:27:33 +0800 Subject: [PATCH] mk: fix cross build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit ebaa070de85e49ad01214b1940c7cdcdba2f4ef6 ] The "-Wimplicit-fallthrough=2" option was introduced into gcc 7.0, it was enabled when the cross compiler gcc is greater than 7.0, but for the host side buildtools/pmdinfogen, if the native gcc is older than 7.0, or the host cc compiler is clang, it should not be enabled. The fix is to differentiate the host gcc Werror options from the cross gcc. gcc -Wp,-MD,./.pmdinfogen.o.d.tmp -W -Wall -Wstrict-prototypes -Wmissing-prototypes -Wmissing-declarations -Wold-style-definition -Wpointer-arith -Wcast-align -Wnested-externs -Wcast-qual -Wformat-nonliteral -Wformat-security -Wundef -Wwrite-strings -Wdeprecated -Werror -Wimplicit-fallthrough=2 -Dbbb -Wno-format-truncation -g -I/dpdk/build/include -o pmdinfogen.o -c ~/dpdk/buildtools/pmdinfogen/pmdinfogen.c gcc: error: unrecognized command line option ‘-Wimplicit-fallthrough=2’ Fixes: ced3e6f8 ("mk: adjust gcc flags for new gcc 7 warnings") Signed-off-by: Gavin Hu Reviewed-by: Honnappa Nagarahalli Reviewed-by: Steve Capper Tested-by: Ali Alnubani Acked-by: Thomas Monjalon --- buildtools/pmdinfogen/Makefile | 2 +- mk/toolchain/gcc/rte.toolchain-compat.mk | 5 +++++ mk/toolchain/gcc/rte.vars.mk | 9 +++++++++ 3 files changed, 15 insertions(+), 1 deletion(-) diff --git a/buildtools/pmdinfogen/Makefile b/buildtools/pmdinfogen/Makefile index bf07b6f2e..ff7a5fae6 100644 --- a/buildtools/pmdinfogen/Makefile +++ b/buildtools/pmdinfogen/Makefile @@ -41,7 +41,7 @@ HOSTAPP = dpdk-pmdinfogen # SRCS-y += pmdinfogen.c -HOST_CFLAGS += $(WERROR_FLAGS) -g +HOST_CFLAGS += $(HOST_WERROR_FLAGS) -g HOST_CFLAGS += -I$(RTE_OUTPUT)/include include $(RTE_SDK)/mk/rte.hostapp.mk diff --git a/mk/toolchain/gcc/rte.toolchain-compat.mk b/mk/toolchain/gcc/rte.toolchain-compat.mk index 01ac7e232..8dbd4417e 100644 --- a/mk/toolchain/gcc/rte.toolchain-compat.mk +++ b/mk/toolchain/gcc/rte.toolchain-compat.mk @@ -42,6 +42,11 @@ GCC_MAJOR = $(shell echo __GNUC__ | $(CC) -E -x c - | tail -n 1) GCC_MINOR = $(shell echo __GNUC_MINOR__ | $(CC) -E -x c - | tail -n 1) GCC_VERSION = $(GCC_MAJOR)$(GCC_MINOR) +HOST_GCC_MAJOR = $(shell echo __GNUC__ | $(HOSTCC) -E -x c - | tail -n 1) +HOST_GCC_MINOR = $(shell echo __GNUC_MINOR__ | $(HOSTCC) -E -x c - | tail -n 1) +HOST_GCC_PATCHLEVEL = $(shell echo __GNUC_PATCHLEVEL__ | $(HOSTCC) -E -x c - | tail -n 1) +HOST_GCC_VERSION = $(HOST_GCC_MAJOR)$(HOST_GCC_MINOR) + # if GCC is older than 4.x ifeq ($(shell test $(GCC_VERSION) -lt 40 && echo 1), 1) MACHINE_CFLAGS = diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk index 3b907e201..e7008c052 100644 --- a/mk/toolchain/gcc/rte.vars.mk +++ b/mk/toolchain/gcc/rte.vars.mk @@ -99,6 +99,15 @@ ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1) WERROR_FLAGS += -Wno-uninitialized endif +HOST_WERROR_FLAGS := $(WERROR_FLAGS) + +ifeq ($(shell test $(HOST_GCC_VERSION) -gt 70 && echo 1), 1) +# Tell GCC only to error for switch fallthroughs without a suitable comment +HOST_WERROR_FLAGS += -Wimplicit-fallthrough=2 +# Ignore errors for snprintf truncation +HOST_WERROR_FLAGS += -Wno-format-truncation +endif + ifeq ($(shell test $(GCC_VERSION) -gt 70 && echo 1), 1) # Tell GCC only to error for switch fallthroughs without a suitable comment WERROR_FLAGS += -Wimplicit-fallthrough=2 -- 2.11.0