From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80042.outbound.protection.outlook.com [40.107.8.42]) by dpdk.org (Postfix) with ESMTP id 0D607288C for ; Fri, 27 Jul 2018 04:28:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/pRqEcXJXBYL15GWuPTLMkVtjjHYPHnc1E9aIWC81bs=; b=vYK8kg2OQ2CoK1fNw75rW9VGSRqpSAXWZHDAJdhUafdexr7ywgJMWl0D7f3SgyQEGwc5/TErippUR53Ufx6KhvU103f3xOZkuATBjWt5ooDMVgaxH+LL0st+u28ircSewk18E9qhBIPDHf+JzsQZcaNsdbrT+4tHUQQ0KcgSTJo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:28:14 +0000 From: Yongseok Koh To: Qi Zhang Cc: Gaetan Rivet , dpdk stable Date: Thu, 26 Jul 2018 19:27:46 -0700 Message-Id: <20180727022746.38457-10-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727022746.38457-1-yskoh@mellanox.com> References: <20180727022746.38457-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM5PR21CA0034.namprd21.prod.outlook.com (2603:10b6:3:ed::20) To HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d500981f-396e-4d45-7320-08d5f3689c55 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2043; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 3:VLCXFgzRFP4TUjK3NKS2GXtJ4CNkAykXe2du4XhWKy2a6US50RRMG2KMBCWqVa5jmyb34wWGZ27FDzBOLADYehpIwaFsSyjc1FZsKLnvDl3WocOEpDrAtfmtlSR518k9pO6lTrEHuQAB9L8XZsKo9EEhq9/l/UJGk/9ZXvr+258I/Ud8OsB2IpgAvKq2R1uI3WlstmQn+ibpc9qi1ZqlGPr+SIaAq194Hbz2/5wWdxLeZRBKVZRTFwtUWUxf+EXO; 25:TKUJGjAUj4ZFWcMO42Of4Z/L0Zomvz0p2muV08vVcw9mr4qKVRFC2YmszF7Dr5I+dE3Ua9yGxZVEg9TNi9jh94BlhVvqy2A5yOVbSMgObjLQC17OJ5LZ1CZWB8q9swPocWRH0ZB6A32TeiGH7E0wVVD8h4SyvNZEmRbu6+0JzCu51WGwdmVBTtoAHmaoV1pan3pWe/bqZiAxmH4m740TtVgtFLY5/BuRGIE8uKXobEkWLjMGOVSFRltyGhidWBmeLKhV76k6Za7v+F1KDaHP2pPNM16vBiwHVEXpdZyyqGQEu2JUyvqYzIcOU1a/e8GXB4nrNoRuCf/YD4rS6Nz6Zw==; 31:HkTy7ctlkp1c9DdhA0bFp+B6QTEsKVbMkEYPp8dgDp2g2F+a5GrQs9xP0KDCA2HOBcELLPS8O08ST9I2wSAabNFpPJwsrzas7GljFflMKFHH/k8R4yv+FZ85o6pm6DOHBJ0PJZW7JQsW5GP2nJwiE+V6Mvu+8BTmqDePfHQME6lWtvzrMlTtQARoCbIpO5IoPYJOzEwTXECpJ2NghurNdkQ+e3Xd7Q84INu49/Bo75A= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2043: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 20:P5fC6POFRDYkFO3XuCVRl48QEgS1h2WaaQEQLzJfhVGVWhSA4xsRMku++cF0kpYkGfs9kl3AFEUdyfv1OphwG+8Uk+H1EUVsWJVNOKd3w6yt++PRevjuq2OSv8CAKTZ4aDiZzN6hlEJI7uujz4kjgDdF2047mkcv/moWI6ci7fyRJ7nXyWPJBh2/7U6haKyPAHOaMJIzYKHh0uUDW95FLQXSl+UYWS/KyX3ebnfZyIDt19QT7aX2THNvJ9+nQqrKzQuMLmJYFbK33D6eZ29/nMmzEpJyOOe9NI1io4ciagwY1mYKHFAZP7rVWMzkeB4hrbkG7x7wrULoF1BvPJnvOS33bkcrX44P9EDyM6fa5WT3hvi/otIYW6SEsq9z/k0VTnRp9QUa64rZ+zuEJqKVnFWSD3MYxnGRc6fRW57XHHJkE9it6oSvusDEL5L+zFhv18diC4sM/rCijMxwwZNnSSWPhgjiRuVb5FsKYmuriI768+wRicfmgBwLDUxrrkNA; 4:H7HLH4C5+8j1W2vfSISyf3ttTVP0wwm+ITUGLg+7gqK2gz2GSyvmo2AdkmB5TmvH+cXzuV1DAjoeh47h3mNUkW5Ad06B3T4EUxGiGGxUWoHugUL5Dytmh53nWIiMNUZQVCEs+CSlf/jTVrqCik0sVmjCKe+2p5yLq4qE54PoLAalmmG52g26pJbNUbiLtmcW5SQzIdMREccSj2q8ZoQk99qlQiW5lEmZNtx/eMcJgFAXnQWowQwxu917ecxroS5duJLJIOPDkG4wDzTZ5xJRtur1Az1LTKj6kzitYa16y/Ei9crBOmORBBmY0vOHywUE X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2043; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2043; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(136003)(39850400004)(376002)(346002)(396003)(28163001)(69234005)(189003)(199004)(478600001)(16586007)(5024004)(68736007)(6306002)(7736002)(316002)(1720100001)(53936002)(54906003)(47776003)(55016002)(6666003)(8676002)(966005)(4326008)(956004)(476003)(53376002)(81156014)(21086003)(2616005)(14444005)(8936002)(446003)(16526019)(2906002)(86362001)(5660300001)(11346002)(106356001)(7696005)(50226002)(97736004)(66066001)(26005)(186003)(52116002)(6116002)(76176011)(486006)(50466002)(53546011)(3846002)(69596002)(6916009)(386003)(305945005)(81166006)(1076002)(51416003)(25786009)(105586002)(48376002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2043; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2043; 23:ppupTh/oAiXF5OOUydDMf10i+YBfQjsvFz3gXSi?= =?us-ascii?Q?mlU5lEo1QzC39yCm+1zdW1k/XX7aATM/heQosQ2YFeSCYXTQtYM7JNtOMeUW?= =?us-ascii?Q?1dL79cZg4+96rSA3TT4jG5aNWUjMnIbk202tsUrq8vLh1iTD9+AmQZj1Is14?= =?us-ascii?Q?5pi4Vu3vgptvruwH9InPwiK7U4aspg4ufRK5GL6zC1YVHA9W6uO+Zr6v9b19?= =?us-ascii?Q?GMwIzWdrMK9P99RfpPuhra8u7DVqFtYECTIDUgwblkQtLu/k33C3MP04qaiY?= =?us-ascii?Q?kOVi5a9uSgWj5bLPoFhhw0ExtGFLG/z1t99IrrK5g3nM0tL+6kxMjwqjtYNM?= =?us-ascii?Q?oy2DWTjdF/CrNOqIH2Ct7D+wIy5LGv3kFN4yjNWHOMJh5g6A7IKPxAaAu/WK?= =?us-ascii?Q?AqZEcok/t+b2XW2QnD9IMcwIK9Fub0yOUqPN8kPOv2j2R2dnvL63bclFc/56?= =?us-ascii?Q?NN1EcoMfrKxeL9O1le77Avwv1dmVdTcE76yI6HKASwV/t+DVgpeQLiT+WYWF?= =?us-ascii?Q?0Tr0BnAhU8+GaUc/M0XcIQeG4oU4YgPpuq2hLcdbsndJNPAdqJnSIuytWmsc?= =?us-ascii?Q?gvi9HLyGFiRSy6TM/rXy1WeoK+2gp6JoqlHPpfeYwS8iZwC+rW2x6zbD+OVd?= =?us-ascii?Q?WxzkPm5Wy/D0iJiRnRgXL/n1Bv3bCI+LAzBY1O8lz+1Knye8Q3CFRS7EQHpu?= =?us-ascii?Q?Y7BacJiAi4gkWLdOB+NxR6ozHSnivF1CTfVsn3+Ieq4tZE//5M7F+b9EQ2Nu?= =?us-ascii?Q?Wr2x5D4VZ5kmR8/6bWLAqfq72Jd0kBenYwNKRtF3cRwF5CM50HQazjoioyIo?= =?us-ascii?Q?8dM/hF2aK8/+/uG4H7enD0A18Po1UCpnZWrOV0+g2Y7PXRdQQ6/Dvm2j7Hte?= =?us-ascii?Q?4sRsqnsk9dGdnsvpMRl4Ee6030XQRpHD02eASLnx9gmGGW3Yje7NYTZvZ+NQ?= =?us-ascii?Q?zojMc1QcS1r9w7nCOvyXUgfKdsRcUKMVPhmRzCSM+4Tl+EfzkEBu46KH6FzK?= =?us-ascii?Q?ji+5Q2LRreTdHj1Kybv0/YTPFEnTFHI/Z02xfFM1PXmJ7qnXRXuOrbptjQOz?= =?us-ascii?Q?siTpLpjz9geXs4lmT+YTJ9cCfo6CjDSkgV/Pi2MZbB5WBcngTw7N/vTKG4fC?= =?us-ascii?Q?/GFcU4tfg3gJXEOZCwvbI7PxGRQurAqz17IHBXFFhIWejPA0kCt9b5GUaYpN?= =?us-ascii?Q?WKK+HNzeyKk9TMHmuzU1soGlHnhsA5OkMs+hCiUSLz69G3UCpIjm67kJi9cW?= =?us-ascii?Q?pFu4z3Yt3470a8+39YeF75DhDE2W9JV3CKj1WgD7SY0pl4U/FP1WttGrjNW6?= =?us-ascii?Q?bPLdi2Sz2F0TqHSvbKuWZnnDc14T2yH/FGlIWRXytq8GQhvbnQYHSsZPnwCs?= =?us-ascii?Q?CqLETnDPiHgrx7dt0TDX9GxenawV3daMEnaKIlpQR9xsseAcdMTXpMS8T6+Z?= =?us-ascii?Q?HJNzgwrUYqg=3D=3D?= X-Microsoft-Antispam-Message-Info: jvRP/ZRLy4xRjc07MLouE7YXYksOww0IEEIPlBFwQSrLEEeiacbOV1NM/epPSg/eipdpggmZWIN8RaN6pfRmIknCWT/0RNcYtWK1hfga4pVes0gxws5zbyF0z57uhGVHTJDvFyXj8XGEHSbwl+0dC0aSly0j0phIQZLCwj24RwD13ebJr4zB633I5Pv3Sto/yEEjQrx80wdWYJnvKy2fxXWp1Sp8/1yg8evuOrBQfYmHX0BIh/JN/IjUzq1R081sBbVqzpeA+iN/0hPnY8clUs/kTy6YIb+mmoUMKdXcSx/lbh5OiBiCyIONoDWJZJwBvXOoaMecA2nvf9yNJ/WO32TlRGRch1ZJM7Owd+HX+UQ= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 6:U2MbFa0gxP2IywINloybdJe7uUVWigWLHFDlYNyUHlRAC3Em8/xuY+TZqS2ZDesbhtW9CUs+817hT9R1XpA8fj1lhahabPPclL5EYr0PZXW98ML9O0Gr1JKmyDikJgnyITXqbz4Lu8H2To7HOnMK7Duk14f1z5MAjH/ewPXnP9lZB5+nL83cI6lY3SJDOUAL8L+ryYPc7ZXRkBI8rk47LXnmATFwL1KB2T1DIAvGLx7FjMyskc+oJp9rUprooI/j1rJoQa7n4t+a1f6f0cMRMKT8/PiqWG6dlZPUMHk275IoAv5Z2ABVOBFlr/b6r8Sqf43jEnpOzwPdUPbClOF4zOqfmuK4l1bHbrzg7sju/63RWuE8JTvAAMdntVbXHd9DluHw25lB6YJTjFQAW6ZsTVE4NRKUjsVMURWIr3lVr2lcgP2dTPX2YxyEv0SWHTWCFG8XdgVTcFqSWSGfxX2SIQ==; 5:loqoZISQqbIbKSXyEAk/SBNUuwes+J/4mzBW3zD7ry1z+1t4zeBWUizU9Wp1iwmZj4sFz9oyYqkrd01SE6qUZML7z+2bTG+T0MKK7YxMl2Rg3uGYWFl3pkXXbINltbMllqUzfuhnpW9PZRaqBX2O9KtY6ceY4AJxRA4JUcj2ufE=; 7:uRi49efBWYoQgEva5PZojONUgQaXq9ObOVSYGzCG/eTldBPiLXw+ifs68SPyy0K2nXN1mglagni9qJMIeHbVeYj2IO51lVyfmbjL0zoV/vU2SzauiUZIL4d/tCTnVpGsDVVniUmGfo9mTLD6PEyJsV5ih3xLoza7qY9J/cimFnJIbcGnULqsPZFAlsF/RPRSbnOOqjgntIsfvRIVnTa7Nu4C6nLIsCY164HIM/J0YmuV7v03ToNxUnPu6crwAWPC SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:28:14.0911 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d500981f-396e-4d45-7320-08d5f3689c55 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2043 Subject: [dpdk-stable] patch 'vfio: fix PCI address comparison' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:28:18 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 8cd25bd5635f6b7e9e36dea7eee8919355531cb6 Mon Sep 17 00:00:00 2001 From: Qi Zhang Date: Thu, 12 Jul 2018 22:01:42 +0800 Subject: [PATCH] vfio: fix PCI address comparison [ upstream commit 2a3de3710fbc54499867b44951b5b41cdb2aba35 ] When use memcmp to compare two PCI address, sizeof(struct rte_pci_addr) is 4 bytes aligned, and it is 8. While only 7 byte of struct rte_pci_addr is valid. So compare the 8th byte will cause the unexpected result, which happens when repeatedly attach/detach a device. Fixes: 94c0776b1bad ("vfio: support hotplug") Signed-off-by: Qi Zhang Acked-by: Gaetan Rivet --- drivers/bus/pci/linux/pci_vfio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c index e7d7f5dc1..745db260c 100644 --- a/drivers/bus/pci/linux/pci_vfio.c +++ b/drivers/bus/pci/linux/pci_vfio.c @@ -671,7 +671,7 @@ pci_vfio_unmap_resource(struct rte_pci_device *dev) vfio_res_list = RTE_TAILQ_CAST(rte_vfio_tailq.head, mapped_pci_res_list); /* Get vfio_res */ TAILQ_FOREACH(vfio_res, vfio_res_list, next) { - if (memcmp(&vfio_res->pci_addr, &dev->addr, sizeof(dev->addr))) + if (rte_pci_addr_cmp(&vfio_res->pci_addr, &dev->addr)) continue; break; } -- 2.11.0