From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80081.outbound.protection.outlook.com [40.107.8.81]) by dpdk.org (Postfix) with ESMTP id E6DAC1C01 for ; Fri, 27 Jul 2018 04:28:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X7+4BbKT6mky2M0oZLk/dTdVCui2mo09xkPblKaamUQ=; b=edHlWQJke4wDzrH8iRlAtfSxomZA1XhB7oHWrir9xjx6rWkUGqkpwG7ZS2daJSLEln4nsjHoP+AEUIISvjw0BRP7yn1T8+hxb+Aa8GezzuIm5KgNLy6Meo54QAxu5i4yMI5tBveNTekM12wENSDnLunBjHCg8HCXm9O8BPG7TNk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:28:04 +0000 From: Yongseok Koh To: Yipeng Wang Cc: Pablo de Lara , dpdk stable Date: Thu, 26 Jul 2018 19:27:40 -0700 Message-Id: <20180727022746.38457-4-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727022746.38457-1-yskoh@mellanox.com> References: <20180727022746.38457-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM5PR21CA0034.namprd21.prod.outlook.com (2603:10b6:3:ed::20) To HE1PR0501MB2043.eurprd05.prod.outlook.com (2603:10a6:3:35::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e764fbff-ae21-4b2b-8ec6-08d5f36895a5 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:HE1PR0501MB2043; X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 3:9nw94oFnwOOUy/3zUTJgAHSmF0izlt/zyneWYo9mb7cB6DJNkFzR82EUFR2EC4IL8kqi/qAr0zWDqJKLhrW4Eb2TSBzRUnyCrufK3a82NLt4LnoY4Gy0S2H9/dN1Ln5oTPY3TMBoFTntbY6pDjnYkTRzo8NUXrbSROlCozUhfYtkYs4/vkxZnTFMPb8oGr/lgnWXvrLvWnC4WPWbt4QnypILwGan2kRle5/3lV4KT8cN52K4kBGLSxC/ScY636RQ; 25:wflKK2RWaQxmq3S3zNROCgZ4jYSYPCAzQG8QteEeATkTSkN02tj/iPr9zZg+YY9pknyns4KCBaUHlGw24VeBF0p3FH4jI//WBhfOZNWN8ZZZslG2wCyfv+DmmI64+KT9JZxESfq+YIwYlzMPZjTyDxw0U+JzxS6lSICN61coSQe659zBCytF7YATOpQ+sf9t6X89YfAlNrbrjCBdKc1c2f0AY2hw78WuWP3hiJ7+kBYQslvCvBBYErqIWNFppRva63CqUQLMFEEMjcGzldlcZr71sJTbm9LniCEMWPkvlRac9scpnWbDoA+73qH9T21XrCmIXTeiIRWiHGXS0Uo+Cg==; 31:xeVB9z/d6glbZZW9gEvWhWjoFFJZrfA7ntEmyZp1s9O2+2a6l987tpCiDH/9ApJDzSUEiovrkbT56rl6MA3pM3wgdEK2VgRUXsF01p7JDb59Y04Ldf8xPURwSGPbVMZhdIYVfevg1LeZUgAdq1OBlJcAewwxTompwv8dgWeXzHFk5uriTeWcaLhjV/AqdPDEL4cvkafeOYEcwWCChR6e87UzlYPfYy5+xnQpAZNLIVo= X-MS-TrafficTypeDiagnostic: HE1PR0501MB2043: X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 20:K5HrOpTBCYSkVGW4sdJKKzUyzIm+8cEp67ZXIZisgrILSi3xrVVUkx2BT6ZJCT6KmfhbKjG49YeBHcRPgBM05I20/AENFhKpYSgqK9RxkxV9IL5uijwlQY4XCo6svMyxvOL7z5tn5wyJAYcdvSJOCUv38hwERoLLRffuQaYPOL5o4+FXGaC9HaJrKBWIKc5fQovEInBNHqXC/lkrii+Gv75l7ATx8RStEUXUWoRMttI/MQVqg4YcSch0O+PwasOVXmIyGZ2zmzRvn0D8jTlbzEOaT683FsSoggJANI0T3rwvh37h41Hq6xK4tJrE41kTOKWSYAaSpUr38a1GIAwZRwBMzyCMnVPdOoQa1Ew/mGqLk18MmehIWeunBWNXSeasW7PQ0EsbpvudZNXb8Rk7Z2US2mNNOYISahsri3uUNkzbJOvK6nwXlb8JEZCe6PyD/CKKwsfPLrfp9n77FkhngeGwkxL7dKxBDRVKFS0TYxIhXYF3ejTRIaEXUPb6/+4b; 4:s63erURWsV/dWKTMhP+WwMRV+HGFhRksZMOS7GmbrcUrtnx6/N2q9qS+uW/+7MLwREDd4wh3H2SaMsDccbwaLFGrVG1eYR8iVgu3r9UizDpFpKt5YE+IWW0vAFcMdtvAcn2ToWNikhEjhjOrxv3iP5dy42aDNsHnHBRcDlVMttG0D3aQd/dHF/jogvJxUtn8BySjGogELUfRVGLB6vDEGRDE31KttpdEqkZguxuc8pXnlzGXSgr/85Ho3D/vQX5MAeAsIN1aYoXJdsZrfDLmauF2+hYbyNu8H332j8oq0jiMORLn0BN1VYKfPl6Fq/x/ X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123558120)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:HE1PR0501MB2043; BCL:0; PCL:0; RULEID:; SRVR:HE1PR0501MB2043; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(136003)(39850400004)(376002)(346002)(396003)(28163001)(69234005)(189003)(199004)(478600001)(16586007)(68736007)(6306002)(7736002)(316002)(1720100001)(53936002)(54906003)(47776003)(55016002)(6666003)(8676002)(966005)(4326008)(956004)(476003)(53376002)(81156014)(21086003)(2616005)(14444005)(8936002)(446003)(16526019)(2906002)(86362001)(5660300001)(11346002)(106356001)(7696005)(575784001)(50226002)(97736004)(66066001)(26005)(186003)(52116002)(6116002)(76176011)(486006)(50466002)(53546011)(3846002)(69596002)(6916009)(386003)(305945005)(81166006)(1076002)(51416003)(25786009)(105586002)(48376002)(36756003); DIR:OUT; SFP:1101; SCL:1; SRVR:HE1PR0501MB2043; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; HE1PR0501MB2043; 23:Is4sJkGMRbTqq6TozrT2HTUsmtXckQ78lppFxbm?= =?us-ascii?Q?jBDCrUJVOeZUdbQNY5mA9E2hm5+3t0OaXRrL3yYkx5Bq5mKy6VloY3tLw43x?= =?us-ascii?Q?9/eZxYxBDC+2xbBv9tuqANWUaQSHV+XmcWYR3fhSfIQv767waDKKk9vd8irO?= =?us-ascii?Q?ERkwp8sCluuTTGBpmYBjHsP8TajFQ6MHvVYe0GjaI2a+sBzzkIergPGwYtV6?= =?us-ascii?Q?QdUljFhBO884yuvG/EuSoZG466zhpcB38xpfBaE16u2c253s+2i/AlEMCs74?= =?us-ascii?Q?dm35vFTiya6QUaLh/3V42Z/8xv4UplVQ9Zp/gng5c6t/YeZN4NeMXpCI+2bg?= =?us-ascii?Q?YNC0KhHt/b0vFI0H2RuuAtVuKmCApvTAp4HgBMiAPPqz67VdIR0Pyc/FqesJ?= =?us-ascii?Q?rLxFppBLmspu68i8CeRfJSxkb4o+iynt5fxanLUUpcsJBL4W34KwR5Of2FMy?= =?us-ascii?Q?HcfOtlxfwgwRwyfBuQ5QMEKhKzmjUNEqNVQS65srjRe6cpFoXneg96NkO947?= =?us-ascii?Q?PcBuzZ4xXC1JRSnXMOCQy8nz9KNznqr4s9LRruZZAQ+7pWDrcL4nZuFUF2kh?= =?us-ascii?Q?+FBBSizNOTKDhpZ5K2yuq12nWoxt4CttGEus2cXOSY6tjjnqy8O7F/uBS4Bl?= =?us-ascii?Q?+hwJ+iPiwTUbShryuYtMvxOtd+EuTWIDll5ZrV2u6UISXcHEyiS0O4DtEXzG?= =?us-ascii?Q?MN5kK7OO64v1bdsIrrQd/u0Q76J5varB+IlbearTaz5tTi4nAckCw6NBzSBF?= =?us-ascii?Q?8uOEcMXUQ83PM754KNIwyBMK0oPZoIhjdTVy+fzDCxsw5Qb4irSPS378Vwdt?= =?us-ascii?Q?V01BxzMxdkQqLRGKvTm79nyEArW4kfoHSutg60iGBEK9EJOSU4VVmTcKXHzN?= =?us-ascii?Q?VlMcRcv62k4ixN7xhQkqZAs40JhQIo9LK1szQpuBymvtSKwG9EqASqakIyxH?= =?us-ascii?Q?rxSGLowIibpzAHUcsluSCVBRXxdvf+VA2XVhGxWCK72yAUEZCjzQspx6CQYx?= =?us-ascii?Q?C//pdIoLRUvRp+LeDBMbfqRRy9yL6UyIowSek7r+s5NRL51AEZ2dNSJE7Zki?= =?us-ascii?Q?zZgrWSEunR9Vn5Z4t5ZFLYzQ21Fw26R9bpV/LBDx1s+76sX1RV3k4B6nwbMS?= =?us-ascii?Q?LXB0CmQGDB5ZUK+cGJj5IzLkVxEqeGu1VgtBXA9ZkgznjJq3TFad42gKTaYG?= =?us-ascii?Q?tKQMQgfZ6N7mRiLKQAWYPsfIeltEE7S+1KpOHsRx5VMT16AebccM45+qvLKo?= =?us-ascii?Q?DGcSUbbbn3ACVkY0P/MoCBqiHrnHwB4FNBzBnfCzfm/JQbh53GTu6c19cZoY?= =?us-ascii?Q?LkHdy3ro4+BlfoxsVukEnqDEFEx/ZSwcRtOgsEyIVQJGP52C814dtCOe28UP?= =?us-ascii?Q?lkOZNolMwK55VyIxzVF2YZQld/QDx7kQqAzXtmK51isCF7M+yHVgMfma8b/3?= =?us-ascii?Q?ABQUSmRXh+A=3D=3D?= X-Microsoft-Antispam-Message-Info: W+FDFU/zI1JlKZSG1nZLLRpu2MnQHDlAt2LVkmAG5mNdBWftGT2Dl0evPWyvntsgoZ2LE44SvrLsqpGGo5N/IiH82fw6LamV1X3zqEs3npmQRTHAfdOPQ06jSCrs7KwVHPak6KkA3QBW2bsrtWjl3KNBOkh/DpolDRRCBJulFokO+LqfsCqiXRWQTsH2sOjE8CHIVCiqFAwsIAyTpt4a+7h74i30ulmvMX2i+Cg3Nqvjla11Zak3wKIjS5YBsANhUk5lwDTT3/iFJtCvJRmZRgRb7F7nNEwFgIO4G6KOvfPwEaxskgs8xUAiVTiTZc5o9d2W/XySL2cpkgmM+1tpIoryrs7Tm0SarGC/nyEpdbI= X-Microsoft-Exchange-Diagnostics: 1; HE1PR0501MB2043; 6:D/Oyo7JMxzkQKMjuJyiOrQbirn3Z687wuBg9pu4CnFJjCpBsgEPcWjNda9DPD8EdAWdY8arU1BggPFmlUjZkXtbvjJ/oGWeBR78zKfbIcrrdTWMPRBi+ZPC+iJBRN5R5OLjqfRJJCS+RBtVkQDu+a6rzDfX7zjTEJiqdKWmV7YeMQaTTov06LTlTGk/7G8q+RjX44l7xpotSvqVfX9ZjQCiYTBduI7teA3f8jl6MZSUnfAKXcexdLJ0x6D1/ndh57Pa69Z2vkTFrtf8MBBC+ZopNXyj/cg7Za9zhAywWsCK9D+7IX5VwbF/BLGTqIaFnfCyM7pQfUY0XM/meKrlZLqL39vGBjVRhF6f8IqOXhy6tDTYqXCphUp9yY67CfN7lpmkqH5aqzwRBC0LwZoQMhf/1vip/bwCwKRAWpEji+Xi0/l60ryEXnsDmrpbQNqhiNciCI02C+8IodhoRvPgniA==; 5:kw1EIcC8rQl3SHntw1D2nyf5kwgZslIgd7/PzsLNJKkztrjy6yTJLmxy5/b6VkRrZRbEVh7rfLfz2QWi4IEODY8Ccsavbd9a9NMg1AUcrQZfLIiSfD+E+u17KnGLryFGF5H/XCEvao6oHgkdmOxmZ5zm6JFZDDnMA6Rp1eLlgMc=; 7:4JI08fcZDZRju/jY1cisCqwzDMXZstEfBR8nZfErwn11Mo0QM8qc2aSWrqC0xjIG+z6rz3/BvBPWdYPwHoOStMe3ov5hFnPTofLdPRv4p07Z4+jH+VdGB6Uq3BrrKungk1uFW14DMj3iqEOBpPY3Xc2YcCGFG+30OVlj0/lTSLdPsx9A2m+Oz2PJAMbcrTgmfNoOhrBAkpaIRHT9y47cxC+ZoNWI/xbJZWbS52HulgaBHZf3cr8JgPhuW6ljaDg5 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:28:04.4190 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e764fbff-ae21-4b2b-8ec6-08d5f36895a5 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1PR0501MB2043 Subject: [dpdk-stable] patch 'hash: fix multiwriter lock memory allocation' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:28:07 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From f0e6f88b0975443aa72cedf233fbe002c8aaf733 Mon Sep 17 00:00:00 2001 From: Yipeng Wang Date: Tue, 10 Jul 2018 09:59:54 -0700 Subject: [PATCH] hash: fix multiwriter lock memory allocation [ upstream commit 27c813679ea961b94d3184c09e50a055ad726da3 ] When malloc for multiwriter_lock, the align should be RTE_CACHE_LINE_SIZE rather than LCORE_CACHE_SIZE. Also there should be check to verify the success of rte_malloc. Fixes: be856325cba3 ("hash: add scalable multi-writer insertion with Intel TSX") Signed-off-by: Yipeng Wang Acked-by: Pablo de Lara --- lib/librte_hash/rte_cuckoo_hash.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/lib/librte_hash/rte_cuckoo_hash.c b/lib/librte_hash/rte_cuckoo_hash.c index cbf78fab2..bc7a9d998 100644 --- a/lib/librte_hash/rte_cuckoo_hash.c +++ b/lib/librte_hash/rte_cuckoo_hash.c @@ -302,7 +302,10 @@ rte_hash_create(const struct rte_hash_parameters *params) h->add_key = ADD_KEY_MULTIWRITER; h->multiwriter_lock = rte_malloc(NULL, sizeof(rte_spinlock_t), - LCORE_CACHE_SIZE); + RTE_CACHE_LINE_SIZE); + if (h->multiwriter_lock == NULL) + goto err_unlock; + rte_spinlock_init(h->multiwriter_lock); } } else -- 2.11.0