patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
	Olivier Matz <olivier.matz@6wind.com>,
	dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'eal: fix return codes on thread naming failure' has been queued to LTS release 17.11.4
Date: Thu, 26 Jul 2018 19:27:43 -0700	[thread overview]
Message-ID: <20180727022746.38457-7-yskoh@mellanox.com> (raw)
In-Reply-To: <20180727022746.38457-1-yskoh@mellanox.com>

Hi,

FYI, your patch has been queued to LTS release 17.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/28/18. So please
shout if anyone has objections.

Thanks.

Yongseok

---
>From 5d33178a0e3bdab6619bd47da8f7f8848a4ad02c Mon Sep 17 00:00:00 2001
From: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Date: Tue, 10 Jul 2018 12:44:46 +0200
Subject: [PATCH] eal: fix return codes on thread naming failure

[ upstream commit 82dcc8b4bcb8adcb7fc819839833e74a3d0ad497 ]

The doc says this function returns negative errno
on error, but it currently returns either -1 or
positive errno.

It was incorrectly assumed that pthread_setname_np()
returns negative error numbers. It always returns
positive ones, so this patch negates its return value
before returning.

Fixes: 3901ed99c2f8 ("eal: fix thread naming on FreeBSD")

Signed-off-by: Dariusz Stojaczyk <dariuszx.stojaczyk@intel.com>
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
---
 lib/librte_eal/linuxapp/eal/eal_thread.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/librte_eal/linuxapp/eal/eal_thread.c b/lib/librte_eal/linuxapp/eal/eal_thread.c
index e9a579e46..c3947d731 100644
--- a/lib/librte_eal/linuxapp/eal/eal_thread.c
+++ b/lib/librte_eal/linuxapp/eal/eal_thread.c
@@ -205,7 +205,7 @@ int rte_sys_gettid(void)
 
 int rte_thread_setname(pthread_t id, const char *name)
 {
-	int ret = -1;
+	int ret = ENOSYS;
 #if defined(__GLIBC__) && defined(__GLIBC_PREREQ)
 #if __GLIBC_PREREQ(2, 12)
 	ret = pthread_setname_np(id, name);
@@ -213,5 +213,5 @@ int rte_thread_setname(pthread_t id, const char *name)
 #endif
 	RTE_SET_USED(id);
 	RTE_SET_USED(name);
-	return ret;
+	return -ret;
 }
-- 
2.11.0

  parent reply	other threads:[~2018-07-27  2:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27  2:27 [dpdk-stable] patch 'mk: fix cross build' " Yongseok Koh
2018-07-27  2:27 ` [dpdk-stable] patch 'bus/dpaa: fix phandle support for Linux 4.16' " Yongseok Koh
2018-07-27  2:27 ` [dpdk-stable] patch 'bus/dpaa: fix buffer offset setting in FMAN' " Yongseok Koh
2018-07-27  2:27 ` [dpdk-stable] patch 'hash: fix multiwriter lock memory allocation' " Yongseok Koh
2018-07-27  2:27 ` [dpdk-stable] patch 'hash: fix a multi-writer race condition' " Yongseok Koh
2018-07-27  2:27 ` [dpdk-stable] patch 'hash: fix key slot size accuracy' " Yongseok Koh
2018-07-27  2:27 ` Yongseok Koh [this message]
2018-07-27  2:27 ` [dpdk-stable] patch 'eal/linux: fix invalid syntax in interrupts' " Yongseok Koh
2018-07-27  2:27 ` [dpdk-stable] patch 'eal/linux: fix uninitialized value' " Yongseok Koh
2018-07-27  2:27 ` [dpdk-stable] patch 'vfio: fix PCI address comparison' " Yongseok Koh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180727022746.38457-7-yskoh@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dariuszx.stojaczyk@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).