patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Cc: Ankur Dwivedi <ankur.dwivedi@cavium.com>, dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'examples/l2fwd-crypto: fix digest with AEAD algo' has been queued to LTS release 17.11.4
Date: Thu, 26 Jul 2018 19:29:47 -0700	[thread overview]
Message-ID: <20180727022955.38613-2-yskoh@mellanox.com> (raw)
In-Reply-To: <20180727022955.38613-1-yskoh@mellanox.com>

Hi,

FYI, your patch has been queued to LTS release 17.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/28/18. So please
shout if anyone has objections.

Thanks.

Yongseok

---
>From 54cffda5be78ae6c300f83a13e4561f817e751ef Mon Sep 17 00:00:00 2001
From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Date: Mon, 16 Jul 2018 09:26:16 +0100
Subject: [PATCH] examples/l2fwd-crypto: fix digest with AEAD algo

[ upstream commit 6df38301de93165d2b12e793f2cf0e084414d917 ]

When performing authentication verification (both for AEAD algorithms,
such as AES-GCM, or for authentication algorithms, such as SHA1-HMAC),
the digest address is calculated based on the packet size and the
algorithm used (substracting digest size and IP header to the packet size).

However, for AEAD algorithms, this was not calculated correctly,
since the digest size was not being substracted.

Bugzilla ID: 44
Fixes: 2661f4fbe93d ("examples/l2fwd-crypto: add AEAD parameters")

Reported-by: Ankur Dwivedi <ankur.dwivedi@cavium.com>
Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Tested-by: Ankur Dwivedi <ankur.dwivedi@cavium.com>
---
 examples/l2fwd-crypto/main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c
index ff5752224..056aa5831 100644
--- a/examples/l2fwd-crypto/main.c
+++ b/examples/l2fwd-crypto/main.c
@@ -439,7 +439,7 @@ l2fwd_simple_crypto_enqueue(struct rte_mbuf *m,
 	/* Zero pad data to be crypto'd so it is block aligned */
 	data_len  = rte_pktmbuf_data_len(m) - ipdata_offset;
 
-	if (cparams->do_hash && cparams->hash_verify)
+	if ((cparams->do_hash || cparams->do_aead) && cparams->hash_verify)
 		data_len -= cparams->digest_length;
 
 	if (cparams->do_cipher) {
-- 
2.11.0

  reply	other threads:[~2018-07-27  2:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27  2:29 [dpdk-stable] patch 'examples/ipsec-secgw: fix IPv4 checksum at Tx' " Yongseok Koh
2018-07-27  2:29 ` Yongseok Koh [this message]
2018-07-27  2:29 ` [dpdk-stable] patch 'examples/l2fwd-crypto: check return value on IV size check' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'examples/l2fwd-crypto: skip device not supporting operation' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'examples/ipsec-secgw: fix bypass rule processing' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'net/i40e: fix packet type parsing with DDP' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'net/i40e: fix setting TPID with AQ command' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'net/i40e: fix link speed' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'net/i40e: fix check of flow director programming status' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'ethdev: fix queue statistics mapping documentation' " Yongseok Koh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180727022955.38613-2-yskoh@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=ankur.dwivedi@cavium.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).