From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00077.outbound.protection.outlook.com [40.107.0.77]) by dpdk.org (Postfix) with ESMTP id C7AD01C01 for ; Fri, 27 Jul 2018 04:30:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UdD+nyyHFON0EV5qVlK8WRDPrmYa0KHeEdoE9BBqg0s=; b=J6nrMTzoMLfwJ2yF2750aKyJ/CbrZdYe0LUbBymitoAE0NkR0xFsdMbu5j7sNf+whfpyv7Gf8YmHBTwbNnh9Q8+194Pj4wHvlo2AJectQ16JHRz5LkT0DhNRswCvKZqiuG982TyNYPbWr1r5LsMT8S+jSlQCMDR4w4+PwdSDZfU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2048.eurprd05.prod.outlook.com (2603:10a6:800:36::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.17; Fri, 27 Jul 2018 02:30:16 +0000 From: Yongseok Koh To: Pablo de Lara Cc: Fiona Trahe , dpdk stable Date: Thu, 26 Jul 2018 19:29:48 -0700 Message-Id: <20180727022955.38613-3-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727022955.38613-1-yskoh@mellanox.com> References: <20180727022955.38613-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BN6PR1001CA0005.namprd10.prod.outlook.com (2603:10b6:405:28::18) To VI1PR0501MB2048.eurprd05.prod.outlook.com (2603:10a6:800:36::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f814d69f-b5ff-44a2-3484-08d5f368e45b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2048; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2048; 3:LOzxyST/yq2lSRVlQLj0oZGmBcOL0Ky5V4mlTrDk49bUV2mm2rGuGl4T/KXmB0Vx1/zpr0GkM0CiZrDIn56COvQ6hfKStMaKieZOeilH+pht7uTDgv/VU0geW4XRf83mZZYTUC6LYhaZy91RBbiGVWvkj8FJAlMViY0yBIgZLyc/DWqfNuIlD2mAMm1XUVg/mw00qkhWkFSf+xQmNW9q6g0ueA2mZcHp0pByRzw6yu/BQGm/HT9j/IUAEiovkaZm; 25:ac/Tum0qDbO+O7ureuOnsORUGE2xnvZZG14sH2EMbNLklDDEN9FF0lAKZxBMv0/HQhg5P+GqZGdPWZilVS5IXVFB3GmLg7+vdmff9ZLCWt3mGXhyQp8iS0dKvQH2pGT1hvzbQ70OThVmxEXahLAppymcJ4+sRfOV773wv2nDCbJWym6DFky+r88/gTJanxesmP5v1iUEXj5UQhzTfRigUgyioPOsbPBRNXIc62LOCkSn1Ui1lkjced9qIRuUGluHcwWWG2BPJqZFqYTjOOr3EFTDa7Ue6tdIL+btOhfk7Q5tw/xAkI8Rkw1dNYHLxOaQsocUenj/tcDGbgQ+ksoVOg==; 31:qnEZmrBDDhJiE733XTMHT/DUm/1O0jJYLu4q0VwHoEZI/SltyrfUJdniWHKsVXJjKblUWcLGEEDezUm6VgPC1qRIG/Fa+QOYvYyxRZ3Me2BBKvGWaNJnvRShNa3wqpRlk0x1YCVWhmLSDkdipn/L2klk3zOa8qINAco/TcX+IZwS8Bxfix0A2JOFkTqvcDDlFTa0bqF/o9y2u11m3gVD0pS9n1s54eHB+nGUJlyFXjs= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2048: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2048; 20:IIa3yQYkBeTyTud4x8nuG2NlDVQcGHQnxhyVslH7gpxRYGodMhvp5PnNg+Sdk2mMswMRGTlHptSxneC8zpb8xP4cJJ4iUdHTTA9u0BJNpp3WbQjJtoKJM2y8w4JnSA0GoFEPNQInvfTtdSkOtPVLQOoccIozu75E1zE5Rx8wZO5a1YPzcSvnGTMamNMmPr5S2KdkR4Acu2pvAZ2SBSuWuMZLvn8t9S83Ej1r5+IR85FMJlAXubhaJzXI5H65fEVh8Pk4DqQtHP5A4OjPBbIepD6XiX2zGU7gwdVoJXsGBcDzfRoMetOdDKgES6D8dt59B/i7wPpRyK57E/5dy5u1EYIxVBUKSzIQUCdSxAPssKy9+G+jYN8ZAwF7uVM9Z12XX+Ew5M06z/Dj2oH/zfoXVNvROH3DnIGw4CzIZHKjYW04/kkIfDzwVB16pOjOTeXLKJW7bTFM05ylKQO0+fBwnQjQNTKjimxfZDIahACAsLvhVW2akwPM+rZHTI1kCAVE; 4:nK6sGaoIdE0Tov730oEjXDoHrfSTUIpXt8N7etIsNzmYaQcFrLJ5krZlgdx7tfYVBUN9CttHq6pWHH5z3xLdrmC4Xsjyvn/iihrirKyyTMIjN2bqYKyHiMKHJERLIMPrL7pC2wtxY5tfpKZemtbj77gsoEcl+23wphRLQJPbgnPaKJ/DEocLH8n9gz/NFmuLx4fSjLj8GpovAPhBIOTZf8BZS7SAoDhWpOHrrId+mSxGzqs4Vf1ue4NdXvYW+99iHTvMuV1vaYm8i3IiHiRvjByqGRv3jVFBZY3BgIh+rA291tpOPfEagJJUM6XBPp1W X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2048; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2048; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(396003)(366004)(346002)(376002)(39850400004)(189003)(199004)(69234005)(28163001)(54906003)(6116002)(76176011)(53546011)(16586007)(966005)(97736004)(52116002)(3846002)(386003)(1720100001)(21086003)(6666003)(305945005)(316002)(7736002)(6916009)(36756003)(5660300001)(6306002)(51416003)(1076002)(7696005)(66066001)(50466002)(48376002)(55016002)(105586002)(106356001)(4326008)(50226002)(486006)(478600001)(53936002)(186003)(575784001)(86362001)(47776003)(69596002)(446003)(81156014)(81166006)(16526019)(2906002)(11346002)(2616005)(8676002)(25786009)(26005)(956004)(476003)(68736007)(8936002)(53376002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2048; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2048; 23:lJlHyDwTaUP8otOhjBbeJYEi2yslZczSCLsuZvQ?= =?us-ascii?Q?E5S/NCUQ62Lz3HH8nrzwzcMzE0STRP36s+LestwYsQefht0s7Z4wB52JHNe5?= =?us-ascii?Q?U+J8j0sU/x1FOy+lZsC+TAGTS+ckeL1M6YbN9H5l7fnYbCTx6k+RfHSC2aSZ?= =?us-ascii?Q?/hswa/3PHRXkePRKoEwtP9TRHxEiFy3zmplGYTd6r4Hm7z/ydvNRNNOQBpPK?= =?us-ascii?Q?p41Ov6ASS6VeajtLViHvZCipWt/sVr1w2w/qjXtrZ/U9lZWmkjtc690mAXiR?= =?us-ascii?Q?7XDyB1OzqT752nvTfnENxu6fdOJY+DrGbJ6YjoloMZv6hhuR0mbqNTBXVXYW?= =?us-ascii?Q?GziDRb8g6XSi7UZC6oLiBXqVIP4wUSZ+MQni1aYnlSeK1xMXz4+bsofDEwwr?= =?us-ascii?Q?ut3s/AL0xtQl66OyR1Z54cI9ZoWi3ayQN/1eqR6csSE0pOy2au0rcdBCr+bf?= =?us-ascii?Q?zAb2RKBZwtae3v83yzuPFgcYyFkPWQyelPSdbsMqahmIHx4sw2o20ktjAgEv?= =?us-ascii?Q?tGvFln2kTyESYlG9WWD8ToHMAM6LljaIrVJAMp51LlSAfIEl/F8yNLmyPgEF?= =?us-ascii?Q?4wVk1m48471SsTcX/SPiAby73msEWozRAH0EfSdDZgcqiM8OfgPPUA4Efp+e?= =?us-ascii?Q?6MN/ngxaMQQUgvwe/0CGLClocASzn6keroHo4ltb5dNBm1T4f0u5eUZOsqsy?= =?us-ascii?Q?v7cAPLhqXKFyKXBQO6HgC6pReHL5UIdCK3tZZBVkpOVA7keb7EXzFE8+BXA/?= =?us-ascii?Q?V5JU9j6w5C7RuwW6QjDX/CZDBusJ9fZVSxIqIjuzazllGAwxSa4jp6wL50Vn?= =?us-ascii?Q?f125CoG+O3pe7vm9soKMFvsWbJSXiiL6bPXAThDrV5RVGLrWUcnLVmLu/JnI?= =?us-ascii?Q?ipz/L5HPpn8xEpSmU456aZ8DvtptCt3anEXsydVLNYhVUezFbqVk+pfd0qId?= =?us-ascii?Q?lPYmoCpnOQBtgnso/OesKTpPC4/WT10WX6edENMFqIGZ8N/7zhNXik5MVipx?= =?us-ascii?Q?CPEYtMNvCsiYB3Wji/mxbWFPG+CI02q1494sYtbjCoTIyLEsXsrreltzjN5l?= =?us-ascii?Q?20AZwhG+OnwNcQ/rSfYaikFHNZO0IdET5YRUgqu8iSpqHnR38YYvQch6IHLy?= =?us-ascii?Q?pbOP+0seZuAt6vy2CXL4kuluSz4gnXZVpblZ4jxU1aZ2EQGez5a77vJTVQ6y?= =?us-ascii?Q?D2Dq7Kg2Nuj0k2rb8oP4c/NkULfcMQuJRqaZfaEaNxNHXxdoqhv+TCH3M2t7?= =?us-ascii?Q?5lYfw8RPPWDnLMAThltuSIiBrxMFHCVe0PZsncS3SVKxcvYGvN1jQgNxJVVB?= =?us-ascii?Q?FxxaGq1nteYJbL12pXcYp7QepklHZ8hPln2Zs183sFznX/9MiFy4axg7zxZL?= =?us-ascii?Q?tLagg7qF5HeSwporIK9Ssu5WHnVaUo6LKKJlvlxZ1wLLUgdG6?= X-Microsoft-Antispam-Message-Info: 69Z0BaKqAkcO1YX81KXJ6lBpRVupwngw6o+zB/wme0ii6q4d9e/E55uZIavUn2mWUwTJWuBZHxV33vApBQFIOAxjAEY1DDhaHAo0y5Fh3pNjHoVeG4sc8/sToZwlUmm/PY/Jo5Tta4nIutU4UDGIp0ujRdguuH1CMe6Ac5KYjiczuQQctyoifpaVyolYe/gjs1w+OZQKtIElUK+HxllxFxMou2/y/Q8X1pP/tL573Coy3o07ZNuSvDDPW1MmZOp0o7kTj5udxVCSCNZGTuh8fdmUNge7O2HLvPiZCyMb0hFD/6SD8KufKjV3hdzArDF6fLDlo7PBhoZKBjM2K2ydUDWmXiQEO7cwSVpzIYtNfb8= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2048; 6:vdYkW5ft5Ns5uZma/JBzhT6UzJ582355JX0EfrjlFyimmoozbS6PRILXagD5xVf8XQR1oXhSXvkG0EpsOq2j84d1VPl/dWAN4FdRtaKp9Dmp5/uvSc4fqSK6XiKpoDZ8S6DDFrflldI/Bn8woLL7hC9+b+fa7QRtVGX4lU36IDq3hjLHN69I2oPAUgppgVM65XkGwf4crYWBDz8u72OHSbCZCp7CdpIU8sAvA4DhSyzx11Mq78xo+Ebu57JQe8yFyjOUXyynSM/0azTviIBPvnazEF9VgpW5XZ7Il2Z8MdxXelwySAwmtgnmEHnObWYOGvL40n2VBS69u8rq13PmEV3jXQVeNMCx/49D1oG97xqEydiosIxFx5Lh7qqB37Aaq00TvLnxFYBur5/MY3QH7bSCgd5DB7w2KHhN7fB+SV3KCUCoS81FoJxwfoGvT23NrhQg9aLxO+KFMgGDsQV4EQ==; 5:2fUt4xSB4SU5xFowPOamrWMIW36wlqADVo+GG3NeLj0AHqMBZUd58vWNx4itEeWRqdYRlzf0N0RAf3/+UwqknS7PUzReMkOXrBCM05BDiTm8CX0JbzYfHKTap6U5zB1eridqk3dmAzqC9iVCzNlxaGZYIzf1B+HgpN9ECR/BTGU=; 7:I4GPwxHUuPQmxrnyohr62cpbwqn5M4Pwfm0kyKu/R7vUXxHEIp1JFaImvMgeUnf6DOCwA71Fs+Z4JE53aKiWO6wV8sCA6nVT3GzPvt4Wk/stI058PJrauM1Yut6+Fz8OFPl4TKrdqUt4owDNRFfyKCHj3DY5UgTqnQ0f5tzvw+zVG2+Xjoy53mC24BgTSVEHNOR8LTTjbyuIIwRNOyQUXPIbpYaGb1JJATZpNNSqCvjIE7tqhboRtnAcheSfReHJ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:30:16.5905 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f814d69f-b5ff-44a2-3484-08d5f368e45b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2048 Subject: [dpdk-stable] patch 'examples/l2fwd-crypto: check return value on IV size check' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:30:23 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 9780c141d8f2d5ad9c55a9cd17d14bc7cb05d8e1 Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Thu, 19 Jul 2018 09:39:55 +0100 Subject: [PATCH] examples/l2fwd-crypto: check return value on IV size check [ upstream commit 53b9a5b66d6e2df2e0d92586d6636f03c529ea1a ] IV size parameter is checked through a function, but its return value was not checked. Fixes: 0fbd75a99fc9 ("cryptodev: move IV parameters to session") Fixes: acf8616901b5 ("cryptodev: add auth IV") Fixes: 2661f4fbe93d ("examples/l2fwd-crypto: add AEAD parameters") Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe --- examples/l2fwd-crypto/main.c | 15 +++++++++------ 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index 056aa5831..d73d2af1c 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -2081,10 +2081,11 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, options->block_size = cap->sym.aead.block_size; - check_iv_param(&cap->sym.aead.iv_size, + if (check_iv_param(&cap->sym.aead.iv_size, options->aead_iv_param, options->aead_iv_random_size, - &options->aead_iv.length); + &options->aead_iv.length) < 0) + return -1; /* * Check if length of provided AEAD key is supported @@ -2189,10 +2190,11 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, options->block_size = cap->sym.cipher.block_size; - check_iv_param(&cap->sym.cipher.iv_size, + if (check_iv_param(&cap->sym.cipher.iv_size, options->cipher_iv_param, options->cipher_iv_random_size, - &options->cipher_iv.length); + &options->cipher_iv.length) < 0) + return -1; /* * Check if length of provided cipher key is supported @@ -2245,10 +2247,11 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, if (cap == NULL) continue; - check_iv_param(&cap->sym.auth.iv_size, + if (check_iv_param(&cap->sym.auth.iv_size, options->auth_iv_param, options->auth_iv_random_size, - &options->auth_iv.length); + &options->auth_iv.length) < 0) + return -1; /* * Check if length of provided auth key is supported * by the algorithm chosen. -- 2.11.0