From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-AM5-obe.outbound.protection.outlook.com (mail-eopbgr00044.outbound.protection.outlook.com [40.107.0.44]) by dpdk.org (Postfix) with ESMTP id ACDE41DB8 for ; Fri, 27 Jul 2018 04:30:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jkkQ4zruvr1JitgPNA/sMfx006weFtuf9+kasD7ojaM=; b=KIS518aWUZjuhSLRRdH/TsijCC8MZLW8jMi7Mq1E7zm/mL6R0BycyiKfwk6u+WySdAbqdCZG4ghvsDbGVUWbl4BAn+nf5PJ3hiyu/OOfED0Dn5t7PCueLhwqiiUl/2lbw7DDL8BOwicKtGYBG0hGbyev6nuOtniPYpRHcCdU/Uk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2048.eurprd05.prod.outlook.com (2603:10a6:800:36::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.995.17; Fri, 27 Jul 2018 02:30:21 +0000 From: Yongseok Koh To: Pablo de Lara Cc: Fiona Trahe , dpdk stable Date: Thu, 26 Jul 2018 19:29:49 -0700 Message-Id: <20180727022955.38613-4-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727022955.38613-1-yskoh@mellanox.com> References: <20180727022955.38613-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BN6PR1001CA0005.namprd10.prod.outlook.com (2603:10b6:405:28::18) To VI1PR0501MB2048.eurprd05.prod.outlook.com (2603:10a6:800:36::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 109229f9-7d43-43df-7646-08d5f368e737 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2048; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2048; 3:NL3YQbK/yxbu8yEWydTOAJcCWyAA+Gc1JcTiEuYi+C+hjkCTA/1DARMNmQZUC0cIkkfQwqYcN5ele4AlBolcsJDAylk/66MB8wooon6DnA/65LqSWfY+MDzKeM6CQ2tAy+IF/89qFf2FdUnkz4LW610BGKUgTrnYaKaNh20stNzVEjlO0rX011266ETPr4HNe7zwugbtAdTv/t/P+sni0c9u7SwcNcgt32cF3q2V8gn41iwYLkrzLkIUYRg+eXfg; 25:teVK0XCUaPEL15/ZjUCTlNq0LvV9ei6id1eTB8H0+CjgkXcDkyZ42YhJwckI7aTOX3m7gkE+6UXXNlZy2TCyaXXaVKNLK+LU0fF+yIijmzqo2d7Ldi5VYJzzsWJnWAKOa6nhVtokoJ8kYlnmIBRBwLu1BpQs1uDvFtreNOAK39FBcMZNjK0yJ8LWt0713bDa8zBY+Htpv7TQgvHfizsOimVu2h/uvWB3g4NE4jc5h57GW3xQGYjCDuydO0hOelckNPOgxKtLnQKEwZp7BLurXzaxI0EluuRhHM/XCI1cwt9PLtt5hlffQlwK0updE7np3R42+XzgJXvqrVb4+eIXBw==; 31:ATZRyMcV3RBFHxQkJhNH8M8lCcEgXA777UW7tvkxs/lxPS7BN1MmbPVvH9s8KCv6eGREmNB0koy1/vcV4nwrjAf900gWnopiX/KqG/3OEFWSWAS0RbopZn1sCuBHAiSWgGWiUXGJCAOAUQJPNzXCGQqQSWYSDLgr4jlwSwsf+VXiGkfDTCxHCan5XVIv11meU7ZNijDyyhXr6DIC8SocTbyDfuY1qCiwX0TnnVQuVUw= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2048: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2048; 20:PQU+fSZ+VQ64HSJYAImU7+CyDV99ei7JCvCvD8+Hxxos6qVFayyjSqxZHE19Ts5cE4QPS+lcY7ADuBs+q6dddjtxskQdrnKXUBDlwEQv5vnBI6lkBpgxDgtlfkQ6nRAFOnTRohnPkA4k5/Bd48Rap80jDdzPLdWqdWsBj/5PYKneZLbvN2zQ56L4+1wJVU+x2Blbk/adfdMepceHEaXHHPVPJ9Vs7rw/d0yDinYFzsZ2cXR8mY/gfnaNjh3hzkyPu4PHmFVR3Zaa1qjVBOpf4D1BLTqkG2ZouEBwpsVVStdju0kVZNCSA1zeo+kp6QSbyzgZZncnarGBq0lEFBqtuYk1zY8E1rtkGa3QGM2k+jvFhArWffuDLX1TjgI7Ab46eLA7uw18qAvDTzW40VCzO3LSDYKOKziUG4q5hdRKdPmTVOxjCmJwKyg6rFrh4dpdQ5dAB0zhXz8cR0rbxWSafxitEK03WP09Uolu6DfxkTVckdmNTj1mix3/FQ0sRYPS; 4:Ks1nSo4ECqYul9CrDY1kUeZ5RYypoaYBGACFm+LKLks2iwPldIBHFw+zHqi7hlGzM2kGeuZ2qzxxHUQqtsadCBJNdD1ngyxyyJn7MLJXhhkEMXTB/r6wMvtnHDgF5xuzLJVcJ+MoKzOJxNW/yqFi6O5cHJccIMHqWola0/spZup4VXA7Qhu4j83Hm2voPPMJlcjhqEctHLdxbeARUxEWe3WB6dJEykOMNAYlrX506ZSrzkFCKsoA/9bZy4dsWL7w14chSx71CDSBWzqXoK7pXzCcG/+KbohhzNYf5zcinITW/3iv5wUn6rTXoIXYljPq X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2048; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2048; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(396003)(366004)(346002)(376002)(39850400004)(189003)(199004)(69234005)(28163001)(54906003)(6116002)(76176011)(53546011)(16586007)(966005)(97736004)(52116002)(3846002)(386003)(1720100001)(21086003)(6666003)(305945005)(316002)(7736002)(6916009)(36756003)(5660300001)(6306002)(51416003)(1076002)(7696005)(66066001)(50466002)(48376002)(55016002)(105586002)(106356001)(4326008)(50226002)(486006)(478600001)(53936002)(186003)(575784001)(86362001)(47776003)(69596002)(446003)(81156014)(81166006)(16526019)(2906002)(11346002)(2616005)(8676002)(25786009)(26005)(956004)(476003)(68736007)(8936002)(53376002); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2048; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2048; 23:t4iEvHKpz12PC7+AG1dlUNalYUtazl4xGlLs5qg?= =?us-ascii?Q?2svvUIM4ZOg5UDcN7ZjfYBJtsQpLY0v7mfwzR4YRZD5eKA0oKbgbf24uTVDL?= =?us-ascii?Q?XJnBXd8KVITwq2LsfUBc7P+sqlswYYrDeJnzFm1SBqdmEQoQ+WyR98cmtR/e?= =?us-ascii?Q?JZGUjOgUdmQioOngqDYvZlq1Wf40f0OZjjueF1A/ytoznq7Ldex9mQAeRK9M?= =?us-ascii?Q?zdKY4bqr0CH0Q7wJwsm1lNFcV1dcOKAARuQlGwcaVdUP6KFDIfIqHKDPc6LJ?= =?us-ascii?Q?3Xjezqvbye/9O9TvVYNetVGo94VlL499J3gl9mZwz8Iijn2SRRS59wZBVnL8?= =?us-ascii?Q?coDc/j7C6r00F9MMJyr/xMb3jQyCBjNGBqohOeMcvyQbW68AwdlFq7JKXRwr?= =?us-ascii?Q?KoD9+5S6w8Sof2zwKNSOHv8tYhG7fu5X6lUpxRIH99UFHBI7+jIcARXL6iaA?= =?us-ascii?Q?IL1AmfFmD0kjuVlKOu3df4Alhbe7SPp129TRR+KjvPwLBHTGcK0APmE0yYOX?= =?us-ascii?Q?6ph5WqCftcb5275RBNkpzhy0ncsNQ+IZeYMg+SDJ3SP67MYwWdecpOV/Z41N?= =?us-ascii?Q?dDo2HOpzG0EcoZNuRTy/rtTX0vwP8XKXTos/LsjU/9aDLpWdBac6eEtvRLzp?= =?us-ascii?Q?sQ3tCrZWNxbMRBvKFhgxu2XmX1A0RQVeh0hCajJaa4pVqaMjBanB/7DUi+/I?= =?us-ascii?Q?8gIN0wC3F6KxKtVFg8R9fYZtCUsbqkgjHOUHqARgWqMua6Awgp2LyYJhzPjj?= =?us-ascii?Q?o9c8fOlPfa/xOfN7lfxtrkMBiX4r7d3QugXOiniakFi/qK4ytPN8P8fHWT8a?= =?us-ascii?Q?vqnq18ZoSGBgP8di7ivqWb0jQyFw4SUt3AisEJyjOD6tEnKZfYuca3eV2ihF?= =?us-ascii?Q?l5bjjC7Ypyhu7uJOI2U7wqW0eGodMdnn4XHdw9zrzcjuZAxzXYbyBe/97rO4?= =?us-ascii?Q?UaV8idi/jWUvRiSH0JfGrmp51MRzKmIuwJE3L5dmLiXtKOofzoA8pvP7VxpZ?= =?us-ascii?Q?3Z08b3N2aFIuvjwAwp7BXN/Twx9/RDq8aF8jREY6d+U68aB1Jkpy+klMddm6?= =?us-ascii?Q?ASffPPdThjWX4GaWqCPPTeSKn5wospWBmMSugPMnlzBfYq7ziM5TN5R3V4UE?= =?us-ascii?Q?+6GfZSt1xmeoq6f7Jb97Avo3TT+XKPJ4D/UDXxfQ4LNIvROJbxT74HtC6hjK?= =?us-ascii?Q?Lc425x4YrInyljbpP9CzqJnHUW8rjjqi4x/TNGfb4wj8dpJTSACnYk2ZBLu5?= =?us-ascii?Q?1TzEnN0jLwLLG5SoHe18sehZXWpMvCdNkGvyJVYVJmHd1E3qYvDzOYLYSKnh?= =?us-ascii?Q?ZTdkGiSspVhS/dbhQnVK7RVTKKD+CemR3/2p8CNgjy+xFEOlcLohZCo3NVdG?= =?us-ascii?Q?eXRSiZBHVLV2OPrfIz8Q4WyA2Kii3rLwc6CTG08D8THuQD5HG?= X-Microsoft-Antispam-Message-Info: mzwe/ShdqOrF1Q3cMyX4VnfwzPo5cONdQmm9pGcbEF+dYIt9KXlJe2JwIt/xJ6F/qnsrFRad/7RmM2u6z6IBkHUnzOKj1PzTEezvqvaFGidAKb1kSZ9LZ/XXkh9+qUcx8koZH2SN163CMbdYrul6zrZulcuDhCX9DK/6WH/1oaxjcDuNNIkfdmcitWlUyNWjtaDIV9OrvxolHDOZ3tYBSIRdma0ceL7h+sLstINtZ+v12iq8gSRYciqZd2wjFJitlXUpM+IZrAkmH+Bq3o+n7eNG87o6PyfqHwPR9SIUZYF6TrUaAEnnxHvHUgtqrwFc/gZzT2qwDlTwVNC0UGZ+UkOamR8OX2kY9kB7ZIrresU= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2048; 6:nVX6WGuofguy0n8GFW0ZsdqBWmjJMMPP1bHSC4lJtEoJDONGPD5HrJkOFENkxjtBr4nUUMGR8yge4/8ZF4FGXmA6qWoRDJDptUxyEAqKNjx1l98QAXAnouM7QOI7RZToJLsT6rLIO+klQxpiRsGbhgEAsCPtm9GDXERutFg/0UKA/ADF5ZUA1jsnPYFQH8gIGVoW0JrJG3dn7hPacXK+RkO3/MJXXyThVWWmD+U7JNU5vOPSza223RDRdDZFg/cmYZuirN00V7/q047lZH6yk5hcaG6nP/QFq096fBXnFoDs2xAfxa9UDESIUh/qTsyiZJHUTNukRSjwQerGYg5OOK6S4nOd0Qyyx7bAgQZRcGhgIoOMuzqf+VIkWcgkQEtDcqDIZULtizH05X4I1NJoivpeaifnC+lUyXJzqKSJ1fTaZhcBIczUX58KLLjGRkv6+vCPzbKbzfsowyqb40ZLPg==; 5:Qp9IE8r9f8YMpzigUepMido91TF2a7ben9kuv08Aa1/X1Ii/ugsIQZTztbnY6JD7ErNKEhGMXXbe1CTm/ePv4oj3YvgwuHZR1pBip4xRR4CmAUQBnW3gaFesPM3MfUG9HtJ89ocUOI7bpOgNIdM3fHczdHaNpZeor8m+nwYmP5s=; 7:28x4zCVwb85Z+jDuJg53Nd0TCKthRRBMgtpkCsDQwmJbu2f8v5jEhdP0DydKLWYvmgfK7Dn4CeocEY1yithyMtgb4o7fSGAhi3r3rCAFSk59htVkeR/VKgRLX4bmUX8GQu2H5Pdgl4eTgmH35ZIwcLqOwIAePlKDX5U5pH9eZPDQlV+Jr/1x+0JPjKCAlV9Y2+KR0Eo9xf9qVfYlxfKOhvdj7XjX+VZdDeYYRpj2JyX0PNSnfs/1VGCYb1vuvPYZ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:30:21.3914 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 109229f9-7d43-43df-7646-08d5f368e737 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2048 Subject: [dpdk-stable] patch 'examples/l2fwd-crypto: skip device not supporting operation' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:30:23 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 071e32ef1592db954e8f7c2fbd404edba9b2289f Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Thu, 19 Jul 2018 09:39:56 +0100 Subject: [PATCH] examples/l2fwd-crypto: skip device not supporting operation [ upstream commit a8fd8881ddf7be88c05e0fb258a54e861ae54a29 ] When a crypto device does not support an algorithm, it is skipped and not used. However, when it does support it, but not the rest of the parameters (IV, key, AAD sizes...), application stops. Instead, the device should be skipped and the search of a suitable device should continue. Fixes: a061e50a0d97 ("examples/l2fwd-crypto: fix ambiguous input key size") Signed-off-by: Pablo de Lara Acked-by: Fiona Trahe --- examples/l2fwd-crypto/main.c | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/examples/l2fwd-crypto/main.c b/examples/l2fwd-crypto/main.c index d73d2af1c..77af7e6a0 100644 --- a/examples/l2fwd-crypto/main.c +++ b/examples/l2fwd-crypto/main.c @@ -2085,7 +2085,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, options->aead_iv_param, options->aead_iv_random_size, &options->aead_iv.length) < 0) - return -1; + continue; /* * Check if length of provided AEAD key is supported @@ -2099,7 +2099,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, cap->sym.aead.key_size.increment) != 0) { printf("Unsupported aead key length\n"); - return -1; + continue; } /* * Check if length of the aead key to be randomly generated @@ -2112,7 +2112,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, cap->sym.aead.key_size.increment) != 0) { printf("Unsupported aead key length\n"); - return -1; + continue; } options->aead_xform.aead.key.length = options->aead_key_random_size; @@ -2137,7 +2137,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, cap->sym.aead.aad_size.increment) != 0) { printf("Unsupported AAD length\n"); - return -1; + continue; } /* * Check if length of AAD to be randomly generated @@ -2150,7 +2150,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, cap->sym.aead.aad_size.increment) != 0) { printf("Unsupported AAD length\n"); - return -1; + continue; } options->aad.length = options->aad_random_size; /* No size provided, use minimum size. */ @@ -2168,7 +2168,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, cap->sym.aead.digest_size.increment) != 0) { printf("Unsupported digest length\n"); - return -1; + continue; } options->aead_xform.aead.digest_length = options->digest_size; @@ -2194,7 +2194,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, options->cipher_iv_param, options->cipher_iv_random_size, &options->cipher_iv.length) < 0) - return -1; + continue; /* * Check if length of provided cipher key is supported @@ -2208,7 +2208,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, cap->sym.cipher.key_size.increment) != 0) { printf("Unsupported cipher key length\n"); - return -1; + continue; } /* * Check if length of the cipher key to be randomly generated @@ -2221,7 +2221,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, cap->sym.cipher.key_size.increment) != 0) { printf("Unsupported cipher key length\n"); - return -1; + continue; } options->cipher_xform.cipher.key.length = options->ckey_random_size; @@ -2251,7 +2251,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, options->auth_iv_param, options->auth_iv_random_size, &options->auth_iv.length) < 0) - return -1; + continue; /* * Check if length of provided auth key is supported * by the algorithm chosen. @@ -2264,7 +2264,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, cap->sym.auth.key_size.increment) != 0) { printf("Unsupported auth key length\n"); - return -1; + continue; } /* * Check if length of the auth key to be randomly generated @@ -2277,7 +2277,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, cap->sym.auth.key_size.increment) != 0) { printf("Unsupported auth key length\n"); - return -1; + continue; } options->auth_xform.auth.key.length = options->akey_random_size; @@ -2299,7 +2299,7 @@ initialize_cryptodevs(struct l2fwd_crypto_options *options, unsigned nb_ports, cap->sym.auth.digest_size.increment) != 0) { printf("Unsupported digest length\n"); - return -1; + continue; } options->auth_xform.auth.digest_length = options->digest_size; -- 2.11.0