From: Yongseok Koh <yskoh@mellanox.com>
To: Konstantin Ananyev <konstantin.ananyev@intel.com>
Cc: Akhil Goyal <akhil.goyal@nxp.com>, dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'examples/ipsec-secgw: fix bypass rule processing' has been queued to LTS release 17.11.4
Date: Thu, 26 Jul 2018 19:29:50 -0700 [thread overview]
Message-ID: <20180727022955.38613-5-yskoh@mellanox.com> (raw)
In-Reply-To: <20180727022955.38613-1-yskoh@mellanox.com>
Hi,
FYI, your patch has been queued to LTS release 17.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/28/18. So please
shout if anyone has objections.
Thanks.
Yongseok
---
>From 908d3bae6e1663f81255fab8966e71cc64bdff9a Mon Sep 17 00:00:00 2001
From: Konstantin Ananyev <konstantin.ananyev@intel.com>
Date: Tue, 5 Jun 2018 15:16:02 +0100
Subject: [PATCH] examples/ipsec-secgw: fix bypass rule processing
[ upstream commit c1fe6dbfcec2b17dd5fd115dcdec2ea573c4de0d ]
For outbound ports BYPASS rule is erroneously treated as PROTECT one
with SA idx zero.
Fixes: 2a5106af132b ("examples/ipsec-secgw: fix corner case for SPI value")
Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
---
examples/ipsec-secgw/ipsec-secgw.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index d7f26e777..46af3f05f 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -476,11 +476,13 @@ outbound_sp(struct sp_ctx *sp, struct traffic_type *ip,
sa_idx = ip->res[i] & PROTECT_MASK;
if (ip->res[i] & DISCARD)
rte_pktmbuf_free(m);
+ else if (ip->res[i] & BYPASS)
+ ip->pkts[j++] = m;
else if (sa_idx < IPSEC_SA_MAX_ENTRIES) {
ipsec->res[ipsec->num] = sa_idx;
ipsec->pkts[ipsec->num++] = m;
- } else /* BYPASS */
- ip->pkts[j++] = m;
+ } else /* invalid SA idx */
+ rte_pktmbuf_free(m);
}
ip->num = j;
}
--
2.11.0
next prev parent reply other threads:[~2018-07-27 2:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 2:29 [dpdk-stable] patch 'examples/ipsec-secgw: fix IPv4 checksum at Tx' " Yongseok Koh
2018-07-27 2:29 ` [dpdk-stable] patch 'examples/l2fwd-crypto: fix digest with AEAD algo' " Yongseok Koh
2018-07-27 2:29 ` [dpdk-stable] patch 'examples/l2fwd-crypto: check return value on IV size check' " Yongseok Koh
2018-07-27 2:29 ` [dpdk-stable] patch 'examples/l2fwd-crypto: skip device not supporting operation' " Yongseok Koh
2018-07-27 2:29 ` Yongseok Koh [this message]
2018-07-27 2:29 ` [dpdk-stable] patch 'net/i40e: fix packet type parsing with DDP' " Yongseok Koh
2018-07-27 2:29 ` [dpdk-stable] patch 'net/i40e: fix setting TPID with AQ command' " Yongseok Koh
2018-07-27 2:29 ` [dpdk-stable] patch 'net/i40e: fix link speed' " Yongseok Koh
2018-07-27 2:29 ` [dpdk-stable] patch 'net/i40e: fix check of flow director programming status' " Yongseok Koh
2018-07-27 2:29 ` [dpdk-stable] patch 'ethdev: fix queue statistics mapping documentation' " Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727022955.38613-5-yskoh@mellanox.com \
--to=yskoh@mellanox.com \
--cc=akhil.goyal@nxp.com \
--cc=konstantin.ananyev@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).