patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Beilei Xing <beilei.xing@intel.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>, dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/i40e: fix setting TPID with AQ command' has been queued to LTS release 17.11.4
Date: Thu, 26 Jul 2018 19:29:52 -0700	[thread overview]
Message-ID: <20180727022955.38613-7-yskoh@mellanox.com> (raw)
In-Reply-To: <20180727022955.38613-1-yskoh@mellanox.com>

Hi,

FYI, your patch has been queued to LTS release 17.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/28/18. So please
shout if anyone has objections.

Thanks.

Yongseok

---
>From fd25d574f08832c8a86affb12f49f0fbabd674d4 Mon Sep 17 00:00:00 2001
From: Beilei Xing <beilei.xing@intel.com>
Date: Thu, 5 Jul 2018 15:03:08 +0800
Subject: [PATCH] net/i40e: fix setting TPID with AQ command

[ upstream commit 2c99142384db1796e42209f5fc112c8babc402c0 ]

TPID can be set by set_switch_config AdminQ command on
new FW release. But find fail to set 0x88A8 on some NICs.
According to the datasheet, Switch Tag value should not
be identical to either the First Tag or Second Tag values.
So set something other than common Ethertype for internal
switching.

Fixes: 73cd7d6dc8e1 ("net/i40e: use set switch AQ instead of register setting")

Signed-off-by: Beilei Xing <beilei.xing@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index afdeeab5a..70c51ff37 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -1211,6 +1211,13 @@ eth_i40e_dev_init(struct rte_eth_dev *dev)
 	hw->bus.func = pci_dev->addr.function;
 	hw->adapter_stopped = 0;
 
+	/*
+	 * Switch Tag value should not be identical to either the First Tag
+	 * or Second Tag values. So set something other than common Ethertype
+	 * for internal switching.
+	 */
+	hw->switch_tag = 0xffff;
+
 	/* Check if need to support multi-driver */
 	i40e_support_multi_driver(dev);
 
-- 
2.11.0

  parent reply	other threads:[~2018-07-27  2:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-27  2:29 [dpdk-stable] patch 'examples/ipsec-secgw: fix IPv4 checksum at Tx' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'examples/l2fwd-crypto: fix digest with AEAD algo' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'examples/l2fwd-crypto: check return value on IV size check' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'examples/l2fwd-crypto: skip device not supporting operation' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'examples/ipsec-secgw: fix bypass rule processing' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'net/i40e: fix packet type parsing with DDP' " Yongseok Koh
2018-07-27  2:29 ` Yongseok Koh [this message]
2018-07-27  2:29 ` [dpdk-stable] patch 'net/i40e: fix link speed' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'net/i40e: fix check of flow director programming status' " Yongseok Koh
2018-07-27  2:29 ` [dpdk-stable] patch 'ethdev: fix queue statistics mapping documentation' " Yongseok Koh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180727022955.38613-7-yskoh@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=beilei.xing@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).