From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40066.outbound.protection.outlook.com [40.107.4.66]) by dpdk.org (Postfix) with ESMTP id D28481C01 for ; Fri, 27 Jul 2018 04:31:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3yG2LaL8AJckAgDlJ0I9IGRlvJH4y7dJmJ1tBRwkyYU=; b=MeHszQP1WFFdCYnnpwVbOUwXNnUXD+9/N1KoAzTkSGTgbQgMLFHYsvaIBP7L8N6gGT4LyrvptpKucvvDTcrDtUxtgjTVoOZQNPXUOtu1D1xGQomsK71+BnitpWTORyLN4+MUeFTZyRBF/y77NWoYXK6CXxBxsSEnI8U5baB5AC4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2046.eurprd05.prod.outlook.com (2603:10a6:800:36::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Fri, 27 Jul 2018 02:31:25 +0000 From: Yongseok Koh To: Kiran Kumar Cc: Jerin Jacob , dpdk stable Date: Thu, 26 Jul 2018 19:31:00 -0700 Message-Id: <20180727023108.38699-2-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727023108.38699-1-yskoh@mellanox.com> References: <20180727023108.38699-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BL0PR02CA0084.namprd02.prod.outlook.com (2603:10b6:208:51::25) To VI1PR0501MB2046.eurprd05.prod.outlook.com (2603:10a6:800:36::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 3b35e4e4-d6e9-4811-f0b1-08d5f3690d5b X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2046; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 3:L4IcJ62Wvt2BofEndeEupKAkM2u+77u0jpTqroyjTlEsLsY076pj9wYZhw3G261852Ya5cuPAXH3XhaLNIE7r92EjUbaU3ok5oE9ckW9LI6U2jOC+Ujc+4MaEhapqUzRIVlzNPxAuJTZIEIPli2Wld719nywgs9j8pdrndQp7msJeJYNSs4r9WY8Hv0O1FFuH4b31Q0EE+Oip3F8QjE1PbfEn2qQuN3MHFIeyeR4KTpao+pOdaEisdEV2R48O5pg; 25:XJyZpT+JzlS1ZpxVPAT6Tk+4/8NIbXE7l3jVa51si7Bgp0wGeHWNus278ofrRv5h/xcws3nwwBbXH3odCq2wDGegc5M8HwhvvrXhHVT3bG1/OUp1mdcBUpQ1pSH0T1WSKAHLf+y77bH98MnEPNuvcnQcc1Ep3Y8yoiAqn/4gACggY67y0gzEJ6Z4VADj4+sSCrqnqYgtpW2WonTB7n1RTXBzDjfAiRX63zE3ZUVmO5S5AQnq5QiPQyw1BMZ7rfJZ3hvK78Zb3nG8ss2204qNBxMfLqcA3IRE8nUJGjYeqaDz6nwgOZzNt4XuGJzxP+3zi0Q6Hmm0cXjMQ8BJcyRzYg==; 31:KVOjd/DBhoZA/BC9qzwGuVwWU2kZEa6Y74ZFjBEMlpwCnvfM4HpY01va3+lmTW723GCr9H2aYCSvHbvsKqWSuPRnunXJ+nMB9PLltxoHj971gty9B4H5oPlFwL4VD1au4S0EeW9Mdi+ZHaEzn6BUZV1BVRRi5Wm9I8o5z/D2s5IrEQVdftzB/QmSL7EXBh41Qgdv22ipAeOK9GM8KbN/wMCs5EvttwhhjuJwN8kUoQE= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2046: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 20:fkhAJfuKaEFtCIfeEYb+vzqo+UEVA7ub9Nuf/mOUjsMsakh7Ck9wdWiH5uWrjg0kav6L/X0GOpuvtt6vjMtlJV900OjdYmiKY0PRhXyTzETQwetqRlJQYQHFfZEST5UqcoDNh7BgPEK8/4UvgzHxgKwo4Qs182r0qEg32KVqbaxM8cTxUZon2XDhyta0Bgh2fA6mNs3xOuyYpS9LaATQ6KAoNy+uFBTkyIy8FXtviKWLwcBYvIZL8oMt8OvV8SH+uYwMj6hhV93haIXfaVEAXLwOevw6rffQR20TO3GCb8hOfn9BePzqMPnvkQ81oc2KxsAPkog74ZkSU1jBlpYWyfeij9+Aub3/1xc19Nof8GEKyNl6wCUgBS8hf21xbtRTKQ2jh8sKtGYJDm5S/klE7RwXKNwMl13pjoCc+F1ziog6oWgtX6A6dQfemn04Q1IjQyUWDHwj0Oc5rJ7WGWZlkvprgQpGx5k2M8THShoZgOD98ssF4QZhaULyQxo4yGRE; 4:njhXi1mEFlvP6rdpSbSC62Do66yLbBVAFeA8+eUuozKU+2CVdI4+mPVM5TZ3XhBCKxx1zkgcybcMtMOc6V1OR5SucUT+RLueC1bJacaEgQwDbrNawuY/flaxEHc/eGdI+gQ9k5E2L/x3JdYTU9lxcU7LNu+FONa+JQOobx1j+dXKmvkzjxkgVeBPJoDnTvhMYLDoVKw33s7my/WPq6f6f5/ue7YNLQjXoyzx34rQtCOJgCk8EyGGkeuYunKBnMkk9bZN2fmYpg0nEQ4L+jt+aw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2046; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2046; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(366004)(136003)(346002)(396003)(189003)(199004)(69234005)(28163001)(186003)(53546011)(26005)(86362001)(51416003)(16526019)(3846002)(11346002)(6666003)(8936002)(36756003)(386003)(76176011)(7696005)(25786009)(446003)(52116002)(575784001)(97736004)(486006)(53376002)(4326008)(6916009)(2616005)(476003)(5660300001)(69596002)(956004)(966005)(54906003)(81166006)(81156014)(55016002)(7736002)(16586007)(47776003)(106356001)(2906002)(305945005)(48376002)(66066001)(105586002)(53936002)(68736007)(6116002)(21086003)(1076002)(50226002)(6306002)(478600001)(50466002)(8676002)(316002)(1720100001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2046; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2046; 23:Pqz1NoFGU9HehXeHRT7UAooIe9+xI3RSWG+FJzt?= =?us-ascii?Q?1HbHrCIk11ZrZYA3jmYxlEn55APZyz3r3fzpLrtD68UQHtr442cQ8S5fWDWm?= =?us-ascii?Q?nsUbCsnx/IRbQx1XboqtQ0z9Nn2Rx3gootMp/tnCiuVfzqskr/RZdicWVaMQ?= =?us-ascii?Q?Bg7Q0ntOlorOt7lJM1cnyaEgcTGpRXKNfk9UDZkbwT9sVpuH00EGUSBx/ZtI?= =?us-ascii?Q?6MnEqhPA/kQfFyZBPCPSlD0rvHonv+f8u1LG0PU2DuXHy02pKVIYnwrbHW5z?= =?us-ascii?Q?mjs3xlumLo8Srd0i4B46C4/br0gAaMLLVtFd0pmHg3wG68VSHU2HXrh+bmSK?= =?us-ascii?Q?Za0zjy/VKnp8jMP9MMWpgLE9UBLVO1sQOu4Wmxq0gIlcPzw2Ttjymdq6fXLy?= =?us-ascii?Q?5IDUoGzJSQIf98B6OpObdeiqxdcaqdZcQp3Q6JPQMqrI5+SV/OCm3nFQjLTp?= =?us-ascii?Q?pmVCMB/KVxHJ0umURwSQ3wdxocGCrTSIAWtwJ6E5OAV2d+NrNVjQb1hz5M50?= =?us-ascii?Q?YMk1bEgsca6XCd0ilFojwf6At386X6qx9JWmJJ0p2rPkcEMkRZJjQM4boj0/?= =?us-ascii?Q?+x8Askmjci9gUo/MwSfZVD0QOj2ztDoJ3CMURmUIPExsue9gtmGr9ZjdZP5B?= =?us-ascii?Q?Q3JY5PUf9Gu8W+Td7QdRq/cMt39LDh2wf4AphBDn8M5b/sv5+qNakghaVI4p?= =?us-ascii?Q?5GyG96j4s98CQsTnrZpT7id8f8O8gXoA4ABBspZ0iCMZ6ZszhJqfNE34uxCt?= =?us-ascii?Q?kvHwkHdMKYkql5k66m08H84A10RCbwkFU2FFlOf/hV8RFWKUkrwp2kyH6cH8?= =?us-ascii?Q?lfu3ZeFB4x2F0Nytw7pDSrCh/SiXZHXouGg8EfhFbptWlhgKDjp3M7F/4Av7?= =?us-ascii?Q?FhypiPjdJl/AayUk2BTWRO661LwaWQoDPKMO53cGBSCHowXarHHo1sE4stXZ?= =?us-ascii?Q?U0QNdCoHEGmx21+Dp/7t6V1zX3B7pgCYG5YDcXreTZE+gBJfKMu5QxSYXkeB?= =?us-ascii?Q?XH72mkU1kZtCLZcbaAqq+MZ3OcHOLh2DC6Egcr65VywGk2ileZYGMhvN2GTO?= =?us-ascii?Q?Xakj0HC/w8ueTp+c8MFaTifHFGv9wfzo8jaeB4q+A9gRtZKxgvxXovJU7mX4?= =?us-ascii?Q?5pygXR23KzuNia19TNciodaxCjuYbpolx9GgAag3DmveWTiXSebFLJ0fee1T?= =?us-ascii?Q?lsnM+cIMvkodjkM4UBZz1WuOMCnjV6Bxxr3Hbu0EyYYP4T5Ts5rCjqM6OuxE?= =?us-ascii?Q?lg4e6u1KyL9wbWT7LNfh2h/QeUBKdxbmnSUjx5y166blFQC8WQ5NyKZRI08i?= =?us-ascii?Q?khfa+/BgxE6GPA1zPIlly+w0h/av15Amp9n4GEQKM9pLmF5QIAj7KnD4QPIY?= =?us-ascii?Q?NWmZrTCNVCZAzkggeLk35g3BwFt2cDmubmoFuriZXJYk5egYN?= X-Microsoft-Antispam-Message-Info: Mzp4gDKZUSr8xP/ElF1y/1CR9UowZzZ649sBntVkZSAx36dnn9G8jXp7YzH8SMhqtC9M7P40pLrV3gI71g0qKUbuxi+7tCl3orsfZ8SFX+kzEt13Aulb6wh7Ra6h1ZR466lMUpUF7/BaA3zun463l4iqU4giXSnEveTk1Nd47+3CwtYKZvlbzg1ieCvBVF92J7gkr5+ZXkVpRrkKMCe6oFl89qdx569F88PeN+oDb7MDNKjOAk9tWcehY5aElh6V9vyuvas2naKZLGfcGdUDCr3bBpuJypbSFnR1lcggBkk+K8582iMtN0z17PnN734W9sRpqtxrVwvqYlb+jSJaLs48ZMjy4XnzV6Tue0u6FOU= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 6:d4hJ1WkpP8tJdvDpgdw9SpsHWNuTq62OyWD6nb/BL9FUd0tybR48s4NJwTcgCUK+dV0s3XB/J00k0B5USeYTON9X97EEliFzjrWsSWzwGmIsyyUCkYJB1d0Om8o47OhEmbFwF0qS5yuKoYPmG4wRCg+KpQi3lJCT4BA1LGV5OAvDP/sQsYu8bG3PJod36Gv1WNeH7OPhLIdJAO6JDH0Kjuui3zSJXMJMlHdzisGCQYU2NzenHUbwnnbzdGVhiISghVCuSaz8vOF/j1F57GjQZNQWj74nMF5gVoA5DYVIoweDru88i+8AyY1QHpHQYCzCOv1Sm4FvB+j9hzQ0mmKq9C2GIVC9f1w9QiQpo1RanOhE+LZSQKJzk+fvfrxhKk5BqZ6Ki2mK0dS8bqB2pSk/DO01ueswJPatxEWEzY1fPSZ1UVGxPJqAYLKM5idUBPzCkjQw+Zs5uSM+y1Iq054fbw==; 5:ipnA2ZGOYfZ4TV1LgkNfjAeTDR20lhPpLMffko2Anyxq5/YNq5p6HJ7ENKf9x2Ne5akKD1T4yzak4NPas9n5nUS9Pm6MsRxblxgIYAaLCT1dASNBw8vYX8wuhDEd8Jniv3VFy7/g1TgrzvqgdQhNCw+W/KP5Z2s+YkYOk5lzouI=; 7:RZfkeV0u9CXtizdV9uSipSFECohU3NqBOVfm63qJ7TDj6RbCwzyLd8pm7hPv0J17LLGJJ5Ryk49wCmwnlMAlUOehqFa210L97CBD+rHAvV5ZFlExpe5SPn79m39LFeKkVtBsKk7KVRzOY6f+CYhuHNn4o2n2hHAkwWaxO0qAEdv9YR4J9UHgsPpMpXAOOTgxnmYYPtem1K4GRBzPW/7WYJ3oXIJR/4Z30RaEk0dAdVs4qVFBQ9dGHSmyyYEZGXiG SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:31:25.3725 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3b35e4e4-d6e9-4811-f0b1-08d5f3690d5b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2046 Subject: [dpdk-stable] patch 'net/thunderx: avoid sq door bell write on zero packet' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:31:28 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 998da59e9e3cc06f565c648e9e870a93d0a7ad37 Mon Sep 17 00:00:00 2001 From: Kiran Kumar Date: Wed, 11 Jul 2018 13:54:36 +0530 Subject: [PATCH] net/thunderx: avoid sq door bell write on zero packet [ upstream commit 47636efe878dd8885bb47b142765c9ccae6babe3 ] Avoid sq door bell write on zero packet case to reduce additional traffic on register bus. Fixes: 1c421f18e0 ("net/thunderx: add single and multi-segment Tx") Signed-off-by: Kiran Kumar Acked-by: Jerin Jacob --- drivers/net/thunderx/nicvf_rxtx.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/net/thunderx/nicvf_rxtx.c b/drivers/net/thunderx/nicvf_rxtx.c index 9d69cf4e2..06cbc4635 100644 --- a/drivers/net/thunderx/nicvf_rxtx.c +++ b/drivers/net/thunderx/nicvf_rxtx.c @@ -190,12 +190,14 @@ nicvf_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) free_desc -= TX_DESC_PER_PKT; } - sq->tail = tail; - sq->xmit_bufs += i; - rte_wmb(); + if (likely(i)) { + sq->tail = tail; + sq->xmit_bufs += i; + rte_wmb(); - /* Inform HW to xmit the packets */ - nicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT); + /* Inform HW to xmit the packets */ + nicvf_addr_write(sq->sq_door, i * TX_DESC_PER_PKT); + } return i; } @@ -246,12 +248,14 @@ nicvf_xmit_pkts_multiseg(void *tx_queue, struct rte_mbuf **tx_pkts, } } - sq->tail = tail; - sq->xmit_bufs += used_bufs; - rte_wmb(); + if (likely(used_desc)) { + sq->tail = tail; + sq->xmit_bufs += used_bufs; + rte_wmb(); - /* Inform HW to xmit the packets */ - nicvf_addr_write(sq->sq_door, used_desc); + /* Inform HW to xmit the packets */ + nicvf_addr_write(sq->sq_door, used_desc); + } return i; } -- 2.11.0