From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-DB5-obe.outbound.protection.outlook.com (mail-eopbgr40080.outbound.protection.outlook.com [40.107.4.80]) by dpdk.org (Postfix) with ESMTP id E528D2B92 for ; Fri, 27 Jul 2018 04:31:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=JsJOlzeWSFdwq87Ww17/2/MHbQ229MB4MAJGsFyiXw0=; b=lVFaV2uiYHDglI6aFwwQQQK4C2V3ywktBISND1YMYCrW15EYMPP1EbplSXufHQ6Bia4OHGybJ/qC5My+4LGWleLlhFjQIqgppJ4/BPIwyGB3ZLU6e9HHTh4Rj3ljiQm2fqP+KRRUexMZveTDDebeSdXgO79Xap+4+eF0keD8Zs8= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0501MB2046.eurprd05.prod.outlook.com (2603:10a6:800:36::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Fri, 27 Jul 2018 02:31:32 +0000 From: Yongseok Koh To: Nithin Dabilpuram Cc: Jasvinder Singh , dpdk stable Date: Thu, 26 Jul 2018 19:31:05 -0700 Message-Id: <20180727023108.38699-7-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727023108.38699-1-yskoh@mellanox.com> References: <20180727023108.38699-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BL0PR02CA0084.namprd02.prod.outlook.com (2603:10b6:208:51::25) To VI1PR0501MB2046.eurprd05.prod.outlook.com (2603:10a6:800:36::20) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fa897645-3b92-4d94-a164-08d5f36911cf X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:VI1PR0501MB2046; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 3:opZYcnDFi92MR9BYnsP2QymOWpYwPgkTICghgnSuwhZ3HeE2JdMfyt57E8Vc1MX8+2OfNlj67WbPWpSiSFwtvYugVgUYAbp3BE4u3O6WH+RyeXDvttVPw7THSmf3Awm5hAP+dLdrCm0urioWLavKOx52qpz/c3KnXGk6i4a2oj2tPBHZPRFoDgsd816XMnOmiqZDkDhy0Yis6eAM6OT5QQe/+GVaqQPtcn5nQ8L03IPrPTsx/HbyQ/u2aSobokQD; 25:WGD1MT5B03Y12frnVbP+yZcFUQfBpjbJKK0UYa/roouzcOg4YebgZ5QuY1fuuWGpnJpF3BBFCEEIdHRjm/X4L/iLI2aOkeuvLsAWXrZ0fdGL1oFuUdEf0Fh77GWefXSPTBiYQhVJUHXXTiYBTIM8PpNutuqtTc23GJAShpb8hfXD+lwyck2dWdaX5NN8LIOp4YrrL06E1vvsnGwA6fMYk78h0daGev3lg6jiY/QQP49m/yzxU0HVkBU0gstl61pcrlGNO60afKrhLX+eObB5qNkAJ/B9L0ZhgMZLE+4wcuFfyrippI6OfvRqoH8yz+8h3cX+HnOeZZI7PJ8C1YQ5Bg==; 31:g049xRV5VHPtTYvaO2R6skspZycKpiBm342wYUYbXUWXJa2tsiv7k3Iw1pECIpH158S7Q1VQ9xEY8101dxSeDl9LgbuXrrGbcviRG01sUffxnv71oFccSHQ98nnsDzi1eq5KgMhHpk3uZAPutiWkpw6SFHJh4dOSn2ImhDY3m5VHwySdJhbMes77VarlYMR3vEXaaZX7cDhBfeSagQbdoFDP9F5LrPPXUKOgdMXbxVk= X-MS-TrafficTypeDiagnostic: VI1PR0501MB2046: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 20:6FB7BIlNIffGzC04sy6tsTSIsSPd6cn9ni96i3ElpAa99pXbZ9sBloVQFHx1uFBPO2G38x61NAWfSqwRe9NB/EY0C5bMMLPzAcCEtH1G8qbHPcBNhDv0xD7JayeLWs1nFBZIcJvUM/OT7H0ZSYxt4/LOVl65Zldqy68CRSK5VLZIWzPoswC9fJbZLPU26mKzTk1H7KQKgkr/YExZ5bnkLJdYUV38t5pmmp9F0EDozCCNCvk0aQIoCZnzzAulKRRAp/5/RRHr9fUn0zTT/JPn8qkH/9yZxhP6r5oO9wuUvoayrUC44SWyFHmDKFEZEaTOPxnn3x8tBr1zlebNZbBceipXJgTg3P1cClmK0Fro05yF08CVvlDvDOJkXQw90a+zPkFSWgih+vzPGuMNSuyyA7C+eLeUm0eVFL+i8I9/D21TcoKiYnIolYtkQR9i2Nynno64KfUKfE4JaCe+kQnaxtqQkAeNzM50mkIMJe99FHLUJKOhhjzvK0xuSI6aXfD8; 4:Usw8vXwQnfam2oKwCc0RprfRYU4RxsjcjzQKB4ZHGMcGqUqmZYLkXeR/CB6zflmDyEyLLLrPE+7jUGJEs6zx4G+17H0h7bN4/QnCBW73OTLDOioFnUbP3ZpZwLgT/Kd8hPRETLId+9Ml3aLdjMdEWArDo8wi8WudWcseXhGelEZGJ3lkk2t25+rJB9mdboAuP0ABZiN2x2KAudqNgAaehSy0cJSLQ059pStm8DnmB6vbDeziI6aZF+TW/UnfOyv730IIm74Aw61ookKzhco2c7BB+Cmus3x6MxNoEUwc06dZsEaZ8KdpVdQpcBOG0dqW X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:VI1PR0501MB2046; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0501MB2046; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(376002)(366004)(136003)(346002)(396003)(189003)(199004)(69234005)(28163001)(186003)(53546011)(26005)(86362001)(51416003)(16526019)(3846002)(11346002)(6666003)(8936002)(36756003)(386003)(76176011)(7696005)(25786009)(446003)(52116002)(97736004)(486006)(53376002)(4326008)(6916009)(2616005)(476003)(5660300001)(69596002)(956004)(966005)(54906003)(81166006)(81156014)(55016002)(7736002)(16586007)(47776003)(106356001)(2906002)(305945005)(48376002)(66066001)(105586002)(53936002)(68736007)(6116002)(21086003)(1076002)(50226002)(6306002)(478600001)(50466002)(8676002)(316002)(1720100001); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0501MB2046; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0501MB2046; 23:ZsFSFmp+a2rBR+krxSY/IdPBPpPA+9Ah1k9CJhW?= =?us-ascii?Q?CQ/w6Clgifi90RlAxodliz/9JVM1hxwj4peEAkrd/qfn4LM+ZmBPmzdudfIw?= =?us-ascii?Q?xRiQwaUaLeaaOgr91HbYCQHYHuQL4fvtZ+cz6huKHT8ckHnfW8w3+rRu/3+Q?= =?us-ascii?Q?t3OGEIL4kB10YwA0dcClP9GS4bf8S6y98xSq4ZksShxfH19WfeKhqxVX/BLo?= =?us-ascii?Q?qYu2g6tsxTl5F3uGv47TW1LB3B9lkEQZzFVW46EQi55nYRm34vmvPb5QT3EB?= =?us-ascii?Q?D1xVs7UWlO8L9OMWDhdy29RNfsP/F6aHzpqy5GXxmcXpsAWwlCZa3YqetBSH?= =?us-ascii?Q?7UqfCHxWZewTkHK6RbzwG8ok9MkMBtxGxT0T7QrCQcOObtT1DZb1AR45/Zq4?= =?us-ascii?Q?DPVsSos/HFVPlD4BESGDC5/XfvRtsYCRhVRq8usFg/t/mS79oA+v1QPoB7ft?= =?us-ascii?Q?C0XQd7dmY0hGBH9Z8O/k84hxnf8HptGGmnvW80e7nLb/qkm9ZT9bfcUhViFo?= =?us-ascii?Q?xY/XM+ILtt51MzCOJa3ld3EbLdQoxAs2cWG4Wx6QJjy+4jYC3BWDHeuvPKhJ?= =?us-ascii?Q?Hre3af7rp6OvCQ4BdVpnF8AaZgjPtYL9sj2A3Iw4i+bqn78EsyPZ74nqeG1d?= =?us-ascii?Q?WGtVJKG1gH+iq6oUjr2Mc1pXV+oDhC2YsU0TEv44yUs4ST4e8amYw//jByC2?= =?us-ascii?Q?WrLBA0WFO5YE49xZRYApZ9Kr7hitb2GTC/i5OzezpPvIeisPUJtvloMFunyv?= =?us-ascii?Q?0XeD65JiamkX0I3+E33kC0jj5YOVloMuzGuLCDvZix4kE5WLewCrelML8Qwm?= =?us-ascii?Q?F8Wg+e2HpxqYXMYsQLyUtR6kmCOKxaz3SwnP+mTlzMfWz5KAZ8IOnx14ZUhe?= =?us-ascii?Q?+jCUKaaIQ3e6T1QwxexSlOLJ2z3DIeTWUL/RF4rpw4e43rq5m3E/YB/ra6IC?= =?us-ascii?Q?ofN2nhi/Fhr/Du3iCBngUo0GUb1c0zR0hNWoleWIP6dsQYaofz/H8S7OID2Q?= =?us-ascii?Q?pTXyyXEfHgBxyp4nSdQl6PgiobuzxQ+bSVX/U/MzjaCkwslX0m3SQtoKctOX?= =?us-ascii?Q?aJwVonvWJL1oiUrCFRrEH14JdEPvvpwvGo/cZdWNwvku2ljJKU+QrlDeTsaz?= =?us-ascii?Q?aLTzKktSn5RYyU+BsTathLwO5OQee3MjB3+aJMjzx2wvybQ3hHD8s2fowD8c?= =?us-ascii?Q?vppIZ5pjFzOA0UGzLBuSNUb/BJXwcQHBKxo0b1zoPc2f0pSL82SCRnx8oK2K?= =?us-ascii?Q?0WC00QoSVOIBbteGs7CpVW+CuY2/FqAPNaW2xQedxDAp0ZIMtxCSJc4E+ZmQ?= =?us-ascii?Q?vn5/bMVCSlHymdGoqvWy50bB2TWtUnANSafQAPFexjc6siN5brMlrVsc/4w0?= =?us-ascii?Q?ceU/zwTkDiwvCRAob1GBKPBm4p40=3D?= X-Microsoft-Antispam-Message-Info: QLrQlgCj7I/wUBMvsk9kb7a5pYUHqPzRCqVGoSCTfw8/0XK3bwOfbNPNxxcacqjZhyByKI6uJA5une62QIHUbxAuNUoRaK+MPKhfc0xOlMzLnZljcYDxcYa01zrbPRE7C4XbcnycCMN82unRyIvmz8xh+2ARX5MuD1lzROBjdCGQGPyg0TZioJRG1T1OlsW8z4vPxjkSgFHlsMwxVWsqXGvp2rX0GfQxRYLppFgwrsikZpA9lZB+dwkIgjs5qu8LZzZqwYpLlYMMBxmmbRoIv1KgFPAWRzHTrQ7iCG8J3Fml0NwIYZNJJmc1x79WCyKOvRQufCJX31cYlsYZhvEvpY/wFAGldbBFITtfVS9Be5E= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0501MB2046; 6:WvYi9a4MPC/i9Upu7YG1LyUS6+nkFcf/nV6iricijJ7Jj5TBtuU+wfJ5JeT/eZCFbWhcY5nS5r8gdVFA9nJUwcZvqkueW7TaPPdAtAlZJMG5BiBfg7Ozke2ogG8jh1q8j1NrESL8Hk4mGM8LdAwgRmM/BwnN1xtOOdPJg4H7TotnXcHGjR1gOrNBUhRBsQhJ30gc4zlLdG1fWa6ZMw3d0ZAAB/fwZPmYfj1b+y+DgR7k7YkGsBfggRZZx0iSdzvggB734cQfgDyIpAlQQssKOcqXt4rb9AohVawyI/IoOtKtdwI3HkXvwl31Og4d/XXfJlSU6UOvbDnM1xeR5TEUusO+/UjXs2oqu5sUgqoakUvU7oPO5Eycjha2A/6U+aNWOS9j+vnkD1VZ92U+7lAmK+aiUfr3bq3F6dnuKF1fQdqVg05TbeVExKHmfq5tXbR2L1aXtuiOZZssvnk01mzpxw==; 5:S4VgTSMhjQ97SSNbInZqmiawh6Lbq0QliLZjwUQxHjbYuTegvs4QFPevOtbF63mRLHvYL6OEbNzRQ6LZujssrOMplzNC/HpLr7f2FxfN4yITV7RnCOqz8C2jKwGOT63Bba2z9rTkm4YySGfmJYozFmUgHgMJY6hcxkVt49sD+a0=; 7:HvyMMTW4WpIt3fpC1ic7fYUh3TilEid9Vair2j6hJZKp8Tn3zrJnDvCHc/djweny0k8qNkZga8aJK4Nz2U6raCInmoxWKx3y5cwqrkz47IutoN6/aTalq+D9S79dj8I/Iz5XtJdDlWx3pDmjRielh4Z+k9v7F0aiFRdW5g3wPpIZo5s17IzA9fxH4Fvdh3cwBPx/IkA1FGf1PIdkr4rHqLpw4OJ5/9WYYHlNSZb0Cp9Y7IKKrqc7Ys8L9MeFotbu SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:31:32.8415 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fa897645-3b92-4d94-a164-08d5f36911cf X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2046 Subject: [dpdk-stable] patch 'app/testpmd: fix buffer leak in TM command' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:31:35 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From fd417e1a22343c69844cc70417e7a6e3cf6228c4 Mon Sep 17 00:00:00 2001 From: Nithin Dabilpuram Date: Thu, 5 Jul 2018 11:15:46 +0530 Subject: [PATCH] app/testpmd: fix buffer leak in TM command [ upstream commit b23ee8f2ac5de4a52573f844ba3c4f3261c3f7e7 ] Free the buffer allocated for shared_shaper_id array in case of configuration without shared shapers. Fixes: 996cb153af06 ("app/testpmd: add commands for TM nodes and hierarchy commit") Signed-off-by: Nithin Dabilpuram Acked-by: Jasvinder Singh --- app/test-pmd/cmdline_tm.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/app/test-pmd/cmdline_tm.c b/app/test-pmd/cmdline_tm.c index 803fae444..d40a427d8 100644 --- a/app/test-pmd/cmdline_tm.c +++ b/app/test-pmd/cmdline_tm.c @@ -1624,10 +1624,12 @@ static void cmd_add_port_tm_nonleaf_node_parsed(void *parsed_result, np.shaper_profile_id = res->shaper_profile_id; np.n_shared_shapers = n_shared_shapers; - if (np.n_shared_shapers) + if (np.n_shared_shapers) { np.shared_shaper_id = &shared_shaper_id[0]; - else - np.shared_shaper_id = NULL; + } else { + free(shared_shaper_id); + shared_shaper_id = NULL; + } np.nonleaf.n_sp_priorities = res->n_sp_priorities; np.stats_mask = res->stats_mask; @@ -1779,10 +1781,12 @@ static void cmd_add_port_tm_leaf_node_parsed(void *parsed_result, np.shaper_profile_id = res->shaper_profile_id; np.n_shared_shapers = n_shared_shapers; - if (np.n_shared_shapers) + if (np.n_shared_shapers) { np.shared_shaper_id = &shared_shaper_id[0]; - else - np.shared_shaper_id = NULL; + } else { + free(shared_shaper_id); + shared_shaper_id = NULL; + } np.leaf.cman = res->cman_mode; np.leaf.wred.wred_profile_id = res->wred_profile_id; -- 2.11.0