From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0071.outbound.protection.outlook.com [104.47.1.71]) by dpdk.org (Postfix) with ESMTP id BB6A198 for ; Fri, 27 Jul 2018 04:32:26 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J+v8oo/Bdnwd82eCjmsTODrJHbru/PWtQl6L3tnIBkA=; b=WRitJA6oKpabKvUPuwhkyix14pXvXS/4WVFtqfTIbaUu1ms2TVVae4CPjtNZaQmS1PXolo7X4ZKTCc6dcjKRqC+LbhONyevq7HseS51OiBYaBR90rrgUjiCeDohqg8xvF0jqrTdDrm/2Q45MW+jn930/qukvd3aV82cER0oLCWM= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2035.eurprd05.prod.outlook.com (2603:10a6:203:1a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:32:24 +0000 From: Yongseok Koh To: Remy Horton Cc: Ferruh Yigit , dpdk stable Date: Thu, 26 Jul 2018 19:31:56 -0700 Message-Id: <20180727023205.38767-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR15CA0056.namprd15.prod.outlook.com (2603:10b6:301:4c::18) To AM5PR0501MB2035.eurprd05.prod.outlook.com (2603:10a6:203:1a::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c43eb39b-ec4c-4e64-ff82-08d5f3693068 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2035; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 3:24WrbU9jfN9daewGjsH9ULDmnQQJNh9RS5ISTUjcJy+wDmDNAZ5HZz6bbLBH1AClCB4i1MT2fb1P8xSZijB3KLfP13XobfqwgUgyTS18VZIfJQLclTEzrNQ2kIiMOGm0b+2HLAYZ12G2Rjpd54uD9tzfrif6G1+9tMTtU8xJ0H6/lJiIo/CtwoDj/mT0IYhKvZOkl62E3owKQFcKA6f3rUYtsWE+q5ekwaoIwOepnKVLHoTHO2vzX84GPcwK2l/D; 25:X3BFYQpofLOaEnq02DFtXe8oAxhmeVEglPSR/eqGxWy8L8xkDDcSmJIzdc2vmII9cW6zSfOnlnNaRqFZHC7CLLqiAgUip1Y7zPkwFXFENOwveRpupknq3EMzItOodQL+sR+D8kHwV39zFxYz7MKzf2zB8Cv3f/5UZuQHBYUoYNG1HvMWciCKySE141JXqKJgRJGK1qk4R/MVp4CieZ4NkWwa/VHXNcYLssmdzkHdMo/PS8X5gfkEHuCh599aDGAa15jbvTGJm5qOWRU3d+oJcbQCgP6I8AmL+GffKikxmmIzgDx0aXMXktiq0GeFFDZaheYh02V4tOGVNq241M+kcw==; 31:shDo3Zf9jHbelUpu4H4VLRGQqfsw4LHpmxCqMQGOaZEoy5Ni5RMijIThct8cGF8sOZvMIOfFidcAz0w/vT1ApfrU1mxblQtfslww0iY8qE8Qe8HUBKc1qsqRTyo1pA8zcELhV9oL1yAStBX7hmRf64zZrjoShy9CUNnGmcj7+A3LHLlzi0RW6at81x7+jYcnqgXhmiA6HDF+gmELysnP0MLAnupGO6BStuZXjL8lhWM= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2035: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 20:r9BsoNV9c8vR8dAaDT4UjpXy4WQzq4yJiYPkRte9C6wRZytYyv5X1lHBbBCJX/+jI+/CSAHPUsg5GSUMZr8wp6VVyOOpw60MdrPODgk94ah3ftbmd6LGbtcfkICXn5YhGGAkdyjLanD9X0YZ09Y+Ww3B34+1C38TYnWZLGRJ+9OYtVxGXKziPqMEgK5ClEBFTW0+rPRckj1Z5WXlQXJSksbDQ8KetjM+TZh3jfg1XC42X811VQFROlDld6fTvCA/vRvG4JfBXjoYnmKGqKe/J4v4oHplMWcGte6LI/cBYOVyN5hhA9gYJY80OKiJhLJ7Rk3d2ysUFu+aK05nBdi0VzOo/gNr7uzdTUv1arF9KCObQLPlP4941tUmUiQYL4u3R02pGGLydAbgVW2fFyL2ozOvQpeV+I3ycgt89Lm3+CSE2+1VUsd25dlm7loH6z4mt11jgzlrcZttzhQns4pc+mPxNkAiHNBgAVB0j0oRRofYQzm+CfbOUvyeJDml3Q8M; 4:s/cI6kI84qLgon4/f/8hSE/6tvIPzvOzuj+zNzBSLwdZwSedFO7WarP9z5O18UgEDlvCfAzVSfbJ8ERdAyK6ZAXk4M5prbDSqhC2BpJe6UgRZgs+Hnjk3Hoo4W3oLIIXhdjnrHC68GkmVwElvNs7NXUGrKBuD9WcLIvLoCwOwvwUsvWrnG4V+e4Vs69Lf8ZkWtRBCy0wBX2ej7idmFIN9+wELNA79uIT/XysoTs8tT2a9w67Eh13RtqFo2JCi3inZWS2bncXMFebEmzgA5WVSgnFKkP3FS4DVNLoK+ZtArNqSwLebDuHD+m7LMgtuOZO X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2035; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2035; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(366004)(376002)(346002)(39850400004)(396003)(199004)(189003)(69234005)(28163001)(4326008)(50466002)(48376002)(54906003)(1076002)(1720100001)(14444005)(966005)(25786009)(6666003)(6916009)(53376002)(5660300001)(66066001)(47776003)(105586002)(86362001)(106356001)(478600001)(51416003)(386003)(53546011)(3846002)(7696005)(52116002)(6116002)(316002)(16586007)(97736004)(81156014)(305945005)(26005)(6306002)(55016002)(8936002)(68736007)(186003)(81166006)(50226002)(21086003)(8676002)(36756003)(7736002)(53936002)(476003)(2616005)(486006)(69596002)(2906002)(956004)(16526019); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2035; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2035; 23:WkClAlK3NHYd8e16NIaTTD3xOAtaDZx4suz0iau?= =?us-ascii?Q?gZg9EN4zzdgwPEwAu4FSiApFmGQ9OHQvMpObnJF3ePOZIAx4iUhEFS+upVuv?= =?us-ascii?Q?ofOcFe7UzeXsc5TqLrYnVQ2mV9OKcvKu+krbzBletGA3OjxuNqMPc3lhf0xy?= =?us-ascii?Q?18g3boVX8MFwscYYfXpdNQBhzkPAJHKYSU+jY6Nx+sPy+GMGQvq6cp38nWSD?= =?us-ascii?Q?yxtDwYppzjJIp9pgRiDzQydlIV/VddyaFP+ry1MQoow9Ry9ERZkeSuXaDCGp?= =?us-ascii?Q?10UsMpI9rr8ZXs7EHlCe6E3r+P+u0Xu9OeLKIrU31p5UOQeprKaglKxNF0zU?= =?us-ascii?Q?bLh46VYEa9QHOR7RAglJvBVH8mrfuuVzHz379cPyRzy7ja0FhVQmDip0vGlc?= =?us-ascii?Q?vJ65QfRWvjB/BUzLA1IJ9a2TQIeL3oUlCoROsTkhuibsRgM9A1qym6GgWzYj?= =?us-ascii?Q?h/+XlhEYtZgLh8d8jFVOC6MjCPbrgYG3sSbWln+v+Wn0jQqeQRr0v4OgZyMj?= =?us-ascii?Q?nRg80LNrqH8iodxk3ReTBBSpwKJqMhGvA5P1Z7Gtz0Jj4at6k/4XCbesFNZa?= =?us-ascii?Q?4NkV5C/UVIP8gQ4RWdF28kbP9yKcRTlRlRKvMX7p8+n+MWLns/7/4QgLzDkP?= =?us-ascii?Q?RCy0ErHQRaM/c6w/UNPYow0Et+fRdi4i719BWM9G0Gugo0MHYPgCSDzDK9Ov?= =?us-ascii?Q?K+hRqzIBZnlkvxBSt/wtvi3SUwk/s2ug+Zc2d1DzpFrwNvhwALWneZp46nql?= =?us-ascii?Q?ysCdLC7rNfsGTfxZKha0HlXKnrxGhO5jv03K67KXO6jkao53EQYK2x7WM07m?= =?us-ascii?Q?0e+C2LsdomiuDMLXCzf4rB4PjOFJJqf5dDIo5WWV483R7ezak5bPMiBhs5tP?= =?us-ascii?Q?697QUX5XjyLF84G678bXICElyWszOwfa2hfpbABe0HFd5CpJYZvRGXobkyK1?= =?us-ascii?Q?h6BFWP0wENA+l3cMDi92xqA3I8RtvcGpfJscToQw5zmrhWCMMwYXC/B/nN1k?= =?us-ascii?Q?URTOBddDnHmqYTKfnH+DQsgx+u/grxodLvQDpNBxHgt3NAsDF3h4vJX6aSsd?= =?us-ascii?Q?2oeAQZ28r7G/zRGqa7oiMRN/9QtI4u9Ap4GVRwyM194g7PBsFbfKTxGvnn1Q?= =?us-ascii?Q?2fLTM3i7o9YnSxKKXiBeed9ejwVi7pVPfYdIIfJ2CE4v+s2+BF6fJvPbTPxU?= =?us-ascii?Q?/c3L6tz7UDUDUkQ+UUkUkGSuxmdM5OuhAKvydw2mktT5ETxot/O8orG6BTsk?= =?us-ascii?Q?rw381VYJAFO/AVV9Q1yjnkbgqlUw1MwQ4xGLfxDsMOXtqRIfKSFe0cm0XhCd?= =?us-ascii?Q?qkN/VlHHh5xfZ202mOhP5OWhbqGhDbWnCaKGQ7AGNXRYW7cdo2HV9B2S8CKq?= =?us-ascii?Q?nz33H5g=3D=3D?= X-Microsoft-Antispam-Message-Info: iFbYkDINsPc65ZItwBxyv/EIxbJjTqMsyIM2aWxOJrQvkTqCRH6buLaseEp8V25CCM2rD7/H5EjcES7gjKSqn+BeA3YxI4f8uIFwN9jzg3splwxrriW7VU7oEpm69mHFTsnn1UFJykCYBfY1aZ1Ks6/SAdzSDBxaQ8B05QKWE4rM6YU9NOmSwtMdPoeTwvGM1EYLq/z2BiF1VItdltp1n5iLZryJ2PIVHEtlrL/xbl5RFIRIrytXINYkfdWTiEDD7bKoFpVqCf/0CaSMO0jlWihxAxFyDb9K6On7x8FIBTdjCSEVByXMirdAAXmgiJQM3ma6S8NHGiGT0M77pI8MHjXi8zqpuuVt21/cIEfTXis= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 6:/RV0u3tCT4heowGXjao3ci7aHt3qCg+i6R1UqEsEk4x5BnJt2UT7EE3MBGftCrYhkztUUByfkjwPBwaCYjB4NDDeh1s+RSxoft+P25p0is/XTvGuOTqQ2kPKP5/CouvbciM+6Hmc76NZ0krqlCj+CSy+I3Rfo1XH39CVyOHNJxSUcLdWnaFKBxJe5Jsvdn02Ot/cy8C2E0Q/zEa/EEld8OJTcnwyYvG4MeT2UzGe4mjRYU8r9Y+tw89G4+y+QQNOq7pr7nKBd99cMblz6N3wrGeYvEdjnM8pMLYQYZkgqFd8Z16ZGdNsUs1IqqREuEfaXP0fifBJXCVOHnpynmjoflIl0HiFY3JRy/DLgffFdv+tWugN98nCy+GH2j4FLjF65SgwcA6b4sNysT7SukxDFKicaDH2I5G7Fp1V6UfLhcmRdEGnBlK+tmwNCbuQRAiL0FKlidjoJgy3Lu70pqNtXA==; 5:DDKmRK/cTATQ9tSZLR8cDR4Zyku7/KuHi4ADaKGhuCZGkZmEFOl9g0gLtfeXi9EVHw8mtaEd7AZ7F6Gi//vr8i5IDN0jgkHDYi+xcECclRgnTHh6ara5hdEXDTHmRD5EzXdWcygM4jMYzNRGSfpeHNGhc4psEp2d9AHyjsBgR6A=; 7:JaIAPwNXbmByY9RSvCmrz0aHvio0k3qCSZ9VpdJ8vOzK+g9hyUuihC/my1R7pCps/m/BoYULEL5vjIfoVERmd/ecYzubJJ6DJF5PA2+BSD5txb5kikxmV/9OrIK8sPEvAdw0GktqwbsuDr33tCY3biIRq5vMTN5atr6R0qXx1Z85LBo8XRkW676967ggtmp4qjJzkvT7cXXvHaCxl50CAT0KyfhywhORWGsLB4cm3oNZcXwvnpgiN+WF+piAwNI4 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:32:24.1526 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c43eb39b-ec4c-4e64-ff82-08d5f3693068 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2035 Subject: [dpdk-stable] patch 'metrics: add check for invalid key' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:32:27 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From f4f7cd84a0527f12005b59dfaca10340727a2977 Mon Sep 17 00:00:00 2001 From: Remy Horton Date: Fri, 6 Jul 2018 14:21:19 +0100 Subject: [PATCH] metrics: add check for invalid key [ upstream commit 50d2459fdde1916c2ebce1a3751ab2fa59c0766f ] This patchset adds a check to rte_metrics_update_values() that prevents the updating of metrics when presented with an invalid metric key. Previously, doing the latter could result in a crash. Fixes: 349950ddb9c5 ("metrics: add information metrics library") Signed-off-by: Remy Horton Acked-by: Ferruh Yigit --- lib/librte_metrics/rte_metrics.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c index d9404001a..26c65b173 100644 --- a/lib/librte_metrics/rte_metrics.c +++ b/lib/librte_metrics/rte_metrics.c @@ -190,6 +190,11 @@ rte_metrics_update_values(int port_id, stats = memzone->addr; rte_spinlock_lock(&stats->lock); + + if (key >= stats->cnt_stats) { + rte_spinlock_unlock(&stats->lock); + return -EINVAL; + } idx_metric = key; cnt_setsize = 1; while (idx_metric < stats->cnt_stats) { -- 2.11.0