From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0071.outbound.protection.outlook.com [104.47.1.71]) by dpdk.org (Postfix) with ESMTP id A14441C01 for ; Fri, 27 Jul 2018 04:32:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rGjkghbI3TBELLQOt2t7/bThwPJHsvotfh2DPPXLFbo=; b=ulu5FN2rSYrbflbQjpvfr/q0CLw7gbuDnMQHQbi2627s2DVdGP9usJbDs3W0r0le6kOVSK+0+xH6IsY45T8cDO1XaIs4NCCWynl2fMkDgylvwgtTFzyDijItrbp5lO1KyddnwmTK5ZE2Zils/wWEZb/oHyUKYz8DyjZUuTrmJjo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2035.eurprd05.prod.outlook.com (2603:10a6:203:1a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:32:25 +0000 From: Yongseok Koh To: Remy Horton Cc: dpdk stable Date: Thu, 26 Jul 2018 19:31:57 -0700 Message-Id: <20180727023205.38767-2-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727023205.38767-1-yskoh@mellanox.com> References: <20180727023205.38767-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR15CA0056.namprd15.prod.outlook.com (2603:10b6:301:4c::18) To AM5PR0501MB2035.eurprd05.prod.outlook.com (2603:10a6:203:1a::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 57975528-f687-42a9-2235-08d5f369313d X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2035; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 3:ro0+pJ/tPwOX3lLKeZbt22+h4Wi8frLlCle+zoGvdzLy/82btGWVQFBqqxWT+q6Zf69z2r1YZeXSwV9nKpUOtAvZ5Zuw0ZQGP+yq/4MbKZi3kFbn3EfNhCDMA/hlt3reoiShA1jV/8h/jxkyiclNu9ORB+7xPRhdm/UGpy/OIfY/o/cXb/BFIvV8cqjGo1hYvrubsUtbmSSqyo0guXQ6y/ezTqH9l8/kIeY6mGW2RrM9u2dfe0nZJFJ+CU4RV7Wk; 25:qpfkwdx/cKRsXQuwd392ZYGWy8dr6k9ejixsn9yKbd82JAborynIk5asTTkOLhKV6cSySXjHlYIfSq8b1+/2ZM4jXlV8FSmoSROZ8UM6JJ8M1wYpKP3jemBaxzLzwS46+iRccg9ZFA7+uusKo+lPicOeEGjFkqZveg2V/Y5mkrH6ij2b1elhI4xo7qwL47oWYt867qHWSFIc4p5q0roFPhVRpWRmcT/A+3AQvKlRqhxLCV/MNebDR6tISAZYsixaZq1sxmeBkMABy6/jkawaVEFzBg0D1i2Q4yWQNUxQAp8122n5P0IQKDweB0u/Hu89cc5D/G3nwqz9pMzHGQiITQ==; 31:b1aMpegMkJs6UHZ2ma2NKcjh5HnhUvWTpSt3uXMujYBVg3pIJ6RRGwf0RHsK/SYi+BXc4L+Z1Lj7KKZeNBoQ0Q5pa+RDanSiVDThfVELv25cyaBxW9YxF9ZXts0nkb1rz9xs/1AYvtw4tAJCMngDFS5kukoMzcoBUP6wO/kl9kLpbc7ld+yLCknUMc2Cqf91um+wKlSFzUXnwMih+yI938yL+A/TFXEGYNxvApPKv6Q= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2035: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 20:S916DWe4C8xt4GqVBaw1hMeqec7Ee63dgzjHyHF0yLnV1EnWWH8mcks4UsHVhoRk0KyvsLmpD3x+tASUm3BBof23BFJ7+1MkbOIvk4PLNzuE3Ddnp0/mMTYdjkEnSMW4nxZ1iC0wpxpKmPYf/Eyn2G6yJ++OoCAncEcexeCACbDOPkTgLhmjixXyNz6nUot7I899bnYQya7Ae7KE2oMtVb0HkpocYzFEOeAuBPml1AaOIJyE6G4nT0Bdog8dhj1ElABrrKXhWfQnJbStJ8+JNACx2ZGCrD/aUD1tsyMoVG2PCnqyDPd5BFKssY0cqIm+5zgJVBjPrSLf3qpQVdGMRfHQ3r0JH391SbZPWgu+cH/HGHgoqdeDkoU7KoXyEbTpMPbiAySwwSQiOHRbctN5vHiaom/c+J7oAY6wXRp4jtwBmmQmpvXM8CC8R8+SZKu0bT4SDMQyIPGmE9WaZibCh+pvD4P4PoGi0Sk4sXJvYmPEbDFkq8DPBpo6Y8Rmexpv; 4:E042xnbeTQuImF1lKe8CKyEhsjZzf1IUcVWPsN+X7tEBhP6hlIOjPvFb5oJkf1435bOoR0jX+LBRuAJP/HQFgtJWbZWgT98Ecx9QACGmUwwJbmjiqNrWex/Itg/H/UF6bBRgzOkjEwB5FISZ19weup21B6owYXCLM6OT2XFnzuZlXlEItfHFDxEvAXXAJgR26JN016VAjHeN7jTSHHo4e/7MhrFfY7lJgBJ0mK1DObguihhl31++LNKPQCI9G7Qw7iwUXI4gmRamyToDCMSkT71me/l1xorkGJdHbT1+5cv3G/Q8hJ6Ee5BCE0/7rNcI X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2035; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2035; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(366004)(376002)(346002)(39850400004)(396003)(199004)(189003)(69234005)(28163001)(4326008)(50466002)(48376002)(1076002)(1720100001)(14444005)(966005)(25786009)(6666003)(6916009)(53376002)(5660300001)(66066001)(47776003)(105586002)(86362001)(106356001)(478600001)(51416003)(386003)(53546011)(3846002)(7696005)(76176011)(52116002)(6116002)(316002)(16586007)(446003)(97736004)(81156014)(305945005)(26005)(6306002)(55016002)(11346002)(8936002)(68736007)(186003)(81166006)(50226002)(21086003)(8676002)(36756003)(7736002)(53936002)(476003)(2616005)(486006)(69596002)(2906002)(956004)(16526019); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2035; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2035; 23:n7nac5rerLl9SCvP/bsjUOorlXhpOVOW04Bsk/E?= =?us-ascii?Q?NwT9YjIqAxSNpls0cEy1MV87qhAlMJvtQ4NBCb8lAU3cYWy5o1qw9hYrZxfM?= =?us-ascii?Q?DsAUlxplWNOEx5nTchmY36l6XWL8ltXMyni7RPZ/Uowsie419W4VKVn/FfK4?= =?us-ascii?Q?xTtvG7sgUgEz/m3W40mvMXXBWRpzNobDcPKnfOu7kGshpNM/YXYswvm4JcYY?= =?us-ascii?Q?leSi3fuJIIYexdc01eAhcVlhsTmU+vrAEOuR9GD6HHoUp7YeExHBlFk/SNma?= =?us-ascii?Q?JY3W5HoW6AFcGNcv+AEUYzB4xgupiAZOaEfWiiauNAY2l1lE04dYFH01iYmH?= =?us-ascii?Q?ao8U/TmCpmKYC0yb/XLVMfXtUBvjrPauuy2iJmqVItAxIR2ugEqT/msJ5r67?= =?us-ascii?Q?t/qlM19DQbQBcrlHZAhX7qC/wuc1yYSA+/D9jlk2HWy13LzfUOW71ggD3hKt?= =?us-ascii?Q?qeUeGELygL8GI9wfmKZBtrSDhNSZPGakb/Hgfqs9eLuw6N1TKc4Z2oK75yU+?= =?us-ascii?Q?oDLPo5PQNr6b5MwdRHHHj3paP2bS2SzyxbiyoevJ73GKaNBB1Lgd++QA8bMO?= =?us-ascii?Q?f8kdw8vCXeitRY41TBwkCiyPcOiHEYqY8VgC2sLoWCpnmjcjU1fKUWUKwfrV?= =?us-ascii?Q?M1yJD0cpUS4oMUTTO3ZJlk7JPeHr5sGd9RIkhQgVa84qU7I837HQlRwhvxMZ?= =?us-ascii?Q?eBMgqUjaJXAjx/E8kYZ8uM414oC7TUXm7+QP7pc9A1/cn6qboIEPAkmxgQjl?= =?us-ascii?Q?AZXQd75RfRVJtz+BdzZM3hHkQSwDtuubDVoOqA/L03+0DbFyJmXz1UNLNfB4?= =?us-ascii?Q?vr1j7gfg/sYJOKxIyiNeNq5kajqqMrhSt9TNaS1dK5FbmpsyXqypEcQmpi7+?= =?us-ascii?Q?p32+eD0mIyTHzgU9qguPg5sqaZ0MOKSbBLtnmfoIcqplq6K3In8DyXZz0vaM?= =?us-ascii?Q?CixywYs6Y58WlELsUQvtxOAFKLFxi5j0FYUel6UJAgtALveW0GSqRI9k6FwK?= =?us-ascii?Q?I6pYnH8Us5A5v71PUq1jUkxdIdMgF31D9lcCtwabOoP0S572W/vTt/axuKLe?= =?us-ascii?Q?Qq3DIMjcrJRByldg2z+x3x13/SBl0HH6LwZRqkso6birUMzojHGTGEr9Klpj?= =?us-ascii?Q?rhsPIjx5a7qub4RwqFG2pChOS+xwt44eAHBxdimMwmuv4mUB5DOeJI7GPDzR?= =?us-ascii?Q?7fdYeFgKDl9vBQKfHNHV1enda5HZICvBC08tMXpdFLXnfBMhdJ2jvr5c6dhb?= =?us-ascii?Q?Ja9Mvgzb5pX7BOYAGtBQbaVMfAemZEpKDlXtVZAwZb67jrRms3VfMh8fRkvz?= =?us-ascii?Q?kC1iPkT8+F0YNcVaEvAuIKH+8pxAlGg2OQWAtwnFzGxn4mVEBqqThAlYCBBZ?= =?us-ascii?Q?m2In1XleXwtDX2N0LfdlZ4NNoB5U=3D?= X-Microsoft-Antispam-Message-Info: 8PhNPDx0bcbC0xATqeYfKJMIO5cE9RqHPTS5LfHtTq9zGzCDorpH5VuTSR7edV24cSj3+IzRCSRSGisGE8SDOdckWzVtKDLsvx/AhnaL5i4UtIeNZ95QXK6baux522NP6roSfPkO2nv70K1h0mS2JszZTKkFPsTlfYyufrAuifD8GxdWo2Ag/Ffb5ozuF4jZnrqMy11rbXcr3kOUiKLjSnS0KDHUI9OU0E4D/RROaE4uHgO4eWSp32fvt2zxcpOt9wVdbYNwnIDzapnLm8g6gBwQimXkpd/JvQmzqPNY/mYqQwGPW3VZOJ2RlG91Xsls+BEQMkfW2Kyyiw/epK6gYhe9JhqivXkyVP+UamYsidc= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 6:Ff4jEysK6E032zcoJ9fwqbXGrmif04Y8m5Xn0hjHsHGjhMLlwHw4EhyaXqqhaZfjmO4ITWIzVmYYYY/+gIfJm1bUG0nMEUgj84H0BhDiMfSyiOEyjv96RtI4evQd039/SugmCurh5/Dos9VpYMobv2b40+mZ0Fv7b0nsLa5LWG2472UAdr+c8AnizYh7SjgpreAWZQGYUPmN134H0zL5nbpz7mRi5gRroIa0EkoMNSfrLKchnJdAgFpVeBQVZZGD9biWPzioFcFu8KNurBySfsmyhdjhshTFQcIHg6Iom96B4Vhk1r97L60Alg5fxKpiSN/goBsYk5t0G9jxstHf0VyKFcYfnJ9Me7ix9kTmp9+fgxnSXfDaYpHhzSINK8y6qQ+a5KZgNFIIKw219VJSGzSYv4MVhpQXKgWMScccBxp1cdD5mfhuq4c3/AOof0dEY6bfejuqkPWC/86vy0fMDQ==; 5:2Ixsa+zuk32GkxSHxKrtwwKsCefXT0+pQWT+YyLTkfMrnTT+XH3eGLyCKbZfHl7DpoEkarcblME5+jitsMRi94MNzXgQn7zWznI7dAC1pCi7so32VF2fXU04aAheJQakWrAA0qOVhIbMk2ycez8PQUOU8sVW6VkjCXLR3J1/pA0=; 7:0zczJGK+tKN+MlPqIc4t5sGat9ZUvultIBZO+FIt97vY0yiO7wjt1LIO3qdd+iASfqO3SlzAUHvE9qkwsQdNltqL55gVVBMlklhWBaMtwYRQA6Hn2r5xwaKHH9bKYR6HSf6hNVolD2O+WE81wIGTCD5JHjlEcb5QLdoQa3nETP6jWQf86N2gJO/o/ZV+4rTAsv4z0aorqmdjZAj5gv2bEcm5iWtzj35fSaF/nbMD0pYEGCbp4gUJhzq00MER6Gh4 SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:32:25.7221 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 57975528-f687-42a9-2235-08d5f369313d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2035 Subject: [dpdk-stable] patch 'metrics: do not fail silently when uninitialised' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:32:28 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 2191a73c5584a610d097f34fb8b419c666255488 Mon Sep 17 00:00:00 2001 From: Remy Horton Date: Mon, 2 Jul 2018 15:55:47 +0100 Subject: [PATCH] metrics: do not fail silently when uninitialised [ upstream commit a84bdf6a101f2ab3c3859a40f366962d78c12868 ] If rte_metrics_init() had not been called and hence the internal metric storage is not allocated, rte_metrics_get_values() and rte_metrics_get_name() would silently fail by returning zero (i.e. no metrics registered). This patch changes the result of this scenario to an explicit fail by returning -EIO. Fixes: 349950ddb9c5 ("metrics: add information metrics library") Signed-off-by: Remy Horton --- lib/librte_metrics/rte_metrics.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/librte_metrics/rte_metrics.c b/lib/librte_metrics/rte_metrics.c index 26c65b173..3ddf9caa4 100644 --- a/lib/librte_metrics/rte_metrics.c +++ b/lib/librte_metrics/rte_metrics.c @@ -236,9 +236,8 @@ rte_metrics_get_names(struct rte_metric_name *names, int return_value; memzone = rte_memzone_lookup(RTE_METRICS_MEMZONE_NAME); - /* If not allocated, fail silently */ if (memzone == NULL) - return 0; + return -EIO; stats = memzone->addr; rte_spinlock_lock(&stats->lock); @@ -274,9 +273,9 @@ rte_metrics_get_values(int port_id, return -EINVAL; memzone = rte_memzone_lookup(RTE_METRICS_MEMZONE_NAME); - /* If not allocated, fail silently */ if (memzone == NULL) - return 0; + return -EIO; + stats = memzone->addr; rte_spinlock_lock(&stats->lock); -- 2.11.0