From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0071.outbound.protection.outlook.com [104.47.1.71]) by dpdk.org (Postfix) with ESMTP id 0760498 for ; Fri, 27 Jul 2018 04:32:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vMib2VRNZi+NPGC1XkhsjW489/AbN4Oc1c+YvYUeHLs=; b=Met+8Q9ctSZE4nztliiJ6Z15oyqo1JZkn6D2iJYzKWzEI/0qFh2qh8WT15rvgZhKXY34DlrG5MQ+zNcS6In1TqdBa7K4yUd0vPrkoLTPp8XPXh2N4KDfB7wQyxQz3mmVB6pAJwmiPsgYS3y8z9MrhvNNY9MnJvI7tYUPJCUh8Ik= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2035.eurprd05.prod.outlook.com (2603:10a6:203:1a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:32:29 +0000 From: Yongseok Koh To: Reshma Pattan Cc: Anatoly Burakov , dpdk stable Date: Thu, 26 Jul 2018 19:32:00 -0700 Message-Id: <20180727023205.38767-5-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727023205.38767-1-yskoh@mellanox.com> References: <20180727023205.38767-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR15CA0056.namprd15.prod.outlook.com (2603:10b6:301:4c::18) To AM5PR0501MB2035.eurprd05.prod.outlook.com (2603:10a6:203:1a::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: b02f2156-7858-48f6-a34d-08d5f36933e0 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2035; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 3:AzO5cFdKKjVx5z5nf3CiOI/2cbTmK8/n7VsA1ud+DxIQeWbWbCLXRre2jUtpAkUZxapQR3uOgms4BJCQCEdWSogFTE3Ctv17AXUjvgjvRVokHyoyKtZxbAkvGUw+24RqCRwutPS1n31KSDqynW2ld95vWFv8ySaWru/NJKApuAbB9UyIaq+ELsjgIqMag41lCp09liZ0zNfKl5LzWC1EYBBvmhBaFrIysTRlk3rXizDQ41bsgLWCQGFw0rUkWMzU; 25:zzb5h+ZKwNLgbHg8IIYA5EW5OtjJ4H0cpATU1uQhCEfhy0qduE0EFCNTJoTaUyqwABt1yfhbw/7jiWTOwpG226V3Db9YBLTN/mxBGxglUSZXcu7hGJi1qC8m/Vu1b7HUz8/1KyT/4bbaGiLqpttoKAiW9JZzgL+83sr536oz6wMEcceN56RDssr6CPC7KU1k975OGJWdJOKqGkvX31YOmCyOW4nlZ/CnZp1ABSST4ADv/lm3yK+Q0DTQ2HvGdeXtVPk1pIg5WyysFK0kI1WrP56XXR7KMS4GdQ/Dv3AorL2CDrOnVvOVVcuqeHp7m2/It2J89IhrX1y63uNWkd0uTQ==; 31:IlAI+F0LE09KbZBpAEd2JAZIPga9M6EYEOzbOSYoA3c9yWp0uDOL11/XdcYwmb0tJUTjwVXiXMrjnQmU2MG5QFHYXKBr088MfVF7ccRfNbfF1FeW2NB1WPju74hrp9yzDlisdp6wnbamBIwRf9ruwMcP/N6nFw8nAMk/cIMT/j2DyzoSbThpIIjbUxsZR2jzDcpLle5Bmxe/YONr/VNvWWtNZ3KbpjjtSq8fAmavjps= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2035: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 20:NHePgZM90M1C9friyEYNy7cq0Lgtp0k82/0D4RsACUsgg0mbrFASA61wB74PJ0wDJlhFA1FC9Hy8FGOo8mjxk9UX+v+evtlRqNNdIWNQwH30XGySCd6hWhiQ/K2OHi/O3d1WLuFP757GSUk1xk9TWqvo/bsqHtiX57YrwfMbTG7UlVS7Pm5ry4Ompg3K4mDrzjulhM+Gc3t2dkBkdkOjW6tmjBXE5P5jNWRRECI6iS+vRbyJJmu9HPOUOgclFsE5wKpj4gN78wZ0JKU6rqRoabn88wxa8f1lo/DNS+eqD8sSUEz94jC+UL9sG220C0e9Gy+Cq5rX/H2MRG28HOHRFhypf3ii+LLy7IA7HSBs/MbHgBtU+ldHNT3pvQAYZejs+7z0evBLZoP8bExRZmMSorsfuwTWi2ibKeMlrWBcucjoHDpTGDD8Q3qOEwAn/1I9CT3jB6Xuq8lfXyeG10R5n8OAksj12HbTMf+vm//7mjbEh3zM+XEryOL2QjWU8xFV; 4:hsLH2FWZaM+IEGBI/GBH0Mfr3dfukK2sgPv0GqBZs7dP3ivPqvUkD5nFMq8q6SqytNo9wXpjC0gtuGRbTrAHqTcCBEdHZ/dswvC8X375Muddlhgnww+WWcMBg9+iZyMlGKwEbUfdsqvsKS20BsIsT22XGx+0DbMYM0Fd+tQl/r1ACOzfcvqWV/9/fx9X0Wn1P8tF/WTAVtiMBTpx16pX7SY92SIpZi+yg98coSMj82TiZinVJoNfCRgsB4vJBeRrilH+0hRCc/SggInbaDWngUvt2I0GPOehDZhFL80EZRliSzS/op7gYxgxbOy8ydsa X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2035; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2035; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(366004)(376002)(346002)(39850400004)(396003)(199004)(189003)(69234005)(28163001)(4326008)(50466002)(48376002)(54906003)(1076002)(1720100001)(966005)(25786009)(6666003)(6916009)(53376002)(5660300001)(66066001)(47776003)(105586002)(86362001)(106356001)(478600001)(575784001)(51416003)(386003)(53546011)(3846002)(7696005)(76176011)(52116002)(6116002)(316002)(16586007)(446003)(97736004)(81156014)(305945005)(26005)(6306002)(55016002)(11346002)(8936002)(68736007)(186003)(81166006)(50226002)(21086003)(8676002)(36756003)(7736002)(53936002)(476003)(2616005)(486006)(69596002)(2906002)(956004)(16526019); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2035; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2035; 23:p3FzchobvpaCMjy+1LemmNx5qnchp1zKNVwhYbr?= =?us-ascii?Q?6P70Q8ybn1Dt5s+RBvx4eHITe+7a0jfaIKBoxWre4Td1MMGElzrz8CSeYdKD?= =?us-ascii?Q?vgqdPIuwZSXbU7Pak8xCISs5cB3ne7wnRW0c9OdkUGtvrk2+b5QJ/0quhsGr?= =?us-ascii?Q?w/Id3Y4IyCnX+mWgPEThi3cbrW5IvS/itQayEC1kRWTGdTmDjtFRn4TILAoq?= =?us-ascii?Q?A9/N24JXBnUkmCox+acN1trDT1D1Mkfv3vURXHnCk3wXycAN9v4jfwIJGTJw?= =?us-ascii?Q?wCryUTkTkBCRdQZeho/9haKdv+OUMiTjSK2w2Sm1on8DIGaYlVJF77izVcYO?= =?us-ascii?Q?tPIahOck0uYeBmxFIg28DjHmzK/yHF4/Cu5LrKRuB44xqR4ER2wDHPU9TFRu?= =?us-ascii?Q?Ok9hVMtaxOFxH3W36xu/bRj+f/AumuvDDpfc6uLtKdB4DgqsxZIM2nn5Zewb?= =?us-ascii?Q?wi6IfODfAlyYI/6/P6JEW9ISI57Rxt8bKRkGj3KFTOxI6niy/BpDPrPxts+J?= =?us-ascii?Q?CyTADktYC8dowX0L2EX9Q8QGRZyD2Q9/OUtP+aQXw2U58Jz9k4wyucjq3ByV?= =?us-ascii?Q?QVeR/IP8zuTI048HJYZw+1ebi4lfNBOXHGWf8enxg/7cGjtJ1GkwPl7GUlBS?= =?us-ascii?Q?j7ysbxOZ55hW8DGhUp5TqaxTJg0GmB2OdX3vYggYJbgLayV4+60qayeJ9Ju5?= =?us-ascii?Q?xRIBfug09eikVEGkAlcjU9D5nlK8c8IdKPLyTcB91P+ls6Ek9TbK9dFIyIym?= =?us-ascii?Q?pvef/8s8Phon2CJ0PcMXnvAeOUrrtGqqoX86cTDXrVebLkuRmHltQ/Hl9OPK?= =?us-ascii?Q?FDH4w0Cc9LJRneoWZJc2cCxckbYsxgn4OR9L09OqVzj04o5YAiSEbRouJZwr?= =?us-ascii?Q?2A0ijTPgEh4BmFJyg2OLwLO/E/Qv6BO8QL67a6ABhnT7S6qVSCE8i0Zi47xD?= =?us-ascii?Q?38ynYu2pyNhFRYFKc/inY6jRdD+mcfChtMnlRFA6CEgoZ3WQ+j54bcEmwLkY?= =?us-ascii?Q?/72BbXBfM+nzkdfQJ94VVnDOYvZqSrK+lAVsQSg/eR/f6UVdGDcQuxD0A1ij?= =?us-ascii?Q?i3nBLZsleggqZCuxG15NINhOYXayf5NzuEgU71NM5LE+FNwnmkwlpfK6K3u4?= =?us-ascii?Q?k1Whj+7ydu+8Soco2dByIJX9KYP4G2I0xU0N4Bb/revdd6twI4ODeiGd+QBj?= =?us-ascii?Q?zWOlVPHOdqbfW7B5HQF5OI7f7jzeZjmnMcaYTcPPUjDABzDE0XflKoi+Hsub?= =?us-ascii?Q?Gqr7F/dTVho4rc823rUZshnT6jfv8jwszKf9Tlcm8dEQ5LRRQWou9Xw4ITrj?= =?us-ascii?Q?fqIMI6WK/jL1BCdeCHSmx0vjGtrCx/Zn402tJWPUegU+IECKzLGNSxgLaliI?= =?us-ascii?Q?WjlkZj8UeYI9sB5rM0mg86GAjYwkp+b5HZ30E4ny09UiaYiT2?= X-Microsoft-Antispam-Message-Info: 6z4zTNn62U4kZE74uvjTd/xFx4/TCvaGNQnsiEdbB4q2HSYptRfy0zUQcjc+vsCbD7Ex2/y674V5TYwyvM9AqSBpjb+JxmKunK0wsFClP19ELnf/co9wilZsjm+ue6A59RzP+SCRmkrH2XswsVUYQ2ksJqDLFcOO6q26kWOFwfYhqN/0mjQOQJltVPbcMbE9mVw6/x7md2+CRXcHVV6Qt0NTlJFpBaNwDxUuRJZd5oeB1bf6Ou3Cyt+LgAiWWEvitNitKLJL4qLgRY5eUEPMQrtv/R5tGYwoae9bh6PxkxznP6wPzOAaQ7yRqEYGHgJ0ZDtDS9aHVZzdR6AqyqJJNAjiJd8GXBN0rv2q81tB6PA= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 6:Ndb/UYEMhoiaU735h8+0HdXvIgUPqo9PkTTgtFqsKXHI3Cvutwyd0gVxiYL4ZAfudgisOvXA/i8Qdaeu9yQpoU5PyPLVTlGBRxRumzWU7RuS8LTbZtVu7xyt1dpwyoksAl13oE5rgFuHri39m0LzefjEPs05mheR6Xyx9whdTUiF2SrpGb58RwDceu2NRIFbhSwW+RA68HTgJt9znRSEswyL3+MSP7abpnKQBWG1iqP+sXSBY1tFiiiPCEavPbZVNH46qb4cVJBcnPlMcn7Y4xLcKpGewlFRkDJ/6BCoRmqhvp6Bi3REbAvEO1VWTQYmvHVdIRW3SzBZDO70ne5r1l6ADT09Xrfj7fsUdAD9l/uSSLow47sFtbd/C+ygkzOm8ePt828ZBNQH1AHycM1TqVm660o8zsR/O6a2gNutDBWfI7bHQQJCtN0uROxPTXwPXDpQ6JhgHTsW1Xm2tTRxVA==; 5:DXl+ZbIMMLkyucOvHD36wFILS+f5hKIycBefIL0QB0i1nmwExFu8Gb8E360E+cz0piMm1G2h3R3nMsPuINTBzZyemOyPPnTZq7Dezw/dA3daAspbkAuIK+qOpMv/DftptyUefSYjv7bdP9X77g/Z13NK0CItLZzhH+28mOi80yQ=; 7:HsDL1DAUd5StTO7u4M6L3AuQ6t8N1U0IgjzbcQoC/pgXSKIKxnWdjX4IX8n0aWVG7t0lX5UCbSJpNUlJf1Cr2JRygGwVdahcBhFhqCGH1ATmM2AVSIaRt/GXISmKrFVN+J8cGVqFLF7hnxNldV2gM4a3Z6PM+buuufSLug0bPwsLlLN00Oz8ouimRcoHwkecxMnatqRYNjVIq0mE4o1eR9Co3WWbmLCeZmt1y9sSaxGNkpWtgaLW6T8VUF5xjJW+ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:32:29.8988 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b02f2156-7858-48f6-a34d-08d5f36933e0 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2035 Subject: [dpdk-stable] patch 'test/flow_classify: fix return types' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:32:32 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From d67b45ebbb287517f4528ac116d5b0d25005ab66 Mon Sep 17 00:00:00 2001 From: Reshma Pattan Date: Tue, 17 Jul 2018 17:44:45 +0100 Subject: [PATCH] test/flow_classify: fix return types [ upstream commit 4f872116c59a1342dd7ab7165adf05a624480b70 ] UTs should return either TEST_SUCCESS or TEST_FAILED only. They should not return 0, -1 and any other value. Fixes: 9c9befea4f ("test: add flow classify unit tests") Signed-off-by: Reshma Pattan Reviewed-by: Anatoly Burakov --- test/test/test_flow_classify.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/test/test/test_flow_classify.c b/test/test/test_flow_classify.c index 9f331cd8e..a8a1cad41 100644 --- a/test/test/test_flow_classify.c +++ b/test/test/test_flow_classify.c @@ -641,32 +641,32 @@ test_flow_classify(void) printf("Line %i: f_create has failed!\n", __LINE__); rte_flow_classifier_free(cls->cls); rte_free(cls); - return -1; + return TEST_FAILED; } printf("Created table_acl for for IPv4 five tuple packets\n"); ret = init_mbufpool(); if (ret) { printf("Line %i: init_mbufpool has failed!\n", __LINE__); - return -1; + return TEST_FAILED; } if (test_invalid_parameters() < 0) - return -1; + return TEST_FAILED; if (test_valid_parameters() < 0) - return -1; + return TEST_FAILED; if (test_invalid_patterns() < 0) - return -1; + return TEST_FAILED; if (test_invalid_actions() < 0) - return -1; + return TEST_FAILED; if (test_query_udp() < 0) - return -1; + return TEST_FAILED; if (test_query_tcp() < 0) - return -1; + return TEST_FAILED; if (test_query_sctp() < 0) - return -1; + return TEST_FAILED; - return 0; + return TEST_SUCCESS; } REGISTER_TEST_COMMAND(flow_classify_autotest, test_flow_classify); -- 2.11.0