From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0070.outbound.protection.outlook.com [104.47.1.70]) by dpdk.org (Postfix) with ESMTP id 8BEBA98 for ; Fri, 27 Jul 2018 04:32:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hNzlh37TxTuItpKYeqC/too4m8JSuhCPFCmoUn0sUPI=; b=KnRFYyOlt+pHRA5aslEZNJrvjsgzm6ExUVXTeiA+HxcJ75+aiCf3JkWY4C82TcyRvJQXRtvhlHls11SDWbs7TbTEyiUUhDss/G5fPLLidQVx5frU8sV3sSRaOUfs8FW8HQuO6aE2OeRUU40Xf9Pq3wWh9CXLLOTj0cdYEzmlRoo= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by AM5PR0501MB2035.eurprd05.prod.outlook.com (2603:10a6:203:1a::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.21; Fri, 27 Jul 2018 02:32:32 +0000 From: Yongseok Koh To: Pablo de Lara Cc: dpdk stable Date: Thu, 26 Jul 2018 19:32:02 -0700 Message-Id: <20180727023205.38767-7-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180727023205.38767-1-yskoh@mellanox.com> References: <20180727023205.38767-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: MWHPR15CA0056.namprd15.prod.outlook.com (2603:10b6:301:4c::18) To AM5PR0501MB2035.eurprd05.prod.outlook.com (2603:10a6:203:1a::21) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 20fd0ef0-f81d-4431-a02a-08d5f3693570 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(5600074)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020); SRVR:AM5PR0501MB2035; X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 3:reQZRP4TpJNkkACifq4tHKjjg5wzyrOrem+Wu3dClbzclKfZU8bq36vPLgRQinitTKC0nLMrFgyoG2XpAePaeuytUtyq27jYUHGVGIjAR5fhio1LBCbjudyWEu+6p0GulKsa4hnwGZly1BWP3+J/SDxrHEj1NfE9SJvovDcJnbyZhGaAeeFyCnpGIGwzrGsF1jemAlaPe3CWE7r1ymqbOXG3zbQKETeNx5pQVYKrylq/xzZRmJ9qvImT3Cu+nZxc; 25:IiJCu6+teBtAcBXBgwk7aHRqiEa/GTQGrKsbQBRWHrF0S9Nzuh1udriT2teGU+bh8Pt6QHdUz2qX+Ro44WSeRoHXru3c4anmQ3UvYzzPJbBQ8+5tkS1zCb6W+6UUeAkFr+plvZ4+GzZKbEUpSSrqPFVrAdGJ9u4dXtEu8HTCSL3M/Ec/SV18uZ0mjRFHb9ZXkDf9gAQ5y1OHPUTgyVJdSnikX4zyKCAukc/+rXsAa6pLHCs+/Xy/t0gmbJ63JnWqBhfPPRSbPrb3I7SQxg0bb4TtDmJPrrxU1hI3/MKnPuUpmfp9hl31YKWOk8KdPCsvrUzqEIgAzcGX8Mo8TYcmHA==; 31:qJMB+E10DT2sxPveZrFaRyQOFwdmgTFakay0cuUkpGhZBpjnrsUDiM8SMHJ+xXKnpp9wE/P8l58U9JufEBNvOxib24+1AUrZeRiwgdk7krD0nBXwSi049flGhOyDszeGb43ScEuwyULhyCCF3OJqLvA+HdiZKYio7xyJPILKqughjTKzMi/T40pbulgD62pjcXRJzFS6qWJ8s9UfNEHsYVYNIDfriijACNO8092LPTc= X-MS-TrafficTypeDiagnostic: AM5PR0501MB2035: X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 20:0WCbiLhyJIjHxsM4/AyeceDnx4XNq6LD5lfFobjOxZjiCVARmewu7+czHU8AXFZNqEeJ48V8XGiNe0maocGAz1xuBUrhJRGrhAnQADwY5T32wcJWGPKo8P4NBsK+GTFoMdQQytO2hf5RqhxKeFjWOx2MhuOQertVaTjSNi/gkyutpShNM7fzgSPwNXLr8LP/QcvyBKSN4cDLeAzJ3cgEHYOJO4YjEFQeDMkZosPCwm3YWanSV3tjcMY8lg46/UbR/yVMiTlFMgNBoC4PYCb6b0rw+q4KcTNYWvg0q7CO0QhfeY1Vzl8z+jCqlxExjupHw0DnoM6cky+QwjZZv14+gPj9CVyP8sBkwY1mgmbRuEx63E9Cr1FEUypzRq7iJrSBlQmYkpfmhHn9N03ApHqeSuY4q879nug7aYdFmLV94PV+tmjVRcH4ujSQnbYaeEmbLU7wvQaOEmiLM/twAiWa/AfzxiAiuSq9lJi/rPQqGOpMaR+g3szT93sei69E50xD; 4:gxv1zPfgH/0IR71//VJ+6XTsEfer7Z2aR4eLd9gELgExeR6FMToBkqvYNzKniArPUOVTjZGmekQP5cWK2yernta5bL5E4Ma6ypjD4KBx2yfVpWSIOqUWe6i/fEkqiE45vUDPtOpT1/fCrl3QXfHoxUwQDdO9xOZ0tGrSbNqc4ZLE9abw3M19tTc8oXitJUxpHWPSejPM7BuLwm3FLVEDKqtNBRW5ICAKSkyVxyS30iE6fyVakSKDqt3AboKqCh4FKU75brLasl/kLNQoUmWBRVFSfaUJFvril0Uax43PqPDHxiH83fcU0YvJ97Wrw94s X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(6055026)(149027)(150027)(6041310)(20161123562045)(20161123560045)(20161123564045)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016); SRVR:AM5PR0501MB2035; BCL:0; PCL:0; RULEID:; SRVR:AM5PR0501MB2035; X-Forefront-PRVS: 07467C4D33 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(136003)(366004)(376002)(346002)(39850400004)(396003)(199004)(189003)(69234005)(28163001)(4326008)(50466002)(48376002)(1076002)(1720100001)(14444005)(966005)(25786009)(6666003)(6916009)(53376002)(5660300001)(66066001)(47776003)(105586002)(86362001)(106356001)(478600001)(575784001)(51416003)(386003)(53546011)(3846002)(7696005)(76176011)(52116002)(6116002)(316002)(16586007)(446003)(97736004)(81156014)(305945005)(26005)(6306002)(55016002)(11346002)(8936002)(68736007)(186003)(81166006)(50226002)(21086003)(8676002)(36756003)(7736002)(53936002)(476003)(2616005)(486006)(69596002)(2906002)(956004)(16526019); DIR:OUT; SFP:1101; SCL:1; SRVR:AM5PR0501MB2035; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; AM5PR0501MB2035; 23:2gfqVj/QLi7WAEabg4MgK2irKZvhzyNGTtPyN5g?= =?us-ascii?Q?Qqx7lJU1v8Icd9+ytx2O+eC12VZMfwKTd+YYZiWW1pzWgA5vL/1tMzT9TDSD?= =?us-ascii?Q?Ukj5KvBmyL7h3H5OX2c2bmQY29ft5vwsihs9HJXRppBRZHpMUjwaCdpp9sb2?= =?us-ascii?Q?C+d24S6BG6sZjcpcsoA6AjlRFgxiND3WNaTE8lXI0+yKbx3X0SINnmwuAcqY?= =?us-ascii?Q?kwtZ9aKbyZuOt2+V6olVrAvr1cNNx1GkvfBTVpwzZ9HEcr4jh5gpWVBBbpZN?= =?us-ascii?Q?Cq5a2Toxqk0e53327/s3sq1wqevcWDaZcG2w/F2lQX/uSCpaTuz2lNENixZz?= =?us-ascii?Q?yRA/DtRBWuBGcCKQ3qKghn/PnIBnAaa1AjqVxZuovs96XUO0ARrKMC1jMHaE?= =?us-ascii?Q?ltfZkaXMoHL/H5F5PFjEM8rVwN8Q3C++3DPxZQJ6plafvNCihgAOk9nizAn9?= =?us-ascii?Q?I0fcbaIRkZMzXN+EWB27REwosmoUCh++dSxog/FDBnlA5AeGutvbWLOaf7Di?= =?us-ascii?Q?nxvyqDI+216fv0cPk1o0uYu6uf5BrevrVx5KLz/n/NDN30F8ZGvt0fCJdA5P?= =?us-ascii?Q?Q9ZFXz+3wrOgetWumDqZVjElMEapFkZMwNitmJIcQhPrRcTIWUq7aOqm9ND2?= =?us-ascii?Q?Hrj0mPDE9SFWUbRVkPOzPgtjlbvwj8cq8YgA1E6MV8DdppgwK5IV/Rj3XuBn?= =?us-ascii?Q?fV4EOOTRNbUgXko4nXq+X3P6iBiHkOAzzQeD5mAG5ztNBN81RiqO7ppoiTka?= =?us-ascii?Q?LAT74aHA/LWmcW8xJsVw6fHBq2sSn0SGoFrs7Z6xY2HEsb97ovdF3/dXAm09?= =?us-ascii?Q?WaWTEBa1AJj3woJk/u+KdjgertqOH5rYB45WakXzDQ6KnruHh6IGOTsS99KH?= =?us-ascii?Q?PuiCtYH+JOXP6Yp21B8JGfAVDqFJ8l5b217vh1KOa71O/G23nYpg8s+o+34x?= =?us-ascii?Q?3KYC1W9ATwxGZSC95QXHZeTPwGIw9tysAInfuBURj/Y8pQ+7BdxaPw0hpeeO?= =?us-ascii?Q?1qbAiFQcnZtXxVI4OD6mkF4xgorZYGU+0egtr52sXIx6JHXPDjhqkWjtXTG4?= =?us-ascii?Q?U8Srluzj1uYGSbpGFpDOik4/1vFN7Ou8k2wNKYl7jezYyQ2PPEL27J19QukZ?= =?us-ascii?Q?6GEvVUdEJCJ3CSSmmxMhU3e5/lHdn+HE76kfhiEAyJyAP+lB+ACIStt3tGI5?= =?us-ascii?Q?jTkTc49K2DYdeXTsFzeXFYhHVr16cpbwMqAiQ5NVN0oi2HDIFcx7zz123xXp?= =?us-ascii?Q?Wiz928/WPfVNqJnwwo5ycOWSJcun11CZyrsTEhumY+eiD70L+7iJ9pVNLnuB?= =?us-ascii?Q?1v0o40ppHtUKaf6155fW6wJFHzQebsyF+5GedBehGtjgkK6bIEGuZtsW23DW?= =?us-ascii?Q?/BwmE9NrcBs7CcybSY8CpCknA4+sHWNtDcUhD4B4SYH1KG8Hk?= X-Microsoft-Antispam-Message-Info: vlZm96aBfHuWUixe/LK+Q+N2Dqf9XIbZpRLO2bxOQBvKi14RykGJd6x1B5TSnk/N3T8vq8lHhE1UFME7ebnvslCbNTfO0Ttfclevq4cukTfpjd1BkQwdNV3Po8Ea7GTDUNePPcKa3RoqWoBn0qMRQXqVU+lze6xEIsPs1sdzWJc8Rt3zjjxNDIYHq6cDlugk7wFx5ks0LsOIdSGtpy7GRELIsVQL3ZcT7VsxBEqXWujHLhfaIKHlyGZhINiYx8uo5c3j3ZxD71x7PO+ENn62853AYFfm/qPgUUg1/uH+JzVAfR5hwTWvPoeNdtI3+E9GlfMWhXoERgbDii/lDrp8rnzaSUZK7KIHtA5oSQqIdPU= X-Microsoft-Exchange-Diagnostics: 1; AM5PR0501MB2035; 6:QzppsecihQnVstSqsWDzOuBM9LXpFm9DwHbAznsM6TCQZy+qDYD+OJgz2SyEt6ymPfIDHF/3zSyjeCAw/9IuTIHm7c2U3GpE6HvSxzqnPyhwh3Nq2FSP8Ya7IexYq+XMZz1o5H/qngU9mJlvH3uViNdtk1liHfat2bkfKU6jusX8fm3hV/YLU+r4jrHDptpJpXy1ahWPkbaI4FAzrnb1/Unao0Xk7M/b7jM8FLXeVts7QR6DDYM5nN7RLAfP4RPAh4gpgdIcvjtxUhjxoVw8cY18PAO4LOpoJQMDIZnWP6VRjuGCQKIXWR1iDnFJhrnx0xTM3QLSysHoimi4OLbrMOcWIKklVA3958DjQcK3DH367JQ0aq3gOMW/OcTJUf5SZTKumcbL/Tbh9lOX7e6K9tz+nU5LO16efm+IaK2he7L+FIaYuk0RBjqys5kzZqTVz8mb9K/CsLGwZ8AVKlUH7Q==; 5:20fiY9f9346lbV3UVVS0A2M3eacDay7B+JahkgEnw+UIdnZQqtU1/Vv6u3vqrTyttbu+cKBDvgjkIcgON3TGsOLAmHQOerNIP9RAQpjbwaETdjzRqE2jHpvXqxhnAXTKzYEcEl/dcXPFQ0kss17nB5hG5klIXq99p1GHqw+dQMg=; 7:ou2zXBmpNaxbKor9wXcn1iQ4qpWC+uamZIeiQyb8Au4Z5Q83Sv0Ov5j0Va78bi8mjfPG+clnbXqdAiAb5jhxuPMSyxBS6n/OB7ZVNfU9i/LGxEBrqRAoT/Opg4Gu4vdhAR0QqYxv4fqIelR/n4P+MaEV/daKaof9WoKqcZYh+nT/pkgmdVpVZneUkcxz3q57aZxtx+ppL4fz3Juj8sbIOKAaImrwWFOszmr9qc3tzgSarg03CCJX0knaO7m0KTVr SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Jul 2018 02:32:32.7173 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20fd0ef0-f81d-4431-a02a-08d5f3693570 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0501MB2035 Subject: [dpdk-stable] patch 'test/hash: fix potential memory leak' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 02:32:34 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/28/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 13621ecc7ba85128300cee9599a37d5a58400442 Mon Sep 17 00:00:00 2001 From: Pablo de Lara Date: Tue, 17 Jul 2018 14:31:51 +0100 Subject: [PATCH] test/hash: fix potential memory leak [ upstream commit a4492ab49ec3b829745c9060a1719354e0a572b7 ] In the multiwriter test, if "found" array allocation failed, the memory of "keys" array, which was successfully allocated could not be freed, since by this time, tbl_multiwriter_test_params.keys was not set to this array, which is the pointer freed when finishing the test or when a failure happens. To solve this, tbl_multiwriter_test_params.keys is set to the "keys" address, just after allocating and filling the array. Fixes: be856325cba3 ("hash: add scalable multi-writer insertion with Intel TSX") Signed-off-by: Pablo de Lara --- test/test/test_hash_multiwriter.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/test/test_hash_multiwriter.c b/test/test/test_hash_multiwriter.c index 951c3e743..0e9ac7162 100644 --- a/test/test/test_hash_multiwriter.c +++ b/test/test/test_hash_multiwriter.c @@ -181,16 +181,17 @@ test_hash_multiwriter(void) goto err1; } + for (i = 0; i < nb_entries; i++) + keys[i] = i; + + tbl_multiwriter_test_params.keys = keys; + found = rte_zmalloc(NULL, sizeof(uint32_t) * nb_entries, 0); if (found == NULL) { printf("RTE_ZMALLOC failed\n"); goto err2; } - for (i = 0; i < nb_entries; i++) - keys[i] = i; - - tbl_multiwriter_test_params.keys = keys; tbl_multiwriter_test_params.found = found; rte_atomic64_init(&gcycles); -- 2.11.0