From: Yongseok Koh <yskoh@mellanox.com>
To: Yongseok Koh <yskoh@mellanox.com>
Cc: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/mlx5: fix error number handling' has been queued to LTS release 17.11.4
Date: Thu, 26 Jul 2018 19:33:38 -0700 [thread overview]
Message-ID: <20180727023339.38855-3-yskoh@mellanox.com> (raw)
In-Reply-To: <20180727023339.38855-1-yskoh@mellanox.com>
Hi,
FYI, your patch has been queued to LTS release 17.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/28/18. So please
shout if anyone has objections.
Thanks.
Yongseok
---
>From 8e47ba2b073a2cb6eb87b97e81436346f729737c Mon Sep 17 00:00:00 2001
From: Yongseok Koh <yskoh@mellanox.com>
Date: Tue, 19 Jun 2018 16:13:13 -0700
Subject: [PATCH] net/mlx5: fix error number handling
[ upstream commit 5cffc8b28dc874d04df7675abf7187c271524f70 ]
rte_errno should be saved only if error has occurred because rte_errno
could have garbage value.
Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values")
Signed-off-by: Yongseok Koh <yskoh@mellanox.com>
Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
---
drivers/net/mlx5/mlx5_flow.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 57b654c35..d261ba13b 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -2991,15 +2991,17 @@ wrong_flow:
/* The flow does not match. */
continue;
}
- ret = rte_errno; /* Save rte_errno before cleanup. */
if (flow)
mlx5_flow_list_destroy(dev, &priv->flows, flow);
exit:
+ if (ret)
+ ret = rte_errno; /* Save rte_errno before cleanup. */
for (i = 0; i != hash_rxq_init_n; ++i) {
if (parser.queue[i].ibv_attr)
rte_free(parser.queue[i].ibv_attr);
}
- rte_errno = ret; /* Restore rte_errno. */
+ if (ret)
+ rte_errno = ret; /* Restore rte_errno. */
return -rte_errno;
}
--
2.11.0
next prev parent reply other threads:[~2018-07-27 2:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-27 2:33 [dpdk-stable] patch 'net/mlx5: fix queue rollback when starting device' " Yongseok Koh
2018-07-27 2:33 ` [dpdk-stable] patch 'maintainers: update for Mellanox PMDs' " Yongseok Koh
2018-07-27 2:33 ` Yongseok Koh [this message]
2018-07-27 2:33 ` [dpdk-stable] patch 'net/mlx5: fix compilation for rdma-core v19' " Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180727023339.38855-3-yskoh@mellanox.com \
--to=yskoh@mellanox.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).