From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 882E45681 for ; Fri, 27 Jul 2018 18:46:27 +0200 (CEST) Received: from eucas1p1.samsung.com (unknown [182.198.249.206]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180727164626euoutp02902a535a221ecb94d888bbc3c5d4ba05~FR5ykp0CX1638916389euoutp02c for ; Fri, 27 Jul 2018 16:46:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180727164626euoutp02902a535a221ecb94d888bbc3c5d4ba05~FR5ykp0CX1638916389euoutp02c DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1532709986; bh=+94q545C+W3DevltO3L9rByl2PiIGr5hBPx9p6x41vA=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=lRtBNqpifchHIXarvX+Y/TWTQZcpT1xiuZEWy1bdWgZ9IgM4n5+Kb2X+5IvnjEgXq MPKCcerxXkaZBuwWYXRzNr/k/Oj+BmIGjJo/92purE3vpf+UmIO7bJhFWlwWIxk/yw Sohp/Te+VAja6h/554euFQGsOp/hYlcawJSPYvTw= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180727164625eucas1p24055eac8bfaedb1030a6e1accbea4701~FR5yMhGK43042430424eucas1p2b; Fri, 27 Jul 2018 16:46:25 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id 20.76.61560.16C4B5B5; Fri, 27 Jul 2018 17:46:25 +0100 (BST) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20180727164624eucas1p1d04b8c165d9690781a1d99623cc28510~FR5wyolb60227802278eucas1p1K; Fri, 27 Jul 2018 16:46:24 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20180727164624eusmtrp1392b4abde8a3989e4b712d70a705cc37~FR5wisXk11474614746eusmtrp1B; Fri, 27 Jul 2018 16:46:24 +0000 (GMT) X-AuditID: cbfec7f5-207ff7000002f078-e2-5b5b4c61245c Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id 81.6D.04178.F5C4B5B5; Fri, 27 Jul 2018 17:46:24 +0100 (BST) Received: from [106.109.129.180] (unknown [106.109.129.180]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20180727164623eusmtip1e6ec92f83f966b81ff7482cab8373c6c~FR5v-oJdN2228222282eusmtip1N; Fri, 27 Jul 2018 16:46:23 +0000 (GMT) To: Kevin Traynor , Yongseok Koh , dpdk stable , Luca Boccassi Cc: Maxime Coquelin , Peng He , Tiwei Bie From: Ilya Maximets Date: Fri, 27 Jul 2018 19:46:56 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <80ad5117-ceb1-7d59-0e12-96f4ab4ed90d@redhat.com> Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrFKsWRmVeSWpSXmKPExsWy7djPc7qJPtHRBhuPK1lcaf/JbrH20Ad2 i7OX77BbHOvcw2Lxr+MPu8XWhv9MFv3797FZXJm/j9mBw+PXgqWsHjtn3WX3WD7tKKPH4j0v mTyeTT/M5PF+31U2j74tqxgD2KO4bFJSczLLUov07RK4Mj6fW8NacE+v4tr918wNjO9Vuhg5 OSQETCS6/19k62Lk4hASWMEo8eLzBGYI5wujRNOPFkYI5zOjxNL/6xhhWrYvnADVspxRYsXy HVDOR0aJv7vamEGqhAUiJL7tO88CkhARmMIo8b+lixUkwSxQJNH5Yh2YzSagI3Fq9RGwsSwC qhInZj4As0WBmjdO+AQ2iFdAUOLkzCdAgzg4OAXsJK6vYocYIy7R9GUl1Eh5ie1v54DdLSFw il1i7apWsHpegTKJ3Y9jIa52kdj7rZcFwhaWeHV8CzuELSNxenIPVLxe4n7LS0aIOR2MEtMP /WOCSNhLbHl9jh1kJrOApsT6XfoQYUeJs6vPM4KEJQT4JG68FYQ4h09i0rbpzBBhXomONiGI ahWJ3weXM0PYUhI3331mn8CoNAvJj7OQPDYLyWOzEPYuYGRZxSieWlqcm55abJyXWq5XnJhb XJqXrpecn7uJEZiiTv87/nUH474/SYcYBTgYlXh4K6yio4VYE8uKK3MPMUpwMCuJ8AqrAIV4 UxIrq1KL8uOLSnNSiw8xSnOwKInzSvtERAsJpCeWpGanphakFsFkmTg4pRoYtbNdDq5JVxTS 7s5xYY7mtaheaNb0+tprkQ0OrNM88+/GXSyXmJzVfmL7njcJZ70F29/OuHUxiuvnzqI5+7+r GpUabz3pJSBqKbV1gszeGLc91wUvTe7uKVvH/+3Z86A//lLndFIqFWf4rPksueKm/zEf458X L+WJpAS4553745K8wHtZ75w4JZbijERDLeai4kQAFjgAIE0DAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrLIsWRmVeSWpSXmKPExsVy+t/xu7oJPtHRBh+2MVlcaf/JbrH20Ad2 i7OX77BbHOvcw2Lxr+MPu8XWhv9MFv3797FZXJm/j9mBw+PXgqWsHjtn3WX3WD7tKKPH4j0v mTyeTT/M5PF+31U2j74tqxgD2KP0bIryS0tSFTLyi0tslaINLYz0DC0t9IxMLPUMjc1jrYxM lfTtbFJSczLLUov07RL0Mj6fW8NacE+v4tr918wNjO9Vuhg5OSQETCS2L5zA1sXIxSEksJRR 4v+aJcwQCSmJH78usELYwhJ/rnVBFb1nlDjw6CsjSEJYIEJi5dYuJpCEiMAURon5M3eCdTML FEn0/V3ODNGxhkli781NbCAJNgEdiVOrjwB1c3DwCthJ7L+YCBJmEVCVODHzAdhQUaChTfPW sIPYvAKCEidnPmEBKecEKr++ih1ivLrEn3mXoFaJSzR9WckKYctLbH87h3kCo9AsJN2zkLTM QtIyC0nLAkaWVYwiqaXFuem5xYZ6xYm5xaV56XrJ+bmbGIFRue3Yz807GC9tDD7EKMDBqMTD e8EmOlqINbGsuDL3EKMEB7OSCK+wClCINyWxsiq1KD++qDQntfgQoynQbxOZpUST84EJI68k 3tDU0NzC0tDc2NzYzEJJnPe8QWWUkEB6YklqdmpqQWoRTB8TB6dUA2PNpu/Hj/j7Xz5s/YM9 eG77pDc1Jyzm/dW/sY1Br+ny56tnOStvH7PO77t2ietm+GW9zEuxTKyCVjwSIW8O3zFle/3u rHh/+BTnvx8nz12esdNYomj1zSMpx7uCjr5Xv2HEnFVzlissL+J3goDYlNnXOXRzeJwqVrv1 LH1XkDatc76L646P788rsRRnJBpqMRcVJwIA2iZxgOACAAA= Message-Id: <20180727164624eucas1p1d04b8c165d9690781a1d99623cc28510~FR5wyolb60227802278eucas1p1K@eucas1p1.samsung.com> X-CMS-MailID: 20180727164624eucas1p1d04b8c165d9690781a1d99623cc28510 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20180727024051epcas3p20e5aa80ae259e6d8d83d44d60fd32625 X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180727024051epcas3p20e5aa80ae259e6d8d83d44d60fd32625 References: <20180727024008.39497-1-yskoh@mellanox.com> <20180727074215eucas1p19e45258ec15a10881b3006b70723c3f2~FKeqOKwSp3270732707eucas1p1b@eucas1p1.samsung.com> <80ad5117-ceb1-7d59-0e12-96f4ab4ed90d@redhat.com> Subject: Re: [dpdk-stable] please help backporting some patches to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 16:46:27 -0000 On 27.07.2018 19:25, Kevin Traynor wrote: > On 07/27/2018 08:42 AM, Ilya Maximets wrote: >> [keeping in CC only e11411b52 related persons] >> [CC: Luca Boccassi] >> >> Hi. >> I beleive that I was added to this thread as a reviewer of >> "e11411b52 Maxime Coquelin vhost: fix missing increment of log cache count". >> >> Looking at the current dpdk-stable/17.11 I see that the patch could not be >> applied because it fixes issue introduced by another patch >> c16915b87109 ("vhost: improve dirty pages logging performance") that doesn't >> exist in this branch. OTOH, this patch exists in stable 16.11. >> So, I have a question: Is there any reason why c16915b87109 was backported >> to 16.11 but not to 17.11 ? >> > > Hi Ilya, Guessing it was because it was an optimization as opposed to a > functional fix. See below commit wrt clarifying this - ref last para. Sure, I understand that. But this doesn't clarify why we have this patch in 16.11 and not in 17.11. From the user point of view this means that upgrade from 16.11 LTS to 17.11 LTS will significantly slow down live-migration. Later upgrade to master/future-LTS will speed up it back. > > Kevin. > > commit 56c7ddc1381a56612018b75a848169b917bc33fb > Author: Kevin Traynor > Date: Sat Jun 30 00:10:43 2018 +0100 > > doc: add default that all fixes should be backported > > Set the starting point that all commits on master branch > with Fixes tag should be backported to relevant stable/LTS > branches, and explain that the submitter may indicate it is > not suitable for backport. > > Of course there will be exceptions that will crop up from time > to time that need discussion, so also add a sentence for that. > > This is to ensure that there is consistency between what is > backported to stable/LTS branches, remove some subjectivity > as to what constitutes "a fix" and avoid possible conflicts > for future backports. > > Signed-off-by: Kevin Traynor > Acked-by: Luca Boccassi > Acked-by: Aaron Conole > Acked-by: Thomas Monjalon > >> P.S. I don't feel that I should backport e11411b52 myself, but I can do that >> if author/maintainers are too busy. Please, let me know in that case. >> Regarding 16.11, to backport e11411b52 you only need to change the >> destination file,because related code placed in >> lib/librte_vhost/virtio_net.c instead of lib/librte_vhost/vhost.h. >> >> Best regards, Ilya Maximets. >> >> On 27.07.2018 05:40, Yongseok Koh wrote: >>> Hi commit authors (and maintainers), >>> >>> I didn't manage to apply following commits from upstream to stable branch >>> 17.11: conflict happens. I'm wondering can the authors check the following >>> list and backport those patches belong to you? >>> >>> FYI, branch 17.11 is located at tree: >>> git://dpdk.org/dpdk-stable >>> >>> It'd be great if you could do that in one or two weeks. Also, please add a >>> heading line like below before the commit log body: >>> [ backported from upstream commit xxx ] >>> >>> Example: http://dpdk.org/browse/dpdk-stable/commit/?h=16.07&id=c4831394c7d1944d8ec27d52c22997f20d19718e >>> >>> Also please mention the target LTS in the subject line, as we have more than one >>> at the same time, for example: >>> >>> [PATCH 17.11] foo/bar: fix baz >>> >>> With git send-email, this can be achieved by appending the parameter: >>> >>> --subject-prefix='17.11' >>> >>> Please let me know if you have any comments, say, need more time, or it's >>> worthless to packport it. And please send it to "stable@dpdk.org", but not >>> "dev@dpdk.org". >>> >>> Thanks. >>> >>> Yongseok >>> >>> --- >>> 422515b9a Adrien Mazarguil app/testpmd: fix crash when attaching a device >>> 66f2ac0f8 Adrien Mazarguil net/mlx4: fix minor resource leak during init >>> 0cc1fcdeb Ajit Khaparde net/bnxt: check filter type before clearing it >>> 6a9360963 Ajit Khaparde net/bnxt: fix clear port stats >>> 3c2e87c10 Ajit Khaparde net/bnxt: fix close operation >>> 90362583e Ajit Khaparde net/bnxt: fix incorrect IO address handling in Tx >>> 812bb2087 Andrew Rybchenko net/sfc: handle unknown L3 packet class in EF10 event parser >>> 2a4ed7233 Damjan Marion net/i40e: do not reset device info data >>> 64cb90f88 Fiona Trahe crypto/qat: fix checks for 3GPP algo bit params >>> 2a7e3d546 Hyong Youb Kim net/enic: do not overwrite admin Tx queue limit >>> e11411b52 Maxime Coquelin vhost: fix missing increment of log cache count >>> 79d098921 Moti Haimovsky net/mlx5: fix build with old kernels >>> c44fbc7cc Nelio Laranjeiro net/mlx5: clean-up developer logs >>> 179c7e893 Pavan Nikhilesh mempool/octeontx: fix pool to aura mapping >>> 196e9a486 Qi Zhang eal: fix hotplug add and remove >>> 9f32c7e7e Rafal Kozik net/ena: change memory type >>> 46916aa17 Rafal Kozik net/ena: check pointer before memset >>> 41e59028d Rafal Kozik net/ena: set link speed as none >>> 3abe17195 Rahul Lakkireddy net/cxgbe: fix Rx channel map and queue type >>> 1fc3afdf7 Rasesh Mody doc: update qede management firmware guide >>> c6dd1eb8a Rasesh Mody net/qede: fix default extended VLAN offload config >>> a16aef523 Rasesh Mody net/qede: fix for devargs >>> e46821e9f Shahaf Shuler net/mlx5: separate generic tunnel TSO from the standard one >>> 496f15c2c Shahed Shaikh net/qede: fix incorrect link status update >>> c7641841a Shahed Shaikh net/qede: fix unicast MAC address handling in VF >>> 82dbef2c8 Somnath Kotur net/bnxt: revert reset of L2 filter id >>> 0989161b2 Tiwei Bie vhost: release locks on RARP packet failure >>> b2a4a69f7 Xiaoxin Peng net/bnxt: fix Tx with multiple mbuf >>> >>> > > >