patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Timothy Redaelli <tredaelli@redhat.com>
To: thomas@monjalon.net
Cc: bruce.richardson@intel.com, bluca@debian.org, stable@dpdk.org
Subject: Re: [dpdk-stable] filenames of DPDK stable packages
Date: Fri, 27 Jul 2018 19:15:11 +0200	[thread overview]
Message-ID: <20180727191511.72c35d46@redhat.com> (raw)
In-Reply-To: <5213154.30SCDzBaau@xps>

On Tue, 24 Jul 2018 11:12:56 +0200
thomas at monjalon.net (Thomas Monjalon) wrote:

> Hi,
> 
> 23/07/2018 19:07, Luca Boccassi:
> > On Tue, 2018-07-17 at 13:34 +0000, Richardson, Bruce wrote:  
> > > Therefore a small ask - can we please provide a package for stable
> > > releases where the standard naming convention is used. I quite
> > > like having the "dpdk-stable" in the name, so perhaps as well as
> > > the regular tarball, could we also have a copy on the server
> > > called e.g. "dpdk-stable-17.11.3.tar.gz"?  
> 
> This is what the hook is doing:
> 
>     for ext in gz xz ; do
>         echo "generating tarball dpdk-$ver.tar.$ext..."
>         wget
> http://dpdk.org/browse/dpdk-stable/snapshot/dpdk-stable-$ver.tar.$ext
> mv -f dpdk-stable-$ver.tar.$ext /srv/rel/dpdk-$ver.tar.$ext done
>     echo "MD5 (to copy in HTML page)"
>     md5sum /srv/rel/dpdk-$ver.tar.xz
> 
> > It would be perfectly fine to me to have an additional copy of the
> > tarball, however all we maintainers do is push a tag, then the cgit
> > server does all the magic. The directory name I guess it's based on
> > the git root directory name on the server.
> > 
> > Thomas, any idea how to do what Bruce is asking?  
> 
> All is possible.
> 
> I am not in favor of having two copies with different names because it
> would bring more questions.
> 
> When listing tarballs, it is easier to have the same prefix for all:
> 	http://fast.dpdk.org/rel/
> 
> We could rename the directory inside the tarball but we would have
> a different checksum compared to the one in cgit:
> 	http://git.dpdk.org/dpdk-stable/refs/
> 
> Or we could change the prefix in cgit with repo.snapshot-prefix:
> 	https://git.zx2c4.com/cgit/tree/cgitrc.5.txt#n590
> However I guess it would change every old tarballs.
> 
> Opinions?

Hi,
I suggest to have the filename "dpdk-17.11.3.tar.xz" (so without
changing it) that extracts in a directory called "dpdk-17.11.3/" (by
changing the "snapshot-prefix" configuration in cgitrc). 

This will avoid copy & pastes when changing version from a stable to a
"master" release (that can lead to typos, for example in [1], or
hacks in order to support both the directory paths).

Thank you

[1]
https://github.com/openvswitch/ovs/commit/5e925cc#diff-7f20b7d93319bb633bf2173988183d64R91

      reply	other threads:[~2018-07-27 17:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-17 13:34 Richardson, Bruce
2018-07-23 17:07 ` Luca Boccassi
2018-07-24  9:12   ` Thomas Monjalon
2018-07-27 17:15     ` Timothy Redaelli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180727191511.72c35d46@redhat.com \
    --to=tredaelli@redhat.com \
    --cc=bluca@debian.org \
    --cc=bruce.richardson@intel.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).