From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id 179374C8C for ; Fri, 27 Jul 2018 19:15:14 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E2E574022905; Fri, 27 Jul 2018 17:15:12 +0000 (UTC) Received: from localhost (unknown [10.32.181.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1EAAC21568A1; Fri, 27 Jul 2018 17:15:11 +0000 (UTC) Date: Fri, 27 Jul 2018 19:15:11 +0200 From: Timothy Redaelli To: thomas@monjalon.net Cc: bruce.richardson@intel.com, bluca@debian.org, stable@dpdk.org Message-ID: <20180727191511.72c35d46@redhat.com> In-Reply-To: <5213154.30SCDzBaau@xps> References: <59AF69C657FD0841A61C55336867B5B072664923@IRSMSX103.ger.corp.intel.com> <1532365653.7624.9.camel@debian.org> <5213154.30SCDzBaau@xps> Organization: Red Hat MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 27 Jul 2018 17:15:13 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Fri, 27 Jul 2018 17:15:13 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'tredaelli@redhat.com' RCPT:'' Subject: Re: [dpdk-stable] filenames of DPDK stable packages X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Jul 2018 17:15:14 -0000 On Tue, 24 Jul 2018 11:12:56 +0200 thomas at monjalon.net (Thomas Monjalon) wrote: > Hi, > > 23/07/2018 19:07, Luca Boccassi: > > On Tue, 2018-07-17 at 13:34 +0000, Richardson, Bruce wrote: > > > Therefore a small ask - can we please provide a package for stable > > > releases where the standard naming convention is used. I quite > > > like having the "dpdk-stable" in the name, so perhaps as well as > > > the regular tarball, could we also have a copy on the server > > > called e.g. "dpdk-stable-17.11.3.tar.gz"? > > This is what the hook is doing: > > for ext in gz xz ; do > echo "generating tarball dpdk-$ver.tar.$ext..." > wget > http://dpdk.org/browse/dpdk-stable/snapshot/dpdk-stable-$ver.tar.$ext > mv -f dpdk-stable-$ver.tar.$ext /srv/rel/dpdk-$ver.tar.$ext done > echo "MD5 (to copy in HTML page)" > md5sum /srv/rel/dpdk-$ver.tar.xz > > > It would be perfectly fine to me to have an additional copy of the > > tarball, however all we maintainers do is push a tag, then the cgit > > server does all the magic. The directory name I guess it's based on > > the git root directory name on the server. > > > > Thomas, any idea how to do what Bruce is asking? > > All is possible. > > I am not in favor of having two copies with different names because it > would bring more questions. > > When listing tarballs, it is easier to have the same prefix for all: > http://fast.dpdk.org/rel/ > > We could rename the directory inside the tarball but we would have > a different checksum compared to the one in cgit: > http://git.dpdk.org/dpdk-stable/refs/ > > Or we could change the prefix in cgit with repo.snapshot-prefix: > https://git.zx2c4.com/cgit/tree/cgitrc.5.txt#n590 > However I guess it would change every old tarballs. > > Opinions? Hi, I suggest to have the filename "dpdk-17.11.3.tar.xz" (so without changing it) that extracts in a directory called "dpdk-17.11.3/" (by changing the "snapshot-prefix" configuration in cgitrc). This will avoid copy & pastes when changing version from a stable to a "master" release (that can lead to typos, for example in [1], or hacks in order to support both the directory paths). Thank you [1] https://github.com/openvswitch/ovs/commit/5e925cc#diff-7f20b7d93319bb633bf2173988183d64R91