From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 0C02223D for ; Mon, 30 Jul 2018 18:19:12 +0200 (CEST) Received: from 1.general.paelzer.uk.vpn ([10.172.196.172] helo=lap.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fkAs2-00009D-4U; Mon, 30 Jul 2018 16:18:06 +0000 From: Christian Ehrhardt To: Beilei Xing Cc: Qi Zhang , dpdk stable Date: Mon, 30 Jul 2018 18:13:02 +0200 Message-Id: <20180730161342.16566-137-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180730161342.16566-1-christian.ehrhardt@canonical.com> References: <20180730161342.16566-1-christian.ehrhardt@canonical.com> Subject: [dpdk-stable] patch 'net/i40e: fix setting TPID with AQ command' has been queued to stable release 18.05.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 16:19:12 -0000 Hi, FYI, your patch has been queued to stable release 18.05.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/01/18. So please shout if anyone has objections. Thanks. Christian Ehrhardt --- >>From 3abd2b301dcd554c44a0fa7bc6fd7c8231e59e37 Mon Sep 17 00:00:00 2001 From: Beilei Xing Date: Thu, 5 Jul 2018 15:03:08 +0800 Subject: [PATCH] net/i40e: fix setting TPID with AQ command [ upstream commit 2c99142384db1796e42209f5fc112c8babc402c0 ] TPID can be set by set_switch_config AdminQ command on new FW release. But find fail to set 0x88A8 on some NICs. According to the datasheet, Switch Tag value should not be identical to either the First Tag or Second Tag values. So set something other than common Ethertype for internal switching. Fixes: 73cd7d6dc8e1 ("net/i40e: use set switch AQ instead of register setting") Signed-off-by: Beilei Xing Acked-by: Qi Zhang --- drivers/net/i40e/i40e_ethdev.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 4b4f53b32..ee0781335 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -1236,6 +1236,13 @@ eth_i40e_dev_init(struct rte_eth_dev *dev, void *init_params __rte_unused) hw->bus.func = pci_dev->addr.function; hw->adapter_stopped = 0; + /* + * Switch Tag value should not be identical to either the First Tag + * or Second Tag values. So set something other than common Ethertype + * for internal switching. + */ + hw->switch_tag = 0xffff; + /* Check if need to support multi-driver */ i40e_support_multi_driver(dev); -- 2.17.1