From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 88DC923D for ; Mon, 30 Jul 2018 18:17:12 +0200 (CEST) Received: from 1.general.paelzer.uk.vpn ([10.172.196.172] helo=lap.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fkApl-00009D-Ph; Mon, 30 Jul 2018 16:15:45 +0000 From: Christian Ehrhardt To: Rasesh Mody Cc: dpdk stable Date: Mon, 30 Jul 2018 18:11:38 +0200 Message-Id: <20180730161342.16566-53-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180730161342.16566-1-christian.ehrhardt@canonical.com> References: <20180730161342.16566-1-christian.ehrhardt@canonical.com> Subject: [dpdk-stable] patch 'net/qede: remove primary MAC removal' has been queued to stable release 18.05.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 16:17:12 -0000 Hi, FYI, your patch has been queued to stable release 18.05.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/01/18. So please shout if anyone has objections. Thanks. Christian Ehrhardt --- >>From 030c48fb62f16475daeafe8ef49ef1c4ce0662d1 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Sat, 23 Jun 2018 14:20:33 -0700 Subject: [PATCH] net/qede: remove primary MAC removal [ upstream commit 475ff28951b69ce0c46514e8c6a6e8bfd91c5eb3 ] This was added to dev_stop when set MTU requested vport restart. We are not requiring vport restart any more with set MTU as it just needs vport to be inactive and doesn't need the port reconfigured. Fixes: d121a6b5f781 ("net/qede: fix VF MTU update") Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 8bbfa95e3..b726e89d1 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1355,9 +1355,6 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) /* Disable traffic */ ecore_hw_stop_fastpath(edev); /* TBD - loop */ - if (IS_PF(edev)) - qede_mac_addr_remove(eth_dev, 0); - DP_INFO(edev, "Device is stopped\n"); } @@ -2096,8 +2093,6 @@ int qede_update_mtu(struct rte_eth_dev *eth_dev, uint16_t mtu) goto err; /* Restore config lost due to vport stop */ - qede_mac_addr_set(eth_dev, &qdev->primary_mac); - if (eth_dev->data->promiscuous) qede_promiscuous_enable(eth_dev); else @@ -2526,9 +2521,6 @@ static int qede_set_mtu(struct rte_eth_dev *dev, uint16_t mtu) dev->data->dev_started = 0; qede_dev_stop(dev); restart = true; - } else { - if (IS_PF(edev)) - qede_mac_addr_remove(dev, 0); } rte_delay_ms(1000); qdev->mtu = mtu; -- 2.17.1