From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 0FC2F5B2C for ; Mon, 30 Jul 2018 18:15:53 +0200 (CEST) Received: from 1.general.paelzer.uk.vpn ([10.172.196.172] helo=lap.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fkApq-00009D-I0; Mon, 30 Jul 2018 16:15:50 +0000 From: Christian Ehrhardt To: Adrien Mazarguil Cc: Nelio Laranjeiro , dpdk stable Date: Mon, 30 Jul 2018 18:11:42 +0200 Message-Id: <20180730161342.16566-57-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180730161342.16566-1-christian.ehrhardt@canonical.com> References: <20180730161342.16566-1-christian.ehrhardt@canonical.com> Subject: [dpdk-stable] patch 'net/mlx5: fix invalid error check' has been queued to stable release 18.05.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 16:15:53 -0000 Hi, FYI, your patch has been queued to stable release 18.05.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/01/18. So please shout if anyone has objections. Thanks. Christian Ehrhardt --- >>From 64ba5b166d0a623d0bcc4d95733b0e9a75cc593e Mon Sep 17 00:00:00 2001 From: Adrien Mazarguil Date: Wed, 27 Jun 2018 11:20:52 +0200 Subject: [PATCH] net/mlx5: fix invalid error check [ upstream commit f264c7980ca5b5f574c5f4c93644daf702124e4d ] Since its return type is unsigned, if_nametoindex() returns 0 in case of error, never -1. Fixes: ccdcba53a3f4 ("net/mlx5: use Netlink to add/remove MAC addresses") Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5_ethdev.c index 90488af33..ebe5cb6e3 100644 --- a/drivers/net/mlx5/mlx5_ethdev.c +++ b/drivers/net/mlx5/mlx5_ethdev.c @@ -192,13 +192,13 @@ int mlx5_ifindex(const struct rte_eth_dev *dev) { char ifname[IF_NAMESIZE]; - int ret; + unsigned int ret; ret = mlx5_get_ifname(dev, &ifname); if (ret) return ret; ret = if_nametoindex(ifname); - if (ret == -1) { + if (ret == 0) { rte_errno = errno; return -rte_errno; } -- 2.17.1