From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 852875B38 for ; Mon, 30 Jul 2018 18:14:28 +0200 (CEST) Received: from 1.general.paelzer.uk.vpn ([10.172.196.172] helo=lap.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1fkAoW-00009D-EC; Mon, 30 Jul 2018 16:14:28 +0000 From: Christian Ehrhardt To: Shahed Shaikh Cc: dpdk stable Date: Mon, 30 Jul 2018 18:10:53 +0200 Message-Id: <20180730161342.16566-8-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20180730161342.16566-1-christian.ehrhardt@canonical.com> References: <20180730161342.16566-1-christian.ehrhardt@canonical.com> Subject: [dpdk-stable] patch 'net/qede: fix link change event notification' has been queued to stable release 18.05.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 16:14:28 -0000 Hi, FYI, your patch has been queued to stable release 18.05.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/01/18. So please shout if anyone has objections. Thanks. Christian Ehrhardt --- >>From 8beb51e90341197455739b1babf272d091c5e061 Mon Sep 17 00:00:00 2001 From: Shahed Shaikh Date: Thu, 7 Jun 2018 09:30:52 -0700 Subject: [PATCH] net/qede: fix link change event notification [ upstream commit cfab13aa93897524a4c8d4f6e30d91e7dd9e247b ] As per existing behavior, when firmware sends a link change notification, PMD only updates the link structure but does not notify applications about it. This results in application sending packets even when link status is down. Fix this issue by issuing RTE_ETH_EVENT_INTR_LSC. Fixes: ec94dbc57362 ("qede: add base driver") Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_main.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_main.c b/drivers/net/qede/qede_main.c index c3407fe94..de5a7ca80 100644 --- a/drivers/net/qede/qede_main.c +++ b/drivers/net/qede/qede_main.c @@ -634,8 +634,11 @@ void qed_link_update(struct ecore_hwfn *hwfn) { struct ecore_dev *edev = hwfn->p_dev; struct qede_dev *qdev = (struct qede_dev *)edev; + struct rte_eth_dev *dev = (struct rte_eth_dev *)qdev->ethdev; - qede_link_update((struct rte_eth_dev *)qdev->ethdev, 0); + if (!qede_link_update(dev, 0)) + _rte_eth_dev_callback_process(dev, + RTE_ETH_EVENT_INTR_LSC, NULL); } static int qed_drain(struct ecore_dev *edev) -- 2.17.1