From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 4EAFC4F9B; Wed, 1 Aug 2018 04:07:08 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2018 19:07:07 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,430,1526367600"; d="scan'208";a="59466365" Received: from debian.sh.intel.com (HELO debian) ([10.67.104.228]) by fmsmga008.fm.intel.com with ESMTP; 31 Jul 2018 19:07:06 -0700 Date: Wed, 1 Aug 2018 10:06:35 +0800 From: Tiwei Bie To: Maxime Coquelin Cc: zhihong.wang@intel.com, dev@dpdk.org, stable@dpdk.org Message-ID: <20180801020635.GA7165@debian> References: <20180730082804.20143-1-tiwei.bie@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [dpdk-stable] [PATCH] net/virtio-user: fix the param string X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 02:07:09 -0000 On Mon, Jul 30, 2018 at 10:43:37AM +0200, Maxime Coquelin wrote: > On 07/30/2018 10:28 AM, Tiwei Bie wrote: > > Add the missing param "server" to param string. > > Also add the missing spaces after params. > > > > Fixes: bd8f50a45d0f ("net/virtio-user: support server mode") > > Cc: stable@dpdk.org > > > > Signed-off-by: Tiwei Bie > > --- > > drivers/net/virtio/virtio_user_ethdev.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/virtio/virtio_user_ethdev.c b/drivers/net/virtio/virtio_user_ethdev.c > > index 5ee59d5e5..525d16cab 100644 > > --- a/drivers/net/virtio/virtio_user_ethdev.c > > +++ b/drivers/net/virtio/virtio_user_ethdev.c > > @@ -681,6 +681,7 @@ RTE_PMD_REGISTER_PARAM_STRING(net_virtio_user, > > "cq= " > > "queue_size= " > > "queues= " > > - "iface=" > > - "mrg_rxbuf=<0|1>" > > + "iface= " > > + "server=<0|1> " > > + "mrg_rxbuf=<0|1> " > > "in_order=<0|1>"); > > > > Reviewed-by: Maxime Coquelin Applied to dpdk-next-virtio/master, thanks.