From: Jens Freimann <jfreiman@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: tiwei.bie@intel.com, zhihong.wang@intel.com, dev@dpdk.org,
stable@dpdk.org
Subject: Re: [dpdk-stable] [PATCH v2] vhost: flush IOTLB cache on new mem table handling
Date: Fri, 3 Aug 2018 13:27:33 +0200 [thread overview]
Message-ID: <20180803112733.ukgxzxaxj7ght6j6@jenstp.localdomain> (raw)
In-Reply-To: <20180802172122.25923-1-maxime.coquelin@redhat.com>
On Thu, Aug 02, 2018 at 07:21:22PM +0200, Maxime Coquelin wrote:
>IOTLB entries contain the host virtual address of the guest
>pages. When receiving a new VHOST_USER_SET_MEM_TABLE request,
>the previous regions get unmapped, so the IOTLB entries, if any,
>will be invalid. It does cause the vhost-user process to
>segfault.
>
>This patch introduces a new function to flush the IOTLB cache,
>and call it as soon as the backend handles a VHOST_USER_SET_MEM
>request.
>
>Fixes: 69c90e98f483 ("vhost: enable IOMMU support")
>Cc: stable@dpdk.org
>
>Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
>---
>Changes since v1:
>- Fix indentation (Stephen)
>- Fix double iotlb-lock lock
>
> lib/librte_vhost/iotlb.c | 10 ++++++++--
> lib/librte_vhost/iotlb.h | 2 +-
> lib/librte_vhost/vhost_user.c | 5 +++++
> 3 files changed, 14 insertions(+), 3 deletions(-)
>
Reviewed-by: Jens Freimann <jfreimann@redhat.com>
prev parent reply other threads:[~2018-08-03 11:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 17:21 Maxime Coquelin
2018-08-03 2:30 ` Tiwei Bie
2018-08-03 7:54 ` Maxime Coquelin
2018-08-03 8:37 ` Tiwei Bie
2018-08-04 23:49 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
2018-08-03 11:27 ` Jens Freimann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803112733.ukgxzxaxj7ght6j6@jenstp.localdomain \
--to=jfreiman@redhat.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).