From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 518941B4AD for ; Mon, 6 Aug 2018 12:56:40 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id u12-v6so11928413wrr.4 for ; Mon, 06 Aug 2018 03:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=cky+6SmqZGbkmzQ10e4K8VAnw5X4odI8LbT8SGfDtLQ=; b=uUQRPAvyM29mn4BwhgddG/pGceMgky4/aMCJAWzReGSJzbzhMNZ2wxv24CYvCaeV1e BqdS4BPKZrm7p1RJQ9MZCwAZwsJZ5lvIdDI1WDWYBcz337DclwKemm0TMx30xKNvV3yb 9wecUeWQqPyOyStbQFmKFNMr0Ia5AnqTWhuEqj5Er6mTT3KxxcaiU25neySj++9Tf7S+ V7RUxGJSHsm/21RkHT5lfFea4AeFcLVgBfPTVWMrTBIwlWe3OOUn8+JTEaHm/Q9uRqfL P2ijLL5mL0q0UwFoPdp9meIUXeEANIVGj9B8vop3d/ZhN3Rc1hSqAd1MwJ8Sw2nSm1Qb +wHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=cky+6SmqZGbkmzQ10e4K8VAnw5X4odI8LbT8SGfDtLQ=; b=rKfF4i0BIWPUPNcbIZ8AadMtd3I9+VOpiKjlPONSulTcM8NM9UNbKLREFMIoMrE8S/ rKzhVsiig0Q2l4ZNSk+wfVX52i0VIvdRRq126bdNaBifY7BqetP08Q0PPkRaV0YLBAdM L/LrHJgLgoYbefQS1IpN+kOsD5NcJBO+aA81nsEHGEkkjbjxBpfDiTIynNSRN+iawHu6 +dfMhMeQrPIQ7XHrPk1+8WqFMgsNAsuRZ84BTpHEusTSK2cWLr/d1L9ebcHY7FdlDXs6 wxiyeCNkRsL82kjRQspONb1c4anFUIjxMzONTWBh3r0pqpQA7YulgAhi+J+CNdyHZV13 N1tQ== X-Gm-Message-State: AOUpUlG0MsFmthOYy9yjd/6QR3VWRVGEaIeIHDQkkR1d4P6rrmChghMo uz6JCRG7rTVx9yQQ8dEVw1dP82HK X-Google-Smtp-Source: AAOMgpf9p3Cg4+knF7gFT2lRFhOMttgQ5cDh5XzoChWYIJXAUGqUk99V4zZDXdtwcbnDoXwf/c1ohA== X-Received: by 2002:adf:b726:: with SMTP id l38-v6mr9468709wre.115.1533553000039; Mon, 06 Aug 2018 03:56:40 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:8361:8946:ba2b:d556]) by smtp.gmail.com with ESMTPSA id m200-v6sm7199646wma.32.2018.08.06.03.56.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 06 Aug 2018 03:56:39 -0700 (PDT) From: luca.boccassi@gmail.com To: Radu Nicolau Cc: Chas Williams , dpdk stable Date: Mon, 6 Aug 2018 11:56:18 +0100 Message-Id: <20180806105619.24253-9-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180806105619.24253-1-luca.boccassi@gmail.com> References: <20180727101748.30228-1-luca.boccassi@gmail.com> <20180806105619.24253-1-luca.boccassi@gmail.com> Subject: [dpdk-stable] patch 'net/bonding: fix race condition' has been queued to LTS release 16.11.8 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 Aug 2018 10:56:40 -0000 Hi, FYI, your patch has been queued to LTS release 16.11.8 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/08/18. So please shout if anyone has objections. Thanks. Luca Boccassi --- >>From 64463044f24ff88b30f153df2b9451698e8fafbc Mon Sep 17 00:00:00 2001 From: Radu Nicolau Date: Wed, 25 Jul 2018 10:39:40 +0100 Subject: [PATCH] net/bonding: fix race condition [ upstream commit 5922ff069fb910946f97780754ad4b66b987d5b6 ] Race condition can appear in the bond_mode_8023ad_periodic_cb() callback when bonding port is stopped, reconfigured and restarted. Re-ordered calls in bond_ethdev_start() to have callback alarm set after slave ports are reconfigured. Fixes: 2efb58cbab6e ("bond: new link bonding library") Signed-off-by: Radu Nicolau Acked-by: Chas Williams --- drivers/net/bonding/rte_eth_bond_pmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 5905c70707..6081918e79 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -1545,10 +1545,6 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev) } } - /* Update all slave devices MACs*/ - if (mac_address_slaves_update(eth_dev) != 0) - goto out_err; - /* If bonded device is configure in promiscuous mode then re-apply config */ if (internals->promiscuous_en) bond_ethdev_promiscuous_enable(eth_dev); @@ -1577,6 +1573,10 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev) (void *)&rte_eth_devices[internals->port_id]); } + /* Update all slave devices MACs*/ + if (mac_address_slaves_update(eth_dev) != 0) + goto out_err; + if (internals->user_defined_primary_port) bond_ethdev_primary_set(internals, internals->primary_port); -- 2.18.0