patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'test: fix code on report' has been queued to LTS release 17.11.4
Date: Mon, 13 Aug 2018 13:37:42 -0700	[thread overview]
Message-ID: <20180813203749.25171-2-yskoh@mellanox.com> (raw)
In-Reply-To: <20180813203749.25171-1-yskoh@mellanox.com>

Hi,

FYI, your patch has been queued to LTS release 17.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/15/18. So please
shout if anyone has objections.

Thanks.

Yongseok

---
>From 7357090c23be7060c1f2caad64517c7be326ecad Mon Sep 17 00:00:00 2001
From: Anatoly Burakov <anatoly.burakov@intel.com>
Date: Fri, 27 Jul 2018 10:40:12 +0100
Subject: [PATCH] test: fix code on report

[ upstream commit 5a6feec6c89aa657ad9d2568379da6d71d4433c3 ]

There are no reports defined for any test, so this codepath was
never triggered, but it's still wrong because it's referencing
variables that aren't there. Fix it by passing target into the
test function, and reference correct log variable.

Fixes: e2cc79b75d9f ("app: rework autotest.py")

Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 test/test/autotest_runner.py | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py
index 380d0589d..ff7a2653c 100644
--- a/test/test/autotest_runner.py
+++ b/test/test/autotest_runner.py
@@ -69,7 +69,7 @@ def wait_prompt(child):
 # quite a bit of effort to make it work).
 
 
-def run_test_group(cmdline, test_group):
+def run_test_group(cmdline, target, test_group):
     results = []
     child = None
     start_time = time.time()
@@ -156,14 +156,15 @@ def run_test_group(cmdline, test_group):
             # make a note when the test was finished
             end_time = time.time()
 
+            log = logfile.getvalue()
+
             # append test data to the result tuple
-            result += (test["Name"], end_time - start_time,
-                       logfile.getvalue())
+            result += (test["Name"], end_time - start_time, log)
 
             # call report function, if any defined, and supply it with
             # target and complete log for test run
             if test["Report"]:
-                report = test["Report"](self.target, log)
+                report = test["Report"](target, log)
 
                 # append report to results tuple
                 result += (report,)
@@ -371,6 +372,7 @@ class AutotestRunner:
             for test_group in self.parallel_test_groups:
                 result = pool.apply_async(run_test_group,
                                           [self.__get_cmdline(test_group),
+                                           self.target,
                                            test_group])
                 results.append(result)
 
@@ -395,7 +397,7 @@ class AutotestRunner:
             # run non_parallel tests. they are run one by one, synchronously
             for test_group in self.non_parallel_test_groups:
                 group_result = run_test_group(
-                    self.__get_cmdline(test_group), test_group)
+                    self.__get_cmdline(test_group), self.target, test_group)
 
                 self.__process_results(group_result)
 
-- 
2.11.0

  reply	other threads:[~2018-08-13 20:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13 20:37 [dpdk-stable] patch 'test: fix result printing' " Yongseok Koh
2018-08-13 20:37 ` Yongseok Koh [this message]
2018-08-13 20:37 ` [dpdk-stable] patch 'test: make autotest runner python 2/3 compliant' " Yongseok Koh
2018-08-13 20:37 ` [dpdk-stable] patch 'test: print autotest categories' " Yongseok Koh
2018-08-13 20:37 ` [dpdk-stable] patch 'test: improve filtering' " Yongseok Koh
2018-08-13 20:37 ` [dpdk-stable] patch 'mk: update targets for classified tests' " Yongseok Koh
2018-08-13 20:37 ` [dpdk-stable] patch 'mk: remove unnecessary test rules' " Yongseok Koh
2018-08-13 20:37 ` [dpdk-stable] patch 'test: fix uninitialized port configuration' " Yongseok Koh
2018-08-13 20:37 ` [dpdk-stable] patch 'app/testpmd: fix DCB config' " Yongseok Koh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180813203749.25171-2-yskoh@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=anatoly.burakov@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).