From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR02-VE1-obe.outbound.protection.outlook.com (mail-eopbgr20087.outbound.protection.outlook.com [40.107.2.87]) by dpdk.org (Postfix) with ESMTP id A7A762661 for ; Mon, 13 Aug 2018 22:38:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VO7f/Zbl0wLj5oxRL+x5/beVDPaVMTNZGQpKi1haDps=; b=GvamCL5pmY8A8uKqmn2dtUbypRyHs8c/hSwXlpFIURo4WsUd6vsO2l8R1GqKTMs9j/Ilw9kUtRSHFy/FQWAp4dCn+zWkBJC9FyfmvQuA53pn3DNJxkq9vKIobMoUWYWPV9fXi2QjRy9LtiAQuBE5snrAc2YcXlztpqKBcd0ele0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by VI1PR0502MB3984.eurprd05.prod.outlook.com (2603:10a6:803:24::26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.22; Mon, 13 Aug 2018 20:38:05 +0000 From: Yongseok Koh To: Anatoly Burakov Cc: dpdk stable Date: Mon, 13 Aug 2018 13:37:42 -0700 Message-Id: <20180813203749.25171-2-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180813203749.25171-1-yskoh@mellanox.com> References: <20180813203749.25171-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: DM5PR2001CA0017.namprd20.prod.outlook.com (2603:10b6:4:16::27) To VI1PR0502MB3984.eurprd05.prod.outlook.com (2603:10a6:803:24::26) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7775950c-faae-47ba-6022-08d6015cac5f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0502MB3984; X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3984; 3:MY2MtjqmHaw10ionCT/O/yM2zeIxLYbc9AmBgy+aAflwDzm91S0it17k/V3YIvLsJ/N3Rc2ePMWOPOpo7frXugii74oUpQGhzYNztfgTRoHCCdqUo7xDEVa/lhvZ8D7sZ93tjfKzxf9qFldIC7ox5Fgvmx2hFm1Ep+POegE+TTsaVJEwNRms6HeG/B+hH5QzFVXNhmropFn6up037HO9vmiVc5VoytHMWMh3FViJKqr4FAGXenpFYr5bLyzJ4AqH; 25:o9WkOaAyShibn3e4JbC0CBfGDLLCPzc/1mdK9p9Ao7wp7oljzgCczs9zLG9gscxfGwB74uAudeyyndpBSLRxuA62+IYf/eXxQh0x1vJCbw7HKZbqyZlhIvHANz2YJYQfDuLb4tiCF61JWy3iCk0miOcgahXoiOvMDNDI90sSmE7GDdDbWyUYZSPWqc/63WTSiDaARIyGmj6vscgIdWeBayzr0utbH/F+x+fdpggK8SrOxrJ0lMQrgq58waebsy/7uzL3KG0nj2VGyeNsEW1b6Lc7Wh6L+LTYutMr7LfsAeJtGf+FAwdFMwr8ZA1LZKWgBgh6nMF1SISwAnIsYt/eFQ==; 31:4goYFBY0llzviLsXY+xRdqPE074w1AemR04qKSjGK01vqSz/SjhMtssoi3vn5lL0szV3ilnwtQxXWVut4w8dGEU4kkA7fensPtrhf6RCiRqNCVBeooE5efqq6JiHy7m14J0BZiePuDYwS8J9BpT/I7B1QQhk7l0Kr8UnuidbJ3cnlCwm2bMmYKMUSPTj8MhAAgKE3cy47UkluRL91U/cTrOZhjHCodbCq2kHfLFGOZA= X-MS-TrafficTypeDiagnostic: VI1PR0502MB3984: X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3984; 20:NPs9zj75yU7fOjP+Ch0XPQOpKF1rvEKynmv/DilpuSk0kSXO/asBTXM/szhWNE17ux64iaoxcc3VjNZSKanOOP0XO1/yHZOhacozPKvjUu4Leoe/Q0UdorGid1axTHOSiUCKVoBCreFsnfl4K3aJToB6vHw658UtYzJk3PPTrUFjl0mwA18eKVsPyjBvLUlcTmqIWPFFBvnu9FwzCg0q67kLxW7mp6SRuwmZ/ZsWjJMZXGzbGXKZgpZNMisvLW6YUD/qWz0ZoJwKDUkaD3NtSjw6RFRZlC/cLLanULi++aSWDlJX1s2sw1gNqTNFIpDqglcXQWlwMToHITUShRMY/XA0lUocM44OYbkmW+hyMZKP8h4wztfrOPl3bR3dwYeeAIBYy8wNMuNH7fRd5Qq3dKcLDLCxfsB8Jd0Yf/dTR+Zso5OGU+yxaz+M6OfuY9LEOEmWkR5auVGVhZhu9nWj/Tp/7wKfnlQjnXx0Am+t5VLiHHhR+eBQxI23TySu/ASf; 4:MZUrVg/MRvDGw0UWBZBzIiiev6YtGjQNpPklOEv3LX9qEnNC6KI4jPYoohjxNsHhsHiC9KJZrzcT0UMzIo9gdDuqz6sC9J+C/gVAlJoicE4DNbbv71W+A8t14ymvwEcO1ViLQHIHPgzBfgH1XrkuVjpwECcquAvIKpQ7Oo6gKN2aQjVcflFaUYdxx0aTVawJXXzXScoy9nfw3vw0hWEPMxlaiuDjU2BpZNBjGzMco3487QMuOFrIJetTA+/RXd8PM8V08XJIySMI9WqxranYbCPjHnM5qd5IQgrg044uWeSYTbOcm+R8bX7Xh0hNihBbAoblWcB+SnPN58H5MXtdozRNjECj/dKR1krhp0Lvwl4= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(20558992708506)(228905959029699); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:VI1PR0502MB3984; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0502MB3984; X-Forefront-PRVS: 07630F72AD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(346002)(376002)(136003)(39860400002)(396003)(28163001)(189003)(199004)(69234005)(3846002)(5660300001)(186003)(6116002)(305945005)(86362001)(16526019)(6666003)(8676002)(81156014)(97736004)(25786009)(8936002)(106356001)(66066001)(105586002)(4326008)(966005)(50226002)(81166006)(1076002)(6916009)(47776003)(48376002)(11346002)(68736007)(51416003)(7736002)(52116002)(2616005)(7696005)(478600001)(476003)(486006)(956004)(76176011)(69596002)(2906002)(1720100001)(26005)(316002)(6306002)(55016002)(53936002)(50466002)(53376002)(16586007)(21086003)(446003)(53546011)(36756003)(386003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0502MB3984; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR0502MB3984; 23:jPj+MfIJS+NzY/OQupbCrnDgprCwV6KKK+ps8Re?= =?us-ascii?Q?8iH42c6Uc2o/arYMCPFVq8DzPoyT9eop1rAp9r/DUuk8L0hON5d69P9+LqiL?= =?us-ascii?Q?lzFF1YspR24gZBX8fM9wmIf28VtrO1AQ0cmxXzAmbnw+LClqcNx+DIVFH979?= =?us-ascii?Q?a2eKAzVt2Avfwe3klGBKNiEpSqYj+f5k0vcC3t3V2q/MvvPtojAP4bjehgZH?= =?us-ascii?Q?6IqYQ1K6YlIlZ3qQ5RidSZivTkydQ3Zolp6qYWgus7P6pUkEP4r95vJqy7Af?= =?us-ascii?Q?0uWvSCVJb1Mo5j3fD9tJcc7zo6pwXij5mPzMaXUrjbCzT1rHrSYa0g6/CnnZ?= =?us-ascii?Q?dTPRJVGxlbq2D+8aW/sIQF3rV1kJV+Xpvxzi7ozoCxHYnaeDFEBQ6vCu3rTN?= =?us-ascii?Q?10jovEPPg1m79wDpWwvN6tmCZFxqS1uMcPLR2gXKqC4Gah3MmIWQfPlD1tRI?= =?us-ascii?Q?I6Z9zGl7aidyLJBGupum5xsyqycdjg5FQEP0gfVu6NQnflRTKk7GTWeDy3si?= =?us-ascii?Q?txRl9rScp1sy1KPXmtFvS7xOMQqf7AHwXBtIAqKncbPG97wBoYKzucvyII3F?= =?us-ascii?Q?iZffRw1pmubXy46vWCtpAOcjXGTcwy0tf4O+A/3IrplA1DzwA98W9aNPXv3g?= =?us-ascii?Q?v5yqtCP755ex36xEkPv1xXjuB/oAUSldLhWKw2KWXLtOi7o66zFQuhH5DVwM?= =?us-ascii?Q?1TSCeg7nQNDTJwry5vVX3683a2KdR2GTGEs05RuEwXIH2SuF6JKIfuerpSku?= =?us-ascii?Q?ipdIvjNuzVHYKcZ5XLYWjYtizEKuusPWBgNJbcX25KzlFOXPDbnPlcM5lYnm?= =?us-ascii?Q?xf/HIQtjDUbP93NNwhxqDfoDEkI+W3IEcGxQCQjCDXKKnUTNbDinoha51oe0?= =?us-ascii?Q?9e4825MKbSnQ+XMajTasTJSDizLSf1BRa1ZXNA88iTiX7bFiO6zsiu2xmVE6?= =?us-ascii?Q?mOOLnPB6uLrr9U+LqfEnFF7/pzxMZAuXjq3xLIRsklS4VNPKmHXv4nEfrm8F?= =?us-ascii?Q?bIHfv6UQTFVzhLcbAcvwl4mDhb+xmkMKfeqJltY+S64Q1U1uUrwPf7BT34i2?= =?us-ascii?Q?FQsiFHKGXmMymvYwK13IUj1+k1N7WWKEea+ahURWWBYeSbI6UyQNhHSopN5a?= =?us-ascii?Q?RTdLXLOUo62HKb2x2exLg0n2UT15r7wn/2SbnACSQmgCvCnoYwGC9YKtLME3?= =?us-ascii?Q?gsGjVMhIUjeRZt2cA1h4gWZ3RWLtE86PAsHYeM3kTza0AnuScnRLqBSdPKdy?= =?us-ascii?Q?z7vQ2w6mHrAZjuD7kWgpKb17Qh00olnoo8NhETn9stFhYp9MKRBguXYMxK8t?= =?us-ascii?Q?ovn/S8jqawLpQL7mxkVacv/tUdaMASPsePsB7gQ1tyZqiQIe5x1WbauAlp5T?= =?us-ascii?Q?Bipb+Pw=3D=3D?= X-Microsoft-Antispam-Message-Info: 4ABbHDYhRhEO2UAbXAiGX3+nJM2gMiGOKfk0bTku9Y1SuIlRORC/9dGdDLd6l7aKDNJJEFfy4q8F7p3MKTwisB+2B/WhvMkA6o6OB9Hqa0OQGVVH6zWdobDogX97uBDBaEeLi9Mxpev+l/qXLvM2UIZuaip+muXyjoHYSA7sgEfOSgVDpODbKyVa4tMQr3m+ARCI0ZilFehzfrViMnIYh+mQU4Unvd2hV0GH66zmm85t0UCn0UU57899dCicYvxTHREBqPPfquml/Bw3OosDbpawgxCaCEwyMfJ69Gx2lpSHvjCTfZ5H76ODswk0HWvwoI57NsfmsnMArSpYMxde4tv4rSClmRBfNpwhkLilQTc= X-Microsoft-Exchange-Diagnostics: 1; VI1PR0502MB3984; 6:fbhYNeUPVu1LjcaA/gFBgOo17JUAQOoD1i6RqT2ECjv9JMf+7j0y8oKUF43ERL6QEN/TNw6xPfE8qwb7RchCOVSoPcp9fPqGAcOpDYmZYSiqmuibpm9ZUuu8pnoaVv2/rpR/BPC7SOnYJIDLbvQGsJhd8ySeFPT0/HIi2oByhfL0QK6h/Ni82IYGwGXiHUEuFcF4UP4NHeToMQGuhwSv1Mtp8lR4fvZ+hboIfN4k4K5tYB4WdDSkT/uMcJ8sFHfHjIkusmm+6iNMRskjrdAkdEe9caVlKtkQ1hY9t0eFNbIHe3NV/aVZ9HpvSrf593IKiYD70ZVp7MSKS0MpXxbaoQUu7QGaabW/mDaf35zi1IC5xZN1S8PJMvPTXUUoc6AK/jwzQ8BH3oxMthpNhoMfhnytDXbUET2agxENL4VXaEagoU0E8Tuol5hZZlZttjUfM3lYOlX5FwdsVcsFcQYfLg==; 5:0XqHH0QH6KkEaRNJUJ6Es2o+njrb7zO0MRm+/+84vRUvEXcL5cgMR7F+0CEFx8qzLyO8f4tobkfHKpN2/vdBzGUM/nPsUPEP0qdmMKJBuUrL9qhfspKC61LLvjncWTv84TDLD7vBrRQ0jIRxDNATnnH98vIWCCqa0T5DeSkj7jU=; 7:pkB4t9fopgxy/oqvbH9mZNzEZ8AZwi3C1tb+yDOijj+jje5CMCv/pJ1uad3pC/xSg6Hst6ChgnzLo8cXu+VLUkZO5vW8p51R95YdC1WHLCih+BVc6xiWoy5s+5e2tC3XnQPXHeeYDpdQB5QqQA9L04SMyC8jrXwqtZyxmymfAXdUAsakkNG+gW50oz59FQmwlSiz/rrDaU2Ffan703kPNl5YCZ24CNYkdExFxhNyK6ru6LSBImWkYtArRb9eqdSl SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2018 20:38:05.1460 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7775950c-faae-47ba-6022-08d6015cac5f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0502MB3984 Subject: [dpdk-stable] patch 'test: fix code on report' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 20:38:06 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/15/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 7357090c23be7060c1f2caad64517c7be326ecad Mon Sep 17 00:00:00 2001 From: Anatoly Burakov Date: Fri, 27 Jul 2018 10:40:12 +0100 Subject: [PATCH] test: fix code on report [ upstream commit 5a6feec6c89aa657ad9d2568379da6d71d4433c3 ] There are no reports defined for any test, so this codepath was never triggered, but it's still wrong because it's referencing variables that aren't there. Fix it by passing target into the test function, and reference correct log variable. Fixes: e2cc79b75d9f ("app: rework autotest.py") Signed-off-by: Anatoly Burakov --- test/test/autotest_runner.py | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/test/test/autotest_runner.py b/test/test/autotest_runner.py index 380d0589d..ff7a2653c 100644 --- a/test/test/autotest_runner.py +++ b/test/test/autotest_runner.py @@ -69,7 +69,7 @@ def wait_prompt(child): # quite a bit of effort to make it work). -def run_test_group(cmdline, test_group): +def run_test_group(cmdline, target, test_group): results = [] child = None start_time = time.time() @@ -156,14 +156,15 @@ def run_test_group(cmdline, test_group): # make a note when the test was finished end_time = time.time() + log = logfile.getvalue() + # append test data to the result tuple - result += (test["Name"], end_time - start_time, - logfile.getvalue()) + result += (test["Name"], end_time - start_time, log) # call report function, if any defined, and supply it with # target and complete log for test run if test["Report"]: - report = test["Report"](self.target, log) + report = test["Report"](target, log) # append report to results tuple result += (report,) @@ -371,6 +372,7 @@ class AutotestRunner: for test_group in self.parallel_test_groups: result = pool.apply_async(run_test_group, [self.__get_cmdline(test_group), + self.target, test_group]) results.append(result) @@ -395,7 +397,7 @@ class AutotestRunner: # run non_parallel tests. they are run one by one, synchronously for test_group in self.non_parallel_test_groups: group_result = run_test_group( - self.__get_cmdline(test_group), test_group) + self.__get_cmdline(test_group), self.target, test_group) self.__process_results(group_result) -- 2.11.0