From: Yongseok Koh <yskoh@mellanox.com>
To: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Cc: Jerin Jacob <jerin.jacob@caviumnetworks.com>,
dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/octeontx: fix stop clearing Rx/Tx functions' has been queued to LTS release 17.11.4
Date: Mon, 13 Aug 2018 13:40:01 -0700 [thread overview]
Message-ID: <20180813204010.25281-1-yskoh@mellanox.com> (raw)
Hi,
FYI, your patch has been queued to LTS release 17.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/15/18. So please
shout if anyone has objections.
Thanks.
Yongseok
---
>From f6c78aecd8f42f951eaba2263d24b20511202f76 Mon Sep 17 00:00:00 2001
From: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Date: Tue, 24 Jul 2018 16:13:50 +0530
Subject: [PATCH] net/octeontx: fix stop clearing Rx/Tx functions
[ upstream commit efb9dd148e234aecd01966cd1d2aaa4b75836966 ]
On dev_stop the Rx/Tx_burst functions are being set to NULL, this causes
a SEGFAULT in cases where control path calls stop and a paket is still
being processed by a worker.
Instead clear the fastpath functions in dev_close.
Fixes: da6c687471a3 ("net/octeontx: add start and stop support")
Signed-off-by: Pavan Nikhilesh <pbhagavatula@caviumnetworks.com>
Acked-by: Jerin Jacob <jerin.jacob@caviumnetworks.com>
---
drivers/net/octeontx/octeontx_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c
index 33c6e78e6..13dfbbc04 100644
--- a/drivers/net/octeontx/octeontx_ethdev.c
+++ b/drivers/net/octeontx/octeontx_ethdev.c
@@ -377,6 +377,9 @@ octeontx_dev_close(struct rte_eth_dev *dev)
rte_free(txq);
}
+
+ dev->tx_pkt_burst = NULL;
+ dev->rx_pkt_burst = NULL;
}
static int
@@ -470,9 +473,6 @@ octeontx_dev_stop(struct rte_eth_dev *dev)
ret);
return;
}
-
- dev->tx_pkt_burst = NULL;
- dev->rx_pkt_burst = NULL;
}
static void
--
2.11.0
next reply other threads:[~2018-08-13 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 20:40 Yongseok Koh [this message]
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: fix filter freeing' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: fix memory leaks in NVM commands' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: fix lock release on NVM write failure' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: check access denied for HWRM commands' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: fix RETA size' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/qede: fix interrupt handler unregister' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/qede/base: fix GRC attention callback' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/qede: fix MAC address removal failure message' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnx2x: fix FW command timeout during stop' " Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813204010.25281-1-yskoh@mellanox.com \
--to=yskoh@mellanox.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=pbhagavatula@caviumnetworks.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).