From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30056.outbound.protection.outlook.com [40.107.3.56]) by dpdk.org (Postfix) with ESMTP id C51262661 for ; Mon, 13 Aug 2018 22:40:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SnKnDCAuXuPn+EoT+P216BOsOTU6Zrpx3LobkFaq0m8=; b=UIjhrjNoozL6M+VtuFwsCbNeC1gaNJ9uJRipJjTEaykwRCy/z7APzTs+Qjt1XwOmyboLap1V1dppN2VNu4MmoJRUQ2Dr6wIDyJqpZwiUBgOZy3wZ4vTZdojhQJOFs//DhlDTi8FiSOipJy9JrekNVZPB/6LKCAMsO/vCvqHlwSw= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by DB3PR0502MB3977.eurprd05.prod.outlook.com (2603:10a6:8:10::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.19; Mon, 13 Aug 2018 20:40:30 +0000 From: Yongseok Koh To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk stable Date: Mon, 13 Aug 2018 13:40:01 -0700 Message-Id: <20180813204010.25281-1-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BN6PR2001CA0042.namprd20.prod.outlook.com (2603:10b6:405:16::28) To DB3PR0502MB3977.eurprd05.prod.outlook.com (2603:10a6:8:10::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 983ab7df-800c-4107-5f47-08d6015d0344 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3977; X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 3:JkC6mkZ3hxedvgs98/soTlh1j5hYTeIJlbjVgw9JNoBqde/7zZR8hAOeYSTKxK39UcP8hXduqxBI0/a9UOqyeEV/aVkwFtOVmFvH/f4wt7XFOqBGx2fXxbx8dquVuawB47DsPt5/j5iXZsq7Y2MqjaUscZTDxhEYgcADvAhHX92ARLsno7k7L6mfbzSIrJ7phac+e7/gpQCazsodyh7uX19D7n+TonHjFWjz/YxwwQwSVYFgui7zgUsfTAIq8ybf; 25:o+RQfkFl8rYaKFeRPdqm7c4ckijfTx7/Sy62fahl7B4X6bkaI8ZtpKZq6Lk0i3r+SX3Av9t023suCFMJ5O4XMbFSsp3CjBWnNf8s1NrF4owSTvOZjNL7lobSHvIWjX9kqxAWRJgG0fGKBSi/fGBhxUO7b4b0WI5CreReOISmUbUK04Co/1z1XNGpeGgUd151xnSbU7e89UQrEoPfc7OtheHjfIa8/m24wpHTbkaRIszqnbqtZkjw3ZBq8IGbdYE7Lu6pyIYp1ZWdSK/2ah4AmLCOHiXpWjOW6o38TY9koM8wx4wLRWom2XYVmNve2ga3fjnd6Z6L1YUmT99y+G4l4g==; 31:j1y2FTOScNSmyEHR7pR9ilMlfCH5+4jL6U6dkylQJNniSLy2lyX4zJ7QAQYaXqPrdJ4BQk661RTPh/gNjb/Lzgg1v2i/ragCJyCzmX9T1EVLDT8K5GPmskPnad9S8pza8W7uBokSKIWk8n0tgVgHkrly5eyqxP6+oySQIrzH4U7gR2KBFBwcUJSkZqQg7Rqu+d1GRYl908plWr32aEjyTa0A92ygDlH33XApb8cJkxE= X-MS-TrafficTypeDiagnostic: DB3PR0502MB3977: X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 20:r90eieeZf1VxFPX4Y8as1ILnyHf42GBRwM6oabPzfM5usT7zWLGc71osmrVle536XnMCSv94WStqH1pf1t+kTr1dtPWF1ebw2t437axpglvc53kc8EsK3uS4ZjOghCwStus08tALVMWhy1GncKBb9O2ox9LpTyOtwrF5Qmnj7q2HfTDhOG4tpQIZoLWnTVeczAJuj+ezaBtRbtI7VXklYuuSQsAUDTwNUc3Rkz5tnkP8a6so1W/gzsVm4VmOVMRACRlIfq0ixldBL3d86hmTDBokJZz+eBV1edPFTq0AGVhNfPQ5qYA/8AMg+NrqilzJ6bzB1rmHn5hnmJ7JecMpMeyd8j/anI93GzF717J3a5l2BU/LsjWfPO1+EKHEN5O96qWEzcwqXIkqps+o4dO0B6M3U6DYym4CmJ6vwHL623pLwnfcJvof0JVsfQ74wN+nCPHNDrg56vg9jBblSAJpofGTC1nFvGVbKBsmardQZEzM0qDfmGoN9BKfbY/7Y0bL; 4:my3fS6C+EqezrEQPL6bkRQ32mrgGKXx6EZIMxto9q5vvnMzrhbCnQcde8imuPdKuseBm/1z6hjSuvBU7GYUs9gkXQ3aCEze04IfxpmsA20ODxSHkxhmDR3qupV1mOs/XdpaywTRmJ9wNpzsVTZljj4fs1Cl5TE8n/BI38d/Veu40KcbKhuEKP3P6Qs3176RxkDmtZf5JNojevha2ZOiYEAZtaYTbzODxCK9EyDPGcnyxxXoiTjejxhU6oy3a6aKB0pHN4GEh1GBqQt/vpC0R/w== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB3PR0502MB3977; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3977; X-Forefront-PRVS: 07630F72AD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(979002)(376002)(136003)(346002)(396003)(366004)(39860400002)(69234005)(28163001)(189003)(199004)(4326008)(6666003)(6916009)(7736002)(47776003)(50226002)(25786009)(105586002)(26005)(53376002)(6306002)(48376002)(69596002)(86362001)(53936002)(8676002)(14444005)(81166006)(966005)(81156014)(16526019)(305945005)(186003)(66066001)(68736007)(21086003)(386003)(1720100001)(7696005)(52116002)(51416003)(106356001)(1076002)(50466002)(6116002)(55016002)(2906002)(3846002)(16586007)(486006)(5660300001)(316002)(54906003)(36756003)(53546011)(956004)(8936002)(478600001)(476003)(97736004)(2616005)(969003)(989001)(999001)(1009001)(1019001); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3977; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB3PR0502MB3977; 23:awKZ77HMiu0D7qz8Gn7I/WP3vRlA3UjKHYb2g2q?= =?us-ascii?Q?AmGUyv8ljkwL/8Dc/EWv954AW7bff6DJQ6CKhgj9ubcgazOirWoUOJHCIjLN?= =?us-ascii?Q?1Wz0BcVe1lx/kK0yG46OiP9HMLbSMi1Rnj0KXebgSyy9pzFxIuL6HgKRLQYw?= =?us-ascii?Q?nyo0N3zAXbYOUn0/RnTTjvAZzXX7552YcxZtvdQbFsHW0pE6CqQPMJuF0IwQ?= =?us-ascii?Q?xwBOXJ4TqXFy0NIZcp0DDLFs+32yQQqa4X/taevdbzxMfWlb442R+9uB7aLJ?= =?us-ascii?Q?1s6Jp8h0zi27gRkkS7hNe7SVeBJ88UfblSBaIizmg3m9LArwr9EZIkxi4dt7?= =?us-ascii?Q?36ArHBjyT7c0sl7bdv5JPlu66fIhrAOSOLKIrGiOC1sZQ/zYu4ZMTpeJeZ1q?= =?us-ascii?Q?ZEza9t5UgCkp/xByKCuCtc5YMkl7jxbN4VRgK4rOYxCsrjay3xZxJyJ/Lw/y?= =?us-ascii?Q?2Qr0xZWZ9DaJQeuaTUEEJO6vtS/Ry33wAdxatJwsAdcttxjxI1fgoXec4uph?= =?us-ascii?Q?UkT89pL+dt//I20e0AbiFyXVaRLEd8X/pwQYw/gFcWixZlcnVYwE1Olqqndz?= =?us-ascii?Q?xcYtiDxhFLicWmjhfhuryLl4oDxAgsHyrRUeHKxs9Z+5svDTun0er6GPwIXs?= =?us-ascii?Q?bDO+az9xQUmYOexoB1DRou/QANh0F61By8O9sHTBn3oZVELRACHrijDDZ8Og?= =?us-ascii?Q?h7xI1LXvqWoSqqhjy+uNDb8K+38EucDWFpMbqGpyL8e7ZVGmfXEnRsYaX4FD?= =?us-ascii?Q?9mlNSSYZ6tJxgXOGvVUu39U04hFgcnWD4mNb7Y7b7L7LFG9iTaIJsVoMPtOs?= =?us-ascii?Q?fFbaacLlrLANF3uxnjMMSiTFvVaqkLQ1NRorg6qzQ+/LQKKIp367jc6YqtZH?= =?us-ascii?Q?4qhiGUjCV8XCqS15KlF9b1/wwBDJCFCyz1lMynKfTN70n4cAZqNVwc8onMq0?= =?us-ascii?Q?38wtrn96JxNec7HSMikEmmTnKlvPHSfwUy+72A5TbcDPYQCHrWHphFZ92FIo?= =?us-ascii?Q?Fr3aa3se/9G+CEzu6rhoSbjKl5F89lXZH6cg6td6fKXF1+tIdzhEa1AcaRQV?= =?us-ascii?Q?hdgPmB94VhZWVHNYAfQGoxlsu34s7zh8cdxDUulg3IK23yOaFQJTfAcbeRf4?= =?us-ascii?Q?4kJGOBnLooske+6Mf05bTkUCMIYM3TVWJgtisJXOy2/6k8Z+HQqxBtOpsnKI?= =?us-ascii?Q?T+pcWx2f7WdvAjsyD1Ey444JGZ1aMz/UvJjO4Wq/OoM17mt7dad63rsS6fHn?= =?us-ascii?Q?7PJ9xPCGN2iau93GEZN8vxuRsIn75n6Kqbn2dKo6f8bc+h/Svy050IMr7adg?= =?us-ascii?Q?rYbkI+pfv03GWs+tUxxG3xvZTs3TEx8SLhkq1JSjO5l3fk1Wqc0WvoL9FlGp?= =?us-ascii?Q?ATkK4nqVSGpkeY7BAKF+iFUzmfEeM+qVKUMFd9S7xERPyeOEmqrA3fI03QTc?= =?us-ascii?Q?2tE2PuSVEPxs+2xc3YiEa6eFx1aRJ/Q4=3D?= X-Microsoft-Antispam-Message-Info: ZtY9CmjqoheIgW0wNHBAQLpPGbiUGRxnui2xUZDX/E1d2MljxDWHFUOVkqyg8HNPG5bXXBbafZmivCJ4/kQjmtx7LqmOWlENvrj1mknX266brieaFFHNzKdIHVk4niSMMMz1Vje5/3Fju2QXRjVcrAZER2pUma1cL2CTjso2KLTo/8IH4bfou5SmDsTaG26BxPdxxhmGu+4EcEnmVZLFNwUTo8myiKc+8IlGzavDfAfSb7KS+5aZOOGuUPjn3nFPqyMYNH83t8RhgksrqnBUVj07Ibg03HO6C8vP0tiRFQbVWaCPfS0ehzg78iZ5/OFNqXywd3otnieILoDc8sHwPR6dUWbxAG5sCLzC8/MJkow= X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 6:2Vqo8Naf3fYCgpJTNhZ075Ry8G8qbMKKNp2m2sNksj7g93vHdcIMKS7Smngx/xW+3E+3MbyXf/E3Bi32maIQeiEvFrK6sdKANhVWu/tJOXrYSQJWB5S4sh9nPBhEsRCoxtepRyFOPL9VI2OxcWsSJrEq6Klfx+E1dROl4N7p1Hi4/Nf4BCKj+w6s3rR7nieISHHNu6sGwuPHSeU4slUaxO7GVsW0Ll5BuA4xw7X4x8+8Nqrrd7zgFO7A3Yr+ONG8y/rDgowWKB9REvb4YrhdP2XBMrsBr96TtXXxQZegU5fcGHvJYtic0FWMAkhGtRIuG0ddTfHJJaUCEWzngBVn+ZQqhFSIc652spaI2+sL5InBjKMN1J+RdQ+VZ3moN7AV43Ti5lduc4MGuAOVPQSXS0derS42D/ih6Jul3JAD7K2wpWKNk7aS3OKFEv0scSj6VeTM3vHlnaomfwAa/9tEyw==; 5:IZtGU/FQSljr6fuN2g90QWIIYDjVzDavc7zrwH085/zAcfXGvyhcbIfhANPu78WKlushpNhxboID3s5D300WEOrV6/LWaD8zSGZl6qLCljoNyYOvVV52A345mDQ2tSMfkSWQbntg5YiAftODWLmmKBFmPk6UBlG11/+4VOwtTdo=; 7:49j2kubTdTrIOLJtIbe4zFvD5h40ikJqYDN/51YcdhZUnyfMtYJKsqTW5hcLNDV/YJEcVCntU4KseBWERLDPCK8wHUO17U8hd+wI4SELifYkYzqSMAev15kBPYTTTNgqLnkY2obr1I3gJWt1HWwq/BCgB8NxqWjSJhgRxy8XnU0/CrUftBuoPyA5QzOZg8azUWQyGljjkjUTXHz2woqhYmWnLgWwB8oqXrWp58oBdznnS45piuIjeUpP3ckwmdcP SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2018 20:40:30.7705 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 983ab7df-800c-4107-5f47-08d6015d0344 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3977 Subject: [dpdk-stable] patch 'net/octeontx: fix stop clearing Rx/Tx functions' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 20:40:34 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/15/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From f6c78aecd8f42f951eaba2263d24b20511202f76 Mon Sep 17 00:00:00 2001 From: Pavan Nikhilesh Date: Tue, 24 Jul 2018 16:13:50 +0530 Subject: [PATCH] net/octeontx: fix stop clearing Rx/Tx functions [ upstream commit efb9dd148e234aecd01966cd1d2aaa4b75836966 ] On dev_stop the Rx/Tx_burst functions are being set to NULL, this causes a SEGFAULT in cases where control path calls stop and a paket is still being processed by a worker. Instead clear the fastpath functions in dev_close. Fixes: da6c687471a3 ("net/octeontx: add start and stop support") Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- drivers/net/octeontx/octeontx_ethdev.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/octeontx/octeontx_ethdev.c b/drivers/net/octeontx/octeontx_ethdev.c index 33c6e78e6..13dfbbc04 100644 --- a/drivers/net/octeontx/octeontx_ethdev.c +++ b/drivers/net/octeontx/octeontx_ethdev.c @@ -377,6 +377,9 @@ octeontx_dev_close(struct rte_eth_dev *dev) rte_free(txq); } + + dev->tx_pkt_burst = NULL; + dev->rx_pkt_burst = NULL; } static int @@ -470,9 +473,6 @@ octeontx_dev_stop(struct rte_eth_dev *dev) ret); return; } - - dev->tx_pkt_burst = NULL; - dev->rx_pkt_burst = NULL; } static void -- 2.11.0