From: Yongseok Koh <yskoh@mellanox.com>
To: Ajit Khaparde <ajit.khaparde@broadcom.com>
Cc: Randy Schacher <stuart.schacher@broadcom.com>,
dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/bnxt: fix lock release on NVM write failure' has been queued to LTS release 17.11.4
Date: Mon, 13 Aug 2018 13:40:04 -0700 [thread overview]
Message-ID: <20180813204010.25281-4-yskoh@mellanox.com> (raw)
In-Reply-To: <20180813204010.25281-1-yskoh@mellanox.com>
Hi,
FYI, your patch has been queued to LTS release 17.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/15/18. So please
shout if anyone has objections.
Thanks.
Yongseok
---
>From 063f7f0b46368f58da1a2d6e08dddfb999dfb393 Mon Sep 17 00:00:00 2001
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Wed, 25 Jul 2018 18:15:46 -0700
Subject: [PATCH] net/bnxt: fix lock release on NVM write failure
[ upstream commit 4623c0d4b572e9bea28d59e6e54ae6d5dab2412e ]
In bnxt_hwrm_flash_nvram, before attempting to allocate a buffer
we are grabbing the rte_spinlock. And if the allocation fails we
are returning before releasing the spinlock. We avoid the situation
by calling HWRM_PREP which grabs the lock after the buffer is
allocated successfully.
Fixes: 19e6af01bb36 ("net/bnxt: support get/set EEPROM")
Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Randy Schacher <stuart.schacher@broadcom.com>
---
drivers/net/bnxt/bnxt_hwrm.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index ce66dc53e..fa8f1faca 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -3180,14 +3180,6 @@ int bnxt_hwrm_flash_nvram(struct bnxt *bp, uint16_t dir_type,
rte_iova_t dma_handle;
uint8_t *buf;
- HWRM_PREP(req, NVM_WRITE);
-
- req.dir_type = rte_cpu_to_le_16(dir_type);
- req.dir_ordinal = rte_cpu_to_le_16(dir_ordinal);
- req.dir_ext = rte_cpu_to_le_16(dir_ext);
- req.dir_attr = rte_cpu_to_le_16(dir_attr);
- req.dir_data_length = rte_cpu_to_le_32(data_len);
-
buf = rte_malloc("nvm_write", data_len, 0);
rte_mem_lock_page(buf);
if (!buf)
@@ -3200,6 +3192,14 @@ int bnxt_hwrm_flash_nvram(struct bnxt *bp, uint16_t dir_type,
return -ENOMEM;
}
memcpy(buf, data, data_len);
+
+ HWRM_PREP(req, NVM_WRITE);
+
+ req.dir_type = rte_cpu_to_le_16(dir_type);
+ req.dir_ordinal = rte_cpu_to_le_16(dir_ordinal);
+ req.dir_ext = rte_cpu_to_le_16(dir_ext);
+ req.dir_attr = rte_cpu_to_le_16(dir_attr);
+ req.dir_data_length = rte_cpu_to_le_32(data_len);
req.host_src_addr = rte_cpu_to_le_64(dma_handle);
rc = bnxt_hwrm_send_message(bp, &req, sizeof(req));
--
2.11.0
next prev parent reply other threads:[~2018-08-13 20:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 20:40 [dpdk-stable] patch 'net/octeontx: fix stop clearing Rx/Tx functions' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: fix filter freeing' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: fix memory leaks in NVM commands' " Yongseok Koh
2018-08-13 20:40 ` Yongseok Koh [this message]
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: check access denied for HWRM " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: fix RETA size' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/qede: fix interrupt handler unregister' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/qede/base: fix GRC attention callback' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/qede: fix MAC address removal failure message' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnx2x: fix FW command timeout during stop' " Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813204010.25281-4-yskoh@mellanox.com \
--to=yskoh@mellanox.com \
--cc=ajit.khaparde@broadcom.com \
--cc=stable@dpdk.org \
--cc=stuart.schacher@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).