From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30062.outbound.protection.outlook.com [40.107.3.62]) by dpdk.org (Postfix) with ESMTP id 162FF2661 for ; Mon, 13 Aug 2018 22:40:39 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x/pm0xNv+Y/kvou2qIKZC+r36L+dd0JvQibZtswBBSc=; b=rxfQ7Wn8awP3Wj3fCANGx95qR8urDMavP4iqh0N+eVyb53bQesjCtR8g4y2dyeW6Ocs74cH5YVBxjIMzgbnvjQh1q8rdHILrnPmT+VtgvVxPvbbX/eaXAxu+XVWWVSlzjUW/BjdzEFeWTro5xpklCrdQvECao1vPUjp31IdYM+0= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by DB3PR0502MB3977.eurprd05.prod.outlook.com (2603:10a6:8:10::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.19; Mon, 13 Aug 2018 20:40:37 +0000 From: Yongseok Koh To: Ajit Khaparde Cc: dpdk stable Date: Mon, 13 Aug 2018 13:40:05 -0700 Message-Id: <20180813204010.25281-5-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180813204010.25281-1-yskoh@mellanox.com> References: <20180813204010.25281-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BN6PR2001CA0042.namprd20.prod.outlook.com (2603:10b6:405:16::28) To DB3PR0502MB3977.eurprd05.prod.outlook.com (2603:10a6:8:10::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 4017919c-210c-449e-0286-08d6015d0701 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3977; X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 3:sO9akHkGw2UVqp1ZJK3P2AhxRlg53zUwMTxxNLKR2sL0fGcFKFeJgZ4Onn+SBjJ40BVBu91H+5fdqgzXRjVhxu7IT0pAIwn7NXmCIl5sDmDzn1CPpv87nwZyczppGLrD+BQ4cRPzrUa1iXIAip4EV/tzThrlwLR+PshdgxQ7yRdGMUmDdG1BjTmkZzI61fHlk3HMpaT0cUAujxX8F+5Xe4cfmjmp+Q+4PQtpfLAfdBV3G7P00NguQlPq4GJntl8A; 25:oVLqZg00FZJT5rLDSzXowgBf+fZGeoRpU4DFYpbh8TFQRdB9Uz83YiJ6O8MaN7Hg7vFRBXQqMh/3CR6ge23Kk0jaQFNdQTphrOqnbdISstGw/Uz2f861GPWGMTP35RUg/Ej27+wQFtoygu8lXQKp2ONWJ3gqi3nxcCoDrsT44AdV+iKq+YqdRaYP5J7O55SK+ZyZSEfV20iMzi0jphxgeeU6CkJHiv/kbNU/M8oTEegnqYcjiXsXLLft8KlVmtclXk2rqVCGm5kTA2WH1ZRiLWnpuLmmL6gfLCoH/8jTqCJdpAvcwilmvCzYp+t3sEqKsA4f7yDG2LHt4d1Yyd1eTg==; 31:Bcfpzi757WGfosqwPpHRBz+hjqedGJt5NkLaiq4fhRLk4GA/wuVI7iZJv4ZMzK46YXWiAjJ4ieYS8KtPBtw4EEPnFucvBgguE2jvbedng1B0PTAgV20dp1UvozzY+hBruebnS2C3fgJFGxdIh78f+owburQedU2mtwHaCZcjToD9cVhFb/MbNkpcOmzmiqjzD0HW4Qjdk5odVpHFUsQVyOLduYg6dyAJe/Sb+JsK/Ek= X-MS-TrafficTypeDiagnostic: DB3PR0502MB3977: X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 20:KIbaVPE0irQLpUoRwx3cVcIm2J+JOYyz29Vc3E16JIFmrFTulyf6PoUOERbRK4F13S6uXQ823qm9n2TKomgUdtV/Ms7PB9PP4MCS8d7mxx2P+F9WjU3a3bpwajYcG2oCmQ3QNk2vufguo3ngas6HO7fwmdcn7Lt/QvRJGoxzqTFOl46zVqIqAriDlSjrvxF9LDVmhzAVgBmxH91PZgLXkYKwV4C0dI04Tk55M3DYGuE9RGeYkhAsK3TBF4/L+GEz/iz0+hSMsIlMTfLenR4TSvdtGwibHoYK88IZyouHlYjq8czMrcAw05u7f7FKBfZWng/0dFH3GW4UBYsEfgMaRbPcBpeurioX8XuqiVutiYboOzwHIn8YmCUlvTDci3T0JcSapBdmxDF0uylZEvW7ZSekwugHa7NLxPB1D6VCmUHNgUob81Ws17XPrE+Mz6CR+dWFqu8GJk0Se6Ncn9Wgy6cRAKp/W8n6zjeDwpnOcrwKGMjGEKVJdScncf5QY39t; 4:poT2Ip/uMJIJseFcMje7hdTlN7ZBygW99N/Z51BJGtA8bBpbH0G8vzh8ISWHMYRucU+hBBZkKokJP4sDpt/c/n2VtNDQysV30mV+8/Tn/RHmDk2+XkR91VCLxtlpACmjpOHF+89bNlZutBScK44clA80K0BzT5qDq3KGRI6pEo5XpBeeiwjkMHbG3UJK8RGxBvR13ZnlnAXVUw4GZwm/xwBPYCYl0n6bPKlLtQXUyStaLD0eYVXCyvGK1xc7JVEGWNZ7Gh3shgxKqJguU5QNaVSmE1itQLvKwwP8kZQTDXty9U2Hp+9jnP1iBwDuFLDn X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(208715162771679); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB3PR0502MB3977; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3977; X-Forefront-PRVS: 07630F72AD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(136003)(346002)(396003)(366004)(39860400002)(69234005)(28163001)(189003)(199004)(4326008)(6666003)(6916009)(7736002)(47776003)(50226002)(25786009)(105586002)(26005)(446003)(53376002)(6306002)(48376002)(69596002)(86362001)(53936002)(8676002)(14444005)(81166006)(966005)(81156014)(16526019)(305945005)(186003)(66066001)(68736007)(21086003)(386003)(1720100001)(7696005)(52116002)(51416003)(106356001)(1076002)(50466002)(6116002)(55016002)(2906002)(3846002)(16586007)(486006)(5660300001)(316002)(36756003)(76176011)(53546011)(956004)(8936002)(478600001)(476003)(97736004)(11346002)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3977; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB3PR0502MB3977; 23:wtM8JDzL0RCTjhHULk+KSbl1shh5hbsZlqkzf1d?= =?us-ascii?Q?0TRP0joH+F7YQPH+izAScz34Xt+wPxTuHZkenEMBOOq8Hk5k/eZLaaUJV+pU?= =?us-ascii?Q?gjJchQPoZLk93j07IuQQUdQ4m2BEqV9D2oPq8LcvENmnN/av/2XV9tDcq7no?= =?us-ascii?Q?yKhG7Yh32bY1cNlgtM09beK4w8eCW9Sj9XwRsSpxUdRNRL1M1Zrfnc6s9K51?= =?us-ascii?Q?ucQsEoKJZpKjoPw0AltxbEdZiY2e0+1LgHWcjQFQvo8alNWzzkl/TPbeNueu?= =?us-ascii?Q?NWzBGmgQ7O55s40R6VJgXLfur/1E4r7SgUji/NUTjfbw5GDUZk89g/2vGkWn?= =?us-ascii?Q?WB9jdkvvBTTt0gdzjA5px+e0LZa74NdbZUfNNzAJAktb0RxdY57AoSMY214M?= =?us-ascii?Q?PIQjqiMFfTsA9g+kLdhMjKpqfecJtXjpb/i9Q71CUBmlZRMbkP2g8vx5yJ2Y?= =?us-ascii?Q?dR3TS9RwO+uYOUigsuA1ubCzobX+m8TCGIZ4evbjiEvMBrQ/gV5GztlxlkQX?= =?us-ascii?Q?1FpPbbD960GJ/+xPT17PO2THfY/YlUjj81DklLiFruRMioD7Q7EqMssSfvLv?= =?us-ascii?Q?VWpmymh3RByIb2pcXbFow+H6VyCWqnfy7tQppMlYA6O9W+K+7qkxIl7FSIiU?= =?us-ascii?Q?3Vznx+VdXJ0D5+WcQt78uZJ/NVA/qSwWcV78LnWngYJbqCTOO0XlcSWoCoWk?= =?us-ascii?Q?goNzIMK8qyCSSKDLU2I4kaxosRE+15yikA8quJmHgcXcGrNiqGh3ye/qNk9g?= =?us-ascii?Q?P9UHvUW97CPH4deMuzkdKWZmwY/waACCcdonOUmUY02n25k0K4rcYdu1WzuD?= =?us-ascii?Q?PvslsQRkKnk9vbdZlrxDu7WDPkRLiryedEDkm5EY6csul+nN51rC5sVOn9J/?= =?us-ascii?Q?GmrF9JRgEU9qbqnuo0OBx3crIgQ3gta9pIKY5S5Q2j6Gpgjx2/ZKDUmsFG4T?= =?us-ascii?Q?wJg74OAdJ+CYW4FLABgv7XXyAuaq2+7ZUWmsE/Qo9cpW0e6LQZFXREyPGbQf?= =?us-ascii?Q?lKBcnlN8VvnX3rUF9ZZC1Q/S14aH8R9LvjXH1RuvOFMi//w7G4bw3xzEWI5w?= =?us-ascii?Q?vZlafyHGKbgeCXjqRUKHX/nVmL15Obwo2X9ZgazuklSV/cX+obMELV+A5xby?= =?us-ascii?Q?twU8R0tRLATxtwNVTdReUICcl2HFghmScopyMLuIlesk5JgR3jaGCkEVU5Bd?= =?us-ascii?Q?20V2Oo8Wp5jn9Nlp6Fu6Iyp0ui0FnEQP4GGFCoZPdu2IAjrg7CuIq50JR0Og?= =?us-ascii?Q?O9yqGTpratldzPCl2gY13tMl8bK6ydt/U2O4amfqWWqpNaYaMTayaD2qegHH?= =?us-ascii?Q?Z0XM5Q8KqTuzjYinPjgqR/ySwnFwJOuuKpnLRi4dqaVfyqalTUwXYb74si1A?= =?us-ascii?Q?M2c8KJIert1PMbSJNwMnH2u/XG/k=3D?= X-Microsoft-Antispam-Message-Info: vVbbRyf/W3BIut77dGO3SGIqXteZjAWCzeHxY0CTJEEvqDB2wbWXFrx9ge6jzJQSZOjfoJsrQedVmj/t6FTZ/aCqvc4P6hUNOWyn6OD5DLjcg2Linbfb8vdJSKi95GvkxlKrXblUdrBnbnPei1ouOhINwEv6E1CHK0zMSwThAoEVn3dy+8iJRmGj98M+2C2TdV5C11K8oYXiDLoY0SExJqNhVPpuB0fNhl8ipIMQ4YWAR97c7Y6Ajkl0uAj0JSMYyGmIfs1HqxI9a5xQr3yiBJ17jAjBvT5b12IZDbfVJkA9KR8QuOrf9LkMu9mBjSfEYStUjmAA4t0rq5jm8ORxuy73kWPQ24mpbgh1PhTkNOQ= X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 6:iNOHK9YPUgIPQHFXHUIbx/XqAb6f2F7HO/+x9w41M9IQ1huVwJRnuPw5yQVOFoJv3wv6wQrnPES7x/AZXTY0Qpxie37dYxgmp9MH4suad0Xd4ZgBFFWz3VGg1UD48FOBwCoGZBJGGovRsMo9sjnbQY3/tpigQj6ooOAYxSGa8v2kE1kbeH3IKRQtPEF/ZLdenGzebr/l1rRuSbr9btQeJyZAgp1Ch5rGWOqmjWdQtw+2dqLZxy3XEk14Fmzirr7A1b8tpnp43VlucfSE9bgfIgentUQzqeZlNDU345xrCbwxcthWrmw9q2tDG3Z3Ca/c5nJLNK91k+I3aTZDKF7U8Sq6aaJZhtEoEXKRvwsMeirxe3EDkxHtDSznkiJgn8OaKQMzt0AWwkrlMgajECZF14Pa106TSJq62l1qvCx4MPInG/H4F/rZetgCl+cSI00ioPFoUz4qn670x4YUrxlPyQ==; 5:EfS+hbq9EXjiyX3uRRXJve9wliRkOw0p/Zts5DTiSqZbCF2L1jNzvwdQJViZjxPt6tJe+GT5HG2AhhRXI94bIHaLgMbsv/dIABoVfKKK5FsX/nGlXotOaoTVryrBzNiZCZN0BxFHYQEWZu6n6wVnBvzBHGCvC++1bA95xSY+eY8=; 7:CuwWi3iT0PashF1//JGZTP9fRe/sVb0AgaKoBfL0a+XY00qok67maO15woNf2tOr8svx10+ztMbsFL2ypycabLlut4Uri4rQq0/wETh4wTDjLnGHPrMJHwZoSOnLBB1Pjwp/D28mOg5KNx+hrTRq5f44IbeSA/mzRTL3UAMEK1ImU0SJqPvVTYvG53eEcunotahvrlMtpoycyYSTwVNoyameXtG+tLRRFrK4kLzwGR/rwUjo56SOSdUP9JcFE2PJ SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2018 20:40:37.2120 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 4017919c-210c-449e-0286-08d6015d0701 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3977 Subject: [dpdk-stable] patch 'net/bnxt: check access denied for HWRM commands' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 20:40:39 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/15/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From e6af6f16d45dca27115526bd6201a6c658bf6d2c Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Wed, 25 Jul 2018 18:15:47 -0700 Subject: [PATCH] net/bnxt: check access denied for HWRM commands [ upstream commit 6dc875ab5ff76377376906aa6d05d95ffd34b9f9 ] Firmware can restrict access to certain resources in the hardware depending on various factors. In such cases when the PMD tries to configure these resources the firmware will return HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED error. Parse this and return the standard EACCES error to the applications. Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index fa8f1faca..db3222f4e 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -197,6 +197,10 @@ err_ret: RTE_LOG(ERR, PMD, "%s failed rc:%d\n", \ __func__, rc); \ rte_spinlock_unlock(&bp->hwrm_lock); \ + if (rc == HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED) \ + rc = -EACCES; \ + else if (rc > 0) \ + rc = -EINVAL; \ return rc; \ } \ if (resp->error_code) { \ @@ -218,6 +222,10 @@ err_ret: "%s error %d\n", __func__, rc); \ } \ rte_spinlock_unlock(&bp->hwrm_lock); \ + if (rc == HWRM_ERR_CODE_RESOURCE_ACCESS_DENIED) \ + rc = -EACCES; \ + else if (rc > 0) \ + rc = -EINVAL; \ return rc; \ } \ } while (0) -- 2.11.0