From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30060.outbound.protection.outlook.com [40.107.3.60]) by dpdk.org (Postfix) with ESMTP id 4CC182661 for ; Mon, 13 Aug 2018 22:40:42 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=j9YHakM2Wk3RdZAUlQgn0P0RfSBnSNiaXDuSOleY6uA=; b=ZhRllcP+ctYW93RvEbzrwBCwBSezjVXGyqXic6k+1u2vBWT6R9cofyRdsiSj2TqXlkQKjraBMsIXUeRhq9dMj0OML90OpJl0dbaqc0MhbgILF42mJud1MYcoT0gQtY2dN9rq8opVC0MHC8lOJVuQ5Q6ni1XUW8wNCSwbKhbXchk= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by DB3PR0502MB3977.eurprd05.prod.outlook.com (2603:10a6:8:10::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.19; Mon, 13 Aug 2018 20:40:40 +0000 From: Yongseok Koh To: Shahed Shaikh Cc: dpdk stable Date: Mon, 13 Aug 2018 13:40:07 -0700 Message-Id: <20180813204010.25281-7-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180813204010.25281-1-yskoh@mellanox.com> References: <20180813204010.25281-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BN6PR2001CA0042.namprd20.prod.outlook.com (2603:10b6:405:16::28) To DB3PR0502MB3977.eurprd05.prod.outlook.com (2603:10a6:8:10::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8059ae1d-c01f-4f44-7eb9-08d6015d0906 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3977; X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 3:OA+x1k/XkXGBmfryzIQbH0YTtqI9HoGpw4QL2Po+iHXIFKUyXAmmn7Oth8n+xwKN++cQ4WId/Xuiycn9gFLp4zJges7C9MpLsoJIbxC9z5XVq9znk9Jb1RZgv1mqxoT5dgxo/4EMqY/WWCzd0o+2uXWzontDt4LXIPZUenlfsDyfrFbVUHVSTFtU6Qah2yIb8PCMRcrNXKvd1WFBEpc+HhiecHFbQzRTw9T47sb1xeXjhIvMP8C1LRA5dgru7Qy6; 25:3JHLbZJFEVT5weenzA0NayhdkSYOtnEu5ml6V8T5LSLOZyLrU3FO8QQoIPNuRgoX6NFTPcOqFzzh+kv9GzHMpGoxkF0ldwlKrsVwpsFw8+UvkjbMcwpWgD3glPFpQIAKvrpMvscsF3MtAQgSCYlTL/pZdcKojqv5CsVkcg89baU4+05E5UGTY5wGxkBG+JHehyCT4d9jDWv+elPT7JYPBRQjVzdAHhgOpfFha0my2kBQ2z4xUdQjEd9eC68DABp0prtlH0LiXgpKJ8Twu2ecp5tsmKRtRUtvJVmJImNLuTpZb95zDGmDKcZokg2O+Q38w8e0ZxhqgQajAs/w2jJPBw==; 31:w1G23WCH/yyQw+kgL8oIJ8GGg3/Ty7K3t9nlFNbzzZhGW9OUX2T9jowzlK0HEeliuG0o3bzU/H+sbIt0qP9ukbEGbrCcwjdYM/p1JqcvaH8wQY/rOma1uUT0ML98akE4LfhPNfHUou8s4ZG4juUVTO/cIo5iZNvY+kKGxE/QCqEz5Fjnk7gDQdFoZZNO3AJVSqi2xT6TiegbCdbqxecd1LVR4X1EY8HxUzbh1lP50lU= X-MS-TrafficTypeDiagnostic: DB3PR0502MB3977: X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 20:GKkOlPwn9UnK1nwvTBezdanHnq9Fn2ZteV40cLIsUoTSzAn8B4GH5OylhTUzmvQhUABie+R/DjRqPSO9zlUuay6odBOZvpU6MznmGJKsaXHMAFYvC19J9ffayuojjXcaP6mVfIQRej2kwk6nx/ntl0RhC7B5DfTJelyzOst3Uh9AfddtvcNXt177pHkGz16S2I0jk5i1odPVwgotyVQiO4UErt9WN/uZ9OHr+RwFVHUObbGxvGQBdzDbuynCKSCQ2+wAc8BW/6kqtllzqGvVngvygv3qmLjquofXdOgNPq/4W01D5TU3AnkRRdtVVLhn25deL6ZN4nIYCR8CPuZgRXHYmBr1CdXinK9pMcYmpKtZt5hS6nVmFlsnQh9sLzCZY/lm6+bKFcn+azvqkvSSqruHruugVBgk/QU8Zi04wctH0cnkkAqTcGKVHYK0Mqxl5DZNiekKyVdAR3u9lhq+zpsKM9A38pORmqIM/tWmyxnEQpgioyRjYfIzORvfEG4p; 4:vJt7NPH1qmNDOvvujHRsTX4BqNuzuou+YZ5woi1Ve+arqpHUYltE8UrsYi9vYWVErHDKIcXFa1VUbU2CZxR9hFiiGqMLCOYfM5L89qS1gbXfp3pF9yyFXJndL3lgrgYXO9syUW2wt3vYtoYLF/pYcZipJL4oq6iBSlRgvAFp6e3M3fRf+40J5YvccyGNl0h5p97+CUepwRGZV0zSPxwkg08gNGX9NC9lL6PDKFV0GOxZ21SjGojzJPZ6zbrf1cHTy44EpCWV7V9rYqesDcrmVQ== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB3PR0502MB3977; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3977; X-Forefront-PRVS: 07630F72AD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(136003)(346002)(396003)(366004)(39860400002)(69234005)(28163001)(189003)(199004)(4326008)(6666003)(6916009)(7736002)(47776003)(50226002)(25786009)(105586002)(26005)(446003)(53376002)(6306002)(48376002)(69596002)(575784001)(86362001)(53936002)(8676002)(14444005)(81166006)(966005)(81156014)(16526019)(305945005)(186003)(66066001)(68736007)(21086003)(386003)(1720100001)(7696005)(52116002)(51416003)(106356001)(1076002)(50466002)(6116002)(55016002)(2906002)(3846002)(16586007)(486006)(5660300001)(316002)(36756003)(76176011)(53546011)(956004)(8936002)(478600001)(476003)(97736004)(11346002)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3977; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB3PR0502MB3977; 23:bUdefgS+3hXVDgS/VyfFvHz1A0ebaxWU3BxSVdr?= =?us-ascii?Q?XhkQwlPtmZJeHOplk9HKUvAV0cLOXruaP67RXYBNbw7ZHLnamCn7gyQf3DIu?= =?us-ascii?Q?h7/kP1N5z9SA41qagvGadvhzMd1wi9SYVcZTwCsk1ubrIAT7iAesmL/2jxfK?= =?us-ascii?Q?z+e/VPQPvwqxFLjH0ua2KoITroeOMFNiwHVBh78upvbag00TS7if/Py1HG+J?= =?us-ascii?Q?5zNhZycXMZVLUmtAEBmlrjGGxrxnWOo6IQFcrCGOaT9fI5pBwT7TcFlCEHHg?= =?us-ascii?Q?xDMtXtmaMcM3jGMnr/+LJSZ3wLt2sa7KUo7ALtU0SP/tVI97NFX8bIllboXN?= =?us-ascii?Q?4s3ELAXXbDVHAVZK6qXl19F5PGDdy0D3saBD9aitYcykROQorfUSc23w+dbj?= =?us-ascii?Q?X1nhAoexWhuarVwpcqbKkhyH4Q3yzoflWDSdxV5Hxuv72cGsikVXU+VRSWWp?= =?us-ascii?Q?kxe7Lcs1aHYelFDkX1o/h++oOlx17X7f0J2RV37DBXCiFvgcoxPrbDeZohrN?= =?us-ascii?Q?Oln3AV+XvFWKY4Rqmu9YEcwAcnH7lDMCyyE75RBo9gs3+1Ol/aHNnqfvQfIO?= =?us-ascii?Q?zYj7XUVCl5ih4cDbZDaLtgp6g+aV3HdJ5UV6A3RYo10ebMKV9b3i5RcVNp4g?= =?us-ascii?Q?UCrT7WLQrfoT3biI7cA0kK3THPRw05gXb1IWKCDjTzwS3PKrjuvUwPIwMdkb?= =?us-ascii?Q?1jgVbLJWh15f7oUGPIeae3czzm+lzxaP70h3HiQea85l1N4FQqF3mrxMareH?= =?us-ascii?Q?XnDrCBv5ynzAIMzuOGRtGjIIoByaZgdIHaF9AOZazeSuoUAkuKnv886bUvk9?= =?us-ascii?Q?WAr67+D5Dg8HsrtA0H0G7xtJM3LVfsXbc/6RgYhumf6HDBuZd2Y0ER+iQiZr?= =?us-ascii?Q?HrqEemNHdzg/iM5ol4HlXaOOOiw8mVOxxCAkDZrOXvDX7sFM16K134dLSEyZ?= =?us-ascii?Q?yF1WuHx4qXkCEy09WUMKWVRDqZl7a0gmL/u6EQCMaKDumXsyRDMMkQLRFE2N?= =?us-ascii?Q?Apw7I98SZb7kLdNxZeGoGOrWbXVS776AyM1iAUqW3kipBKEvKrVYOllOymyE?= =?us-ascii?Q?MPhDhwHqV+yHFQNibxSka28kwEpXYTBAf1MBEIX0LeUtCpS5x4Wjg3xRATfb?= =?us-ascii?Q?4BJSjQRmb6PJeCadSDM6wyOgELNV2HL6MBQK150EOl/piqajJs5gDXHvSrzE?= =?us-ascii?Q?ilkTtsf+xciaMUpXzc0MpfbtFa3zEQz2ySbyEWCA7SzkdY0rYMje7UgBGKre?= =?us-ascii?Q?EMPMwsWxfV95Uikc5Aqx5LttPRzNXOO0LGTuSFuuA8Nq/SoLcHIQ7vuU/oXu?= =?us-ascii?Q?vD6xjUMQDAyey/jtDojR3q1oJ3QVsBcaFJd0IazR+L3l83q8wK0NwH/1Do69?= =?us-ascii?Q?FuEZx2fCmtzx5kiHnkMBS7K7KXoBG4rUpojLxDp/edDQS+ejb?= X-Microsoft-Antispam-Message-Info: QoPBvAoRbSuI+J0nfSIhsGBI+MqWqrsu4ioqTItBfYHg5xHKchNJWIRKoh5mc1+qQ2TZq2Y7hUBgXNuBM+4ORoow0bzZLtHRP35kTd2jTiO8kwl3pI+hD0v331fjuJhztqOYtJ93zij0gWkmbiK/L1dCMM9JmY2unIZ6hmDikT0CDcqNqPM4Ts/Uf8b+jBghaTkms9a8hApUCTOenf9IJ3YeJKx9yViMQZLTEcJbIgucf7hYtsCTIcarrw4zViFbAAzAVpxFmCXH4kxYNsSx1kHlCRbA7l0eSmBQ8MKcjPTWRbZ3qlosB2qYlravpGut6HUqK2ykfkVBUPdijKcR4TExcYMU/un+qxrSim73Niw= X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 6:01Jx4OOuawyNuA885Lhcl9XzDYY+WasH/EMlI3o9FZ2u26ocR1GVaviw/wD3CGVahi84jq9RWt2F6FBZfUnN99ct02T/zKFTeATbfZsyJpshuXyXEFVRePWT6WvxRevb2Svpmi/h2xmJPZef6Z4V0CtOviUaHso3RQT94wP+DKW0B6nqWvgveeF1h7+i+rFfkAqdOs8HpNIJPi/kEVBKrQJYp9KIlucPeeo30wsPEmT3BjGMef25yroTemY+Qe1s1o81VHPZbom3L0srrg5g7veazcZ8NmxcmbJvDGyT2vdoQjjqSlUzTuqvTSlruhO1cLR6L7jXlMY/Xl44C7dExq5K8Eiqxdv4L1pfVQZHcUE+RWUYlFv7G9q4sHB6+WP93WCLPWIoRZnbfCv3ENxZY5U+z/DrmZByypNKmZS8y6YIFKcWf0+lA/nUc12wZrG+sV/1crtNfbqVLhHlNsnIUQ==; 5:Z5Zf+EGHbkszdKVqzZIoGFNBFcXUuI77je+Kzs5xqc59rrnuuysKTroFjh3tabqy7F5MsEcKqboiQtX/MoX3rdovbUJt7z1rtHBQkUGRxQXqtNth4Bx9OFA76MkyEHHLAhgyvc4XdQj128uDgaQ8wYNUIWnqaYzdarAWwRT43cs=; 7:eVcv+ljFkmPhjhtEV2H3uzKx1AqJmh1VpMaYLs4Z21YZ9WfKk867ELvJIqnoa2yXziqhw0VGUzPSFX+6kjfBaqQ3VONPMj442Jw3xecHZp77AaUpcMqL6zdyezsWFVC+SYciV4NwWkcTHwMpSAyr2BdWJ3+gB0iRW/dxKGv2kUgHtbdR15kc6RG0UkAzxS7ONeb/FvkTAiihYUYJZrAVmo/rR56rVfdyCrTMjD8BDFxfcd0Vz+Z2ic3vP0liNW1M SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2018 20:40:40.6024 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8059ae1d-c01f-4f44-7eb9-08d6015d0906 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3977 Subject: [dpdk-stable] patch 'net/qede: fix interrupt handler unregister' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 20:40:42 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/15/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From 56cadff31267ebc8a05b38c3227a0c06ef967f4b Mon Sep 17 00:00:00 2001 From: Shahed Shaikh Date: Tue, 24 Jul 2018 15:18:41 -0700 Subject: [PATCH] net/qede: fix interrupt handler unregister [ upstream commit 4eee1bbf25859b72723ec570d77bf5fb501bedcf ] Commit 023d7a0449f11 ("net/qede: fix legacy interrupt mode") added a handler for legacy interrupt mode but forgot to unregister same handler in rte_intr_callback_unregister() Fixes: 245aec289338 ("net/qede: fix legacy interrupt mode") Signed-off-by: Shahed Shaikh --- drivers/net/qede/qede_ethdev.c | 16 ++++++++++++++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 89f6ce05a..3be45d3ee 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1609,8 +1609,20 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) qdev->ops->common->slowpath_stop(edev); qdev->ops->common->remove(edev); rte_intr_disable(&pci_dev->intr_handle); - rte_intr_callback_unregister(&pci_dev->intr_handle, - qede_interrupt_handler, (void *)eth_dev); + + switch (pci_dev->intr_handle.type) { + case RTE_INTR_HANDLE_UIO_INTX: + case RTE_INTR_HANDLE_VFIO_LEGACY: + rte_intr_callback_unregister(&pci_dev->intr_handle, + qede_interrupt_handler_intx, + (void *)eth_dev); + break; + default: + rte_intr_callback_unregister(&pci_dev->intr_handle, + qede_interrupt_handler, + (void *)eth_dev); + } + if (ECORE_IS_CMT(edev)) rte_eal_alarm_cancel(qede_poll_sp_sb_cb, (void *)eth_dev); } -- 2.11.0