From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from EUR03-AM5-obe.outbound.protection.outlook.com (mail-eopbgr30056.outbound.protection.outlook.com [40.107.3.56]) by dpdk.org (Postfix) with ESMTP id B4C182661 for ; Mon, 13 Aug 2018 22:40:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P+u7k79r/QKf6c+GLsrKzpn09yqXsXrepBC72YCDVnE=; b=cqNMsgI2UBFqQlgl/7Op4FHQkGKv7zz3JdxRjUvmGYSHsE9aAapMn7Ifq/KQzLoBtvxwGftM7a5DMzF3fxphBrqRzsbzgmu6G1sDYv9P49yyf30OnquiG98PugZbbOyUYhyih065XOkGbMEIHMZ+Yq1WXq86yrSNaXgVNry0Et4= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=yskoh@mellanox.com; Received: from mellanox.com (209.116.155.178) by DB3PR0502MB3977.eurprd05.prod.outlook.com (2603:10a6:8:10::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1038.19; Mon, 13 Aug 2018 20:40:41 +0000 From: Yongseok Koh To: Rasesh Mody Cc: dpdk stable Date: Mon, 13 Aug 2018 13:40:08 -0700 Message-Id: <20180813204010.25281-8-yskoh@mellanox.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20180813204010.25281-1-yskoh@mellanox.com> References: <20180813204010.25281-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [209.116.155.178] X-ClientProxiedBy: BN6PR2001CA0042.namprd20.prod.outlook.com (2603:10b6:405:16::28) To DB3PR0502MB3977.eurprd05.prod.outlook.com (2603:10a6:8:10::24) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: fb581a43-2472-4905-f411-08d6015d09d2 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0; PCL:0; RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:DB3PR0502MB3977; X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 3:tkursb4wLaE7eRVFgmSsT+cG71BYDVhcJirF6RbWPG+n5/WUKlvqa7Ps7ulV6HH/Nw0GzOzeD2HtNGY/jKRgUTMDTUd9edDnFhNnFBvtZvpPZ37TRI3johqd906SPoSKxxV15IO1RC+E2addU3l3w3zn8xF3u5DaW/KL1uK23GsR0WJp5LohSQmF+uQDsDCcI7WWHRiQ4FiwgrrPQxB0nnM1lHZ5KIx4D8Q6/YD5ZPDJFD5VguMlyluQnY/23Nzo; 25:L0WL4BqTINil+DSkPKJEwRTgoKn/S9wdo2B3wjkBON1vHAFE62IzX5WRxAjK44/Cmcm5Tn7Q97ytnyc+5A+6WFIfLneUPRmyV8p6veG8YgkRKxmjpws45UKUR6Pvxr/FZwev20BFDz+Ee/8w9Nj4MMB6jw7LXocBB3ROC1nVwbzv6+WYV0SAZB1NTYX7pw6XlAI8HJC/w6fsIYhR3djY9Tm643uaUgX+7ksSNoEvNWbQMC3IhkN9e0NlkwIzNXlepoc+jVU7Q+ESihSOyFlp6kMzXMfeOEVQnZc9FNULylRAGfAqFiG4bGNHZboTlTjuac9HN6agqyM+35iGlOiHVA==; 31:0KYnstHWsC585HUwQ5rG5FpDnwbUSaMyXFlc7XPem88JgfecHJqH5KgCvOCSpSEXqXbp0JpSQn2vYKsihtGx5icrTmgNv1giZmbm0S8pAYc6EdfM1utJfRRz58fgML/nk1sEJ2CrUu2B7lTo7ydef3G02q6RoFlGMw2VsSLa/QP45hagBXMEfW/XbETa/M3rwY1TSTcyHui8PeGvJL2AIM1Ft91P2Dzqo/ui2pTHBJ4= X-MS-TrafficTypeDiagnostic: DB3PR0502MB3977: X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 20:l6MkN1jrMniFkQZ9ZNnjpmJrZt4Cyja8c2fuMmJKHTBtD3/zJB+m6dk/os0pBByLTYKH9d2A2114vm427KH8uXjO2ieVfhLgCGsh/PbvPrnI64Fg7Jg88g8YTo4nOm5YxDERoPigCWKSTZYbPh9MyBqSfCqY3hqVwcgbWMAw9w+VeQVJCUPxupXA/Q5SsguhBPE86dZv4qXAQo6/+CJmq5wJNmCmSVM8awI20C5ub6aksx9EykpXYm3LtKa+dMUxJ8RternhBzJLGAEv079/OLQq0MMFJMQYAoMfPLmQzsOz86zT9JV9yfsKdUkThF0O+fX+3J/o4wlb3jUPbTgK0g+uEGZwuuFUrrEkOhum2aagGbT5By2RU27mMitw8Ho7cnSLHQpKaPMa6+iD426KXtNV9VKaJVL8b49OHAFJFfvgJRB/KDhi3MqSqdlOYa/j2+wqSQ8ibZUc06IPd63eXetdzG7S7eP1De9/naNqbn4/BVDPnLd/xJN10HnRV3iU; 4:LKIIXftF+w7cWyeyLpAdANUuYkUg7houwxRHAEKDClYyHLQiKTDqRBaZJ7GVxub+BQe12PMlwOZ6R5+uQYM1yt40sO96Zu3KjKojuftcUQiCQnKYV1SxgX1JSDM5NlFW4o+Zihp9CCO/OWZExGCNNeLvYn5/37dYY023Or9OF2Mu0p64cRCZnYSZxMxwJ+TLXtUDNLgwbmz4Oy7WJ2szzn2l3CO0B+7dC4ktezPuuYC4QzV8WHH82kwH7kWDtwYCe0WbrtGsxR4M+I0DmcyPZg== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3002001)(10201501046)(3231311)(944501410)(52105095)(93006095)(93001095)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011)(7699016); SRVR:DB3PR0502MB3977; BCL:0; PCL:0; RULEID:; SRVR:DB3PR0502MB3977; X-Forefront-PRVS: 07630F72AD X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(376002)(136003)(346002)(396003)(366004)(39860400002)(69234005)(28163001)(189003)(199004)(4326008)(6666003)(6916009)(7736002)(47776003)(50226002)(25786009)(105586002)(26005)(446003)(53376002)(6306002)(48376002)(69596002)(86362001)(53936002)(8676002)(14444005)(81166006)(966005)(81156014)(16526019)(305945005)(186003)(66066001)(68736007)(21086003)(386003)(1720100001)(7696005)(52116002)(51416003)(106356001)(1076002)(50466002)(6116002)(55016002)(2906002)(3846002)(16586007)(486006)(5660300001)(316002)(36756003)(76176011)(53546011)(956004)(8936002)(478600001)(476003)(97736004)(11346002)(2616005); DIR:OUT; SFP:1101; SCL:1; SRVR:DB3PR0502MB3977; H:mellanox.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; DB3PR0502MB3977; 23:L/wuvlz4Bpo1dgY0Q0SHW0BfcuIIXFPk41ftjFU?= =?us-ascii?Q?Eh3l4hj5C0A9dvhra1vjj4mqDTd6fAWQsXwcw9Ex/h6jzV/pLtVu3IAwsxCt?= =?us-ascii?Q?jTiYFm18giqOcdYC7KX8dmH3eBs2B/yN2l/C8I80OmerbdBv0pOP7ICId3LZ?= =?us-ascii?Q?YsCOXaew2fPF3uheFmY2swP5Ic1517lIGNlKjWSkpDUvry8BQ7uOIZSM/Ypj?= =?us-ascii?Q?ArMNqnPSpBknfo2uD1WyFSKJILqengoP1QPsjvi0RC8wX9OGGVPFTPMYDPwS?= =?us-ascii?Q?l+WJTts24Twtbm8vLcVybOqrB7iOLCrbo2ayl8fAhk6Xat+ZYMHbXt5C/ICs?= =?us-ascii?Q?lG98BuZLT8v8NpLfXRMBTYVN/7utq2pNE4Kia+/TcdMVyOZecgyq4TPli6hs?= =?us-ascii?Q?XlGFpc7C4ouDOcE2fMqMaJDq2ieWb6FqnvWfjE5bqmO58/09yWguEFTc3bk3?= =?us-ascii?Q?MkQbKVJpMRtPo9JB8LVkxvWRAfyYWjEegAc50XEgH5drw/25WWb1ktCCv6Mk?= =?us-ascii?Q?kk1xS99UjoSF8/A7gNkJhOiUWxikPr1V1cFNl195umOYRczc4wuc2m2eEyje?= =?us-ascii?Q?nT1YFg1LoO5ecMPJK4W9qGsPldLsV3gjAaANSndE9HGFurwWCsjnY78kUEey?= =?us-ascii?Q?hM2NwhJTtKVtFfiWWrqOEbtE9Oa91ENMi24Uq6RFWPjA1bew3Ib/1Pa7BZOd?= =?us-ascii?Q?FcMZ6W9NuP4tFHAKwVws0nb0OFu4pVKjie+LXL9CkePu8jtF5o+xEa4vh6pK?= =?us-ascii?Q?0EiFjNn2+zQAx5f9hJiXozfNsV5aoQrfM+1gQcaCGTt0RNn4myp4uMHwkD9+?= =?us-ascii?Q?5dCQ6TEK5cduDm4+ba2PaGgUUG7Xvq/2MW0rVJhvMlMby9vwRYjVJBQguEk4?= =?us-ascii?Q?IKXu65zsE6lQ2tCqD5K722SIuT4W88azFAz71PIagzV5e5CwlSLe9fSRjOno?= =?us-ascii?Q?LiQqO/jPuBayZ+Sdc/PMJmGE2/P7BjmGWkO6qOLR6g3IYdXLC/3CW4YFSNB7?= =?us-ascii?Q?ncphvvfCpyMuN31rAPHblk2cgqOWBdeRHjgEylagwvwDb/q/Ph9LJRI7HIEu?= =?us-ascii?Q?7AWF9i4TNocaw4Bxy/sXMDnFt1saTJ8NLBItCQ0ZIkjZNpNPIEMAXSY6nvIH?= =?us-ascii?Q?ffj4sJ3psrYTBsijK7H5UeGm6c+q0yzQekHB2Iv7uDpkkQfva6HTE5FLOJf9?= =?us-ascii?Q?7iD9YCNhPb8y2IcGxTdYHFFYCihKQ6VMHKApE3Is7ESMM/ycGbQYyiBX1BXi?= =?us-ascii?Q?IJR6gwwU8G9auJgUdiJ1i9lSyr+Yu984iYaUYOK0g+sbrvcXYAbB/cr77Fxa?= =?us-ascii?Q?NzfCisup/6vfnnWn7V2coAMId8lwLLQcCPp8COEvSRk3Ixk4yOGOjtCu7tYV?= =?us-ascii?Q?WgsjfyuUXrXzjz1Py41fMjLKCwgk=3D?= X-Microsoft-Antispam-Message-Info: 3+3O1407w+VLh3tV7570Z0vkrTyFFMSBf6eCC0muOuRCkxs9qR6DhQHe13TJjuLW1HE3rR5OMYz5Wxfpvhd9ipYFGpoFwbtEonNdRxMhl1sjoQUtnqVCmCavl1q5zS70y/DbiaaEtQExPleo4KjltPf2oKgUujPtnUzvScsiQnsJSOgmeZFvSOldRLQU+kwWQTI9IPC+NXq1Tj8Uwms9Se7JYDDnNBv/pEIXAjd1uxZWpjr2hCxxST1ae+ByPTLwJz0J/12vPqFm47Pn6O4r3MepOfNCjMVCsvydFwTqcMduwN1RMi1ALv7q/ibLnBHlEuXuu1mTgCwWDRlI/6YKfXGUtM5gtULD1gGAHX5gJBo= X-Microsoft-Exchange-Diagnostics: 1; DB3PR0502MB3977; 6:W3AsjIlzGly3UuxIwo6/elXE7YmXE/Cdbqgei5jQc6QdusCfi1ztT0Si+8RiHlTOuIdbLJLTBbVWnScp+/RFgBZMp/8TIUrNlqCyIBPYlbTGukrKB+IecJZLYqBxPhvuWr4Sr4OEmYsY8oyucRlw5K4remESZRbYwXbYZ9HHuhBvVXIXvZtobWSfqpQMAixc9Ogd143rtL5xLJp6K1d2pXlZ4Dst6PQLD1g6+CvQXPdX62cyUOTcURAawrHAmq2h8C33uLm7asdmaLf8rPwdAlksVT9e8lJt0G1NgwXuDDgMXDAiH0f9ayWTomKbbSzgfFMNdlNvat8LQj4+YDlG/KPAHjVnssiG7zjeBzV52424BXwaFeKc2iyIg6TxMRQ54SO/vql7KFDfcI+04RfyIEtFIKz4DvzAYSvqlws6AN05kQH2uK95rk86GUY0KYHMYWvJr1JLNfP0EpIP3Wf7Jw==; 5:dBhry/7DOzJNvocZUcvNT1VBbZnztPgdwFGBZlHUANz+WtVZE1eTl/Myg9h0lkexIYQfVUMa9r5mkeq8LDe5TIfdiXAhLrHn6ViDij+zFu+Yj8APNl4BPYTzWAhPlcKWhAcLkggYrvmXvrnSsNXEQbrPyfey53FCraCrRAKgfhk=; 7:q2MS/dSh1jxxTlFHcVbpebxtFayxY9g/Ou/vBP8Z5ylOLSCjRI6XDmR0bKVjpomkh3ct6sLI+JgjwrNg4m3ymit2NBped0y7xWwoWMlimQ/hZyB5TKWx0ZenyJuA1cdTCLyyFKd64u5KFjQjwf0Hz1XAMlVlSS+gpGYvrfGDwx9nv3qIZRIZuJsNiccivx4y4zjO+WXjx4lCShQxLgsXQNc/ugL9PE8fEDHaruQoLfxYJfcyrrdwPgI8KAnkAyAX SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2018 20:40:41.9424 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: fb581a43-2472-4905-f411-08d6015d09d2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0502MB3977 Subject: [dpdk-stable] patch 'net/qede/base: fix GRC attention callback' has been queued to LTS release 17.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Aug 2018 20:40:44 -0000 Hi, FYI, your patch has been queued to LTS release 17.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/15/18. So please shout if anyone has objections. Thanks. Yongseok --- >>From f4dd0374363e29506d9b17fbd5dd680b19bbf1c6 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Tue, 24 Jul 2018 15:18:43 -0700 Subject: [PATCH] net/qede/base: fix GRC attention callback [ upstream commit 538bcb378af5d1750a6831efeea4d9565a3267f0 ] Treat any attention which is not for timeout event as invalid and return status accordingly. The HW error handler logs and clears the HW attention. Without this fix we can see flood of GRC attentions. Fixes: e6051bd6b07d ("qede: add interrupt handling support") Signed-off-by: Rasesh Mody --- drivers/net/qede/base/ecore_int.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/qede/base/ecore_int.c b/drivers/net/qede/base/ecore_int.c index e6cef85bc..61e36a430 100644 --- a/drivers/net/qede/base/ecore_int.c +++ b/drivers/net/qede/base/ecore_int.c @@ -231,15 +231,19 @@ static const char *grc_timeout_attn_master_to_str(u8 master) static enum _ecore_status_t ecore_grc_attn_cb(struct ecore_hwfn *p_hwfn) { + enum _ecore_status_t rc = ECORE_SUCCESS; u32 tmp, tmp2; /* We've already cleared the timeout interrupt register, so we learn - * of interrupts via the validity register + * of interrupts via the validity register. + * Any attention which is not for a timeout event is treated as fatal. */ tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt, GRC_REG_TIMEOUT_ATTN_ACCESS_VALID); - if (!(tmp & ECORE_GRC_ATTENTION_VALID_BIT)) + if (!(tmp & ECORE_GRC_ATTENTION_VALID_BIT)) { + rc = ECORE_INVAL; goto out; + } /* Read the GRC timeout information */ tmp = ecore_rd(p_hwfn, p_hwfn->p_dpc_ptt, @@ -263,11 +267,11 @@ static enum _ecore_status_t ecore_grc_attn_cb(struct ecore_hwfn *p_hwfn) (tmp2 & ECORE_GRC_ATTENTION_VF_MASK) >> ECORE_GRC_ATTENTION_VF_SHIFT); -out: - /* Regardles of anything else, clean the validity bit */ + /* Clean the validity bit */ ecore_wr(p_hwfn, p_hwfn->p_dpc_ptt, GRC_REG_TIMEOUT_ATTN_ACCESS_VALID, 0); - return ECORE_SUCCESS; +out: + return rc; } #define ECORE_PGLUE_ATTENTION_VALID (1 << 29) -- 2.11.0