patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Shahed Shaikh <shahed.shaikh@cavium.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/qede: fix MAC address removal failure message' has been queued to LTS release 17.11.4
Date: Mon, 13 Aug 2018 13:40:09 -0700	[thread overview]
Message-ID: <20180813204010.25281-9-yskoh@mellanox.com> (raw)
In-Reply-To: <20180813204010.25281-1-yskoh@mellanox.com>

Hi,

FYI, your patch has been queued to LTS release 17.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/15/18. So please
shout if anyone has objections.

Thanks.

Yongseok

---
>From 9ff59831711b1c24ef25fa7e3602490d7da57d95 Mon Sep 17 00:00:00 2001
From: Shahed Shaikh <shahed.shaikh@cavium.com>
Date: Tue, 24 Jul 2018 15:18:44 -0700
Subject: [PATCH] net/qede: fix MAC address removal failure message

[ upstream commit 7e3060a3704e21ab63e9f1b4338be2fed9a345d1 ]

Don't treat MAC address removal failure as a fatal error
and print in logs.

Fixes: 77fac1b54fc9 ("net/qede: fix filtering code")

Signed-off-by: Shahed Shaikh <shahed.shaikh@cavium.com>
---
 drivers/net/qede/qede_ethdev.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c
index 3be45d3ee..4a5e48579 100644
--- a/drivers/net/qede/qede_ethdev.c
+++ b/drivers/net/qede/qede_ethdev.c
@@ -845,7 +845,10 @@ qede_mac_int_ops(struct rte_eth_dev *eth_dev, struct ecore_filter_ucast *ucast,
 	if (rc == 0)
 		rc = ecore_filter_ucast_cmd(edev, ucast,
 					    ECORE_SPQ_MODE_CB, NULL);
-	if (rc != ECORE_SUCCESS)
+	/* Indicate error only for add filter operation.
+	 * Delete filter operations are not severe.
+	 */
+	if ((rc != ECORE_SUCCESS) && add)
 		DP_ERR(edev, "MAC filter failed, rc = %d, op = %d\n",
 		       rc, add);
 
-- 
2.11.0

  parent reply	other threads:[~2018-08-13 20:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13 20:40 [dpdk-stable] patch 'net/octeontx: fix stop clearing Rx/Tx functions' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: fix filter freeing' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: fix memory leaks in NVM commands' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: fix lock release on NVM write failure' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: check access denied for HWRM commands' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnxt: fix RETA size' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/qede: fix interrupt handler unregister' " Yongseok Koh
2018-08-13 20:40 ` [dpdk-stable] patch 'net/qede/base: fix GRC attention callback' " Yongseok Koh
2018-08-13 20:40 ` Yongseok Koh [this message]
2018-08-13 20:40 ` [dpdk-stable] patch 'net/bnx2x: fix FW command timeout during stop' " Yongseok Koh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180813204010.25281-9-yskoh@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=shahed.shaikh@cavium.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).