patches for DPDK stable branches
 help / color / mirror / Atom feed
From: Yongseok Koh <yskoh@mellanox.com>
To: Ophir Munk <ophirmu@mellanox.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/mlx5: fix secondary process resource leakage' has been queued to LTS release 17.11.4
Date: Mon, 13 Aug 2018 13:42:06 -0700	[thread overview]
Message-ID: <20180813204213.25436-3-yskoh@mellanox.com> (raw)
In-Reply-To: <20180813204213.25436-1-yskoh@mellanox.com>

Hi,

FYI, your patch has been queued to LTS release 17.11.4

Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/15/18. So please
shout if anyone has objections.

Thanks.

Yongseok

---
>From a546122e90627552c02ffd5967a9f1f98edeccaa Mon Sep 17 00:00:00 2001
From: Ophir Munk <ophirmu@mellanox.com>
Date: Tue, 31 Jul 2018 22:38:04 +0000
Subject: [PATCH] net/mlx5: fix secondary process resource leakage

[ upstream commit 09e0fd260e2e414134154b6e0e955c8424b51c0a ]

When running testpmd with an mlx5 device and then executing at testpmd
prompt in a raw: "port start all" followed by "port stop all"
a new file named /var/tmp/net_mlx5_<socket num> is created as a result
of creating a new unix domain socket (used for communication between
the primary and secondary processes).
When the new unix socket file is created the old unix socket file should
have been removed. This commit fixes it by closing the old unix socket
just before creating the new one in function mlx5_socket_init()

Fixes: f8b9a3bad467 ("net/mlx5: install a socket to exchange a file descriptor")

Signed-off-by: Ophir Munk <ophirmu@mellanox.com>
---
 drivers/net/mlx5/mlx5_socket.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/mlx5/mlx5_socket.c b/drivers/net/mlx5/mlx5_socket.c
index 7ab310007..97f90c072 100644
--- a/drivers/net/mlx5/mlx5_socket.c
+++ b/drivers/net/mlx5/mlx5_socket.c
@@ -62,6 +62,12 @@ mlx5_socket_init(struct rte_eth_dev *dev)
 	int flags;
 
 	/*
+	 * Close the last socket that was used to communicate
+	 * with the secondary process
+	 */
+	if (priv->primary_socket)
+		mlx5_socket_uninit(dev);
+	/*
 	 * Initialise the socket to communicate with the secondary
 	 * process.
 	 */
-- 
2.11.0

  parent reply	other threads:[~2018-08-13 20:42 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13 20:42 [dpdk-stable] patch 'net/bnx2x: fix poll link status' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'net/dpaa2: remove loop for unused pool entries' " Yongseok Koh
2018-08-13 20:42 ` Yongseok Koh [this message]
2018-08-13 20:42 ` [dpdk-stable] patch 'net/i40e: revert fix of flow director check' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'vhost: flush IOTLB cache on new mem table handling' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'net/bonding: fix race condition' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'event: fix ring init failure handling' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'app/crypto-perf: fix auth IV offset' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'eal: fix bitmap documentation' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'examples/flow_filtering: add flow director config for i40e' " Yongseok Koh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180813204213.25436-3-yskoh@mellanox.com \
    --to=yskoh@mellanox.com \
    --cc=ophirmu@mellanox.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).