From: Yongseok Koh <yskoh@mellanox.com>
To: Radu Nicolau <radu.nicolau@intel.com>
Cc: Chas Williams <chas3@att.com>, dpdk stable <stable@dpdk.org>
Subject: [dpdk-stable] patch 'net/bonding: fix race condition' has been queued to LTS release 17.11.4
Date: Mon, 13 Aug 2018 13:42:09 -0700 [thread overview]
Message-ID: <20180813204213.25436-6-yskoh@mellanox.com> (raw)
In-Reply-To: <20180813204213.25436-1-yskoh@mellanox.com>
Hi,
FYI, your patch has been queued to LTS release 17.11.4
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 08/15/18. So please
shout if anyone has objections.
Thanks.
Yongseok
---
>From 49806dcbbaa2807e7883594b30b9b48f7a4ece3d Mon Sep 17 00:00:00 2001
From: Radu Nicolau <radu.nicolau@intel.com>
Date: Wed, 25 Jul 2018 10:39:40 +0100
Subject: [PATCH] net/bonding: fix race condition
[ upstream commit 5922ff069fb910946f97780754ad4b66b987d5b6 ]
Race condition can appear in the bond_mode_8023ad_periodic_cb()
callback when bonding port is stopped, reconfigured and restarted.
Re-ordered calls in bond_ethdev_start() to have callback alarm set
after slave ports are reconfigured.
Fixes: 2efb58cbab6e ("bond: new link bonding library")
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
Acked-by: Chas Williams <chas3@att.com>
---
drivers/net/bonding/rte_eth_bond_pmd.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c
index 98515bc39..8880231ea 100644
--- a/drivers/net/bonding/rte_eth_bond_pmd.c
+++ b/drivers/net/bonding/rte_eth_bond_pmd.c
@@ -1932,10 +1932,6 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev)
}
}
- /* Update all slave devices MACs*/
- if (mac_address_slaves_update(eth_dev) != 0)
- goto out_err;
-
/* If bonded device is configure in promiscuous mode then re-apply config */
if (internals->promiscuous_en)
bond_ethdev_promiscuous_enable(eth_dev);
@@ -1976,6 +1972,10 @@ bond_ethdev_start(struct rte_eth_dev *eth_dev)
(void *)&rte_eth_devices[internals->port_id]);
}
+ /* Update all slave devices MACs*/
+ if (mac_address_slaves_update(eth_dev) != 0)
+ goto out_err;
+
if (internals->user_defined_primary_port)
bond_ethdev_primary_set(internals, internals->primary_port);
--
2.11.0
next prev parent reply other threads:[~2018-08-13 20:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 20:42 [dpdk-stable] patch 'net/bnx2x: fix poll link status' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'net/dpaa2: remove loop for unused pool entries' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'net/mlx5: fix secondary process resource leakage' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'net/i40e: revert fix of flow director check' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'vhost: flush IOTLB cache on new mem table handling' " Yongseok Koh
2018-08-13 20:42 ` Yongseok Koh [this message]
2018-08-13 20:42 ` [dpdk-stable] patch 'event: fix ring init failure " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'app/crypto-perf: fix auth IV offset' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'eal: fix bitmap documentation' " Yongseok Koh
2018-08-13 20:42 ` [dpdk-stable] patch 'examples/flow_filtering: add flow director config for i40e' " Yongseok Koh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813204213.25436-6-yskoh@mellanox.com \
--to=yskoh@mellanox.com \
--cc=chas3@att.com \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).